]> git.saurik.com Git - redis.git/commitdiff
removed support for REDIS_HELGRIND_FRIENDLY since Helgrind 3.5.0 is friendly enough...
authorantirez <antirez@gmail.com>
Sat, 16 Jan 2010 12:57:32 +0000 (07:57 -0500)
committerantirez <antirez@gmail.com>
Sat, 16 Jan 2010 12:57:32 +0000 (07:57 -0500)
redis.c

diff --git a/redis.c b/redis.c
index 9484b75a6278ce39eacdd5e9d658d20d186d2ac5..aed49ed8fd97e3b8b00c29fc9f611b9758d99ec3 100644 (file)
--- a/redis.c
+++ b/redis.c
 #include "lzf.h"    /* LZF compression library */
 #include "pqsort.h" /* Partial qsort for SORT+LIMIT */
 
-/* #define REDIS_HELGRIND_FRIENDLY */
-#if defined(__GNUC__) && defined(REDIS_HELGRIND_FRIENDLY)
-#warning "Remember to undef REDIS_HELGRIND_FRIENDLY before to commit"
-#endif
-
 /* Error codes */
 #define REDIS_OK                0
 #define REDIS_ERR               -1
@@ -7710,15 +7705,6 @@ static void *IOThreadEntryPoint(void *arg) {
         /* Get a new job to process */
         lockThreadedIO();
         if (listLength(server.io_newjobs) == 0) {
-#ifdef REDIS_HELGRIND_FRIENDLY
-            /* No new jobs? Wait and retry, because to be Helgrind
-             * (valgrind --tool=helgrind) what's needed is to take
-             * the same threads running instead to create/destroy threads
-             * as needed (otherwise valgrind will fail) */
-            unlockThreadedIO();
-            usleep(1); /* Give some time for the I/O thread to work. */
-            continue;
-#endif
             /* No new jobs in queue, exit. */
             redisLog(REDIS_DEBUG,"Thread %lld exiting, nothing to do",
                 (long long) pthread_self());