better recap of failed tests.

diff --git a/tests/support/test.tcl b/tests/support/test.tcl
index 0fca618222f0c943560292da0cd9acafed123205..4e68905a5a245304ace9020c140c4d18ae89dd84 100644 (file)
--- a/tests/support/test.tcl
+++ b/tests/support/test.tcl
@@ -98,9 +98,7 @@ proc test {name code {okpattern undefined}} {
 
     incr ::num_tests
     set details {}
 
     incr ::num_tests
     set details {}

-    lappend details $::curfile
-    lappend details $::tags
-    lappend details $name
+    lappend details "$name in $::curfile"

 
     send_data_packet $::test_server_fd testing $name
 
 
     send_data_packet $::test_server_fd testing $name
 


@@ -111,7 +109,7 @@ proc test {name code {okpattern undefined}} {
             lappend ::tests_failed $details
 
             incr ::num_failed
             lappend ::tests_failed $details
 
             incr ::num_failed

-            send_data_packet $::test_server_fd err $name
+            send_data_packet $::test_server_fd err [join $details "\n"]

         } else {
             # Re-raise, let handler up the stack take care of this.
             error $error $::errorInfo
         } else {
             # Re-raise, let handler up the stack take care of this.
             error $error $::errorInfo


@@ -126,7 +124,7 @@ proc test {name code {okpattern undefined}} {
             lappend ::tests_failed $details
 
             incr ::num_failed
             lappend ::tests_failed $details
 
             incr ::num_failed

-            send_data_packet $::test_server_fd err $name
+            send_data_packet $::test_server_fd err [join $details "\n"]

         }
     }
 
         }
     }
 

diff --git a/tests/test_helper.tcl b/tests/test_helper.tcl
index 6624ff2850cc92696a493e7927bbdc09f8c5ecbe..86f88f3f8e0dc40971749e045af5f61ab2bf32a8 100644 (file)
--- a/tests/test_helper.tcl
+++ b/tests/test_helper.tcl
@@ -277,7 +277,7 @@ proc the_end {} {
         puts "  $time seconds - $name"
     }
     if {[llength $::failed_tests]} {
         puts "  $time seconds - $name"
     }
     if {[llength $::failed_tests]} {

-        puts "!!! WARNING: The following tests failed\n"
+        puts "\n[colorstr bold-red {!!! WARNING}] The following tests failed:\n"

         foreach failed $::failed_tests {
             puts "*** $failed"
         }
         foreach failed $::failed_tests {
             puts "*** $failed"
         }

diff --git a/tests/unit/other.tcl b/tests/unit/other.tcl
index dff577159c8c4f61a51afd88800b5a086dbd5762..8eebdc6348eb66547e944d20868915b1ea40f9b8 100644 (file)
--- a/tests/unit/other.tcl
+++ b/tests/unit/other.tcl
@@ -1,4 +1,11 @@
 start_server {tags {"other"}} {
 start_server {tags {"other"}} {

+    if {$::force_failure} {
+        # This is used just for test suite development purposes.
+        test {Failing test} {
+            format err
+        } {ok}
+    }
+

     test {SAVE - make sure there are all the types as values} {
         # Wait for a background saving in progress to terminate
         waitForBgsave r
     test {SAVE - make sure there are all the types as values} {
         # Wait for a background saving in progress to terminate
         waitForBgsave r


@@ -242,11 +249,4 @@ start_server {tags {"other"}} {
     test {Perform a final SAVE to leave a clean DB on disk} {
         r save
     } {OK}
     test {Perform a final SAVE to leave a clean DB on disk} {
         r save
     } {OK}

-
-    if {$::force_failure} {
-        # This is used just for test suite development purposes.
-        test {Failing test} {
-            format err
-        } {ok}
-    }

 }
 }