FLUSHALL / FLUSHDB for diskstore implemented

diff --git a/src/db.c b/src/db.c
index 9be26f865667a49c7e2b48eb72ec9f51a6e93549..8b7dbe0becc2df3b294343e0badd10e858352a56 100644 (file)
--- a/src/db.c
+++ b/src/db.c
@@ -200,8 +200,6 @@ void signalModifiedKey(redisDb *db, robj *key) {
 
 void signalFlushedDb(int dbid) {
     touchWatchedKeysOnFlush(dbid);
 
 void signalFlushedDb(int dbid) {
     touchWatchedKeysOnFlush(dbid);

-    if (server.ds_enabled)
-        dsFlushDb(dbid);

 }
 
 /*-----------------------------------------------------------------------------
 }
 
 /*-----------------------------------------------------------------------------


@@ -213,6 +211,7 @@ void flushdbCommand(redisClient *c) {
     signalFlushedDb(c->db->id);
     dictEmpty(c->db->dict);
     dictEmpty(c->db->expires);
     signalFlushedDb(c->db->id);
     dictEmpty(c->db->dict);
     dictEmpty(c->db->expires);

+    if (server.ds_enabled) dsFlushDb(c->db->id);

     addReply(c,shared.ok);
 }
 
     addReply(c,shared.ok);
 }
 


@@ -224,7 +223,10 @@ void flushallCommand(redisClient *c) {
         kill(server.bgsavechildpid,SIGKILL);
         rdbRemoveTempFile(server.bgsavechildpid);
     }
         kill(server.bgsavechildpid,SIGKILL);
         rdbRemoveTempFile(server.bgsavechildpid);
     }

-    rdbSave(server.dbfilename);
+    if (server.ds_enabled)
+        dsFlushDb(-1);
+    else
+        rdbSave(server.dbfilename);

     server.dirty++;
 }
 
     server.dirty++;
 }
 

diff --git a/src/debug.c b/src/debug.c
index b44175d19832b09cfeab84adadfbe379174a6746..47d4c85df4056f53f8a405ca593d6ed3961e2d4d 100644 (file)
--- a/src/debug.c
+++ b/src/debug.c
@@ -262,10 +262,12 @@ void _redisAssert(char *estr, char *file, int line) {
 }
 
 void _redisPanic(char *msg, char *file, int line) {
 }
 
 void _redisPanic(char *msg, char *file, int line) {

+    redisLog(REDIS_WARNING,"------------------------------------------------");

     redisLog(REDIS_WARNING,"!!! Software Failure. Press left mouse button to continue");
     redisLog(REDIS_WARNING,"Guru Meditation: %s #%s:%d",msg,file,line);
 #ifdef HAVE_BACKTRACE
     redisLog(REDIS_WARNING,"(forcing SIGSEGV in order to print the stack trace)");
     redisLog(REDIS_WARNING,"!!! Software Failure. Press left mouse button to continue");
     redisLog(REDIS_WARNING,"Guru Meditation: %s #%s:%d",msg,file,line);
 #ifdef HAVE_BACKTRACE
     redisLog(REDIS_WARNING,"(forcing SIGSEGV in order to print the stack trace)");

+    redisLog(REDIS_WARNING,"------------------------------------------------");

     *((char*)-1) = 'x';
 #endif
 }
     *((char*)-1) = 'x';
 #endif
 }

diff --git a/src/diskstore.c b/src/diskstore.c
index 06d4ae85b15a8b49207bdfb0f04a01a5d6a5e76a..711dd693c2d79f1f2cfa3ca938acce7ecdfc36c4 100644 (file)
--- a/src/diskstore.c
+++ b/src/diskstore.c
@@ -74,6 +74,7 @@
 
 #include <fcntl.h>
 #include <sys/stat.h>
 
 #include <fcntl.h>
 #include <sys/stat.h>

+#include <dirent.h>

 
 int create256dir(char *prefix) {
     char buf[1024];
 
 int create256dir(char *prefix) {
     char buf[1024];


@@ -270,5 +271,51 @@ int dsExists(redisDb *db, robj *key) {
     return access(buf,R_OK) == 0;
 }
 
     return access(buf,R_OK) == 0;
 }
 

-int dsFlushDb(int dbid) {
+void dsFlushOneDir(char *path, int dbid) {
+    DIR *dir;
+    struct dirent *dp, de;
+
+    dir = opendir(path);
+    if (dir == NULL) {
+        redisLog(REDIS_WARNING,"Disk store can't open dir %s: %s",
+            path, strerror(errno));
+        redisPanic("Unrecoverable Disk store errore. Existing.");
+    }
+    while(1) {
+        readdir_r(dir,&de,&dp);
+        if (dp == NULL) break;
+        if (dp->d_name[0] == '.') continue;
+
+        /* Check if we need to remove this entry accordingly to the
+         * DB number */
+        if (dbid != -1) {
+            char id[64];
+            char *p = strchr(dp->d_name,'_');
+            int len = (p - dp->d_name);
+
+            redisAssert(p != NULL && len < 64);
+            memcpy(id,dp->d_name,len);
+            id[len] = '\0';
+            if (atoi(id) != dbid) continue; /* skip this file */
+        }
+        if (unlink(path) == -1) {
+            redisLog(REDIS_WARNING,
+                "Can't unlink %s: %s", path, strerror(errno));
+            redisPanic("Unrecoverable Disk store errore. Existing.");
+        }
+    }
+    closedir(dir);
+}
+
+void dsFlushDb(int dbid) {
+    char buf[1024];
+    int j, i;
+
+    redisLog(REDIS_NOTICE,"Flushing diskstore DB (%d)",dbid);
+    for (j = 0; j < 256; j++) {
+        for (i = 0; i < 256; i++) {
+            snprintf(buf,1024,"%s/%02x/%02x",server.ds_path,j,i);
+            dsFlushOneDir(buf,dbid);
+        }
+    }

 }
 }

diff --git a/src/redis.h b/src/redis.h
index 72c21defd4961721261c78ed7247d52c32a54477..5906fa2a3f76dbc20e7127ee5df4c0632ecd33fe 100644 (file)
--- a/src/redis.h
+++ b/src/redis.h
@@ -791,7 +791,7 @@ int dsSet(redisDb *db, robj *key, robj *val);
 robj *dsGet(redisDb *db, robj *key, time_t *expire);
 int dsDel(redisDb *db, robj *key);
 int dsExists(redisDb *db, robj *key);
 robj *dsGet(redisDb *db, robj *key, time_t *expire);
 int dsDel(redisDb *db, robj *key);
 int dsExists(redisDb *db, robj *key);

-int dsFlushDb(int dbid);
+void dsFlushDb(int dbid);

 
 /* Disk Store Cache */
 void dsInit(void);
 
 /* Disk Store Cache */
 void dsInit(void);