Test for ENCODING_SKIPLIST instead of ENCODING_RAW

diff --git a/src/aof.c b/src/aof.c
index cd7c48d3f0dfe76d24cd5ce0f10346f56c1f3ec5..5d75c3745807007651082073072d0e0f0ad73557 100644 (file)
--- a/src/aof.c
+++ b/src/aof.c
@@ -460,7 +460,7 @@ int rewriteAppendOnlyFile(char *filename) {
                         }
                         zzlNext(zl,&eptr,&sptr);
                     }
                         }
                         zzlNext(zl,&eptr,&sptr);
                     }

-                } else if (o->encoding == REDIS_ENCODING_RAW) {
+                } else if (o->encoding == REDIS_ENCODING_SKIPLIST) {

                     zset *zs = o->ptr;
                     dictIterator *di = dictGetIterator(zs->dict);
                     dictEntry *de;
                     zset *zs = o->ptr;
                     dictIterator *di = dictGetIterator(zs->dict);
                     dictEntry *de;

diff --git a/src/debug.c b/src/debug.c
index 940a0380239160d4f64118c1a5471522529b8921..080e2b2e968ccbfb13da10c31d6d01b39938fce5 100644 (file)
--- a/src/debug.c
+++ b/src/debug.c
@@ -159,7 +159,7 @@ void computeDatasetDigest(unsigned char *final) {
                         xorDigest(digest,eledigest,20);
                         zzlNext(zl,&eptr,&sptr);
                     }
                         xorDigest(digest,eledigest,20);
                         zzlNext(zl,&eptr,&sptr);
                     }

-                } else if (o->encoding == REDIS_ENCODING_RAW) {
+                } else if (o->encoding == REDIS_ENCODING_SKIPLIST) {

                     zset *zs = o->ptr;
                     dictIterator *di = dictGetIterator(zs->dict);
                     dictEntry *de;
                     zset *zs = o->ptr;
                     dictIterator *di = dictGetIterator(zs->dict);
                     dictEntry *de;

diff --git a/src/object.c b/src/object.c
index 4bf1df01fe9c5dce7edae769d25406ed8acaa442..c7c90c546d6c5acc99df9a51fa379c81f9b69847 100644 (file)
--- a/src/object.c
+++ b/src/object.c
@@ -144,7 +144,7 @@ void freeSetObject(robj *o) {
 void freeZsetObject(robj *o) {
     zset *zs;
     switch (o->encoding) {
 void freeZsetObject(robj *o) {
     zset *zs;
     switch (o->encoding) {

-    case REDIS_ENCODING_RAW:
+    case REDIS_ENCODING_SKIPLIST:

         zs = o->ptr;
         dictRelease(zs->dict);
         zslFree(zs->zsl);
         zs = o->ptr;
         dictRelease(zs->dict);
         zslFree(zs->zsl);

diff --git a/src/rdb.c b/src/rdb.c
index d186a9c5445e13e7e2f957d93ca78bc47dbfb12d..353620f286ff92ae9ade3c3f8c6a91696cfddcfa 100644 (file)
--- a/src/rdb.c
+++ b/src/rdb.c
@@ -308,7 +308,7 @@ int rdbSaveObject(FILE *fp, robj *o) {
 
             if ((n = rdbSaveRawString(fp,o->ptr,l)) == -1) return -1;
             nwritten += n;
 
             if ((n = rdbSaveRawString(fp,o->ptr,l)) == -1) return -1;
             nwritten += n;

-        } else if (o->encoding == REDIS_ENCODING_RAW) {
+        } else if (o->encoding == REDIS_ENCODING_SKIPLIST) {

             zset *zs = o->ptr;
             dictIterator *di = dictGetIterator(zs->dict);
             dictEntry *de;
             zset *zs = o->ptr;
             dictIterator *di = dictGetIterator(zs->dict);
             dictEntry *de;

diff --git a/src/sort.c b/src/sort.c
index 1a3fecb6f742483fc262ed1edd81a488676aa524..ff275c958a22684ff7fbb1f92c1ce62ad3ca88f0 100644 (file)
--- a/src/sort.c
+++ b/src/sort.c
@@ -200,7 +200,7 @@ void sortCommand(redisClient *c) {
     }
 
     /* Destructively convert encoded sorted sets for SORT. */
     }
 
     /* Destructively convert encoded sorted sets for SORT. */

-    if (sortval->type == REDIS_ZSET) zsetConvert(sortval, REDIS_ENCODING_RAW);
+    if (sortval->type == REDIS_ZSET) zsetConvert(sortval, REDIS_ENCODING_SKIPLIST);

 
     /* Load the sorting vector with all the objects to sort */
     switch(sortval->type) {
 
     /* Load the sorting vector with all the objects to sort */
     switch(sortval->type) {

diff --git a/src/t_zset.c b/src/t_zset.c
index f630ff02eb447e22b20ffa23af7761beb64e9d23..929714ca6afc161abed5712bc90abdcc30177e46 100644 (file)
--- a/src/t_zset.c
+++ b/src/t_zset.c
@@ -721,7 +721,7 @@ unsigned int zsetLength(robj *zobj) {
     int length = -1;
     if (zobj->encoding == REDIS_ENCODING_ZIPLIST) {
         length = zzlLength(zobj->ptr);
     int length = -1;
     if (zobj->encoding == REDIS_ENCODING_ZIPLIST) {
         length = zzlLength(zobj->ptr);

-    } else if (zobj->encoding == REDIS_ENCODING_RAW) {
+    } else if (zobj->encoding == REDIS_ENCODING_SKIPLIST) {

         length = ((zset*)zobj->ptr)->zsl->length;
     } else {
         redisPanic("Unknown sorted set encoding");
         length = ((zset*)zobj->ptr)->zsl->length;
     } else {
         redisPanic("Unknown sorted set encoding");


@@ -743,7 +743,7 @@ void zsetConvert(robj *zobj, int encoding) {
         unsigned int vlen;
         long long vlong;
 
         unsigned int vlen;
         long long vlong;
 

-        if (encoding != REDIS_ENCODING_RAW)
+        if (encoding != REDIS_ENCODING_SKIPLIST)

             redisPanic("Unknown target encoding");
 
         zs = zmalloc(sizeof(*zs));
             redisPanic("Unknown target encoding");
 
         zs = zmalloc(sizeof(*zs));


@@ -772,8 +772,8 @@ void zsetConvert(robj *zobj, int encoding) {
 
         zfree(zobj->ptr);
         zobj->ptr = zs;
 
         zfree(zobj->ptr);
         zobj->ptr = zs;

-        zobj->encoding = REDIS_ENCODING_RAW;
-    } else if (zobj->encoding == REDIS_ENCODING_RAW) {
+        zobj->encoding = REDIS_ENCODING_SKIPLIST;
+    } else if (zobj->encoding == REDIS_ENCODING_SKIPLIST) {

         unsigned char *zl = ziplistNew();
 
         if (encoding != REDIS_ENCODING_ZIPLIST)
         unsigned char *zl = ziplistNew();
 
         if (encoding != REDIS_ENCODING_ZIPLIST)


@@ -872,9 +872,9 @@ void zaddGenericCommand(redisClient *c, int incr) {
              * too long *before* executing zzlInsert. */
             zobj->ptr = zzlInsert(zobj->ptr,ele,score);
             if (zzlLength(zobj->ptr) > server.zset_max_ziplist_entries)
              * too long *before* executing zzlInsert. */
             zobj->ptr = zzlInsert(zobj->ptr,ele,score);
             if (zzlLength(zobj->ptr) > server.zset_max_ziplist_entries)

-                zsetConvert(zobj,REDIS_ENCODING_RAW);
+                zsetConvert(zobj,REDIS_ENCODING_SKIPLIST);

             if (sdslen(ele->ptr) > server.zset_max_ziplist_value)
             if (sdslen(ele->ptr) > server.zset_max_ziplist_value)

-                zsetConvert(zobj,REDIS_ENCODING_RAW);
+                zsetConvert(zobj,REDIS_ENCODING_SKIPLIST);

 
             signalModifiedKey(c->db,key);
             server.dirty++;
 
             signalModifiedKey(c->db,key);
             server.dirty++;


@@ -884,7 +884,7 @@ void zaddGenericCommand(redisClient *c, int incr) {
             else /* ZADD */
                 addReply(c,shared.cone);
         }
             else /* ZADD */
                 addReply(c,shared.cone);
         }

-    } else if (zobj->encoding == REDIS_ENCODING_RAW) {
+    } else if (zobj->encoding == REDIS_ENCODING_SKIPLIST) {

         zset *zs = zobj->ptr;
         zskiplistNode *znode;
         dictEntry *de;
         zset *zs = zobj->ptr;
         zskiplistNode *znode;
         dictEntry *de;


@@ -967,7 +967,7 @@ void zremCommand(redisClient *c) {
             addReply(c,shared.czero);
             return;
         }
             addReply(c,shared.czero);
             return;
         }

-    } else if (zobj->encoding == REDIS_ENCODING_RAW) {
+    } else if (zobj->encoding == REDIS_ENCODING_SKIPLIST) {

         zset *zs = zobj->ptr;
         dictEntry *de;
         double score;
         zset *zs = zobj->ptr;
         dictEntry *de;
         double score;


@@ -1013,7 +1013,7 @@ void zremrangebyscoreCommand(redisClient *c) {
     if (zobj->encoding == REDIS_ENCODING_ZIPLIST) {
         zobj->ptr = zzlDeleteRangeByScore(zobj->ptr,range,&deleted);
         if (zzlLength(zobj->ptr) == 0) dbDelete(c->db,key);
     if (zobj->encoding == REDIS_ENCODING_ZIPLIST) {
         zobj->ptr = zzlDeleteRangeByScore(zobj->ptr,range,&deleted);
         if (zzlLength(zobj->ptr) == 0) dbDelete(c->db,key);

-    } else if (zobj->encoding == REDIS_ENCODING_RAW) {
+    } else if (zobj->encoding == REDIS_ENCODING_SKIPLIST) {

         zset *zs = zobj->ptr;
         deleted = zslDeleteRangeByScore(zs->zsl,range,zs->dict);
         if (htNeedsResize(zs->dict)) dictResize(zs->dict);
         zset *zs = zobj->ptr;
         deleted = zslDeleteRangeByScore(zs->zsl,range,zs->dict);
         if (htNeedsResize(zs->dict)) dictResize(zs->dict);


@@ -1059,7 +1059,7 @@ void zremrangebyrankCommand(redisClient *c) {
         /* Correct for 1-based rank. */
         zobj->ptr = zzlDeleteRangeByRank(zobj->ptr,start+1,end+1,&deleted);
         if (zzlLength(zobj->ptr) == 0) dbDelete(c->db,key);
         /* Correct for 1-based rank. */
         zobj->ptr = zzlDeleteRangeByRank(zobj->ptr,start+1,end+1,&deleted);
         if (zzlLength(zobj->ptr) == 0) dbDelete(c->db,key);

-    } else if (zobj->encoding == REDIS_ENCODING_RAW) {
+    } else if (zobj->encoding == REDIS_ENCODING_SKIPLIST) {

         zset *zs = zobj->ptr;
 
         /* Correct for 1-based rank. */
         zset *zs = zobj->ptr;
 
         /* Correct for 1-based rank. */


@@ -1159,7 +1159,7 @@ void zuiInitIterator(zsetopsrc *op) {
                 it->zl.sptr = ziplistNext(it->zl.zl,it->zl.eptr);
                 redisAssert(it->zl.sptr != NULL);
             }
                 it->zl.sptr = ziplistNext(it->zl.zl,it->zl.eptr);
                 redisAssert(it->zl.sptr != NULL);
             }

-        } else if (op->encoding == REDIS_ENCODING_RAW) {
+        } else if (op->encoding == REDIS_ENCODING_SKIPLIST) {

             it->sl.zs = op->subject->ptr;
             it->sl.node = it->sl.zs->zsl->header->level[0].forward;
         } else {
             it->sl.zs = op->subject->ptr;
             it->sl.node = it->sl.zs->zsl->header->level[0].forward;
         } else {


@@ -1187,7 +1187,7 @@ void zuiClearIterator(zsetopsrc *op) {
         iterzset *it = &op->iter.zset;
         if (op->encoding == REDIS_ENCODING_ZIPLIST) {
             REDIS_NOTUSED(it); /* skip */
         iterzset *it = &op->iter.zset;
         if (op->encoding == REDIS_ENCODING_ZIPLIST) {
             REDIS_NOTUSED(it); /* skip */

-        } else if (op->encoding == REDIS_ENCODING_RAW) {
+        } else if (op->encoding == REDIS_ENCODING_SKIPLIST) {

             REDIS_NOTUSED(it); /* skip */
         } else {
             redisPanic("Unknown sorted set encoding");
             REDIS_NOTUSED(it); /* skip */
         } else {
             redisPanic("Unknown sorted set encoding");


@@ -1214,7 +1214,7 @@ int zuiLength(zsetopsrc *op) {
         iterzset *it = &op->iter.zset;
         if (op->encoding == REDIS_ENCODING_ZIPLIST) {
             return zzlLength(it->zl.zl);
         iterzset *it = &op->iter.zset;
         if (op->encoding == REDIS_ENCODING_ZIPLIST) {
             return zzlLength(it->zl.zl);

-        } else if (op->encoding == REDIS_ENCODING_RAW) {
+        } else if (op->encoding == REDIS_ENCODING_SKIPLIST) {

             return it->sl.zs->zsl->length;
         } else {
             redisPanic("Unknown sorted set encoding");
             return it->sl.zs->zsl->length;
         } else {
             redisPanic("Unknown sorted set encoding");


@@ -1267,7 +1267,7 @@ int zuiNext(zsetopsrc *op, zsetopval *val) {
 
             /* Move to next element. */
             zzlNext(it->zl.zl,&it->zl.eptr,&it->zl.sptr);
 
             /* Move to next element. */
             zzlNext(it->zl.zl,&it->zl.eptr,&it->zl.sptr);

-        } else if (op->encoding == REDIS_ENCODING_RAW) {
+        } else if (op->encoding == REDIS_ENCODING_SKIPLIST) {

             if (it->sl.node == NULL)
                 return 0;
             val->ele = it->sl.node->obj;
             if (it->sl.node == NULL)
                 return 0;
             val->ele = it->sl.node->obj;


@@ -1379,7 +1379,7 @@ int zuiFind(zsetopsrc *op, zsetopval *val, double *score) {
             } else {
                 return 0;
             }
             } else {
                 return 0;
             }

-        } else if (op->encoding == REDIS_ENCODING_RAW) {
+        } else if (op->encoding == REDIS_ENCODING_SKIPLIST) {

             dictEntry *de;
             if ((de = dictFind(it->sl.zs->dict,val->ele)) != NULL) {
                 *score = *(double*)dictGetEntryVal(de);
             dictEntry *de;
             if ((de = dictFind(it->sl.zs->dict,val->ele)) != NULL) {
                 *score = *(double*)dictGetEntryVal(de);


@@ -1692,7 +1692,7 @@ void zrangeGenericCommand(redisClient *c, int reverse) {
                 zzlNext(zl,&eptr,&sptr);
         }
 
                 zzlNext(zl,&eptr,&sptr);
         }
 

-    } else if (zobj->encoding == REDIS_ENCODING_RAW) {
+    } else if (zobj->encoding == REDIS_ENCODING_SKIPLIST) {

         zset *zs = zobj->ptr;
         zskiplist *zsl = zs->zsl;
         zskiplistNode *ln;
         zset *zs = zobj->ptr;
         zskiplist *zsl = zs->zsl;
         zskiplistNode *ln;


@@ -1849,7 +1849,7 @@ void genericZrangebyscoreCommand(redisClient *c, int reverse, int justcount) {
             else
                 zzlNext(zl,&eptr,&sptr);
         }
             else
                 zzlNext(zl,&eptr,&sptr);
         }

-    } else if (zobj->encoding == REDIS_ENCODING_RAW) {
+    } else if (zobj->encoding == REDIS_ENCODING_SKIPLIST) {

         zset *zs = zobj->ptr;
         zskiplist *zsl = zs->zsl;
         zskiplistNode *ln;
         zset *zs = zobj->ptr;
         zskiplist *zsl = zs->zsl;
         zskiplistNode *ln;


@@ -1943,7 +1943,7 @@ void zscoreCommand(redisClient *c) {
             addReplyDouble(c,score);
         else
             addReply(c,shared.nullbulk);
             addReplyDouble(c,score);
         else
             addReply(c,shared.nullbulk);

-    } else if (zobj->encoding == REDIS_ENCODING_RAW) {
+    } else if (zobj->encoding == REDIS_ENCODING_SKIPLIST) {

         zset *zs = zobj->ptr;
         dictEntry *de;
 
         zset *zs = zobj->ptr;
         dictEntry *de;
 


@@ -1997,7 +1997,7 @@ void zrankGenericCommand(redisClient *c, int reverse) {
         } else {
             addReply(c,shared.nullbulk);
         }
         } else {
             addReply(c,shared.nullbulk);
         }

-    } else if (zobj->encoding == REDIS_ENCODING_RAW) {
+    } else if (zobj->encoding == REDIS_ENCODING_SKIPLIST) {

         zset *zs = zobj->ptr;
         zskiplist *zsl = zs->zsl;
         dictEntry *de;
         zset *zs = zobj->ptr;
         zskiplist *zsl = zs->zsl;
         dictEntry *de;

diff --git a/tests/unit/type/zset.tcl b/tests/unit/type/zset.tcl
index 6e32a4b8ad1f186f9029d640ade6544c809e48eb..4fa7af1b3513f6606ee9dea3019c728d176c3687 100644 (file)
--- a/tests/unit/type/zset.tcl
+++ b/tests/unit/type/zset.tcl
@@ -10,7 +10,7 @@ start_server {tags {"zset"}} {
         if {$encoding == "ziplist"} {
             r config set zset-max-ziplist-entries 128
             r config set zset-max-ziplist-value 64
         if {$encoding == "ziplist"} {
             r config set zset-max-ziplist-entries 128
             r config set zset-max-ziplist-value 64

-        } elseif {$encoding == "raw"} {
+        } elseif {$encoding == "skiplist"} {

             r config set zset-max-ziplist-entries 0
             r config set zset-max-ziplist-value 0
         } else {
             r config set zset-max-ziplist-entries 0
             r config set zset-max-ziplist-value 0
         } else {


@@ -458,7 +458,7 @@ start_server {tags {"zset"}} {
     }
 
     basics ziplist
     }
 
     basics ziplist

-    basics raw
+    basics skiplist

 
     proc stressers {encoding} {
         if {$encoding == "ziplist"} {
 
     proc stressers {encoding} {
         if {$encoding == "ziplist"} {


@@ -466,7 +466,7 @@ start_server {tags {"zset"}} {
             r config set zset-max-ziplist-entries 256
             r config set zset-max-ziplist-value 64
             set elements 128
             r config set zset-max-ziplist-entries 256
             r config set zset-max-ziplist-value 64
             set elements 128

-        } elseif {$encoding == "raw"} {
+        } elseif {$encoding == "skiplist"} {

             r config set zset-max-ziplist-entries 0
             r config set zset-max-ziplist-value 0
             set elements 1000
             r config set zset-max-ziplist-entries 0
             r config set zset-max-ziplist-value 0
             set elements 1000


@@ -684,6 +684,6 @@ start_server {tags {"zset"}} {
 
     tags {"slow"} {
         stressers ziplist
 
     tags {"slow"} {
         stressers ziplist

-        stressers raw
+        stressers skiplist

     }
 }
     }
 }