More informative error when DEBUG RELOAD fails.

[redis.git] / src / debug.c

diff --git a/src/debug.c b/src/debug.c
index 0ef27ba1cbe443c62662bacb6ecf8d75def64f8f..7751adf932b280d552d410c7de2537c0bd85a430 100644 (file)
--- a/src/debug.c
+++ b/src/debug.c
@@ -214,7 +214,7 @@ void debugCommand(redisClient *c) {
         *((char*)-1) = 'x';
     } else if (!strcasecmp(c->argv[1]->ptr,"assert")) {
         if (c->argc >= 3) c->argv[2] = tryObjectEncoding(c->argv[2]);
-        redisAssertWithClientInfo(c,1 == 2);
+        redisAssertWithInfo(c,c->argv[0],1 == 2);
     } else if (!strcasecmp(c->argv[1]->ptr,"reload")) {
         if (rdbSave(server.dbfilename) != REDIS_OK) {
             addReply(c,shared.err);
@@ -222,7 +222,7 @@ void debugCommand(redisClient *c) {
         }
         emptyDb();
         if (rdbLoad(server.dbfilename) != REDIS_OK) {
-            addReply(c,shared.err);
+            addReplyError(c,"Error trying to load the RDB dump");
             return;
         }
         redisLog(REDIS_WARNING,"DB reloaded by DEBUG RELOAD");
@@ -306,34 +306,45 @@ void _redisAssert(char *estr, char *file, int line) {
 }
 
 void _redisAssertPrintClientInfo(redisClient *c) {
-    if (c) {
-        int j;
+    int j;
 
-        redisLog(REDIS_WARNING,"=== ASSERTION FAILED CLIENT CONTEXT ===");
-        redisLog(REDIS_WARNING,"client->flags = %d", c->flags);
-        redisLog(REDIS_WARNING,"client->fd = %d", c->fd);
-        redisLog(REDIS_WARNING,"client->argc = %d", c->argc);
-        for (j=0; j < c->argc; j++) {
-            char buf[128];
-            char *arg;
-
-            if (c->argv[j]->type == REDIS_STRING &&
-                c->argv[j]->encoding == REDIS_ENCODING_RAW)
-            {
-                arg = (char*) c->argv[j]->ptr;
-            } else {
-                snprintf(buf,sizeof(buf),"Object type: %d, encoding: %d",
-                    c->argv[j]->type, c->argv[j]->encoding);
-                arg = buf;
-            }
-            redisLog(REDIS_WARNING,"client->argv[%d] = \"%s\" (refcount: %d)",
-                j, arg, c->argv[j]->refcount);
+    redisLog(REDIS_WARNING,"=== ASSERTION FAILED CLIENT CONTEXT ===");
+    redisLog(REDIS_WARNING,"client->flags = %d", c->flags);
+    redisLog(REDIS_WARNING,"client->fd = %d", c->fd);
+    redisLog(REDIS_WARNING,"client->argc = %d", c->argc);
+    for (j=0; j < c->argc; j++) {
+        char buf[128];
+        char *arg;
+
+        if (c->argv[j]->type == REDIS_STRING &&
+            c->argv[j]->encoding == REDIS_ENCODING_RAW)
+        {
+            arg = (char*) c->argv[j]->ptr;
+        } else {
+            snprintf(buf,sizeof(buf),"Object type: %d, encoding: %d",
+                c->argv[j]->type, c->argv[j]->encoding);
+            arg = buf;
         }
+        redisLog(REDIS_WARNING,"client->argv[%d] = \"%s\" (refcount: %d)",
+            j, arg, c->argv[j]->refcount);
+    }
+}
+
+void _redisAssertPrintObject(robj *o) {
+    redisLog(REDIS_WARNING,"=== ASSERTION FAILED OBJECT CONTEXT ===");
+    redisLog(REDIS_WARNING,"Object type: %d", o->type);
+    redisLog(REDIS_WARNING,"Object encoding: %d", o->encoding);
+    redisLog(REDIS_WARNING,"Object refcount: %d", o->refcount);
+    if (o->type == REDIS_STRING && o->encoding == REDIS_ENCODING_RAW) {
+        redisLog(REDIS_WARNING,"Object raw string len: %d", sdslen(o->ptr));
+        if (sdslen(o->ptr) < 4096)
+            redisLog(REDIS_WARNING,"Object raw string content: \"%s\"", (char*)o->ptr);
     }
 }
 
-void _redisAssertWithClientInfo(redisClient *c, char *estr, char *file, int line) {
-    _redisAssertPrintClientInfo(c);
+void _redisAssertWithInfo(redisClient *c, robj *o, char *estr, char *file, int line) {
+    if (c) _redisAssertPrintClientInfo(c);
+    if (o) _redisAssertPrintObject(o);
     _redisAssert(estr,file,line);
 }