Test: MULTI/EXEC tests moved into multi.tcl.

[redis.git] / tests / integration / aof.tcl

diff --git a/tests/integration/aof.tcl b/tests/integration/aof.tcl
index c7ba93c197947d1f4136b4c5fb8c4cdc9a73eed5..ebf9cb5649888843192bebd4eff8eeb4b365251b 100644 (file)
--- a/tests/integration/aof.tcl
+++ b/tests/integration/aof.tcl
@@ -31,13 +31,20 @@ tags {"aof"} {
     }
 
     start_server_aof [list dir $server_path] {
-        test "Unfinished MULTI: Server should not have been started" {
-            assert_equal 0 [is_alive $srv]
-        }
-
         test "Unfinished MULTI: Server should have logged an error" {
-            set result [exec cat [dict get $srv stdout] | tail -n1]
-            assert_match "*Unexpected end of file reading the append only file*" $result
+            set pattern "*Unexpected end of file reading the append only file*"
+            set retry 10
+            while {$retry} {
+                set result [exec tail -n1 < [dict get $srv stdout]]
+                if {[string match $pattern $result]} {
+                    break
+                }
+                incr retry -1
+                after 1000
+            }
+            if {$retry == 0} {
+                error "assertion:expected error not found on config file"
+            }
         }
     }
 
@@ -48,13 +55,20 @@ tags {"aof"} {
     }
 
     start_server_aof [list dir $server_path] {
-        test "Short read: Server should not have been started" {
-            assert_equal 0 [is_alive $srv]
-        }
-
         test "Short read: Server should have logged an error" {
-            set result [exec cat [dict get $srv stdout] | tail -n1]
-            assert_match "*Bad file format reading the append only file*" $result
+            set pattern "*Bad file format reading the append only file*"
+            set retry 10
+            while {$retry} {
+                set result [exec tail -n1 < [dict get $srv stdout]]
+                if {[string match $pattern $result]} {
+                    break
+                }
+                incr retry -1
+                after 1000
+            }
+            if {$retry == 0} {
+                error "assertion:expected error not found on config file"
+            }
         }
     }
 
@@ -67,7 +81,7 @@ tags {"aof"} {
     }
 
     test "Short read: Utility should be able to fix the AOF" {
-        set result [exec echo y | src/redis-check-aof --fix $aof_path]
+        set result [exec src/redis-check-aof --fix $aof_path << "y\n"]
         assert_match "*Successfully truncated AOF*" $result
     }
 
@@ -83,4 +97,47 @@ tags {"aof"} {
             assert_equal "" [$client get bar]
         }
     }
+
+    ## Test that SPOP (that modifies the client its argc/argv) is correctly free'd
+    create_aof {
+        append_to_aof [formatCommand sadd set foo]
+        append_to_aof [formatCommand sadd set bar]
+        append_to_aof [formatCommand spop set]
+    }
+
+    start_server_aof [list dir $server_path] {
+        test "AOF+SPOP: Server should have been started" {
+            assert_equal 1 [is_alive $srv]
+        }
+
+        test "AOF+SPOP: Set should have 1 member" {
+            set client [redis [dict get $srv host] [dict get $srv port]]
+            assert_equal 1 [$client scard set]
+        }
+    }
+
+    ## Test that EXPIREAT is loaded correctly
+    create_aof {
+        append_to_aof [formatCommand rpush list foo]
+        append_to_aof [formatCommand expireat list 1000]
+        append_to_aof [formatCommand rpush list bar]
+    }
+
+    start_server_aof [list dir $server_path] {
+        test "AOF+EXPIRE: Server should have been started" {
+            assert_equal 1 [is_alive $srv]
+        }
+
+        test "AOF+EXPIRE: List should be empty" {
+            set client [redis [dict get $srv host] [dict get $srv port]]
+            assert_equal 0 [$client llen list]
+        }
+    }
+
+    start_server {overrides {appendonly {yes} appendfilename {appendonly.aof}}} {
+        test {Redis should not try to convert DEL into EXPIREAT for EXPIRE -1} {
+            r set x 10
+            r expire x -1
+        }
+    }
 }