Comments about security of slave-read-only in redis.coinf.

[redis.git] / src / redis-cli.c

diff --git a/src/redis-cli.c b/src/redis-cli.c
index 3b3ef50442e614d5ce109f4a944512b0c5dbdd0a..bdaa3964217d26fbeea21207c0ece2098f5d7868 100644 (file)
--- a/src/redis-cli.c
+++ b/src/redis-cli.c
@@ -49,6 +49,10 @@
 
 #define REDIS_NOTUSED(V) ((void) V)
 
 
 #define REDIS_NOTUSED(V) ((void) V)
 

+#define OUTPUT_STANDARD 0
+#define OUTPUT_RAW 1
+#define OUTPUT_CSV 2
+

 static redisContext *context;
 static struct config {
     char *hostip;
 static redisContext *context;
 static struct config {
     char *hostip;


@@ -67,7 +71,7 @@ static struct config {
     int slave_mode;
     int stdinarg; /* get last arg from stdin. (-x option) */
     char *auth;
     int slave_mode;
     int stdinarg; /* get last arg from stdin. (-x option) */
     char *auth;

-    int raw_output; /* output mode per command */
+    int output; /* output mode, see OUTPUT_* defines */

     sds mb_delim;
     char prompt[128];
     char *eval;
     sds mb_delim;
     char prompt[128];
     char *eval;


@@ -435,10 +439,46 @@ static sds cliFormatReplyRaw(redisReply *r) {
     return out;
 }
 
     return out;
 }
 

+static sds cliFormatReplyCSV(redisReply *r) {
+    unsigned int i;
+
+    sds out = sdsempty();
+    switch (r->type) {
+    case REDIS_REPLY_ERROR:
+        out = sdscat(out,"ERROR,");
+        out = sdscatrepr(out,r->str,strlen(r->str));
+    break;
+    case REDIS_REPLY_STATUS:
+        out = sdscatrepr(out,r->str,r->len);
+    break;
+    case REDIS_REPLY_INTEGER:
+        out = sdscatprintf(out,"%lld",r->integer);
+    break;
+    case REDIS_REPLY_STRING:
+        out = sdscatrepr(out,r->str,r->len);
+    break;
+    case REDIS_REPLY_NIL:
+        out = sdscat(out,"NIL\n");
+    break;
+    case REDIS_REPLY_ARRAY:
+        for (i = 0; i < r->elements; i++) {
+            sds tmp = cliFormatReplyCSV(r->element[i]);
+            out = sdscatlen(out,tmp,sdslen(tmp));
+            if (i != r->elements-1) out = sdscat(out,",");
+            sdsfree(tmp);
+        }
+    break;
+    default:
+        fprintf(stderr,"Unknown reply type: %d\n", r->type);
+        exit(1);
+    }
+    return out;
+}
+

 static int cliReadReply(int output_raw_strings) {
     void *_reply;
     redisReply *reply;
 static int cliReadReply(int output_raw_strings) {
     void *_reply;
     redisReply *reply;

-    sds out;
+    sds out = NULL;

     int output = 1;
 
     if (redisGetReply(context,&_reply) != REDIS_OK) {
     int output = 1;
 
     if (redisGetReply(context,&_reply) != REDIS_OK) {


@@ -458,7 +498,8 @@ static int cliReadReply(int output_raw_strings) {
 
     reply = (redisReply*)_reply;
 
 
     reply = (redisReply*)_reply;
 

-    /* Check if we need to connect to a different node and reissue the request. */
+    /* Check if we need to connect to a different node and reissue the
+     * request. */

     if (config.cluster_mode && reply->type == REDIS_REPLY_ERROR &&
         (!strncmp(reply->str,"MOVED",5) || !strcmp(reply->str,"ASK")))
     {
     if (config.cluster_mode && reply->type == REDIS_REPLY_ERROR &&
         (!strncmp(reply->str,"MOVED",5) || !strcmp(reply->str,"ASK")))
     {


@@ -490,11 +531,14 @@ static int cliReadReply(int output_raw_strings) {
         if (output_raw_strings) {
             out = cliFormatReplyRaw(reply);
         } else {
         if (output_raw_strings) {
             out = cliFormatReplyRaw(reply);
         } else {

-            if (config.raw_output) {
+            if (config.output == OUTPUT_RAW) {

                 out = cliFormatReplyRaw(reply);
                 out = sdscat(out,"\n");
                 out = cliFormatReplyRaw(reply);
                 out = sdscat(out,"\n");

-            } else {
+            } else if (config.output == OUTPUT_STANDARD) {

                 out = cliFormatReplyTTY(reply,"");
                 out = cliFormatReplyTTY(reply,"");

+            } else if (config.output == OUTPUT_CSV) {
+                out = cliFormatReplyCSV(reply);
+                out = sdscat(out,"\n");

             }
         }
         fwrite(out,sdslen(out),1,stdout);
             }
         }
         fwrite(out,sdslen(out),1,stdout);


@@ -546,7 +590,7 @@ static int cliSendCommand(int argc, char **argv, int repeat) {
         }
 
         if (config.pubsub_mode) {
         }
 
         if (config.pubsub_mode) {

-            if (!config.raw_output)
+            if (config.output != OUTPUT_RAW)

                 printf("Reading messages... (press Ctrl-C to quit)\n");
             while (1) {
                 if (cliReadReply(output_raw) != REDIS_OK) exit(1);
                 printf("Reading messages... (press Ctrl-C to quit)\n");
             while (1) {
                 if (cliReadReply(output_raw) != REDIS_OK) exit(1);


@@ -604,7 +648,9 @@ static int parseOptions(int argc, char **argv) {
         } else if (!strcmp(argv[i],"-a") && !lastarg) {
             config.auth = argv[++i];
         } else if (!strcmp(argv[i],"--raw")) {
         } else if (!strcmp(argv[i],"-a") && !lastarg) {
             config.auth = argv[++i];
         } else if (!strcmp(argv[i],"--raw")) {

-            config.raw_output = 1;
+            config.output = OUTPUT_RAW;
+        } else if (!strcmp(argv[i],"--csv")) {
+            config.output = OUTPUT_CSV;

         } else if (!strcmp(argv[i],"--latency")) {
             config.latency_mode = 1;
         } else if (!strcmp(argv[i],"--slave")) {
         } else if (!strcmp(argv[i],"--latency")) {
             config.latency_mode = 1;
         } else if (!strcmp(argv[i],"--slave")) {


@@ -881,7 +927,10 @@ static void slaveMode(void) {
     unsigned long long payload;
 
     /* Send the SYNC command. */
     unsigned long long payload;
 
     /* Send the SYNC command. */

-    write(fd,"SYNC\r\n",6);
+    if (write(fd,"SYNC\r\n",6) != 6) {
+        fprintf(stderr,"Error writing to master\n");
+        exit(1);
+    }

 
     /* Read $<payload>\r\n, making sure to read just up to "\n" */
     p = buf;
 
     /* Read $<payload>\r\n, making sure to read just up to "\n" */
     p = buf;


@@ -896,8 +945,7 @@ static void slaveMode(void) {
     }
     *p = '\0';
     payload = strtoull(buf+1,NULL,10);
     }
     *p = '\0';
     payload = strtoull(buf+1,NULL,10);

-    if (!config.raw_output)
-        printf("SYNC with master, discarding %lld bytes of bulk tranfer...\n",
+    fprintf(stderr,"SYNC with master, discarding %lld bytes of bulk tranfer...\n",

             payload);
 
     /* Discard the payload. */
             payload);
 
     /* Discard the payload. */


@@ -909,10 +957,11 @@ static void slaveMode(void) {
         }
         payload -= nread;
     }
         }
         payload -= nread;
     }

-    if (!config.raw_output) printf("SYNC done. Logging commands from master.\n");
+    fprintf(stderr,"SYNC done. Logging commands from master.\n");

 
     /* Now we can use the hiredis to read the incoming protocol. */
 
     /* Now we can use the hiredis to read the incoming protocol. */

-    while (cliReadReply(config.raw_output) == REDIS_OK);
+    config.output = OUTPUT_CSV;
+    while (cliReadReply(0) == REDIS_OK);

 }
 
 int main(int argc, char **argv) {
 }
 
 int main(int argc, char **argv) {


@@ -933,7 +982,10 @@ int main(int argc, char **argv) {
     config.stdinarg = 0;
     config.auth = NULL;
     config.eval = NULL;
     config.stdinarg = 0;
     config.auth = NULL;
     config.eval = NULL;

-    config.raw_output = !isatty(fileno(stdout)) && (getenv("FAKETTY") == NULL);
+    if (!isatty(fileno(stdout)) && (getenv("FAKETTY") == NULL))
+        config.output = OUTPUT_RAW;
+    else
+        config.output = OUTPUT_STANDARD;

     config.mb_delim = sdsnew("\n");
     cliInitHelp();
 
     config.mb_delim = sdsnew("\n");
     cliInitHelp();