Do not update the LRU info on key lookup when we have a saving child. With this trivi...

[redis.git] / src / db.c

diff --git a/src/db.c b/src/db.c
index c1ce79b56310949f08368dab7b836aa83f3299e7..f2a0c09ee09658823ad783ca4446b6c85e787c99 100644 (file)
--- a/src/db.c
+++ b/src/db.c
@@ -11,8 +11,11 @@ robj *lookupKey(redisDb *db, robj *key) {
     if (de) {
         robj *val = dictGetEntryVal(de);
 
-        /* Update the access time for the aging algorithm. */
-        val->lru = server.lruclock;
+        /* Update the access time for the aging algorithm.
+         * Don't do it if we have a saving child, as this will trigger
+         * a copy on write madness. */
+        if (server.bgsavechildpid == -1 && server.bgrewritechildpid == -1)
+            val->lru = server.lruclock;
 
         if (server.vm_enabled) {
             if (val->storage == REDIS_VM_MEMORY ||
@@ -34,8 +37,10 @@ robj *lookupKey(redisDb *db, robj *key) {
                 if (notify) handleClientsBlockedOnSwappedKey(db,key);
             }
         }
+        server.stat_keyspace_hits++;
         return val;
     } else {
+        server.stat_keyspace_misses++;
         return NULL;
     }
 }
@@ -468,7 +473,6 @@ int expireIfNeeded(redisDb *db, robj *key) {
 
     /* Delete the key */
     server.stat_expiredkeys++;
-    server.dirty++;
     propagateExpire(db,key);
     return dbDelete(db,key);
 }