patch config.h for sync_file_range

[redis.git] / src / scripting.c

diff --git a/src/scripting.c b/src/scripting.c
index 01aa2006f3ddd02fad86bd09ac9c7b5ac25c768a..6f9ec2e89da0a35dae162fbebf564b5429f3f382 100644 (file)
--- a/src/scripting.c
+++ b/src/scripting.c
@@ -544,14 +544,6 @@ void scriptingInit(void) {
     lua_pushcfunction(lua, luaRedisSha1hexCommand);
     lua_settable(lua, -3);
 
-    /* redis.NIL */
-    lua_pushstring(lua, "NIL");
-    lua_newtable(lua);
-    lua_pushstring(lua, "nilbulk");
-    lua_pushboolean(lua, 1);
-    lua_settable(lua, -3);
-    lua_settable(lua, -3);
-
     /* redis.error_reply and redis.status_reply */
     lua_pushstring(lua, "error_reply");
     lua_pushcfunction(lua, luaRedisErrorReplyCommand);
@@ -654,30 +646,9 @@ void luaReplyToRedisReply(redisClient *c, lua_State *lua) {
         addReplyLongLong(c,(long long)lua_tonumber(lua,-1));
         break;
     case LUA_TTABLE:
-        /* The table can be an array or it may be in a special format that
-         * Lua uses to return special Redis protocol data types.
-         *
-         * 1) Errors are retuned as a single element table with 'err' field.
-         * 2) Status reply are returned as a single element table with 'ok'
-         *    field.
-         * 3) A Redis nil bulk reply is returned as a single element table
-         *    with 'nilbulk' field set to true.
-         *
-         * All the rest is considered just an array and is translated into
-         * a Redis multi bulk reply. */
-
-        /* Nil bulk reply */
-        lua_pushstring(lua,"nilbulk");
-        lua_gettable(lua,-2);
-        t = lua_type(lua,-1);
-        if (t == LUA_TBOOLEAN) {
-            addReply(c,shared.nullbulk);
-            lua_pop(lua,2);
-            return;
-        }
-        lua_pop(lua,1);
-
-        /* Error reply */
+        /* We need to check if it is an array, an error, or a status reply.
+         * Error are returned as a single element table with 'err' field.
+         * Status replies are returned as single elment table with 'ok' field */
         lua_pushstring(lua,"err");
         lua_gettable(lua,-2);
         t = lua_type(lua,-1);
@@ -689,9 +660,8 @@ void luaReplyToRedisReply(redisClient *c, lua_State *lua) {
             lua_pop(lua,2);
             return;
         }
-        lua_pop(lua,1);
 
-        /* Status reply */
+        lua_pop(lua,1);
         lua_pushstring(lua,"ok");
         lua_gettable(lua,-2);
         t = lua_type(lua,-1);
@@ -702,7 +672,6 @@ void luaReplyToRedisReply(redisClient *c, lua_State *lua) {
             sdsfree(ok);
             lua_pop(lua,1);
         } else {
-            /* Multi bulk reply. */
             void *replylen = addDeferredMultiBulkLength(c);
             int j = 1, mbulklen = 0;
 
@@ -1008,9 +977,9 @@ void scriptCommand(redisClient *c) {
         sdsfree(sha);
     } else if (c->argc == 2 && !strcasecmp(c->argv[1]->ptr,"kill")) {
         if (server.lua_caller == NULL) {
-            addReplyError(c,"No scripts in execution right now.");
+            addReplySds(c,sdsnew("-NOTBUSY No scripts in execution right now.\r\n"));
         } else if (server.lua_write_dirty) {
-            addReplyError(c, "Sorry the script already executed write commands against the dataset. You can either wait the script termination or kill the server in an hard way using the SHUTDOWN NOSAVE command.");
+            addReplySds(c,sdsnew("-UNKILLABLE Sorry the script already executed write commands against the dataset. You can either wait the script termination or kill the server in an hard way using the SHUTDOWN NOSAVE command.\r\n"));
         } else {
             server.lua_kill = 1;
             addReply(c,shared.ok);