Fixed a never experienced, theoretical bug that can actually happen in practice....

[redis.git] / zmalloc.c

diff --git a/zmalloc.c b/zmalloc.c
index c76b2746e30c7063735c3b411205c127d44c99c7..64263756ea2ccb2a5391e028a449fffae4e66773 100644 (file)
--- a/zmalloc.c
+++ b/zmalloc.c
@@ -28,46 +28,87 @@
  * POSSIBILITY OF SUCH DAMAGE.
  */
 
  * POSSIBILITY OF SUCH DAMAGE.
  */
 

+#include <stdio.h>

 #include <stdlib.h>
 #include <string.h>
 #include <stdlib.h>
 #include <string.h>

+#include <pthread.h>
+#include "config.h"
+
+#if defined(__sun)
+#define PREFIX_SIZE sizeof(long long)
+#else
+#define PREFIX_SIZE sizeof(size_t)
+#endif

 
 static size_t used_memory = 0;
 
 static size_t used_memory = 0;

+pthread_mutex_t used_memory_mutex = PTHREAD_MUTEX_INITIALIZER;
+
+static void zmalloc_oom(size_t size) {
+    fprintf(stderr, "zmalloc: Out of memory trying to allocate %zu bytes\n",
+        size);
+    fflush(stderr);
+    abort();
+}

 
 void *zmalloc(size_t size) {
 
 void *zmalloc(size_t size) {

-    void *ptr = malloc(size+sizeof(size_t));
+    void *ptr = malloc(size+PREFIX_SIZE);

 
 

-    if (!ptr) return NULL;
+    if (!ptr) zmalloc_oom(size);
+#ifdef HAVE_MALLOC_SIZE
+    used_memory += redis_malloc_size(ptr);
+    return ptr;
+#else

     *((size_t*)ptr) = size;
     *((size_t*)ptr) = size;

-    used_memory += size+sizeof(size_t);
-    return (char*)ptr+sizeof(size_t);
+    used_memory += size+PREFIX_SIZE;
+    return (char*)ptr+PREFIX_SIZE;
+#endif

 }
 
 void *zrealloc(void *ptr, size_t size) {
 }
 
 void *zrealloc(void *ptr, size_t size) {

+#ifndef HAVE_MALLOC_SIZE

     void *realptr;
     void *realptr;

+#endif

     size_t oldsize;
     void *newptr;
 
     if (ptr == NULL) return zmalloc(size);
     size_t oldsize;
     void *newptr;
 
     if (ptr == NULL) return zmalloc(size);

-    realptr = (char*)ptr-sizeof(size_t);
+#ifdef HAVE_MALLOC_SIZE
+    oldsize = redis_malloc_size(ptr);
+    newptr = realloc(ptr,size);
+    if (!newptr) zmalloc_oom(size);
+
+    used_memory -= oldsize;
+    used_memory += redis_malloc_size(newptr);
+    return newptr;
+#else
+    realptr = (char*)ptr-PREFIX_SIZE;

     oldsize = *((size_t*)realptr);
     oldsize = *((size_t*)realptr);

-    newptr = realloc(realptr,size+sizeof(size_t));
-    if (!newptr) return NULL;
+    newptr = realloc(realptr,size+PREFIX_SIZE);
+    if (!newptr) zmalloc_oom(size);

 
     *((size_t*)newptr) = size;
     used_memory -= oldsize;
     used_memory += size;
 
     *((size_t*)newptr) = size;
     used_memory -= oldsize;
     used_memory += size;

-    return (char*)newptr+sizeof(size_t);
+    return (char*)newptr+PREFIX_SIZE;
+#endif

 }
 
 void zfree(void *ptr) {
 }
 
 void zfree(void *ptr) {

+#ifndef HAVE_MALLOC_SIZE

     void *realptr;
     size_t oldsize;
     void *realptr;
     size_t oldsize;

+#endif

 
     if (ptr == NULL) return;
 
     if (ptr == NULL) return;

-    realptr = (char*)ptr-sizeof(size_t);
+#ifdef HAVE_MALLOC_SIZE
+    used_memory -= redis_malloc_size(ptr);
+    free(ptr);
+#else
+    realptr = (char*)ptr-PREFIX_SIZE;

     oldsize = *((size_t*)realptr);
     oldsize = *((size_t*)realptr);

-    used_memory -= oldsize+sizeof(size_t);
+    used_memory -= oldsize+PREFIX_SIZE;

     free(realptr);
     free(realptr);

+#endif

 }
 
 char *zstrdup(const char *s) {
 }
 
 char *zstrdup(const char *s) {