* POSSIBILITY OF SUCH DAMAGE.
*/
-#define REDIS_VERSION "0.07"
+#define REDIS_VERSION "0.08"
#include <stdio.h>
#include <stdlib.h>
#define REDIS_CLOSE 1 /* This client connection should be closed ASAP */
#define REDIS_SLAVE 2 /* This client is a slave server */
#define REDIS_MASTER 4 /* This client is a master server */
+#define REDIS_MONITOR 8 /* This client is a slave monitor, see MONITOR */
/* Server replication state */
#define REDIS_REPL_NONE 0 /* No active replication */
list *reply;
int sentlen;
time_t lastinteraction; /* time of the last interaction, used for timeout */
- int flags; /* REDIS_CLOSE | REDIS_SLAVE */
+ int flags; /* REDIS_CLOSE | REDIS_SLAVE | REDIS_MONITOR */
int slaveseldb; /* slave selected db, if this client is a slave */
} redisClient;
dict **dict;
long long dirty; /* changes to DB from the last save */
list *clients;
- list *slaves;
+ list *slaves, *monitors;
char neterr[ANET_ERR_LEN];
aeEventLoop *el;
int cronloops; /* number of times the cron function run */
int maxidletime;
int dbnum;
int daemonize;
+ char *pidfile;
int bgsaveinprogress;
struct saveparam *saveparams;
int saveparamslen;
} redisSortOperation;
struct sharedObjectsStruct {
- robj *crlf, *ok, *err, *zerobulk, *nil, *zero, *one, *pong, *space,
- *minus1, *minus2, *minus3, *minus4,
- *wrongtypeerr, *nokeyerr, *wrongtypeerrbulk, *nokeyerrbulk,
- *syntaxerr, *syntaxerrbulk,
+ robj *crlf, *ok, *err, *emptybulk, *czero, *cone, *pong, *space,
+ *colon, *nullbulk, *nullmultibulk,
+ *emptymultibulk, *wrongtypeerr, *nokeyerr, *syntaxerr, *sameobjecterr,
+ *outofrangeerr, *plus,
*select0, *select1, *select2, *select3, *select4,
*select5, *select6, *select7, *select8, *select9;
} shared;
static void incrRefCount(robj *o);
static int saveDbBackground(char *filename);
static robj *createStringObject(char *ptr, size_t len);
-static void replicationFeedSlaves(struct redisCommand *cmd, int dictid, robj **argv, int argc);
+static void replicationFeedSlaves(list *slaves, struct redisCommand *cmd, int dictid, robj **argv, int argc);
static int syncWithMaster(void);
static void pingCommand(redisClient *c);
static void lremCommand(redisClient *c);
static void infoCommand(redisClient *c);
static void mgetCommand(redisClient *c);
+static void monitorCommand(redisClient *c);
/*================================= Globals ================================= */
{"flushall",flushallCommand,1,REDIS_CMD_INLINE},
{"sort",sortCommand,-2,REDIS_CMD_INLINE},
{"info",infoCommand,1,REDIS_CMD_INLINE},
+ {"monitor",monitorCommand,1,REDIS_CMD_INLINE},
{NULL,NULL,0,0}
};
shared.crlf = createObject(REDIS_STRING,sdsnew("\r\n"));
shared.ok = createObject(REDIS_STRING,sdsnew("+OK\r\n"));
shared.err = createObject(REDIS_STRING,sdsnew("-ERR\r\n"));
- shared.zerobulk = createObject(REDIS_STRING,sdsnew("0\r\n\r\n"));
- shared.nil = createObject(REDIS_STRING,sdsnew("nil\r\n"));
- shared.zero = createObject(REDIS_STRING,sdsnew("0\r\n"));
- shared.one = createObject(REDIS_STRING,sdsnew("1\r\n"));
+ shared.emptybulk = createObject(REDIS_STRING,sdsnew("$0\r\n\r\n"));
+ shared.czero = createObject(REDIS_STRING,sdsnew(":0\r\n"));
+ shared.cone = createObject(REDIS_STRING,sdsnew(":1\r\n"));
+ shared.nullbulk = createObject(REDIS_STRING,sdsnew("$-1\r\n"));
+ shared.nullmultibulk = createObject(REDIS_STRING,sdsnew("*-1\r\n"));
+ shared.emptymultibulk = createObject(REDIS_STRING,sdsnew("*0\r\n"));
/* no such key */
- shared.minus1 = createObject(REDIS_STRING,sdsnew("-1\r\n"));
- /* operation against key holding a value of the wrong type */
- shared.minus2 = createObject(REDIS_STRING,sdsnew("-2\r\n"));
- /* src and dest objects are the same */
- shared.minus3 = createObject(REDIS_STRING,sdsnew("-3\r\n"));
- /* out of range argument */
- shared.minus4 = createObject(REDIS_STRING,sdsnew("-4\r\n"));
shared.pong = createObject(REDIS_STRING,sdsnew("+PONG\r\n"));
shared.wrongtypeerr = createObject(REDIS_STRING,sdsnew(
"-ERR Operation against a key holding the wrong kind of value\r\n"));
- shared.wrongtypeerrbulk = createObject(REDIS_STRING,sdscatprintf(sdsempty(),"%d\r\n%s",-sdslen(shared.wrongtypeerr->ptr)+2,shared.wrongtypeerr->ptr));
shared.nokeyerr = createObject(REDIS_STRING,sdsnew(
"-ERR no such key\r\n"));
- shared.nokeyerrbulk = createObject(REDIS_STRING,sdscatprintf(sdsempty(),"%d\r\n%s",-sdslen(shared.nokeyerr->ptr)+2,shared.nokeyerr->ptr));
shared.syntaxerr = createObject(REDIS_STRING,sdsnew(
"-ERR syntax error\r\n"));
- shared.syntaxerrbulk = createObject(REDIS_STRING,sdscatprintf(sdsempty(),"%d\r\n%s",-sdslen(shared.syntaxerr->ptr)+2,shared.syntaxerr->ptr));
+ shared.sameobjecterr = createObject(REDIS_STRING,sdsnew(
+ "-ERR source and destination objects are the same\r\n"));
+ shared.outofrangeerr = createObject(REDIS_STRING,sdsnew(
+ "-ERR index out of range\r\n"));
shared.space = createObject(REDIS_STRING,sdsnew(" "));
+ shared.colon = createObject(REDIS_STRING,sdsnew(":"));
+ shared.plus = createObject(REDIS_STRING,sdsnew("+"));
shared.select0 = createStringObject("select 0\r\n",10);
shared.select1 = createStringObject("select 1\r\n",10);
shared.select2 = createStringObject("select 2\r\n",10);
server.bindaddr = NULL;
server.glueoutputbuf = 1;
server.daemonize = 0;
+ server.pidfile = "/var/run/redis.pid";
server.dbfilename = "dump.rdb";
ResetServerSaveParams();
server.clients = listCreate();
server.slaves = listCreate();
+ server.monitors = listCreate();
server.objfreelist = listCreate();
createSharedObjects();
server.el = aeCreateEventLoop();
server.dict = zmalloc(sizeof(dict*)*server.dbnum);
- if (!server.dict || !server.clients || !server.slaves || !server.el || !server.objfreelist)
+ if (!server.dict || !server.clients || !server.slaves || !server.monitors || !server.el || !server.objfreelist)
oom("server initialization"); /* Fatal OOM */
server.fd = anetTcpServer(server.neterr, server.port, server.bindaddr);
if (server.fd == -1) {
else {
err = "argument must be 'yes' or 'no'"; goto loaderr;
}
+ } else if (!strcmp(argv[0],"pidfile") && argc == 2) {
+ server.pidfile = zstrdup(argv[1]);
} else {
err = "Bad directive or wrong number of arguments"; goto loaderr;
}
assert(ln != NULL);
listDelNode(server.clients,ln);
if (c->flags & REDIS_SLAVE) {
- ln = listSearchKey(server.slaves,c);
+ list *l = (c->flags & REDIS_MONITOR) ? server.monitors : server.slaves;
+ ln = listSearchKey(l,c);
assert(ln != NULL);
- listDelNode(server.slaves,ln);
+ listDelNode(l,ln);
}
if (c->flags & REDIS_MASTER) {
server.master = NULL;
dirty = server.dirty;
cmd->proc(c);
if (server.dirty-dirty != 0 && listLength(server.slaves))
- replicationFeedSlaves(cmd,c->dictid,c->argv,c->argc);
+ replicationFeedSlaves(server.slaves,cmd,c->dictid,c->argv,c->argc);
+ if (listLength(server.monitors))
+ replicationFeedSlaves(server.monitors,cmd,c->dictid,c->argv,c->argc);
server.stat_numcommands++;
/* Prepare the client for the next command */
return 1;
}
-static void replicationFeedSlaves(struct redisCommand *cmd, int dictid, robj **argv, int argc) {
- listNode *ln = server.slaves->head;
+static void replicationFeedSlaves(list *slaves, struct redisCommand *cmd, int dictid, robj **argv, int argc) {
+ listNode *ln = slaves->head;
robj *outv[REDIS_MAX_ARGS*4]; /* enough room for args, spaces, newlines */
int outc = 0, j;
return REDIS_OK; /* unreached */
}
+static int loadType(FILE *fp) {
+ uint8_t type;
+ if (fread(&type,1,1,fp) == 0) return -1;
+ return type;
+}
+
static int loadDb(char *filename) {
FILE *fp;
char buf[REDIS_LOADBUF_LEN]; /* Try to use this buffer instead of */
char vbuf[REDIS_LOADBUF_LEN]; /* malloc() when the element is small */
char *key = NULL, *val = NULL;
uint32_t klen,vlen,dbid;
- uint8_t type;
+ int type;
int retval;
dict *d = server.dict[0];
robj *o;
/* Read type. */
- if (fread(&type,1,1,fp) == 0) goto eoferr;
+ if ((type = loadType(fp)) == -1) goto eoferr;
if (type == REDIS_EOF) break;
/* Handle SELECT DB opcode as a special case */
if (type == REDIS_SELECTDB) {
}
static void echoCommand(redisClient *c) {
- addReplySds(c,sdscatprintf(sdsempty(),"%d\r\n",
+ addReplySds(c,sdscatprintf(sdsempty(),"$%d\r\n",
(int)sdslen(c->argv[1]->ptr)));
addReply(c,c->argv[1]);
addReply(c,shared.crlf);
dictReplace(c->dict,c->argv[1],c->argv[2]);
incrRefCount(c->argv[2]);
} else {
- addReply(c,shared.zero);
+ addReply(c,shared.czero);
return;
}
} else {
incrRefCount(c->argv[2]);
}
server.dirty++;
- addReply(c, nx ? shared.one : shared.ok);
+ addReply(c, nx ? shared.cone : shared.ok);
}
static void setCommand(redisClient *c) {
de = dictFind(c->dict,c->argv[1]);
if (de == NULL) {
- addReply(c,shared.nil);
+ addReply(c,shared.nullbulk);
} else {
robj *o = dictGetEntryVal(de);
if (o->type != REDIS_STRING) {
- addReply(c,shared.wrongtypeerrbulk);
+ addReply(c,shared.wrongtypeerr);
} else {
- addReplySds(c,sdscatprintf(sdsempty(),"%d\r\n",(int)sdslen(o->ptr)));
+ addReplySds(c,sdscatprintf(sdsempty(),"$%d\r\n",(int)sdslen(o->ptr)));
addReply(c,o);
addReply(c,shared.crlf);
}
dictEntry *de;
int j;
- addReplySds(c,sdscatprintf(sdsempty(),"%d\r\n",c->argc-1));
+ addReplySds(c,sdscatprintf(sdsempty(),"*%d\r\n",c->argc-1));
for (j = 1; j < c->argc; j++) {
de = dictFind(c->dict,c->argv[j]);
if (de == NULL) {
- addReply(c,shared.minus1);
+ addReply(c,shared.nullbulk);
} else {
robj *o = dictGetEntryVal(de);
if (o->type != REDIS_STRING) {
- addReply(c,shared.minus1);
+ addReply(c,shared.nullbulk);
} else {
- addReplySds(c,sdscatprintf(sdsempty(),"%d\r\n",(int)sdslen(o->ptr)));
+ addReplySds(c,sdscatprintf(sdsempty(),"$%d\r\n",(int)sdslen(o->ptr)));
addReply(c,o);
addReply(c,shared.crlf);
}
incrRefCount(c->argv[1]);
}
server.dirty++;
+ addReply(c,shared.colon);
addReply(c,o);
addReply(c,shared.crlf);
}
static void delCommand(redisClient *c) {
if (dictDelete(c->dict,c->argv[1]) == DICT_OK) {
server.dirty++;
- addReply(c,shared.one);
+ addReply(c,shared.cone);
} else {
- addReply(c,shared.zero);
+ addReply(c,shared.czero);
}
}
de = dictFind(c->dict,c->argv[1]);
if (de == NULL)
- addReply(c,shared.zero);
+ addReply(c,shared.czero);
else
- addReply(c,shared.one);
+ addReply(c,shared.cone);
}
static void selectCommand(redisClient *c) {
if (de == NULL) {
addReply(c,shared.crlf);
} else {
+ addReply(c,shared.plus);
addReply(c,dictGetEntryKey(de));
addReply(c,shared.crlf);
}
}
}
dictReleaseIterator(di);
- lenobj->ptr = sdscatprintf(sdsempty(),"%lu\r\n",keyslen+(numkeys ? (numkeys-1) : 0));
+ lenobj->ptr = sdscatprintf(sdsempty(),"$%lu\r\n",keyslen+(numkeys ? (numkeys-1) : 0));
addReply(c,shared.crlf);
}
static void dbsizeCommand(redisClient *c) {
addReplySds(c,
- sdscatprintf(sdsempty(),"%lu\r\n",dictGetHashTableUsed(c->dict)));
+ sdscatprintf(sdsempty(),":%lu\r\n",dictGetHashTableUsed(c->dict)));
}
static void lastsaveCommand(redisClient *c) {
addReplySds(c,
- sdscatprintf(sdsempty(),"%lu\r\n",server.lastsave));
+ sdscatprintf(sdsempty(),":%lu\r\n",server.lastsave));
}
static void typeCommand(redisClient *c) {
de = dictFind(c->dict,c->argv[1]);
if (de == NULL) {
- type = "none";
+ type = "+none";
} else {
robj *o = dictGetEntryVal(de);
switch(o->type) {
- case REDIS_STRING: type = "string"; break;
- case REDIS_LIST: type = "list"; break;
- case REDIS_SET: type = "set"; break;
+ case REDIS_STRING: type = "+string"; break;
+ case REDIS_LIST: type = "+list"; break;
+ case REDIS_SET: type = "+set"; break;
default: type = "unknown"; break;
}
}
static void shutdownCommand(redisClient *c) {
redisLog(REDIS_WARNING,"User requested shutdown, saving DB...");
if (saveDb(server.dbfilename) == REDIS_OK) {
+ if (server.daemonize) {
+ unlink(server.pidfile);
+ }
redisLog(REDIS_WARNING,"Server exit now, bye bye...");
exit(1);
} else {
/* To use the same key as src and dst is probably an error */
if (sdscmp(c->argv[1]->ptr,c->argv[2]->ptr) == 0) {
- if (nx)
- addReply(c,shared.minus3);
- else
- addReplySds(c,sdsnew("-ERR src and dest key are the same\r\n"));
+ addReply(c,shared.sameobjecterr);
return;
}
de = dictFind(c->dict,c->argv[1]);
if (de == NULL) {
- if (nx)
- addReply(c,shared.minus1);
- else
- addReply(c,shared.nokeyerr);
+ addReply(c,shared.nokeyerr);
return;
}
o = dictGetEntryVal(de);
if (dictAdd(c->dict,c->argv[2],o) == DICT_ERR) {
if (nx) {
decrRefCount(o);
- addReply(c,shared.zero);
+ addReply(c,shared.czero);
return;
}
dictReplace(c->dict,c->argv[2],o);
}
dictDelete(c->dict,c->argv[1]);
server.dirty++;
- addReply(c,nx ? shared.one : shared.ok);
+ addReply(c,nx ? shared.cone : shared.ok);
}
static void renameCommand(redisClient *c) {
src = c->dict;
srcid = c->dictid;
if (selectDb(c,atoi(c->argv[2]->ptr)) == REDIS_ERR) {
- addReply(c,shared.minus4);
+ addReply(c,shared.outofrangeerr);
return;
}
dst = c->dict;
/* If the user is moving using as target the same
* DB as the source DB it is probably an error. */
if (src == dst) {
- addReply(c,shared.minus3);
+ addReply(c,shared.sameobjecterr);
return;
}
/* Check if the element exists and get a reference */
de = dictFind(c->dict,c->argv[1]);
if (!de) {
- addReply(c,shared.zero);
+ addReply(c,shared.czero);
return;
}
key = dictGetEntryKey(de);
o = dictGetEntryVal(de);
if (dictAdd(dst,key,o) == DICT_ERR) {
- addReply(c,shared.zero);
+ addReply(c,shared.czero);
return;
}
incrRefCount(key);
/* OK! key moved, free the entry in the source DB */
dictDelete(src,c->argv[1]);
server.dirty++;
- addReply(c,shared.one);
+ addReply(c,shared.cone);
}
/* =================================== Lists ================================ */
de = dictFind(c->dict,c->argv[1]);
if (de == NULL) {
- addReply(c,shared.zero);
+ addReply(c,shared.czero);
return;
} else {
robj *o = dictGetEntryVal(de);
if (o->type != REDIS_LIST) {
- addReply(c,shared.minus2);
+ addReply(c,shared.wrongtypeerr);
} else {
l = o->ptr;
- addReplySds(c,sdscatprintf(sdsempty(),"%d\r\n",listLength(l)));
+ addReplySds(c,sdscatprintf(sdsempty(),":%d\r\n",listLength(l)));
}
}
}
de = dictFind(c->dict,c->argv[1]);
if (de == NULL) {
- addReply(c,shared.nil);
+ addReply(c,shared.nullbulk);
} else {
robj *o = dictGetEntryVal(de);
if (o->type != REDIS_LIST) {
- addReply(c,shared.wrongtypeerrbulk);
+ addReply(c,shared.wrongtypeerr);
} else {
list *list = o->ptr;
listNode *ln;
ln = listIndex(list, index);
if (ln == NULL) {
- addReply(c,shared.nil);
+ addReply(c,shared.nullbulk);
} else {
robj *ele = listNodeValue(ln);
- addReplySds(c,sdscatprintf(sdsempty(),"%d\r\n",(int)sdslen(ele->ptr)));
+ addReplySds(c,sdscatprintf(sdsempty(),"$%d\r\n",(int)sdslen(ele->ptr)));
addReply(c,ele);
addReply(c,shared.crlf);
}
ln = listIndex(list, index);
if (ln == NULL) {
- addReplySds(c,sdsnew("-ERR index out of range\r\n"));
+ addReply(c,shared.outofrangeerr);
} else {
robj *ele = listNodeValue(ln);
de = dictFind(c->dict,c->argv[1]);
if (de == NULL) {
- addReply(c,shared.nil);
+ addReply(c,shared.nullbulk);
} else {
robj *o = dictGetEntryVal(de);
if (o->type != REDIS_LIST) {
- addReply(c,shared.wrongtypeerrbulk);
+ addReply(c,shared.wrongtypeerr);
} else {
list *list = o->ptr;
listNode *ln;
ln = listLast(list);
if (ln == NULL) {
- addReply(c,shared.nil);
+ addReply(c,shared.nullbulk);
} else {
robj *ele = listNodeValue(ln);
- addReplySds(c,sdscatprintf(sdsempty(),"%d\r\n",(int)sdslen(ele->ptr)));
+ addReplySds(c,sdscatprintf(sdsempty(),"$%d\r\n",(int)sdslen(ele->ptr)));
addReply(c,ele);
addReply(c,shared.crlf);
listDelNode(list,ln);
de = dictFind(c->dict,c->argv[1]);
if (de == NULL) {
- addReply(c,shared.nil);
+ addReply(c,shared.nullmultibulk);
} else {
robj *o = dictGetEntryVal(de);
if (o->type != REDIS_LIST) {
- addReply(c,shared.wrongtypeerrbulk);
+ addReply(c,shared.wrongtypeerr);
} else {
list *list = o->ptr;
listNode *ln;
/* indexes sanity checks */
if (start > end || start >= llen) {
/* Out of range start or start > end result in empty list */
- addReply(c,shared.zero);
+ addReply(c,shared.emptymultibulk);
return;
}
if (end >= llen) end = llen-1;
/* Return the result in form of a multi-bulk reply */
ln = listIndex(list, start);
- addReplySds(c,sdscatprintf(sdsempty(),"%d\r\n",rangelen));
+ addReplySds(c,sdscatprintf(sdsempty(),"*%d\r\n",rangelen));
for (j = 0; j < rangelen; j++) {
ele = listNodeValue(ln);
- addReplySds(c,sdscatprintf(sdsempty(),"%d\r\n",(int)sdslen(ele->ptr)));
+ addReplySds(c,sdscatprintf(sdsempty(),"$%d\r\n",(int)sdslen(ele->ptr)));
addReply(c,ele);
addReply(c,shared.crlf);
ln = ln->next;
de = dictFind(c->dict,c->argv[1]);
if (de == NULL) {
- addReply(c,shared.minus1);
+ addReply(c,shared.nokeyerr);
} else {
robj *o = dictGetEntryVal(de);
if (o->type != REDIS_LIST) {
- addReply(c,shared.minus2);
+ addReply(c,shared.wrongtypeerr);
} else {
list *list = o->ptr;
listNode *ln, *next;
}
ln = next;
}
- addReplySds(c,sdscatprintf(sdsempty(),"%d\r\n",removed));
+ addReplySds(c,sdscatprintf(sdsempty(),":%d\r\n",removed));
}
}
}
} else {
set = dictGetEntryVal(de);
if (set->type != REDIS_SET) {
- addReply(c,shared.minus2);
+ addReply(c,shared.wrongtypeerr);
return;
}
}
if (dictAdd(set->ptr,c->argv[2],NULL) == DICT_OK) {
incrRefCount(c->argv[2]);
server.dirty++;
- addReply(c,shared.one);
+ addReply(c,shared.cone);
} else {
- addReply(c,shared.zero);
+ addReply(c,shared.czero);
}
}
de = dictFind(c->dict,c->argv[1]);
if (de == NULL) {
- addReply(c,shared.zero);
+ addReply(c,shared.czero);
} else {
robj *set;
set = dictGetEntryVal(de);
if (set->type != REDIS_SET) {
- addReply(c,shared.minus2);
+ addReply(c,shared.wrongtypeerr);
return;
}
if (dictDelete(set->ptr,c->argv[2]) == DICT_OK) {
server.dirty++;
- addReply(c,shared.one);
+ addReply(c,shared.cone);
} else {
- addReply(c,shared.zero);
+ addReply(c,shared.czero);
}
}
}
de = dictFind(c->dict,c->argv[1]);
if (de == NULL) {
- addReply(c,shared.zero);
+ addReply(c,shared.czero);
} else {
robj *set;
set = dictGetEntryVal(de);
if (set->type != REDIS_SET) {
- addReply(c,shared.minus2);
+ addReply(c,shared.wrongtypeerr);
return;
}
if (dictFind(set->ptr,c->argv[2]))
- addReply(c,shared.one);
+ addReply(c,shared.cone);
else
- addReply(c,shared.zero);
+ addReply(c,shared.czero);
}
}
de = dictFind(c->dict,c->argv[1]);
if (de == NULL) {
- addReply(c,shared.zero);
+ addReply(c,shared.czero);
return;
} else {
robj *o = dictGetEntryVal(de);
if (o->type != REDIS_SET) {
- addReply(c,shared.minus2);
+ addReply(c,shared.wrongtypeerr);
} else {
s = o->ptr;
- addReplySds(c,sdscatprintf(sdsempty(),"%d\r\n",
+ addReplySds(c,sdscatprintf(sdsempty(),":%d\r\n",
dictGetHashTableUsed(s)));
}
}
de = dictFind(c->dict,setskeys[j]);
if (!de) {
zfree(dv);
- addReply(c,dstkey ? shared.nokeyerr : shared.nil);
+ addReply(c,shared.nokeyerr);
return;
}
setobj = dictGetEntryVal(de);
if (setobj->type != REDIS_SET) {
zfree(dv);
- addReply(c,dstkey ? shared.wrongtypeerr : shared.wrongtypeerrbulk);
+ addReply(c,shared.wrongtypeerr);
return;
}
dv[j] = setobj->ptr;
continue; /* at least one set does not contain the member */
ele = dictGetEntryKey(de);
if (!dstkey) {
- addReplySds(c,sdscatprintf(sdsempty(),"%d\r\n",sdslen(ele->ptr)));
+ addReplySds(c,sdscatprintf(sdsempty(),"$%d\r\n",sdslen(ele->ptr)));
addReply(c,ele);
addReply(c,shared.crlf);
cardinality++;
dictReleaseIterator(di);
if (!dstkey)
- lenobj->ptr = sdscatprintf(sdsempty(),"%d\r\n",cardinality);
+ lenobj->ptr = sdscatprintf(sdsempty(),"*%d\r\n",cardinality);
else
addReply(c,shared.ok);
zfree(dv);
/* Lookup the key to sort. It must be of the right types */
de = dictFind(c->dict,c->argv[1]);
if (de == NULL) {
- addReply(c,shared.nokeyerrbulk);
+ addReply(c,shared.nokeyerr);
return;
}
sortval = dictGetEntryVal(de);
if (sortval->type != REDIS_SET && sortval->type != REDIS_LIST) {
- addReply(c,shared.wrongtypeerrbulk);
+ addReply(c,shared.wrongtypeerr);
return;
}
/* Create a list of operations to perform for every sorted element.
* Operations can be GET/DEL/INCR/DECR */
operations = listCreate();
- listSetFreeMethod(operations,free);
+ listSetFreeMethod(operations,zfree);
j = 2;
/* Now we need to protect sortval incrementing its count, in the future
} else {
decrRefCount(sortval);
listRelease(operations);
- addReply(c,shared.syntaxerrbulk);
+ addReply(c,shared.syntaxerr);
return;
}
j++;
/* Send command output to the output buffer, performing the specified
* GET/DEL/INCR/DECR operations if any. */
outputlen = getop ? getop*(end-start+1) : end-start+1;
- addReplySds(c,sdscatprintf(sdsempty(),"%d\r\n",outputlen));
+ addReplySds(c,sdscatprintf(sdsempty(),"*%d\r\n",outputlen));
for (j = start; j <= end; j++) {
listNode *ln = operations->head;
if (!getop) {
- addReplySds(c,sdscatprintf(sdsempty(),"%d\r\n",
+ addReplySds(c,sdscatprintf(sdsempty(),"$%d\r\n",
sdslen(vector[j].obj->ptr)));
addReply(c,vector[j].obj);
addReply(c,shared.crlf);
if (sop->type == REDIS_SORT_GET) {
if (!val || val->type != REDIS_STRING) {
- addReply(c,shared.minus1);
+ addReply(c,shared.nullbulk);
} else {
- addReplySds(c,sdscatprintf(sdsempty(),"%d\r\n",
+ addReplySds(c,sdscatprintf(sdsempty(),"$%d\r\n",
sdslen(val->ptr)));
addReply(c,val);
addReply(c,shared.crlf);
uptime,
uptime/(3600*24)
);
- addReplySds(c,sdscatprintf(sdsempty(),"%d\r\n",sdslen(info)));
+ addReplySds(c,sdscatprintf(sdsempty(),"$%d\r\n",sdslen(info)));
addReplySds(c,info);
addReply(c,shared.crlf);
}
time_t start = time(NULL);
char sizebuf[32];
+ /* ignore SYNC if aleady slave or in monitor mode */
+ if (c->flags & REDIS_SLAVE) return;
+
redisLog(REDIS_NOTICE,"Slave ask for syncronization");
if (flushClientOutput(c) == REDIS_ERR || saveDb(server.dbfilename) != REDIS_OK)
goto closeconn;
if (fd == -1 || fstat(fd,&sb) == -1) goto closeconn;
len = sb.st_size;
- snprintf(sizebuf,32,"%d\r\n",len);
+ snprintf(sizebuf,32,"$%d\r\n",len);
if (syncWrite(c->fd,sizebuf,strlen(sizebuf),5) == -1) goto closeconn;
while(len) {
char buf[1024];
strerror(errno));
return REDIS_ERR;
}
- dumpsize = atoi(buf);
+ dumpsize = atoi(buf+1);
redisLog(REDIS_NOTICE,"Receiving %d bytes data dump from MASTER",dumpsize);
/* Read the bulk write data on a temp file */
snprintf(tmpfile,256,"temp-%d.%ld.rdb",(int)time(NULL),(long int)random());
return REDIS_OK;
}
+static void monitorCommand(redisClient *c) {
+ /* ignore MONITOR if aleady slave or in monitor mode */
+ if (c->flags & REDIS_SLAVE) return;
+
+ c->flags |= (REDIS_SLAVE|REDIS_MONITOR);
+ c->slaveseldb = 0;
+ if (!listAddNodeTail(server.monitors,c)) oom("listAddNodeTail");
+ addReply(c,shared.ok);
+}
+
/* =================================== Main! ================================ */
static void daemonize(void) {
if (fd > STDERR_FILENO) close(fd);
}
/* Try to write the pid file */
- fp = fopen("/var/run/redis.pid","w");
+ fp = fopen(server.pidfile,"w");
if (fp) {
fprintf(fp,"%d\n",getpid());
fclose(fp);
redisLog(REDIS_NOTICE,"DB loaded from disk");
if (aeCreateFileEvent(server.el, server.fd, AE_READABLE,
acceptHandler, NULL, NULL) == AE_ERR) oom("creating file event");
- redisLog(REDIS_NOTICE,"The server is now ready to accept connections");
+ redisLog(REDIS_NOTICE,"The server is now ready to accept connections on port %d", server.port);
aeMain(server.el);
aeDeleteEventLoop(server.el);
return 0;
projects / redis.git / blobdiff