Merged Pietern patch for VM key args helper function. Fixed an obvious bug in the...

[redis.git] / redis-cli.c

diff --git a/redis-cli.c b/redis-cli.c
index 14b24f7538eb6365e20ad794efe8aae3622f39b0..5c1a2a1fb1273f56861a33fd959e27864c7206e1 100644 (file)
--- a/redis-cli.c
+++ b/redis-cli.c
@@ -52,6 +52,7 @@ static struct config {
     long repeat;
     int dbnum;
     int interactive;
     long repeat;
     int dbnum;
     int interactive;

+    char *authpw;

 } config;
 
 struct redisCommand {
 } config;
 
 struct redisCommand {


@@ -61,6 +62,7 @@ struct redisCommand {
 };
 
 static struct redisCommand cmdTable[] = {
 };
 
 static struct redisCommand cmdTable[] = {

+    {"auth",2,REDIS_CMD_INLINE},

     {"get",2,REDIS_CMD_INLINE},
     {"set",3,REDIS_CMD_BULK},
     {"setnx",3,REDIS_CMD_BULK},
     {"get",2,REDIS_CMD_INLINE},
     {"set",3,REDIS_CMD_BULK},
     {"setnx",3,REDIS_CMD_BULK},


@@ -101,8 +103,11 @@ static struct redisCommand cmdTable[] = {
     {"zincrby",4,REDIS_CMD_BULK},
     {"zrem",3,REDIS_CMD_BULK},
     {"zremrangebyscore",4,REDIS_CMD_INLINE},
     {"zincrby",4,REDIS_CMD_BULK},
     {"zrem",3,REDIS_CMD_BULK},
     {"zremrangebyscore",4,REDIS_CMD_INLINE},

+    {"zmerge",-3,REDIS_CMD_INLINE},
+    {"zmergeweighed",-4,REDIS_CMD_INLINE},

     {"zrange",-4,REDIS_CMD_INLINE},
     {"zrank",3,REDIS_CMD_BULK},
     {"zrange",-4,REDIS_CMD_INLINE},
     {"zrank",3,REDIS_CMD_BULK},

+    {"zrevrank",3,REDIS_CMD_BULK},

     {"zrangebyscore",-4,REDIS_CMD_INLINE},
     {"zcount",4,REDIS_CMD_INLINE},
     {"zrevrange",-4,REDIS_CMD_INLINE},
     {"zrangebyscore",-4,REDIS_CMD_INLINE},
     {"zcount",4,REDIS_CMD_INLINE},
     {"zrevrange",-4,REDIS_CMD_INLINE},


@@ -141,8 +146,16 @@ static struct redisCommand cmdTable[] = {
     {"msetnx",-3,REDIS_CMD_MULTIBULK},
     {"monitor",1,REDIS_CMD_INLINE},
     {"multi",1,REDIS_CMD_INLINE},
     {"msetnx",-3,REDIS_CMD_MULTIBULK},
     {"monitor",1,REDIS_CMD_INLINE},
     {"multi",1,REDIS_CMD_INLINE},

-    {"exec",1,REDIS_CMD_MULTIBULK},
+    {"exec",1,REDIS_CMD_INLINE},

     {"discard",1,REDIS_CMD_INLINE},
     {"discard",1,REDIS_CMD_INLINE},

+    {"hset",4,REDIS_CMD_MULTIBULK},
+    {"hget",3,REDIS_CMD_BULK},
+    {"hdel",3,REDIS_CMD_BULK},
+    {"hlen",2,REDIS_CMD_INLINE},
+    {"hkeys",2,REDIS_CMD_INLINE},
+    {"hvals",2,REDIS_CMD_INLINE},
+    {"hgetall",2,REDIS_CMD_INLINE},
+    {"hexists",3,REDIS_CMD_BULK},

     {NULL,0,0}
 };
 
     {NULL,0,0}
 };
 


@@ -294,6 +307,27 @@ static int selectDb(int fd) {
     return 0;
 }
 
     return 0;
 }
 

+static int cliLogin(int fd)
+{
+    int retval = 1;
+    sds cmd;
+    char type;
+    if (config.authpw[0] != '\0') {
+        cmd = sdsempty();
+        cmd = sdscatprintf(cmd,"AUTH %s\r\n",config.authpw);
+        anetWrite(fd,cmd,sdslen(cmd));
+        anetRead(fd,&type,1);
+        if (type == '+') 
+            retval = 0;
+        int ret2 = cliReadSingleLineReply(fd,1);
+        if (ret2)
+            close(fd);
+    } else {
+        retval = 0;
+    }
+    return retval;
+}
+

 static int cliSendCommand(int argc, char **argv) {
     struct redisCommand *rc = lookupCommand(argv[0]);
     int fd, j, retval = 0;
 static int cliSendCommand(int argc, char **argv) {
     struct redisCommand *rc = lookupCommand(argv[0]);
     int fd, j, retval = 0;


@@ -320,6 +354,13 @@ static int cliSendCommand(int argc, char **argv) {
         return 1;
     }
 
         return 1;
     }
 

+    /* Login if necessary */
+    retval = cliLogin(fd);
+    if (retval) {
+        fprintf(stderr,"Authentication failed\n");
+        return 1;
+    }
+

     while(config.repeat--) {
         /* Build the command to send */
         cmd = sdsempty();
     while(config.repeat--) {
         /* Build the command to send */
         cmd = sdsempty();


@@ -387,6 +428,9 @@ static int parseOptions(int argc, char **argv) {
         } else if (!strcmp(argv[i],"-n") && !lastarg) {
             config.dbnum = atoi(argv[i+1]);
             i++;
         } else if (!strcmp(argv[i],"-n") && !lastarg) {
             config.dbnum = atoi(argv[i+1]);
             i++;

+        } else if (!strcmp(argv[i],"-a") && !lastarg) {
+            config.authpw = argv[i+1];
+            i++;

         } else if (!strcmp(argv[i],"-i")) {
             config.interactive = 1;
         } else {
         } else if (!strcmp(argv[i],"-i")) {
             config.interactive = 1;
         } else {


@@ -414,13 +458,13 @@ static sds readArgFromStdin(void) {
 }
 
 static void usage() {
 }
 
 static void usage() {

-    fprintf(stderr, "usage: redis-cli [-h host] [-p port] [-r repeat_times] [-n db_num] [-i] cmd arg1 arg2 arg3 ... argN\n");
-    fprintf(stderr, "usage: echo \"argN\" | redis-cli [-h host] [-p port] [-r repeat_times] [-n db_num] cmd arg1 arg2 ... arg(N-1)\n");
+    fprintf(stderr, "usage: redis-cli [-h host] [-p port] [-a authpw] [-r repeat_times] [-n db_num] [-i] cmd arg1 arg2 arg3 ... argN\n");
+    fprintf(stderr, "usage: echo \"argN\" | redis-cli [-h host] [-a authpw] [-p port] [-r repeat_times] [-n db_num] cmd arg1 arg2 ... arg(N-1)\n");

     fprintf(stderr, "\nIf a pipe from standard input is detected this data is used as last argument.\n\n");
     fprintf(stderr, "example: cat /etc/passwd | redis-cli set my_passwd\n");
     fprintf(stderr, "example: redis-cli get my_passwd\n");
     fprintf(stderr, "example: redis-cli -r 100 lpush mylist x\n");
     fprintf(stderr, "\nIf a pipe from standard input is detected this data is used as last argument.\n\n");
     fprintf(stderr, "example: cat /etc/passwd | redis-cli set my_passwd\n");
     fprintf(stderr, "example: redis-cli get my_passwd\n");
     fprintf(stderr, "example: redis-cli -r 100 lpush mylist x\n");

-    fprintf(stderr, "\nRun in interactive mode: redis-cli -i \n");
+    fprintf(stderr, "\nRun in interactive mode: redis-cli -i or just don't pass any command\n");

     exit(1);
 }
 
     exit(1);
 }
 


@@ -486,12 +530,10 @@ int main(int argc, char **argv) {
     config.interactive = 0;
 
     firstarg = parseOptions(argc,argv);
     config.interactive = 0;
 
     firstarg = parseOptions(argc,argv);

-

     argc -= firstarg;
     argv += firstarg;
 
     argc -= firstarg;
     argv += firstarg;
 

-    if (config.interactive == 1) repl();
-    if (argc < 1) usage();
+    if (argc == 0 || config.interactive == 1) repl();

 
     argvcopy = convertToSds(argc, argv);
 
 
     argvcopy = convertToSds(argc, argv);