more work on ZSETs and a new make target called 32bit to build i386 binaries on mac...

[redis.git] / redis-cli.c

diff --git a/redis-cli.c b/redis-cli.c
index cd106684fbca6152a4fac051e4f048456d710dcd..9df07d0009f86d97abce3f06f6a58b6c00e5099c 100644 (file)
--- a/redis-cli.c
+++ b/redis-cli.c
@@ -28,6 +28,8 @@
  * POSSIBILITY OF SUCH DAMAGE.
  */
 
  * POSSIBILITY OF SUCH DAMAGE.
  */
 

+#include "fmacros.h"
+

 #include <stdio.h>
 #include <string.h>
 #include <stdlib.h>
 #include <stdio.h>
 #include <string.h>
 #include <stdlib.h>


@@ -40,11 +42,7 @@
 
 #define REDIS_CMD_INLINE 1
 #define REDIS_CMD_BULK 2
 
 #define REDIS_CMD_INLINE 1
 #define REDIS_CMD_BULK 2

-#define REDIS_CMD_INTREPLY 4
-#define REDIS_CMD_RETCODEREPLY 8
-#define REDIS_CMD_BULKREPLY 16
-#define REDIS_CMD_MULTIBULKREPLY 32
-#define REDIS_CMD_SINGLELINEREPLY 64
+#define REDIS_CMD_MULTIBULK 3

 
 #define REDIS_NOTUSED(V) ((void) V)
 
 
 #define REDIS_NOTUSED(V) ((void) V)
 


@@ -60,54 +58,71 @@ struct redisCommand {
 };
 
 static struct redisCommand cmdTable[] = {
 };
 
 static struct redisCommand cmdTable[] = {

-    {"get",2,REDIS_CMD_INLINE|REDIS_CMD_BULKREPLY},
-    {"set",3,REDIS_CMD_BULK|REDIS_CMD_RETCODEREPLY},
-    {"setnx",3,REDIS_CMD_BULK|REDIS_CMD_INTREPLY},
-    {"del",2,REDIS_CMD_INLINE|REDIS_CMD_INTREPLY},
-    {"exists",2,REDIS_CMD_INLINE|REDIS_CMD_INTREPLY},
-    {"incr",2,REDIS_CMD_INLINE|REDIS_CMD_INTREPLY},
-    {"decr",2,REDIS_CMD_INLINE|REDIS_CMD_INTREPLY},
-    {"rpush",3,REDIS_CMD_BULK|REDIS_CMD_RETCODEREPLY},
-    {"lpush",3,REDIS_CMD_BULK|REDIS_CMD_RETCODEREPLY},
-    {"rpop",2,REDIS_CMD_INLINE|REDIS_CMD_BULKREPLY},
-    {"lpop",2,REDIS_CMD_INLINE|REDIS_CMD_BULKREPLY},
-    {"llen",2,REDIS_CMD_INLINE|REDIS_CMD_INTREPLY},
-    {"lindex",3,REDIS_CMD_INLINE|REDIS_CMD_BULKREPLY},
-    {"lset",4,REDIS_CMD_BULK|REDIS_CMD_RETCODEREPLY},
-    {"lrange",4,REDIS_CMD_INLINE|REDIS_CMD_MULTIBULKREPLY},
-    {"ltrim",4,REDIS_CMD_INLINE|REDIS_CMD_RETCODEREPLY},
-    {"lrem",4,REDIS_CMD_BULK|REDIS_CMD_INTREPLY},
-    {"sadd",3,REDIS_CMD_BULK|REDIS_CMD_INTREPLY},
-    {"srem",3,REDIS_CMD_BULK|REDIS_CMD_INTREPLY},
-    {"sismember",3,REDIS_CMD_BULK|REDIS_CMD_INTREPLY},
-    {"scard",2,REDIS_CMD_INLINE|REDIS_CMD_INTREPLY},
-    {"sinter",-2,REDIS_CMD_INLINE|REDIS_CMD_MULTIBULKREPLY},
-    {"sinterstore",-3,REDIS_CMD_INLINE|REDIS_CMD_RETCODEREPLY},
-    {"smembers",2,REDIS_CMD_INLINE|REDIS_CMD_MULTIBULKREPLY},
-    {"incrby",3,REDIS_CMD_INLINE|REDIS_CMD_INTREPLY},
-    {"decrby",3,REDIS_CMD_INLINE|REDIS_CMD_INTREPLY},
-    {"randomkey",1,REDIS_CMD_INLINE|REDIS_CMD_SINGLELINEREPLY},
-    {"select",2,REDIS_CMD_INLINE|REDIS_CMD_RETCODEREPLY},
-    {"move",3,REDIS_CMD_INLINE|REDIS_CMD_INTREPLY},
-    {"rename",3,REDIS_CMD_INLINE|REDIS_CMD_RETCODEREPLY},
-    {"renamenx",3,REDIS_CMD_INLINE|REDIS_CMD_INTREPLY},
-    {"keys",2,REDIS_CMD_INLINE|REDIS_CMD_BULKREPLY},
-    {"dbsize",1,REDIS_CMD_INLINE|REDIS_CMD_INTREPLY},
-    {"ping",1,REDIS_CMD_INLINE|REDIS_CMD_RETCODEREPLY},
-    {"echo",2,REDIS_CMD_BULK|REDIS_CMD_BULKREPLY},
-    {"save",1,REDIS_CMD_INLINE|REDIS_CMD_RETCODEREPLY},
-    {"bgsave",1,REDIS_CMD_INLINE|REDIS_CMD_RETCODEREPLY},
-    {"shutdown",1,REDIS_CMD_INLINE|REDIS_CMD_RETCODEREPLY},
-    {"lastsave",1,REDIS_CMD_INLINE|REDIS_CMD_INTREPLY},
-    {"type",2,REDIS_CMD_INLINE|REDIS_CMD_SINGLELINEREPLY},
-    {"flushdb",1,REDIS_CMD_INLINE|REDIS_CMD_RETCODEREPLY},
-    {"flushall",1,REDIS_CMD_INLINE|REDIS_CMD_RETCODEREPLY},
-    {"sort",-2,REDIS_CMD_INLINE|REDIS_CMD_MULTIBULKREPLY},
-    {"info",1,REDIS_CMD_INLINE|REDIS_CMD_BULKREPLY},
-    {"mget",-2,REDIS_CMD_INLINE|REDIS_CMD_MULTIBULKREPLY},
+    {"get",2,REDIS_CMD_INLINE},
+    {"set",3,REDIS_CMD_BULK},
+    {"setnx",3,REDIS_CMD_BULK},
+    {"del",-2,REDIS_CMD_INLINE},
+    {"exists",2,REDIS_CMD_INLINE},
+    {"incr",2,REDIS_CMD_INLINE},
+    {"decr",2,REDIS_CMD_INLINE},
+    {"rpush",3,REDIS_CMD_BULK},
+    {"lpush",3,REDIS_CMD_BULK},
+    {"rpop",2,REDIS_CMD_INLINE},
+    {"lpop",2,REDIS_CMD_INLINE},
+    {"llen",2,REDIS_CMD_INLINE},
+    {"lindex",3,REDIS_CMD_INLINE},
+    {"lset",4,REDIS_CMD_BULK},
+    {"lrange",4,REDIS_CMD_INLINE},
+    {"ltrim",4,REDIS_CMD_INLINE},
+    {"lrem",4,REDIS_CMD_BULK},
+    {"sadd",3,REDIS_CMD_BULK},
+    {"srem",3,REDIS_CMD_BULK},
+    {"smove",4,REDIS_CMD_BULK},
+    {"sismember",3,REDIS_CMD_BULK},
+    {"scard",2,REDIS_CMD_INLINE},
+    {"spop",2,REDIS_CMD_INLINE},
+    {"srandmember",2,REDIS_CMD_INLINE},
+    {"sinter",-2,REDIS_CMD_INLINE},
+    {"sinterstore",-3,REDIS_CMD_INLINE},
+    {"sunion",-2,REDIS_CMD_INLINE},
+    {"sunionstore",-3,REDIS_CMD_INLINE},
+    {"sdiff",-2,REDIS_CMD_INLINE},
+    {"sdiffstore",-3,REDIS_CMD_INLINE},
+    {"smembers",2,REDIS_CMD_INLINE},
+    {"zadd",4,REDIS_CMD_BULK},
+    {"incrby",3,REDIS_CMD_INLINE},
+    {"decrby",3,REDIS_CMD_INLINE},
+    {"getset",3,REDIS_CMD_BULK},
+    {"randomkey",1,REDIS_CMD_INLINE},
+    {"select",2,REDIS_CMD_INLINE},
+    {"move",3,REDIS_CMD_INLINE},
+    {"rename",3,REDIS_CMD_INLINE},
+    {"renamenx",3,REDIS_CMD_INLINE},
+    {"keys",2,REDIS_CMD_INLINE},
+    {"dbsize",1,REDIS_CMD_INLINE},
+    {"ping",1,REDIS_CMD_INLINE},
+    {"echo",2,REDIS_CMD_BULK},
+    {"save",1,REDIS_CMD_INLINE},
+    {"bgsave",1,REDIS_CMD_INLINE},
+    {"shutdown",1,REDIS_CMD_INLINE},
+    {"lastsave",1,REDIS_CMD_INLINE},
+    {"type",2,REDIS_CMD_INLINE},
+    {"flushdb",1,REDIS_CMD_INLINE},
+    {"flushall",1,REDIS_CMD_INLINE},
+    {"sort",-2,REDIS_CMD_INLINE},
+    {"info",1,REDIS_CMD_INLINE},
+    {"mget",-2,REDIS_CMD_INLINE},
+    {"expire",3,REDIS_CMD_INLINE},
+    {"ttl",2,REDIS_CMD_INLINE},
+    {"slaveof",3,REDIS_CMD_INLINE},
+    {"debug",-2,REDIS_CMD_INLINE},
+    {"mset",-3,REDIS_CMD_MULTIBULK},
+    {"msetnx",-3,REDIS_CMD_MULTIBULK},

     {NULL,0,0}
 };
 
     {NULL,0,0}
 };
 

+static int cliReadReply(int fd);
+

 static struct redisCommand *lookupCommand(char *name) {
     int j = 0;
     while(cmdTable[j].name != NULL) {
 static struct redisCommand *lookupCommand(char *name) {
     int j = 0;
     while(cmdTable[j].name != NULL) {


@@ -150,38 +165,26 @@ static sds cliReadLine(int fd) {
     return sdstrim(line,"\r\n");
 }
 
     return sdstrim(line,"\r\n");
 }
 

-static int cliReadInlineReply(int fd, int type) {
+static int cliReadSingleLineReply(int fd) {

     sds reply = cliReadLine(fd);
 
     if (reply == NULL) return 1;
     printf("%s\n", reply);
     sds reply = cliReadLine(fd);
 
     if (reply == NULL) return 1;
     printf("%s\n", reply);

-    if (type == REDIS_CMD_SINGLELINEREPLY) return 0;
-    if (type == REDIS_CMD_INTREPLY) return atoi(reply) < 0;
-    if (type == REDIS_CMD_RETCODEREPLY) return reply[0] == '-';

     return 0;
 }
 
     return 0;
 }
 

-static int cliReadBulkReply(int fd, int multibulk) {
+static int cliReadBulkReply(int fd) {

     sds replylen = cliReadLine(fd);
     char *reply, crlf[2];
     sds replylen = cliReadLine(fd);
     char *reply, crlf[2];

-    int bulklen, error = 0;
+    int bulklen;

 
     if (replylen == NULL) return 1;
 
     if (replylen == NULL) return 1;

-    if (strcmp(replylen,"nil") == 0) {
-        sdsfree(replylen);
-        printf("(nil)\n");
-        return 0;
-    }

     bulklen = atoi(replylen);
     bulklen = atoi(replylen);

-    if (multibulk && bulklen == -1) {
+    if (bulklen == -1) {

         sdsfree(replylen);
         printf("(nil)");
         return 0;
     }
         sdsfree(replylen);
         printf("(nil)");
         return 0;
     }

-    if (bulklen < 0) {
-        bulklen = -bulklen;
-        error = 1;
-    }

     reply = zmalloc(bulklen);
     anetRead(fd,reply,bulklen);
     anetRead(fd,crlf,2);
     reply = zmalloc(bulklen);
     anetRead(fd,reply,bulklen);
     anetRead(fd,crlf,2);


@@ -189,10 +192,10 @@ static int cliReadBulkReply(int fd, int multibulk) {
         zfree(reply);
         return 1;
     }
         zfree(reply);
         return 1;
     }

-    if (!multibulk && isatty(fileno(stdout)) && reply[bulklen-1] != '\n')
+    if (isatty(fileno(stdout)) && reply[bulklen-1] != '\n')

         printf("\n");
     zfree(reply);
         printf("\n");
     zfree(reply);

-    return error;
+    return 0;

 }
 
 static int cliReadMultiBulkReply(int fd) {
 }
 
 static int cliReadMultiBulkReply(int fd) {


@@ -200,21 +203,45 @@ static int cliReadMultiBulkReply(int fd) {
     int elements, c = 1;
 
     if (replylen == NULL) return 1;
     int elements, c = 1;
 
     if (replylen == NULL) return 1;

-    if (strcmp(replylen,"nil") == 0) {
+    elements = atoi(replylen);
+    if (elements == -1) {

         sdsfree(replylen);
         printf("(nil)\n");
         return 0;
     }
         sdsfree(replylen);
         printf("(nil)\n");
         return 0;
     }

-    elements = atoi(replylen);
+    if (elements == 0) {
+        printf("(empty list or set)\n");
+    }

     while(elements--) {
         printf("%d. ", c);
     while(elements--) {
         printf("%d. ", c);

-        if (cliReadBulkReply(fd,1)) return 1;
-        printf("\n");
+        if (cliReadReply(fd)) return 1;

         c++;
     }
     return 0;
 }
 
         c++;
     }
     return 0;
 }
 

+static int cliReadReply(int fd) {
+    char type;
+
+    if (anetRead(fd,&type,1) <= 0) exit(1);
+    switch(type) {
+    case '-':
+        printf("(error) ");
+        cliReadSingleLineReply(fd);
+        return 1;
+    case '+':
+    case ':':
+        return cliReadSingleLineReply(fd);
+    case '$':
+        return cliReadBulkReply(fd);
+    case '*':
+        return cliReadMultiBulkReply(fd);
+    default:
+        printf("protocol error, got '%c' as reply type byte\n", type);
+        return 1;
+    }
+}
+

 static int cliSendCommand(int argc, char **argv) {
     struct redisCommand *rc = lookupCommand(argv[0]);
     int fd, j, retval = 0;
 static int cliSendCommand(int argc, char **argv) {
     struct redisCommand *rc = lookupCommand(argv[0]);
     int fd, j, retval = 0;


@@ -233,31 +260,30 @@ static int cliSendCommand(int argc, char **argv) {
     if ((fd = cliConnect()) == -1) return 1;
 
     /* Build the command to send */
     if ((fd = cliConnect()) == -1) return 1;
 
     /* Build the command to send */

-    for (j = 0; j < argc; j++) {
-        if (j != 0) cmd = sdscat(cmd," ");
-        if (j == argc-1 && rc->flags & REDIS_CMD_BULK) {
-            cmd = sdscatprintf(cmd,"%d",sdslen(argv[j]));
-        } else {
+    if (rc->flags & REDIS_CMD_MULTIBULK) {
+        cmd = sdscatprintf(cmd,"*%d\r\n",argc);
+        for (j = 0; j < argc; j++) {
+            cmd = sdscatprintf(cmd,"$%d\r\n",sdslen(argv[j]));

             cmd = sdscatlen(cmd,argv[j],sdslen(argv[j]));
             cmd = sdscatlen(cmd,argv[j],sdslen(argv[j]));

+            cmd = sdscatlen(cmd,"\r\n",2);
+        }
+    } else {
+        for (j = 0; j < argc; j++) {
+            if (j != 0) cmd = sdscat(cmd," ");
+            if (j == argc-1 && rc->flags & REDIS_CMD_BULK) {
+                cmd = sdscatprintf(cmd,"%d",sdslen(argv[j]));
+            } else {
+                cmd = sdscatlen(cmd,argv[j],sdslen(argv[j]));
+            }

         }
         }

-    }
-    cmd = sdscat(cmd,"\r\n");
-    if (rc->flags & REDIS_CMD_BULK) {
-        cmd = sdscatlen(cmd,argv[argc-1],sdslen(argv[argc-1]));

         cmd = sdscat(cmd,"\r\n");
         cmd = sdscat(cmd,"\r\n");

+        if (rc->flags & REDIS_CMD_BULK) {
+            cmd = sdscatlen(cmd,argv[argc-1],sdslen(argv[argc-1]));
+            cmd = sdscatlen(cmd,"\r\n",2);
+        }

     }
     anetWrite(fd,cmd,sdslen(cmd));
     }
     anetWrite(fd,cmd,sdslen(cmd));

-    if (rc->flags & REDIS_CMD_INTREPLY) {
-        retval = cliReadInlineReply(fd,REDIS_CMD_INTREPLY);
-    } else if (rc->flags & REDIS_CMD_RETCODEREPLY) {
-        retval = cliReadInlineReply(fd,REDIS_CMD_RETCODEREPLY);
-    } else if (rc->flags & REDIS_CMD_SINGLELINEREPLY) {
-        retval = cliReadInlineReply(fd,REDIS_CMD_SINGLELINEREPLY);
-    } else if (rc->flags & REDIS_CMD_BULKREPLY) {
-        retval = cliReadBulkReply(fd,0);
-    } else if (rc->flags & REDIS_CMD_MULTIBULKREPLY) {
-        retval = cliReadMultiBulkReply(fd);
-    }
+    retval = cliReadReply(fd);

     if (retval) {
         close(fd);
         return retval;
     if (retval) {
         close(fd);
         return retval;


@@ -310,6 +336,7 @@ static sds readArgFromStdin(void) {
 int main(int argc, char **argv) {
     int firstarg, j;
     char **argvcopy;
 int main(int argc, char **argv) {
     int firstarg, j;
     char **argvcopy;

+    struct redisCommand *rc;

 
     config.hostip = "127.0.0.1";
     config.hostport = 6379;
 
     config.hostip = "127.0.0.1";
     config.hostport = 6379;


@@ -323,13 +350,6 @@ int main(int argc, char **argv) {
     for(j = 0; j < argc; j++)
         argvcopy[j] = sdsnew(argv[j]);
 
     for(j = 0; j < argc; j++)
         argvcopy[j] = sdsnew(argv[j]);
 

-    /* Read the last argument from stdandard input */
-    if (!isatty(fileno(stdin))) {
-        sds lastarg = readArgFromStdin();
-        argvcopy[argc] = lastarg;
-        argc++;
-    }
-

     if (argc < 1) {
         fprintf(stderr, "usage: redis-cli [-h host] [-p port] cmd arg1 arg2 arg3 ... argN\n");
         fprintf(stderr, "usage: echo \"argN\" | redis-cli [-h host] [-p port] cmd arg1 arg2 ... arg(N-1)\n");
     if (argc < 1) {
         fprintf(stderr, "usage: redis-cli [-h host] [-p port] cmd arg1 arg2 arg3 ... argN\n");
         fprintf(stderr, "usage: echo \"argN\" | redis-cli [-h host] [-p port] cmd arg1 arg2 ... arg(N-1)\n");


@@ -339,5 +359,14 @@ int main(int argc, char **argv) {
         exit(1);
     }
 
         exit(1);
     }
 

+    /* Read the last argument from stdandard input if needed */
+    if ((rc = lookupCommand(argv[0])) != NULL) {
+        if (rc->arity > 0 && argc == rc->arity-1) {
+            sds lastarg = readArgFromStdin();
+            argvcopy[argc] = lastarg;
+            argc++;
+        }
+    }
+

     return cliSendCommand(argc, argvcopy);
 }
     return cliSendCommand(argc, argvcopy);
 }