Allow more useful error messages in _assert macro.

[ldid.git] / ldid.cpp

diff --git a/ldid.cpp b/ldid.cpp
index 39f23070d3c4fe8720b31c2e8207c1e9ee2d381a..8c03ef6a703c5efcd7d55cbcdf7235a89773ec39 100644 (file)
--- a/ldid.cpp
+++ b/ldid.cpp
@@ -45,19 +45,22 @@
 
 #include <plist/plist.h>
 
+#include "ldid.hpp"
+
 #define _assert___(line) \
     #line
 #define _assert__(line) \
     _assert___(line)
-#define _assert_(e) \
-    throw __FILE__ "(" _assert__(__LINE__) "): _assert(" e ")"
 
-#define _assert(expr) \
+#define _assert_(expr, format, ...) \
     do if (!(expr)) { \
-        fprintf(stderr, "%s(%u): _assert(%s); errno=%u\n", __FILE__, __LINE__, #expr, errno); \
-        _assert_(#expr); \
+        fprintf(stderr, "%s(%u): _assert(): " format "\n", __FILE__, __LINE__, ## __VA_ARGS__); \
+        throw __FILE__ "(" _assert__(__LINE__) "): _assert(" #expr ")"; \
     } while (false)
 
+#define _assert(expr) \
+    _assert_(expr, "%s", #expr)
+
 #define _syscall(expr) ({ \
     __typeof__(expr) _value; \
     do if ((long) (_value = (expr)) != -1) \
@@ -66,7 +69,7 @@
         case EINTR: \
             continue; \
         default: \
-            _assert(false); \
+            _assert_(false, "errno=%u", errno); \
     } while (true); \
     _value; \
 })
@@ -921,44 +924,9 @@ class Map {
     }
 };
 
-// I wish Apple cared about providing quality toolchains :/
-
-template <typename Function_>
-class Functor;
-
-template <typename Type_, typename... Args_>
-class Functor<Type_ (Args_...)> {
-  public:
-    virtual Type_ operator ()(Args_... args) const = 0;
-};
-
-template <typename Function_>
-class FunctorImpl;
-
-template <typename Value_, typename Type_, typename... Args_>
-class FunctorImpl<Type_ (Value_::*)(Args_...) const> :
-    public Functor<Type_ (Args_...)>
-{
-  private:
-    const Value_ *value_;
-
-  public:
-    FunctorImpl(const Value_ &value) :
-        value_(&value)
-    {
-    }
-
-    virtual Type_ operator ()(Args_... args) const {
-        return (*value_)(args...);
-    }
-};
-
-template <typename Function_>
-FunctorImpl<decltype(&Function_::operator())> fun(const Function_ &value) {
-    return value;
-}
+namespace ldid {
 
-static void resign(void *idata, size_t isize, std::streambuf &output, const Functor<size_t (size_t)> &allocate, const Functor<size_t (std::streambuf &output, size_t, const std::string &, const char *)> &save) {
+static void Allocate(void *idata, size_t isize, std::streambuf &output, const Functor<size_t (size_t)> &allocate, const Functor<size_t (std::streambuf &output, size_t, const std::string &, const char *)> &save) {
     FatHeader source(idata, isize);
 
     size_t offset(0);
@@ -1132,6 +1100,8 @@ static void resign(void *idata, size_t isize, std::streambuf &output, const Func
     }
 }
 
+}
+
 typedef std::map<uint32_t, std::string> Blobs;
 
 static void insert(Blobs &blobs, uint32_t slot, const std::stringbuf &buffer) {
@@ -1289,10 +1259,10 @@ class Signature {
     }
 };
 
-typedef std::map<uint32_t, std::string> Slots;
+namespace ldid {
 
-void resign(void *idata, size_t isize, std::streambuf &output, const std::string &name, const std::string &entitlements, const std::string &key, const Slots &slots) {
-    resign(idata, isize, output, fun([&](size_t size) -> size_t {
+void Sign(void *idata, size_t isize, std::streambuf &output, const std::string &name, const std::string &entitlements, const std::string &key, const Slots &slots) {
+    Allocate(idata, isize, output, fun([&](size_t size) -> size_t {
         size_t alloc(sizeof(struct SuperBlob));
 
         uint32_t special(0);
@@ -1417,14 +1387,16 @@ void resign(void *idata, size_t isize, std::streambuf &output, const std::string
     }));
 }
 
-static void resign(void *idata, size_t isize, std::streambuf &output) {
-    resign(idata, isize, output, fun([](size_t size) -> size_t {
+static void Unsign(void *idata, size_t isize, std::streambuf &output) {
+    Allocate(idata, isize, output, fun([](size_t size) -> size_t {
         return 0;
     }), fun([](std::streambuf &output, size_t limit, const std::string &overlap, const char *top) -> size_t {
         return 0;
     }));
 }
 
+}
+
 int main(int argc, char *argv[]) {
     OpenSSL_add_all_algorithms();
 
@@ -1458,7 +1430,7 @@ int main(int argc, char *argv[]) {
 
     Map entitlements;
     Map key;
-    Slots slots;
+    ldid::Slots slots;
 
     std::vector<std::string> files;
 
@@ -1581,10 +1553,10 @@ int main(int argc, char *argv[]) {
             _assert(output.open(temp.c_str(), std::ios::out | std::ios::trunc | std::ios::binary) == &output);
 
             if (flag_r)
-                resign(input.data(), input.size(), output);
+                ldid::Unsign(input.data(), input.size(), output);
             else {
                 const char *name(flag_I ?: base);
-                resign(input.data(), input.size(), output, name, entitlements, key, slots);
+                ldid::Sign(input.data(), input.size(), output, name, entitlements, key, slots);
             }
 
             struct stat info;