Fix the custom button problem - applyRightButton was overriding BrowserView's support...

diff --git a/Cydia.mm b/Cydia.mm
index f56107842b9aa87b4bcde0910dd16c61f29292ed..2638e4223f04b7d24efb02706cd8001ef721b8fe 100644 (file)
--- a/Cydia.mm
+++ b/Cydia.mm
@@ -5227,9 +5227,12 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) {
     }
 }
 
     }
 }
 

+// We don't want to allow non-commercial packages to do custom things to the install button,
+// so it must call customButtonClicked with a custom commercial_ == 1 fallthrough.

 - (void) customButtonClicked {
 - (void) customButtonClicked {

-    // Wait until it's done loading.
-    if (![self isLoading])
+    if (commercial_)
+        [super customButtonClicked];
+    else

         [self _customButtonClicked];
 }
 
         [self _customButtonClicked];
 }
 


@@ -5240,6 +5243,16 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) {
 - (void) applyLoadingTitle {
     // Don't show "Loading" as the title. Ever.
 }
 - (void) applyLoadingTitle {
     // Don't show "Loading" as the title. Ever.
 }

+
+- (UIBarButtonItem *) rightButton {
+    int count = [buttons_ count];
+    return [[[UIBarButtonItem alloc]
+        initWithTitle:count == 0 ? nil : count != 1 ? UCLocalize("MODIFY") : [buttons_ objectAtIndex:0]
+        style:UIBarButtonItemStylePlain
+        target:self
+        action:@selector(customButtonClicked)
+    ] autorelease];
+}

 #endif
 
 - (id) initWithDatabase:(Database *)database {
 #endif
 
 - (id) initWithDatabase:(Database *)database {


@@ -5307,19 +5320,6 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) {
     }
 }
 
     }
 }
 

-- (void) applyRightButton {
-    int count = [buttons_ count];
-    UIBarButtonItem *actionItem = [[UIBarButtonItem alloc]
-        initWithTitle:count == 0 ? nil : count != 1 ? UCLocalize("MODIFY") : [buttons_ objectAtIndex:0]
-        style:UIBarButtonItemStylePlain
-        target:self
-        action:@selector(customButtonClicked)
-    ];
-    if (![self isLoading]) [[self navigationItem] setRightBarButtonItem:actionItem];
-    else [super applyRightButton];
-    [actionItem release];
-}
-

 - (bool) isLoading {
     return commercial_ ? [super isLoading] : false;
 }
 - (bool) isLoading {
     return commercial_ ? [super isLoading] : false;
 }

diff --git a/UICaboodle/BrowserView.h b/UICaboodle/BrowserView.h
index f2b0db87c836a8209b2295e1a399b5d3011ca290..23be6317a91438c7400f275efe1977abd26bb02b 100644 (file)
--- a/UICaboodle/BrowserView.h
+++ b/UICaboodle/BrowserView.h
@@ -108,9 +108,10 @@
 - (bool) allowSensitiveRequests;
 
 - (void) alertView:(UIAlertView *)alert clickedButtonAtIndex:(NSInteger)button;
 - (bool) allowSensitiveRequests;
 
 - (void) alertView:(UIAlertView *)alert clickedButtonAtIndex:(NSInteger)button;

+- (void) customButtonClicked;

 - (void) applyRightButton;
 
 - (void) _startLoading;
 - (void) close;
 
 - (void) applyRightButton;
 
 - (void) _startLoading;
 - (void) close;
 

-@end
\ No newline at end of file
+@end

diff --git a/UICaboodle/BrowserView.mm b/UICaboodle/BrowserView.mm
index ee8563f0d8d854443d0ffbb89a63dc7a98da2c72..1615795d295b2c01f9c9c4c8dc166c50074bbd98 100644 (file)
--- a/UICaboodle/BrowserView.mm
+++ b/UICaboodle/BrowserView.mm
@@ -1075,6 +1075,10 @@ static Class $UIWebBrowserView;
     return [customItem autorelease];
 }
 
     return [customItem autorelease];
 }
 

+- (UIBarButtonItem *) rightButton {
+    return reloaditem_;
+}
+

 - (void) applyLoadingTitle {
     [[self navigationItem] setTitle:UCLocalize("LOADING")];
 }
 - (void) applyLoadingTitle {
     [[self navigationItem] setTitle:UCLocalize("LOADING")];
 }


@@ -1087,7 +1091,7 @@ static Class $UIWebBrowserView;
     } else if (button_) {
         [[self navigationItem] setRightBarButtonItem:[self customButton] animated:YES];
     } else {
     } else if (button_) {
         [[self navigationItem] setRightBarButtonItem:[self customButton] animated:YES];
     } else {

-        [[self navigationItem] setRightBarButtonItem:reloaditem_ animated:YES];
+        [[self navigationItem] setRightBarButtonItem:[self rightButton] animated:YES];

     }
 }
 
     }
 }
 


@@ -1615,4 +1619,4 @@ static Class $UIWebBrowserView;
     return 980;
 }
 
     return 980;
 }
 

-@end
\ No newline at end of file
+@end