Akim Demaille [Thu, 15 Jan 2015 09:04:53 +0000 (10:04 +0100)]
version 3.0.3
* NEWS: Record release date.
Akim Demaille [Thu, 15 Jan 2015 08:36:14 +0000 (09:36 +0100)]
gnulib: update
Akim Demaille [Tue, 13 Jan 2015 13:15:47 +0000 (14:15 +0100)]
tests: split a large test case into several smaller ones
* tests/conflicts.at (AT_CONSISTENT_ERRORS_CHECK): Move AT_SETUP/AT_CLEANUP
into it, so that we don't skip non Java tests following a test case in Java.
Akim Demaille [Mon, 12 Jan 2015 11:11:53 +0000 (12:11 +0100)]
package: a bit of trouble shooting indications
* README-hacking: here.
Akim Demaille [Mon, 12 Jan 2015 10:34:42 +0000 (11:34 +0100)]
doc: liby's main arms the internationalization
Reported by Nicolas Bedon.
<https://lists.gnu.org/archive/html/bug-bison/2014-11/msg00005.html>
* doc/bison.texi (Yacc Library): Document the call the setlocale.
Akim Demaille [Fri, 9 Jan 2015 13:21:09 +0000 (14:21 +0100)]
bison: avoid warnings from static code analysis
A static analysis tool reports that some callers of symbol_list_n_get
might get NULL and not handle it properly. This is not the case, yet
we can suppress this pattern.
Reported by Mike Sullivan.
<https://lists.gnu.org/archive/html/bug-bison/2013-12/msg00027.html>
* src/symlist.c (symbol_list_n_get): Actually it is never called
to return 0. Enforce this postcondition via aver.
(symbol_list_n_type_name_get): Simplify accordingly. In particular,
discards a (translated) useless error message.
* src/symlist.h: Adjust documentation.
* src/scan-code.l: Style change.
Akim Demaille [Fri, 9 Jan 2015 11:01:22 +0000 (12:01 +0100)]
c++: fix the use of destructors when variants are enabled
When using variants, destructors generate invalid code.
<http://lists.gnu.org/archive/html/bug-bison/2014-09/msg00005.html>
Reported by Michael Catanzaro.
* data/c++.m4 (~basic_symbol): b4_symbol_foreach works on yysym:
define it.
* tests/c++.at (Variants): Check it.
Akim Demaille [Thu, 8 Jan 2015 13:03:09 +0000 (14:03 +0100)]
style: tests: simplify the handling of some C++ tests
* tests/c++.at: here.
(Doxygen): Pass %define, so that files such as position.hh etc.
are generated, instead of putting everything into input.hh.
Akim Demaille [Thu, 8 Jan 2015 12:37:16 +0000 (13:37 +0100)]
c++: symbols can be empty, so use it
The previous patches ensure that symbols (symbol_type and
stack_symbol_type) can be empty, cleared, and their emptiness can be
checked. Therefore, yyempty, which codes whether yyla is empty or
not, is now useless.
In C skeletons (e.g., yacc.c), the fact that the lookahead is empty is
coded by "yychar = YYEMPTY", which is exactly what this patch
restores, since yychar/yytoken corresponds to yyla.type.
* data/lalr1.cc (yyempty): Remove.
Rather, depend on yyla.empty ().
Akim Demaille [Thu, 8 Jan 2015 10:19:57 +0000 (11:19 +0100)]
c++: variants: don't leak the lookahead in error recovery
During error recovery, when discarding the lookeahead, we don't
destroy it, which is caught by parse.assert assertions.
Reported by Antonio Silva Correia.
With an analysis and suggested patch from Michel d'Hooge.
<http://savannah.gnu.org/support/?108481>
* tests/c++.at (Variants): Strengthen the test to try syntax errors
with discarded lookahead.
Akim Demaille [Thu, 8 Jan 2015 09:19:10 +0000 (10:19 +0100)]
c++: provide a means to clear symbols
The symbol destructor is currently the only means to clear a symbol.
Unfortunately during error recovery we might have to clear the
lookahead, which is a local variable (yyla) that has not yet reached
its end of scope.
Rather that duplicating the code to destroy a symbol, or rather than
destroying and recreating yyla, let's provide a means to clear a
symbol.
Reported by Antonio Silva Correia, with an analysis from Michel d'Hooge.
<http://savannah.gnu.org/support/?108481>
* data/c++.m4, data/lalr1.cc (basis_symbol::clear, by_state::clear)
(by_type::clear): New.
(basic_symbol::~basic_symbol): Use clear.
Akim Demaille [Thu, 8 Jan 2015 09:04:53 +0000 (10:04 +0100)]
c++: clean up the handling of empty symbols
* data/c++.m4, data/lalr1.cc (yyempty_): Remove, replaced by...
(empty_symbol, by_state::empty_state): these.
(basic_symbol::empty): New.
Akim Demaille [Thu, 8 Jan 2015 08:15:10 +0000 (09:15 +0100)]
c++: comment and style changes
* data/c++.m4, data/lalr1.cc: More documentation.
Tidy.
* tests/c++.at (string_cast): Rename as...
(to_string): this C++11 name.
Akim Demaille [Wed, 7 Jan 2015 09:24:53 +0000 (10:24 +0100)]
c++: variants: comparing addresses of typeid.name() is undefined
Instead of storing and comparing pointers to names of types, store
pointers to the typeids, and compares the typeids.
Reported by Thomas Jahns.
<http://lists.gnu.org/archive/html/bug-bison/2014-03/msg00001.html>
* data/variant.hh (yytname_): Replace with...
(yytypeid_): this.
Akim Demaille [Mon, 5 Jan 2015 17:20:28 +0000 (18:20 +0100)]
c++: locations: complete the API and fix comments
There are no support for += between locations, and some comments are wrong.
Reported by Alexandre Duret-Lutz.
* data/location.cc: Fix.
* doc/bison.texi: Document.
* tests/c++.at: Check.
Akim Demaille [Mon, 5 Jan 2015 13:31:44 +0000 (14:31 +0100)]
build: do not clean figure sources in make clean
"make clean && make" fails in in-tree builds.
* doc/local.mk (CLEANDIRS): Replace with...
(CLEANFILES): this safer list of files to clean.
Akim Demaille [Fri, 29 Aug 2014 21:36:20 +0000 (00:36 +0300)]
build: don't try to generate docs when cross-compiling
When cross-compiling don't run the generated bison to update the docs.
Reported by Aaro Koskinen.
<http://lists.gnu.org/archive/html/bison-patches/2014-03/msg00000.html>
* configure.ac (CROSS_COMPILING): New.
* doc/local.mk: Use it.
Akim Demaille [Sun, 4 Jan 2015 16:57:30 +0000 (17:57 +0100)]
package: fix a reporter's name
* THANKS, build-aux/git-log-fix: s/Bernd Edligner/Bernd Edlinger/.
Akim Demaille [Sun, 4 Jan 2015 13:16:23 +0000 (14:16 +0100)]
%union: fix the support for named %union
Bison supports a union tag, for obscure reasons. But it does a poor
job at it, especially since Bison 3.0.
Reported by Stephen Cameron and Tobias Frost.
It did not ensure that the name was not given several times. An easy
way to do this is to make the %union tag be handled as a %define
variable, as they cannot be defined several times.
Since Bison 3.0, the synclines were wrongly placed, resulting in
invalid code. Addressing this issue, because of the way the union tag
was stored (as a code muscle), would have been tedious. Unless we
rather define the %union tag as a %percent variable, whose synclines
are easier to manipulate.
So replace the b4_union_name muscle by the api.value.union.name
%define variable, document, and check.
* data/bison.m4: Make sure that api.value.union.name has a keyword value.
* data/c++.m4: Make sure that api.value.union.name is not defined.
* data/c.m4 (b4_union_name): No longer use it, use api.value.union.name.
* doc/bison.texi (%define Summary): Document it.
* src/parse-gram.y (union_name): No longer define b4_uion_name, but
api.value.union.name.
* tests/input.at (Redefined %union name): New.
* tests/synclines.at (%union name syncline): New.
* tests/types.at: Check named %unions.
Akim Demaille [Sun, 4 Jan 2015 16:31:18 +0000 (17:31 +0100)]
package: bump to 2015
Which also requires:
* gnulib: Update.
Akim Demaille [Wed, 31 Dec 2014 13:48:13 +0000 (14:48 +0100)]
flex: don't trust YY_USER_INIT
Reported by Bernd Edligner and others.
* src/scan-gram.l: here.
Akim Demaille [Wed, 31 Dec 2014 13:15:06 +0000 (14:15 +0100)]
yacc.c: fix broken union when api.value.type=union and %defines are used
Reported by Rich Wilson.
* data/c.m4 (b4_symbol_type_register): Append to b4_union_members,
not b4_user_union_members.
The latter invokes the former, but it is the former which is reinitialized
to empty by b4_value_type_setup_union.
* tests/types.at: Check it.
This reveals another bug, this time in the case of glr.c parsers.
* data/glr.c: Generate the header file before the implementation file,
to be sure that the setup is run before what depends on it.
Akim Demaille [Wed, 31 Dec 2014 11:49:39 +0000 (12:49 +0100)]
doc: fix missing xref
Reported by xolodho.
* doc/bison.texi (Printer Decl): here.
Akim Demaille [Mon, 29 Dec 2014 15:09:28 +0000 (16:09 +0100)]
gnulib: update
Akim Demaille [Mon, 3 Feb 2014 14:03:03 +0000 (15:03 +0100)]
location: remove some ugly debugging code traces
* data/location.cc: here.
Akim Demaille [Mon, 3 Feb 2014 14:01:44 +0000 (15:01 +0100)]
build: use abort to pacify compiler errors
clang, with -DNDEBUG and -Werror fails on some functions that might
lack a return. This is because aver is just another assert, discarded
with -DNDEBUG. So use abort.
* src/muscle-tab.c, src/scan-skel.l: here.
Akim Demaille [Mon, 3 Feb 2014 14:26:25 +0000 (15:26 +0100)]
package: bump to 2014
* AUTHORS, ChangeLog-2012, Makefile.am, NEWS, PACKAGING, README,
* README-alpha, README-hacking, THANKS, TODO, bootstrap.conf,
* build-aux/darwin11.4.0.valgrind, build-aux/local.mk,
* build-aux/update-b4-copyright,
* build-aux/update-package-copyright-year, cfg.mk, configure.ac,
* data/README, data/bison.m4, data/c++-skel.m4, data/c++.m4,
* data/c-like.m4, data/c-skel.m4, data/c.m4, data/glr.c, data/glr.cc,
* data/java-skel.m4, data/java.m4, data/lalr1.cc, data/lalr1.java,
* data/local.mk, data/location.cc, data/stack.hh, data/variant.hh,
* data/xslt/bison.xsl, data/xslt/xml2dot.xsl, data/xslt/xml2text.xsl,
* data/xslt/xml2xhtml.xsl, data/yacc.c, djgpp/Makefile.maint,
* djgpp/README.in, djgpp/config.bat, djgpp/config.sed,
* djgpp/config.site, djgpp/config_h.sed, djgpp/djunpack.bat,
* djgpp/local.mk, djgpp/subpipe.c, djgpp/subpipe.h,
* djgpp/testsuite.sed, doc/bison.texi, doc/local.mk, doc/refcard.tex,
* etc/README, etc/bench.pl.in, etc/local.mk,
* examples/calc++/calc++.test, examples/calc++/local.mk,
* examples/extexi, examples/local.mk, examples/mfcalc/local.mk,
* examples/mfcalc/mfcalc.test, examples/rpcalc/local.mk,
* examples/rpcalc/rpcalc.test, examples/test, examples/variant.yy,
* lib/abitset.c, lib/abitset.h, lib/bbitset.h, lib/bitset.c,
* lib/bitset.h, lib/bitset_stats.c, lib/bitset_stats.h,
* lib/bitsetv-print.c, lib/bitsetv-print.h, lib/bitsetv.c,
* lib/bitsetv.h, lib/ebitset.c, lib/ebitset.h, lib/get-errno.c,
* lib/get-errno.h, lib/lbitset.c, lib/lbitset.h, lib/libiberty.h,
* lib/local.mk, lib/main.c, lib/timevar.c, lib/timevar.def,
* lib/timevar.h, lib/vbitset.c, lib/vbitset.h, lib/yyerror.c,
* m4/bison-i18n.m4, m4/c-working.m4, m4/cxx.m4, m4/flex.m4,
* m4/timevar.m4, src/AnnotationList.c, src/AnnotationList.h,
* src/InadequacyList.c, src/InadequacyList.h, src/LR0.c, src/LR0.h,
* src/Sbitset.c, src/Sbitset.h, src/assoc.c, src/assoc.h,
* src/closure.c, src/closure.h, src/complain.c, src/complain.h,
* src/conflicts.c, src/conflicts.h, src/derives.c, src/derives.h,
* src/files.c, src/files.h, src/flex-scanner.h, src/getargs.c,
* src/getargs.h, src/gram.c, src/gram.h, src/graphviz.c,
* src/graphviz.h, src/ielr.c, src/ielr.h, src/lalr.c, src/lalr.h,
* src/local.mk, src/location.c, src/location.h, src/main.c,
* src/muscle-tab.c, src/muscle-tab.h, src/named-ref.c,
* src/named-ref.h, src/nullable.c, src/nullable.h, src/output.c,
* src/output.h, src/parse-gram.c, src/parse-gram.y, src/print-xml.c,
* src/print-xml.h, src/print.c, src/print.h, src/print_graph.c,
* src/print_graph.h, src/reader.c, src/reader.h, src/reduce.c,
* src/reduce.h, src/relation.c, src/relation.h, src/scan-code.h,
* src/scan-code.l, src/scan-gram.h, src/scan-gram.l, src/scan-skel.h,
* src/scan-skel.l, src/state.c, src/state.h, src/symlist.c,
* src/symlist.h, src/symtab.c, src/symtab.h, src/system.h,
* src/tables.c, src/tables.h, src/uniqstr.c, src/uniqstr.h,
* tests/actions.at, tests/atlocal.in, tests/bison.in, tests/c++.at,
* tests/calc.at, tests/conflicts.at, tests/cxx-type.at,
* tests/existing.at, tests/glr-regression.at, tests/headers.at,
* tests/input.at, tests/java.at, tests/javapush.at, tests/local.at,
* tests/local.mk, tests/named-refs.at, tests/output.at, tests/push.at,
* tests/reduce.at, tests/regression.at, tests/sets.at,
* tests/skeletons.at, tests/synclines.at, tests/testsuite.at,
* tests/torture.at, tests/types.at:
here.
Paul Eggert [Fri, 3 Jan 2014 19:02:58 +0000 (11:02 -0800)]
doc: specify documentation encoding
* doc/bison.texi: Add '@documentencoding UTF-8'; needed since the
manual contains UTF-8 characters. This will cause the .info files
to contain UTF-8 quotes and the like, which should be OK nowadays.
Add @documentlanguage while we're at it.
Akim Demaille [Mon, 9 Dec 2013 15:29:05 +0000 (16:29 +0100)]
package: install the examples
Currently, we do not install the various examples extracted from the
documentation. Let's do it, as they are useful starting points.
* configure.ac: When --enable-gcc-warnings is set, enable ENABLE_GCC_WARNINGS.
* examples/extexi: No longer issue synclines by default.
* examples/local.mk: Except if ENABLE_GCC_WARNINGS.
* examples/calc++/local.mk, examples/mfcalc/local.mk,
* examples/rpcalc/local.mk: Install the example files.
Akim Demaille [Mon, 9 Dec 2013 15:14:15 +0000 (16:14 +0100)]
package: install README and the like in docdir
* Makefile.am: here.
Akim Demaille [Mon, 9 Dec 2013 14:26:52 +0000 (15:26 +0100)]
diagnostics: fix the order of multiple declarations reports
On
%token FOO "foo"
%printer {} "foo"
%printer {} FOO
we report
/tmp/foo.yy:2.10-11: error: %printer redeclaration for FOO
%printer {} "foo"
^^
/tmp/foo.yy:3.10-11: previous declaration
%printer {} FOO
^^
* src/symtab.c (locations_sort): New.
Use it.
* tests/input.at (Invalid Aliases): Stress the order of diagnostics.
Akim Demaille [Mon, 9 Dec 2013 14:40:07 +0000 (15:40 +0100)]
symbol: provide an easy means to compare them in source order
* src/symtab.c (symbols_sort): New.
(user_token_number_redeclaration): Taken from here.
Akim Demaille [Thu, 5 Dec 2013 14:16:28 +0000 (15:16 +0100)]
maint: post-release administrivia
* NEWS: Add header line for next release.
* .prev-version: Record previous version.
* cfg.mk (old_NEWS_hash): Auto-update.
Akim Demaille [Thu, 5 Dec 2013 13:58:22 +0000 (14:58 +0100)]
version 3.0.2
* NEWS: Record release date.
Akim Demaille [Thu, 5 Dec 2013 13:39:30 +0000 (14:39 +0100)]
gnulib: update
* gnulib: here.
Akim Demaille [Wed, 4 Dec 2013 09:51:47 +0000 (10:51 +0100)]
output: do not generate source files when late errors are caught
Reported by Alexandre Duret-Lutz as "second problem" in:
http://lists.gnu.org/archive/html/bug-bison/2013-09/msg00015.html
* bootstrap.conf: We need the "unlink" module.
* src/files.h, src/files.c (unlink_generated_sources): New.
* src/output.c: Use it.
* tests/output.at: Check the case of late errors.
Akim Demaille [Wed, 4 Dec 2013 09:26:46 +0000 (10:26 +0100)]
output: record what generated files are source or report files
* src/files.h, src/files.c (output_file_name_check): Take an additional
argument to record whether a file is a source or report file.
* src/files.c (generated_file): New.
(file_names, file_names_count): Replace with...
(generated_files, generated_files_size): these.
* src/scan-skel.l: Adjust.
Akim Demaille [Wed, 4 Dec 2013 08:30:08 +0000 (09:30 +0100)]
output: do not generate source files when early errors are caught
Reported by Alexandre Duret-Lutz as "second problem" in:
http://lists.gnu.org/archive/html/bug-bison/2013-09/msg00015.html
One problem is that some errors are caught early, before the
generation of output files, while others can only be detected
afterwards (since, for instance, skeletons can raise errors
themselves).
This will be addressed in two steps: early errors do not generate
source files at all, while later errors will remove the files that
have already been generated.
* src/scan-skel.l (yyout): Open to /dev/null when there are errors.
* tests/output.at (AT_CHECK_FILES): Factored out of...
(AT_CHECK_OUTPUT): this.
Fuse the "SHELLIO" argument in the "FLAGS" one.
Use $5 to denote the expected exit status.
Add a test case for early errors.
Akim Demaille [Tue, 26 Nov 2013 15:23:52 +0000 (16:23 +0100)]
xml: also use "%empty" with html output
* data/xslt/xml2xhtml.xsl: No longer issue an Epsilon, display as in
dot and text formats.
Akim Demaille [Tue, 26 Nov 2013 15:20:55 +0000 (16:20 +0100)]
style: formatting changes
* src/print-xml.c: here.
Akim Demaille [Tue, 26 Nov 2013 15:20:52 +0000 (16:20 +0100)]
xml: also display %empty for empty right-hand sides
* data/xslt/xml2dot.xsl, data/xslt/xml2text.xsl: Display %empty where needed.
Akim Demaille [Tue, 26 Nov 2013 14:24:53 +0000 (15:24 +0100)]
reports: display %empty in the generated pointed-rules
* src/print.c (print_core): Use %empty for empty rules.
* src/print_graph.c (print_core): Ditto.
* tests/conflicts.at, tests/output.at, tests/reduce.at: Adjust
expectations.
Akim Demaille [Tue, 26 Nov 2013 14:31:33 +0000 (15:31 +0100)]
news: YYERROR vs variants
Akim Demaille [Mon, 18 Nov 2013 09:29:23 +0000 (10:29 +0100)]
style: scope reduction in lalr.cc
* src/lalr.c: Shorten variable scopes.
(lookahead_tokens_print): Use the same variable name in two loops
iterating over the same structure.
Akim Demaille [Fri, 15 Nov 2013 09:10:41 +0000 (10:10 +0100)]
lalr1.cc: formatting changes
* data/lalr1.cc: Fix indentation.
Akim Demaille [Fri, 15 Nov 2013 09:08:31 +0000 (10:08 +0100)]
lalr1.cc: fix the support of YYERROR with variants
When variant are enabled, the yylhs variable (the left-hand side of
the rule being reduced, i.e. $$ and @$) is explicitly destroyed when
YYERROR is called. This is because before running the user code, $$
is initialized, so that the user can properly use it.
However, when quitting yyparse, yylhs is also reclaimed by the C++
compiler: the variable goes out of scope.
Instead of trying to be too smart, let the compiler do its job: reduce
the scope of yylhs to exactly the reduction. This way, whatever the
type of scope exit (regular, exception, return, goto...) this variable
will be properly reclaimed.
Reported by Paolo Simone Gasparello.
<http://lists.gnu.org/archive/html/bug-bison/2013-10/msg00003.html>
* data/lalr1.cc (yyparse): Reduce the scope of yylhs.
* tests/c++.at: We now pass this test.
Akim Demaille [Fri, 15 Nov 2013 08:43:01 +0000 (09:43 +0100)]
tests: check $$'s destruction with variant, YYERROR, and no error recovery
When variant are enabled, the yylhs variable (the left-hand side of
the rule being reduced, i.e. $$ and @$) is explicitly destroyed when
YYERROR is called. This is because before running the user code, $$
is initialized, so that the user can properly use it.
However, when quitting yyparse, yylhs is also reclaimed by the C++
compiler: the variable goes out of scope.
This was not detected by the test suite because (i) the Object tracker
was too weak, and (ii) the problem does not show when there is error
recovery.
Reported by Paolo Simone Gasparello.
<http://lists.gnu.org/archive/html/bug-bison/2013-10/msg00003.html>
* tests/c++.at (Exception safety): Improve the objects logger to make
sure that we never destroy twice an object.
Also track copy-constructors.
Use a set instead of a list.
Display the logs before running the function body, this is more
useful in case of failure.
Generalize to track with and without error recovery.
Akim Demaille [Thu, 14 Nov 2013 15:58:42 +0000 (16:58 +0100)]
tests: simplify useless obfuscation
* tests/c++.at: $$ is not special for M4, there is no need to "escape"
it.
Akim Demaille [Thu, 14 Nov 2013 15:14:39 +0000 (16:14 +0100)]
skeletons: use better names when computing a "goto"
* data/glr.c (yyLRgotoState): Name the symbol argument yysym, instead
of yylhs.
* data/lalr1.cc (yy_lr_goto_state_): Likewise.
* data/lalr1.java (yy_lr_goto_state_): New, modeled after the previous
two routines.
Use it.
Akim Demaille [Tue, 12 Nov 2013 17:37:14 +0000 (18:37 +0100)]
maint: post-release administrivia
* NEWS: Add header line for next release.
* .prev-version: Record previous version.
* cfg.mk (old_NEWS_hash): Auto-update.
Akim Demaille [Tue, 12 Nov 2013 14:55:33 +0000 (15:55 +0100)]
version 3.0.1
* NEWS: Record release date.
Akim Demaille [Tue, 12 Nov 2013 14:46:27 +0000 (15:46 +0100)]
aver: it is no longer "protected against NDEBUG"
Apply the same rules for aver as for assert: no side effects,
especially not important ones.
* src/AnnotationList.c, src/muscle-tab.c: Adjust aver uses to resist
to -DNDEBUG.
Akim Demaille [Fri, 8 Nov 2013 09:52:15 +0000 (10:52 +0100)]
parsers: rename YY_NULL as YY_NULLPTR to avoid conflicts with Flex
Flex also defines YY_NULL (to 0). Avoid gratuitous conflicts.
* data/c.m4 (b4_null_define): Rename YY_NULL as YY_NULLPTR.
* data/glr.c, data/lalr1.cc, data/location.cc, data/variant.hh,
* data/yacc.c, src/parse-gram.c, tests/actions.at, tests/c++.at,
* tests/cxx-type.at, tests/glr-regression.at, tests/headers.at,
* tests/push.at, tests/regression.at:
Adjust.
Akim Demaille [Tue, 5 Nov 2013 13:32:20 +0000 (14:32 +0100)]
build: use Automake 1.14's non-recursive Makefile features
* configure.ac: Require Automake 1.14.
* examples/calc++/local.mk, examples/local.mk, examples/mfcalc/local.mk,
* examples/rpcalc/local.mk, tests/local.mk: Use %D% and %C%.
Akim Demaille [Tue, 5 Nov 2013 13:15:15 +0000 (14:15 +0100)]
build: restore maintainer-push-check
* tests/local.mk: here.
Akim Demaille [Wed, 23 Oct 2013 08:57:51 +0000 (10:57 +0200)]
c++: use __attribute__((__pure__)) to avoid warnings
Building C++ parsers with -Wsuggest-attribute=const and
-Wsuggest-attribute=noreturn triggers warning in generated code.
* data/lalr1.cc: Call b4_attribute_define.
(debug_stream, debug_level): Flag as pure.
* tests/headers.at (Several parsers): There are now more YY macros
that "leak".
Akim Demaille [Wed, 23 Oct 2013 08:57:09 +0000 (10:57 +0200)]
skeletons: update the handling of compiler attributes
* data/c.m4 (b4_attribute_define): Instead of defining __attribute__,
define YY_ATTRIBUTE conditionally.
(YY_ATTRIBUTE_PURE, YY_ATTRIBUTE_UNUSED, _Noreturn): New.
Use them.
* data/glr.c: Use them.
Akim Demaille [Wed, 23 Oct 2013 08:25:47 +0000 (10:25 +0200)]
gnulib: update
Akim Demaille [Wed, 23 Oct 2013 13:03:45 +0000 (15:03 +0200)]
style: use /* ... */ comments
* src/complain.c: Here.
Akim Demaille [Wed, 23 Oct 2013 13:04:15 +0000 (15:04 +0200)]
tests: skip C++ tests that are too demanding for some compilers
Some tests now fail when compiled with G++ 4.3 or 4.4 on MacPorts.
* tests/local.at (AT_SKIP_IF_EXCEPTION_SUPPORT_IS_POOR): New.
* tests/c++.at (Exception safety): Use it.
Akim Demaille [Tue, 22 Oct 2013 15:32:49 +0000 (17:32 +0200)]
install: do not install yacc.1 when --disable-yacc
* configure.ac (ENABLE_YACC): New conditional.
(YACC_SCRIPT, YACC_LIBRARY): Remove.
* lib/local.mk, src/local.mk: Use the former instead of the latter.
* doc/local.mk: Use ENABLE_YACC to avoid installing yacc.1.
Akim Demaille [Tue, 22 Oct 2013 14:43:17 +0000 (16:43 +0200)]
style: avoid tabs
* src/scan-code.l: here.
Akim Demaille [Tue, 22 Oct 2013 14:30:12 +0000 (16:30 +0200)]
c++: fix generated doxygen comments
* configure.ac: Enable -Wdocumentation if supported.
* data/lalr1.cc: Fix comments.
Akim Demaille [Tue, 22 Oct 2013 14:29:22 +0000 (16:29 +0200)]
fix: uniqstr are already pointers
* src/uniqstr.c (uniqstr_assert): Remove incorrect double indirection,
and now useless cast.
Paul Eggert [Mon, 21 Oct 2013 22:21:32 +0000 (15:21 -0700)]
bison: pacify Sun C 5.12
* src/scan-code.l (show_sub_message):
Redo initializations to work around a bogus Sun C 5.12 warning.
(parse_ref): Remove unreachable code that Sun C 5.12 complains about.
* src/uniqstr.h (uniqstr_vsprintf): Use
_GL_ATTRIBUTE_FORMAT_PRINTF (...) instead of __attribute__
((__format__ (__printf__, ...))). Otherwise, Sun C 5.12
complains about an unknown attribute.
Paul Eggert [Mon, 21 Oct 2013 22:17:16 +0000 (15:17 -0700)]
maint: git now ignores rpcalc
* examples/rpcalc/.gitignore: Ignore rpcalc.
Paul Eggert [Mon, 21 Oct 2013 22:16:43 +0000 (15:16 -0700)]
build: examples/calc++/calc++ requires flex
* configure.ac (FLEX_CXX_WORKS): New AM_CONDITIONAL.
* examples/calc++/local.mk (examples/calc++/calc++):
Build if FLEX_CXX_WORKS, not BISON_CXX_WORKS.
Paul Eggert [Mon, 21 Oct 2013 22:13:52 +0000 (15:13 -0700)]
maint: mention help2man, texinfo, apt-get
* README-hacking: Add help2man, texinfo.
Describe how to add packages if you're using Debian.
Paul Eggert [Mon, 21 Oct 2013 22:12:13 +0000 (15:12 -0700)]
maint: git now ignores .log and .trs files
* .gitignore: Add *.log, *.trs.
Akim Demaille [Fri, 18 Oct 2013 14:22:23 +0000 (16:22 +0200)]
tests: fix incorrect object construction
Reported by Ken Moffat.
http://lists.gnu.org/archive/html/bug-bison/2013-10/msg00009.html
* tests/c++.at (Exception safety): Here.
Akim Demaille [Wed, 16 Oct 2013 13:19:44 +0000 (15:19 +0200)]
glr: allow spaces between "%?" and "{" in predicates
Reported by Rici Lake.
http://lists.gnu.org/archive/html/bug-bison/2013-10/msg00004.html
http://stackoverflow.com/questions/
19330171/
* src/scan-gram.l: Do not try to be too smart when diagnosing invalid
directives.
* tests/glr-regression.at (Predicates): New test.
Akim Demaille [Wed, 16 Oct 2013 08:55:28 +0000 (10:55 +0200)]
diagnostics: "-Werror -Wno-error=foo" must not emit errors
Currently "-Werror -Wno-error=foo" still turns "foo" warnings into errors.
Reported by Alexandre Duret-Lutz.
See http://lists.gnu.org/archive/html/bug-bison/2013-09/msg00015.html.
* src/complain.c (errority, errority_flag): New.
(complain_init): Initialize the latter.
(warning_argmatch): Extract the loop iterating on the flag's bits.
Set and unset errority_flag here.
(warnings_argmatch): -Wno-error is not the same as -Wno-error=everything:
we must remember if category foo was explicitly turned in an error/warning
via -W(no-)error=foo.
(warning_severity): Use errority_flag.
* tests/input.at (Symbols): Just check --yacc, not -Wyacc, that's the
job of tests on -W.
(-Werror is not affected by -Wnone and -Wall): Rename as...
(-Werror combinations): this.
Tests more combinations of -W, -W(no-)error, and -W(no-)error=foo.
* tests/local.at (AT_BISON_CHECK_WARNINGS): Don't expect -Werror
to turn runs that issue warnings into runs with errors, as the
warnings might be enforced as warnings by -Wno-error=foo, in which
case -Werror does not change anything.
* doc/bison.texi (Bison Options): Try to be clearer about how
-W(no-)error and -W(no-)error=foo interact.
Akim Demaille [Tue, 8 Oct 2013 11:01:24 +0000 (13:01 +0200)]
comment changes
* src/complain.h, src/complain.c: More documentation, more comments.
Andreas Schwab [Fri, 27 Sep 2013 22:00:34 +0000 (00:00 +0200)]
location: fix EOF check
* location.c (location_caret): Use int, not char, for values from
getc.
Akim Demaille [Thu, 19 Sep 2013 14:45:09 +0000 (16:45 +0200)]
style: variant: remove empty line
* data/variant.hh (b4_symbol_constructor_define_): Remove
stray eol.
Akim Demaille [Thu, 19 Sep 2013 13:27:19 +0000 (15:27 +0200)]
glr: more assertions
* data/glr.c (yyaddDeferredAction, yyglrShiftDefer, yypdumpstack):
More assertions.
Akim Demaille [Thu, 19 Sep 2013 13:01:24 +0000 (15:01 +0200)]
glr: shorten scopes
* data/glr.c (yyglrReduce): Define yyflag with its value.
Akim Demaille [Thu, 19 Sep 2013 13:00:32 +0000 (15:00 +0200)]
glr: formatting changes
* data/glr.c: here.
Akim Demaille [Thu, 19 Sep 2013 12:58:57 +0000 (14:58 +0200)]
glr: better use of tracing macros
* data/glr.c (yydestroyGLRState): Use YY_SYMBOL_PRINT instead of
yy_symbol_print.
Akim Demaille [Thu, 19 Sep 2013 13:20:22 +0000 (15:20 +0200)]
examples: improve the output of the "variant" example
* examples/variant.yy: Improve the printing of lists.
Akim Demaille [Thu, 19 Sep 2013 13:03:01 +0000 (15:03 +0200)]
variant: remove useless assertion
* data/variant.hh (move): Remove precondition assertion which is
ensured by the first call of the body (this precondition is also one
of "build").
Akim Demaille [Thu, 19 Sep 2013 13:51:32 +0000 (15:51 +0200)]
tests: remove stray debugging traces
* tests/atlocal.in: Remove traces.
Be ready to remove conftest.dSYM generated on OS X.
Akim Demaille [Wed, 4 Sep 2013 15:23:37 +0000 (17:23 +0200)]
tests: do not use grep -q
Reported by Daniel Galloway.
http://lists.gnu.org/archive/html/bug-bison/2013-08/msg00020.html
* tests/java.at: Ignore grep's output instead.
Paul Eggert [Sun, 25 Aug 2013 01:22:22 +0000 (18:22 -0700)]
build: don't require flex for ordinary builds
* configure.ac (LEX): Don't fail if this is lex, as flex is not
required for ordinary builds. Instead, issue a warning and
substitute a no-op LEX. Reported by Michael Felt in
<http://lists.gnu.org/archive/html/bug-bison/2013-08/msg00009.html>.
Paul Eggert [Sun, 25 Aug 2013 01:00:25 +0000 (18:00 -0700)]
maint: update .gitignore
* .gitignore: Add *.eps, *.o, *.pdf, *.png, *.stamp, *~,
.deps, .dirstamp. Needed to suppress unwanted chatter from
'git status' after a bootstrap build.
Paul Eggert [Sat, 24 Aug 2013 14:52:27 +0000 (07:52 -0700)]
build: port to pre-5.8.7 perl
* examples/local.mk (extract): Omit -f from perl options.
This doesn't work with perl versions before 5.8.7
that are configured without USE_SITECUSTOMIZE.
Reported by Michael Felt in
<http://lists.gnu.org/archive/html/bug-bison/2013-08/msg00006.html>.
Akim Demaille [Thu, 1 Aug 2013 14:11:27 +0000 (16:11 +0200)]
tests: minor change to make it easier to test other skeletons
* tests/c++.at (Variants): Pass the skeleton as argument.
Valentin Tolmer [Thu, 1 Aug 2013 12:53:54 +0000 (14:53 +0200)]
uniqstr: fix assertion
* src/uniqstr.c (uniqstr_assert): Really make sure str is a uniqstr,
not just whether some uniqstr with the same content was registered.
Akim Demaille [Thu, 1 Aug 2013 09:41:49 +0000 (11:41 +0200)]
build: ship the ASCII art figures
We don't ship the *.txt files that are used to build the info
file.
Reported by Colin Daley.
* doc/figs/example.txt: New.
* doc/local.mk (bison.info): Depend on the txt files.
And ship them.
Akim Demaille [Thu, 1 Aug 2013 09:19:05 +0000 (11:19 +0200)]
doc: prefer the ".gv" extension to ".dot"
See http://marc.info/?l=graphviz-devel&m=
129418103126092 for the
motivation (basically, some word processor now uses *.dot).
* doc/figs/example-reduce.dot: Rename as...
* doc/figs/example-reduce.gv: this.
* doc/figs/example-shift.dot: Rename as...
* doc/figs/example-shift.gv: this.
* doc/figs/example.dot: Rename as...
* doc/figs/example.gv: this.
* doc/local.mk: Adjust.
Akim Demaille [Thu, 25 Jul 2013 16:13:53 +0000 (18:13 +0200)]
maint: post-release administrivia
* NEWS: Add header line for next release.
* .prev-version: Record previous version.
* cfg.mk (old_NEWS_hash): Auto-update.
Akim Demaille [Thu, 25 Jul 2013 15:55:58 +0000 (17:55 +0200)]
version 3.0
* NEWS: Record release date.
Akim Demaille [Thu, 25 Jul 2013 15:52:15 +0000 (17:52 +0200)]
regen
Akim Demaille [Thu, 25 Jul 2013 15:50:11 +0000 (17:50 +0200)]
news: prepare 3.0
* NEWS (3.0): Reorder.
Akim Demaille [Thu, 25 Jul 2013 15:45:19 +0000 (17:45 +0200)]
tests: fix invalid assignment when using variants in C++11
* tests/c++.at (Exception safety): In variant mode $$ is an instance
of Object. Assigning YY_NULL in C++98 is incorrect, but behaves ok,
as it assigns YY_NULL=0 using Object::operator= (char v). It is wrong
in C++11 as there is operator for "$$ = nullptr".
Akim Demaille [Thu, 25 Jul 2013 14:04:26 +0000 (16:04 +0200)]
yacc: beware of "uninitialized uses" warnings
Again some issues with the fact that yylval is reported by GCC as
possibly not initialized in some cases. Here, the case at hand is the
%destructor.
I am still not convinced that it is worth going all the trouble of
using pragmas to disable temporarily some warnings, instead of just
initializing the looking symbol once for all, but that's what Paul
voted for, see
<http://lists.gnu.org/archive/html/bison-patches/2012-10/msg00050.html>.
* data/c.m4 (b4_attribute_define): Define
YY_IGNORE_MAYBE_UNINITIALIZED_BEGIN, YY_IGNORE_MAYBE_UNINITIALIZED_END,
YY_INITIAL_VALUE here, as we will need them in the generation of the
destructor function, which is defined in yacc.c before yyparse, which
was in charge of defining these macros.
* data/yacc.c (b4_declare_scanner_communication_variables): Simplify:
trying to factor the definitions of the case pure and impure is
too complex.
Actually, it is not even clear that this macro should really exist,
as even the calls are complex.
Be careful not to issue a lone ";", as this is a statement, and C90
forbids declarations after statements ; so write
"YY_INITIAL_VALUE(Decl;)", not "YY_INITIAL_VALUE(Decl);".
Akim Demaille [Thu, 25 Jul 2013 11:33:28 +0000 (13:33 +0200)]
gnulib: update
Akim Demaille [Wed, 3 Jul 2013 15:16:04 +0000 (17:16 +0200)]
tests: skip C++ tests if we can't compile a simple program
There are possible conflicts between gnulib replacement functions (in
<stdio.h>) and their C++ wrappers (in <stream>). Trying to address
these in configure seems too hard, and I don't know how to fix the issue
in gnulib. Cowardly avoid the problem by skipping C++ tests when this
happens.
Reported by Stefano Lattarini.
http://lists.gnu.org/archive/html/bug-bison/2013-06/msg00001.html
* tests/atlocal.in (BISON_CXX_WORKS): Also set it to "skip" if we can't
compile a simple program using <stream>.
* tests/local.at: Comment changes.
Akim Demaille [Fri, 28 Jun 2013 06:33:33 +0000 (08:33 +0200)]
tests: fix 'find' portability issues
Reported by Stefano Lattarini.
http://lists.gnu.org/archive/html/bug-bison/2013-06/msg00000.html
* tests/output.at (AT_CHECK_OUTPUT): Use Perl instead.
Akim Demaille [Mon, 24 Jun 2013 08:29:36 +0000 (10:29 +0200)]
maint: post-release administrivia
* NEWS: Add header line for next release.
* .prev-version: Record previous version.
* cfg.mk (old_NEWS_hash): Auto-update.