build: avoid warning from coverity about lbitset_elt_find

* lib/lbitset.c (lbitset_elt_find): Remove unnecessary test of "elt",
at a point where we know it is non-NULL, due to prior dereference.

diff --git a/ChangeLog b/ChangeLog
index 59b80408f5adad44c646e25bd5dd5fa40af93f44..cefbc832c82c9c3a5f86e958a5f676265cfd1edb 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2012-01-13  Jim Meyering  <meyering@redhat.com>
+
+       build: avoid warning from coverity about lbitset_elt_find
+       * lib/lbitset.c (lbitset_elt_find): Remove unnecessary test of "elt",
+       at a point where we know it is non-NULL, due to prior dereference.
+

 2012-01-13  Akim Demaille  <akim@lrde.epita.fr>
 
        maint: factor copyright year.
 2012-01-13  Akim Demaille  <akim@lrde.epita.fr>
 
        maint: factor copyright year.

diff --git a/lib/lbitset.c b/lib/lbitset.c
index 7d204f0e55e0ad721187d0d1b5fea5ed15a715e9..aa19f45de30770e5138e380ad3660577bbf466f3 100644 (file)
--- a/lib/lbitset.c
+++ b/lib/lbitset.c
@@ -352,7 +352,7 @@ lbitset_elt_find (bitset bset, bitset_windex windex,
 
       /* ELT is the nearest to the one we want.  If it's not the one
         we want, the one we want does not exist.  */
 
       /* ELT is the nearest to the one we want.  If it's not the one
         we want, the one we want does not exist.  */

-      if (elt && (windex - elt->index) < LBITSET_ELT_WORDS)
+      if (windex - elt->index < LBITSET_ELT_WORDS)

        {
          bset->b.cindex = elt->index;
          bset->b.csize = LBITSET_ELT_WORDS;
        {
          bset->b.cindex = elt->index;
          bset->b.csize = LBITSET_ELT_WORDS;