maint: be compilable with GCC 4.0

The "shadows a global declaration" warning in GCC 4.0 was a bit
annoying.  It does not like that a type name be used in a prototype of
a function (not the implementation, just the declaration):

  In file included from src/LR0.c:38:
  src/reader.h:56: warning: declaration of 'named_ref' shadows a
                            global declaration
  src/named-ref.h:35: warning: shadowed declaration is here

It does not like either when a global variable name is used in a
prototype.  Flex 2.5.37 generates this prototype:

  void gram_set_debug (int debug_flag  );

* src/getargs.h, src/getargs.c (debug_flag): Rename as...
(debug): this.
Adjust dependencies.
* src/reader.h: Don't use "named_ref" as a formal argument name.

diff --git a/src/getargs.c b/src/getargs.c
index 70a25e03e07d43e694225eb10e61c2db55691c13..649056943d99bb5653a04aedab25fa0473e977d3 100644 (file)
--- a/src/getargs.c
+++ b/src/getargs.c
@@ -49,7 +49,7 @@
 #include "quote.h"
 #include "uniqstr.h"
 
 #include "quote.h"
 #include "uniqstr.h"
 

-bool debug_flag;
+bool debug;

 bool defines_flag;
 bool graph_flag;
 bool xml_flag;
 bool defines_flag;
 bool graph_flag;
 bool xml_flag;


@@ -664,7 +664,7 @@ getargs (int argc, char *argv[])
        break;
 
       case 't':
        break;
 
       case 't':

-       debug_flag = true;
+       debug = true;

        break;
 
       case 'v':
        break;
 
       case 'v':

diff --git a/src/getargs.h b/src/getargs.h
index 22538cf3ee17bfe5b129c66d260cb0ae753a4ec3..ef97822ae3636af2588f77704540a66329a13a1e 100644 (file)
--- a/src/getargs.h
+++ b/src/getargs.h
@@ -34,7 +34,7 @@ extern int skeleton_prio;
 /* for -I */
 extern char const *include;
 
 /* for -I */
 extern char const *include;
 

-extern bool debug_flag;                        /* for -t */
+extern bool debug;                     /* for -t */

 extern bool defines_flag;              /* for -d */
 extern bool graph_flag;                        /* for -g */
 extern bool xml_flag;                  /* for -x */
 extern bool defines_flag;              /* for -d */
 extern bool graph_flag;                        /* for -g */
 extern bool xml_flag;                  /* for -x */

diff --git a/src/output.c b/src/output.c
index e77a2d1a0fc85a75d6f6bec202d96351778dfef2..4a4d62d1a8ece8d4d208b7d3c98c5e1a1e1d2405 100644 (file)
--- a/src/output.c
+++ b/src/output.c
@@ -628,7 +628,7 @@ prepare (void)
     use_push_for_pull_flag = true;
 
   /* Flags. */
     use_push_for_pull_flag = true;
 
   /* Flags. */

-  MUSCLE_INSERT_BOOL ("debug_flag", debug_flag);
+  MUSCLE_INSERT_BOOL ("debug_flag", debug);

   MUSCLE_INSERT_BOOL ("defines_flag", defines_flag);
   MUSCLE_INSERT_BOOL ("error_verbose_flag", error_verbose);
   MUSCLE_INSERT_BOOL ("glr_flag", glr_parser);
   MUSCLE_INSERT_BOOL ("defines_flag", defines_flag);
   MUSCLE_INSERT_BOOL ("error_verbose_flag", error_verbose);
   MUSCLE_INSERT_BOOL ("glr_flag", glr_parser);

diff --git a/src/parse-gram.y b/src/parse-gram.y
index 6a49923c478baa88668bfa757720900533af814e..5f77a5bd08abd0355531dadbbebe53503442c77a 100644 (file)
--- a/src/parse-gram.y
+++ b/src/parse-gram.y
@@ -252,7 +252,7 @@ prologue_declaration:
                         plain_code.code, @1);
       code_scanner_last_string_free ();
     }
                         plain_code.code, @1);
       code_scanner_last_string_free ();
     }

-| "%debug"                         { debug_flag = true; }
+| "%debug"                         { debug = true; }

 | "%define" variable content.opt
     {
       muscle_percent_define_insert ($2, @2, $3,
 | "%define" variable content.opt
     {
       muscle_percent_define_insert ($2, @2, $3,

diff --git a/src/reader.h b/src/reader.h
index 3722a7f566decc5f2e48cb89a34ecba684e52054..e154deb02e234929e83d481aaeffe09fe0178294 100644 (file)
--- a/src/reader.h
+++ b/src/reader.h
@@ -51,9 +51,9 @@ void grammar_current_rule_prec_set (symbol *precsym, location loc);
 void grammar_current_rule_dprec_set (int dprec, location loc);
 void grammar_current_rule_merge_set (uniqstr name, location loc);
 void grammar_current_rule_symbol_append (symbol *sym, location loc,
 void grammar_current_rule_dprec_set (int dprec, location loc);
 void grammar_current_rule_merge_set (uniqstr name, location loc);
 void grammar_current_rule_symbol_append (symbol *sym, location loc,

-                                        named_ref *named_ref);
+                                        named_ref *nref);

 void grammar_current_rule_action_append (const char *action, location loc,
 void grammar_current_rule_action_append (const char *action, location loc,

-                                        named_ref *named_ref);
+                                        named_ref *nref);

 void reader (void);
 void free_merger_functions (void);
 
 void reader (void);
 void free_merger_functions (void);