tests: add -pedantic for --enable-gcc-warnings.

This should help to avoid some portability problems.  For example,
it would have revealed the empty unions fixed by the last patch
* configure.ac (WARN_CFLAGS_TESTS, WARN_CXXFLAGS_TEST): Implement.
* tests/synclines.at (AT_TEST_SYNCLINE): Avoid -pedantic warning
about an empty translation unit.
(cherry picked from commit 5422d56a718805a2470558808355e04182a12d65)

diff --git a/ChangeLog b/ChangeLog
index 3da26ebc0408fb271fe1301be19f58c96e722d34..ced339c888548f8ce98990244934cb5d766c3485 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2011-08-21  Joel E. Denny  <joeldenny@joeldenny.org>
+
+       tests: add -pedantic for --enable-gcc-warnings.
+       This should help to avoid some portability problems.  For example,
+       it would have revealed the empty unions fixed by the last patch
+       * configure.ac (WARN_CFLAGS_TESTS, WARN_CXXFLAGS_TEST): Implement.
+       * tests/synclines.at (AT_TEST_SYNCLINE): Avoid -pedantic warning
+       about an empty translation unit.
+

 2011-08-21  Joel E. Denny  <joeldenny@joeldenny.org>
 
        tests: fix empty unions.
 2011-08-21  Joel E. Denny  <joeldenny@joeldenny.org>
 
        tests: fix empty unions.

diff --git a/configure.ac b/configure.ac
index 258e6bb1843e747125971907ee5c927adc1ab7b4..a98bc952a2147d011a890ad65bc5643d6b2aace1 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -82,10 +82,9 @@ if test "${enableval}" = yes; then
   AC_SUBST([WARN_CFLAGS])
   # Warnings for the test suite only.
   gl_WARN_ADD([-Wundef], [WARN_CFLAGS_TEST])
   AC_SUBST([WARN_CFLAGS])
   # Warnings for the test suite only.
   gl_WARN_ADD([-Wundef], [WARN_CFLAGS_TEST])

-  WARN_CXXFLAGS_TEST="$WARN_CXXFLAGS $WARN_CFLAGS_TEST"
-  WARN_CFLAGS_TEST="$WARN_CFLAGS $WARN_CFLAGS_TEST"
-  AC_SUBST([WARN_CXXFLAGS_TEST])
-  AC_SUBST([WARN_CFLAGS_TEST])
+  gl_WARN_ADD([-pedantic], [WARN_CFLAGS_TEST])
+  AC_SUBST([WARN_CXXFLAGS_TEST], ["$WARN_CXXFLAGS $WARN_CFLAGS_TEST"])
+  AC_SUBST([WARN_CFLAGS_TEST], ["$WARN_CFLAGS $WARN_CFLAGS_TEST"])

 fi
 
 BISON_TEST_FOR_WORKING_C_COMPILER
 fi
 
 BISON_TEST_FOR_WORKING_C_COMPILER

diff --git a/tests/synclines.at b/tests/synclines.at
index cc2a7229fee60f73592d33b8223f6e3ef74efd1c..42b2a6671ffd5682a1fc5bca46becfe0521f6494 100644 (file)
--- a/tests/synclines.at
+++ b/tests/synclines.at
@@ -88,6 +88,7 @@ m4_define([AT_TEST_SYNCLINE],
 
 AT_DATA([syncline.c],
 [[#error "1"
 
 AT_DATA([syncline.c],
 [[#error "1"

+int i; // avoids -pedantic warning about an empty translation unit

 ]])
 
 AT_SYNCLINES_COMPILE([syncline.c])
 ]])
 
 AT_SYNCLINES_COMPILE([syncline.c])