do not ignore errors like ENOSPC,EIO when writing to stdout

Standard output was never explicitly closed, so we could not
detect failure.  Thus, bison would ignore the errors of writing
to a full file system and getting an I/O error on write, but only
for standard output, e.g., for --print-localedir, --print-datadir,
--help and some verbose output.
Now, "bison --print-datadir > /dev/full" reports the write failure:
bison: write error: No space left on device
Before, it would exit 0 with no diagnostic, implying success.
This is not an issue for "--output=-" or the other FILE-accepting
command-line options, because unlike most other GNU programs,
an output file argument of "-" is treated as the literal "./-",
rather than standard output.
* bootstrap.conf (gnulib_modules): Add closeout.
* src/main.c: Include "closeout.h".
Use atexit to ensure we close stdout.
* .gitignore: Ignore new files pulled in via gnulib-tool.

diff --git a/bootstrap.conf b/bootstrap.conf
index 599b778f0eb26a5420ec98a1b478f8ae70e2d6c5..757111ce5b518bb1aaec952f14058eb3beb3ffd2 100644 (file)
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -17,7 +17,7 @@
 
 # gnulib modules used by this package.
 gnulib_modules='
 
 # gnulib modules used by this package.
 gnulib_modules='

-  announce-gen argmatch assert calloc-posix close config-h c-strcase
+  announce-gen argmatch assert calloc-posix close closeout config-h c-strcase

   configmake dirname error extensions fdl fopen-safer gendocs getopt-gnu
   gettext git-version-gen gitlog-to-changelog
   gpl-3.0 hash inttypes isnan javacomp-script
   configmake dirname error extensions fdl fopen-safer gendocs getopt-gnu
   gettext git-version-gen gitlog-to-changelog
   gpl-3.0 hash inttypes isnan javacomp-script

diff --git a/lib/.gitignore b/lib/.gitignore
index 54edced35b421aef5226e632ceb8161c0a9a89f5..365b84d0dc04e6b646cd048062f3cd0824c1818b 100644 (file)
--- a/lib/.gitignore
+++ b/lib/.gitignore
@@ -259,3 +259,9 @@
 /strerror-override.h
 /strerror_r.c
 /xalloc-oversized.h
 /strerror-override.h
 /strerror_r.c
 /xalloc-oversized.h

+/close-stream.c
+/close-stream.h
+/closeout.c
+/closeout.h
+/fpending.c
+/fpending.h

diff --git a/m4/.gitignore b/m4/.gitignore
index c50ed39a0af804a5c3dda835013b3d8461688107..901724d0fbb214792b62fa75fb304ab46fd35dd7 100644 (file)
--- a/m4/.gitignore
+++ b/m4/.gitignore
@@ -166,3 +166,6 @@
 /raise.m4
 /ssize_t.m4
 /strerror_r.m4
 /raise.m4
 /ssize_t.m4
 /strerror_r.m4

+/close-stream.m4
+/closeout.m4
+/fpending.m4

diff --git a/src/main.c b/src/main.c
index e777ca047c7410d0b3f9c910bac46b707712d0d4..3dbac3a9a92928861f267461c8b369d29a67c1f5 100644 (file)
--- a/src/main.c
+++ b/src/main.c
@@ -28,6 +28,7 @@
 #include <timevar.h>
 
 #include "LR0.h"
 #include <timevar.h>
 
 #include "LR0.h"

+#include "closeout.h"

 #include "complain.h"
 #include "conflicts.h"
 #include "derives.h"
 #include "complain.h"
 #include "conflicts.h"
 #include "derives.h"


@@ -62,6 +63,8 @@ main (int argc, char *argv[])
   (void) bindtextdomain ("bison-runtime", LOCALEDIR);
   (void) textdomain (PACKAGE);
 
   (void) bindtextdomain ("bison-runtime", LOCALEDIR);
   (void) textdomain (PACKAGE);
 

+  atexit (close_stdout);
+

   uniqstrs_new ();
   muscle_init ();
 
   uniqstrs_new ();
   muscle_init ();