Use aver not assert.

* src/output.c: Don't include assert.h.
(output_skeleton): Use aver not assert.
* src/system.h (aver): In documentation of why, add links to
Paul Eggert's explanations in the mailing lists.

diff --git a/ChangeLog b/ChangeLog
index 02e3c6a2501a250eb928ef4895e2c54a4ad2cff9..3e0ad69de72dda77699a4b85ce41943ca85f34b0 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2009-09-03  Joel E. Denny  <jdenny@clemson.edu>
+
+       Use aver not assert.
+       * src/output.c: Don't include assert.h.
+       (output_skeleton): Use aver not assert.
+       * src/system.h (aver): In documentation of why, add links to
+       Paul Eggert's explanations in the mailing lists.
+

 2009-09-05  Alex Rozenman  <rozenman@gmail.com>
 
        Use "Unresolved reference" error message when no symbols were found
 2009-09-05  Alex Rozenman  <rozenman@gmail.com>
 
        Use "Unresolved reference" error message when no symbols were found

diff --git a/src/output.c b/src/output.c
index 23cd8ffaeb940df3b63e64e2a2b62d77d1214caf..562918c0db4f880bbe0ff212f7280b789dd8d9a9 100644 (file)
--- a/src/output.c
+++ b/src/output.c
@@ -21,7 +21,6 @@
 #include <config.h>
 #include "system.h"
 
 #include <config.h>
 #include "system.h"
 

-#include <assert.h>

 #include <configmake.h>
 #include <error.h>
 #include <get-errno.h>
 #include <configmake.h>
 #include <error.h>
 #include <get-errno.h>


@@ -637,7 +636,7 @@ output_skeleton (void)
     argv[i++] = full_m4bison;
     argv[i++] = full_skeleton;
     argv[i++] = NULL;
     argv[i++] = full_m4bison;
     argv[i++] = full_skeleton;
     argv[i++] = NULL;

-    assert (i <= ARRAY_CARDINALITY (argv));
+    aver (i <= ARRAY_CARDINALITY (argv));

   }
 
   init_subpipe ();
   }
 
   init_subpipe ();

diff --git a/src/system.h b/src/system.h
index cc2b09b22d14c280b58e2b18749f5cfd18c34188..8ea5653157fdc72feca09a0324b78b9ae0481f4c 100644 (file)
--- a/src/system.h
+++ b/src/system.h
@@ -124,7 +124,10 @@ typedef size_t uintptr_t;
 `-------------*/
 
 /* <assert.h>'s assertions are too heavyweight, and can be disabled
 `-------------*/
 
 /* <assert.h>'s assertions are too heavyweight, and can be disabled

-   too easily, so use aver rather than assert.  */
+   too easily, so use aver rather than assert.  See discussions at
+   <http://lists.gnu.org/archive/html/bison-patches/2006-01/msg00080.html>
+   <http://lists.gnu.org/archive/html/bison-patches/2006-09/msg00111.html>.
+*/

 static inline void
 aver (bool assertion)
 {
 static inline void
 aver (bool assertion)
 {