tests: minor fixes/simplifications

[bison.git] / tests / local.at

diff --git a/tests/local.at b/tests/local.at
index 1ba859df2223abcfd652b22d2126017f1bdb65d4..a8b38762e259c205ff757693416fc41656e57121 100644 (file)
--- a/tests/local.at
+++ b/tests/local.at
@@ -2,7 +2,7 @@
 
 # Macros for the GNU Bison Test suite.
 
-# Copyright (C) 2003-2011 Free Software Foundation, Inc.
+# Copyright (C) 2003-2012 Free Software Foundation, Inc.
 
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -284,9 +284,10 @@ m4_define([AT_BISON_CHECK_NO_XML],
                 [AT_QUELL_VALGRIND ])[[bison ]]$@)
 m4_if(m4_bregexp([$4], [: warning: ]), [-1], [],
       m4_quote(m4_if(m4_quote($2), [], [0], [$2])), [0], [[
-        # POSIXLY_CORRECT=1 causes bison to complain if options are added
-        # after the grammar file name, so skip these checks in that case.
-        if test x"$POSIXLY_CORRECT" != x1; then
+        # Defining POSIXLY_CORRECT causes bison to complain if options
+        # are added after the grammar file name, so skip these checks
+        # in that case.
+        if test -z "${POSIXLY_CORRECT+set}"; then
           # Don't interfere with caller's files.
           if test -f stderr; then mv stderr at-bison-check-stderr.bak; fi
           if test -f experr; then mv experr at-bison-check-experr.bak; fi
@@ -302,14 +303,12 @@ m4_if(m4_bregexp([$4], [: warning: ]), [-1], [],
           # Build expected stderr up to and including the "warnings being
           # treated as errors" message.
           ]AT_DATA([[at-bison-check-warnings]], [$4])[
-          at_bison_check_first="` \
-            sed -n '/: warning: /=' at-bison-check-warnings \
-            | sed -n 1p \
-          `"
-          at_bison_check_first_tmp="` \
-            sed -n '/conflicts: [0-9].*reduce$/=' at-bison-check-warnings \
-            | sed -n 1p \
-          `"
+          at_bison_check_first=`sed -n \
+            '/: warning: /{=;q;}' at-bison-check-warnings`
+          : ${at_bison_check_first:=1}
+          at_bison_check_first_tmp=`sed -n \
+            '/conflicts: [0-9].*reduce$/{=;q;}' at-bison-check-warnings`
+          : ${at_bison_check_first_tmp:=1}
           if test $at_bison_check_first_tmp -lt $at_bison_check_first; then
             at_bison_check_first=$at_bison_check_first_tmp
           fi
@@ -323,11 +322,9 @@ m4_if(m4_bregexp([$4], [: warning: ]), [-1], [],
           # complaints cause bison to exit early.  Thus, with -Werror, bison
           # does not necessarily report all warnings that it does without
           # -Werror, but it at least reports one.
-          at_bison_check_last="`sed -n '$=' stderr`"
-          if test x"$at_bison_check_last" = x; then
-            at_bison_check_last=1
-          fi
-          at_bison_check_last="`expr $at_bison_check_last - 1`"
+          at_bison_check_last=`sed -n '$=' stderr`
+          : ${at_bison_check_last:=1}
+          at_bison_check_last=`expr $at_bison_check_last - 1`
           sed -n "$at_bison_check_first,$at_bison_check_last"p \
             at-bison-check-warnings >> experr
           ]AT_CHECK([[sed 's,.*/\(]AT_BISON_WERROR_MSG[\)$,\1,' \