bison: avoid warnings from static code analysis

[bison.git] / data / location.cc

diff --git a/data/location.cc b/data/location.cc
index 5cf96de78c764fe1b554a2aec36a5a8b2c0bdc11..53fddd4868b384a5bb0bbc47176a3c7c93e0dca6 100644 (file)
--- a/data/location.cc
+++ b/data/location.cc
@@ -1,6 +1,6 @@
 # C++ skeleton for Bison
 
 # C++ skeleton for Bison
 

-# Copyright (C) 2002-2010 Free Software Foundation, Inc.
+# Copyright (C) 2002-2015 Free Software Foundation, Inc.

 
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
 
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by


@@ -16,34 +16,18 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 m4_pushdef([b4_copyright_years],
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 m4_pushdef([b4_copyright_years],

-           [2002-2010])
+           [2002-2015])

 
 

-# We do want M4 expansion after # for CPP macros.
-m4_changecom()
-m4_divert_push(0)dnl
-@output(b4_dir_prefix[]position.hh@)@
-b4_copyright([Positions for Bison parsers in C++])[
-
-/**
- ** \file position.hh
- ** Define the ]b4_namespace_ref[::position class.
- */
-
-#ifndef BISON_POSITION_HH
-# define BISON_POSITION_HH
-
-# include <iostream>
-# include <string>
-# include <algorithm>
-
-]b4_namespace_open[
-  /// Abstract a position.
+# b4_position_define
+# ------------------
+# Define class position.
+m4_define([b4_position_define],
+[[  /// Abstract a position.

   class position
   {
   class position
   {

-  public:
-]m4_ifdef([b4_location_constructors], [[
+  public:]m4_ifdef([b4_location_constructors], [[

     /// Construct a position.
     /// Construct a position.

-    explicit position (]b4_percent_define_get([[filename_type]])[* f = 0,
+    explicit position (]b4_percent_define_get([[filename_type]])[* f = YY_NULLPTR,

                        unsigned int l = ]b4_location_initial_line[u,
                        unsigned int c = ]b4_location_initial_column[u)
       : filename (f)
                        unsigned int l = ]b4_location_initial_line[u,
                        unsigned int c = ]b4_location_initial_column[u)
       : filename (f)


@@ -54,27 +38,31 @@ b4_copyright([Positions for Bison parsers in C++])[
 
 ]])[
     /// Initialization.
 
 ]])[
     /// Initialization.

-    inline void initialize (]b4_percent_define_get([[filename_type]])[* fn)
+    void initialize (]b4_percent_define_get([[filename_type]])[* fn = YY_NULLPTR,
+                     unsigned int l = ]b4_location_initial_line[u,
+                     unsigned int c = ]b4_location_initial_column[u)

     {
       filename = fn;
     {
       filename = fn;

-      line = ]b4_location_initial_line[u;
-      column = ]b4_location_initial_column[u;
+      line = l;
+      column = c;

     }
 
     /** \name Line and Column related manipulators
      ** \{ */
     /// (line related) Advance to the COUNT next lines.
     }
 
     /** \name Line and Column related manipulators
      ** \{ */
     /// (line related) Advance to the COUNT next lines.

-    /// Set current column to initial value.
-    inline void lines (int count = 1)
+    void lines (int count = 1)

     {
     {

-      column = ]b4_location_initial_column[u;
-      line += count;
+      if (count)
+        {
+          column = ]b4_location_initial_column[u;
+          line = add_ (line, count, ]b4_location_initial_line[);
+        }

     }
 
     /// (column related) Advance to the COUNT next columns.
     }
 
     /// (column related) Advance to the COUNT next columns.

-    inline void columns (int count = 1)
+    void columns (int count = 1)

     {
     {

-      column = std::max (]b4_location_initial_column[u, column + count);
+      column = add_ (column, count, ]b4_location_initial_column[);

     }
     /** \} */
 
     }
     /** \} */
 


@@ -84,36 +72,44 @@ b4_copyright([Positions for Bison parsers in C++])[
     unsigned int line;
     /// Current column number.
     unsigned int column;
     unsigned int line;
     /// Current column number.
     unsigned int column;

+
+  private:
+    /// Compute max(min, lhs+rhs) (provided min <= lhs).
+    static unsigned int add_ (unsigned int lhs, int rhs, unsigned int min)
+    {
+      return (0 < rhs || -static_cast<unsigned int>(rhs) < lhs
+              ? rhs + lhs
+              : min);
+    }

   };
 
   };
 

-  /// Add and assign a position.
-  inline const position&
-  operator+= (position& res, const int width)
+  /// Add \a width columns, in place.
+  inline position&
+  operator+= (position& res, int width)

   {
     res.columns (width);
     return res;
   }
 
   {
     res.columns (width);
     return res;
   }
 

-  /// Add two position objects.
-  inline const position
-  operator+ (const position& begin, const int width)
+  /// Add \a width columns.
+  inline position
+  operator+ (position res, int width)

   {
   {

-    position res = begin;

     return res += width;
   }
 
     return res += width;
   }
 

-  /// Add and assign a position.
-  inline const position&
-  operator-= (position& res, const int width)
+  /// Subtract \a width columns, in place.
+  inline position&
+  operator-= (position& res, int width)

   {
     return res += -width;
   }
 
   {
     return res += -width;
   }
 

-  /// Add two position objects.
-  inline const position
-  operator- (const position& begin, const int width)
+  /// Subtract \a width columns.
+  inline position
+  operator- (position res, int width)

   {
   {

-    return begin + -width;
+    return res -= width;

   }
 ]b4_percent_define_flag_if([[define_location_comparison]], [[
   /// Compare two position objects.
   }
 ]b4_percent_define_flag_if([[define_location_comparison]], [[
   /// Compare two position objects.


@@ -138,34 +134,21 @@ b4_copyright([Positions for Bison parsers in C++])[
    ** \param ostr the destination output stream
    ** \param pos a reference to the position to redirect
    */
    ** \param ostr the destination output stream
    ** \param pos a reference to the position to redirect
    */

-  inline std::ostream&
-  operator<< (std::ostream& ostr, const position& pos)
+  template <typename YYChar>
+  inline std::basic_ostream<YYChar>&
+  operator<< (std::basic_ostream<YYChar>& ostr, const position& pos)

   {
     if (pos.filename)
       ostr << *pos.filename << ':';
     return ostr << pos.line << '.' << pos.column;
   }
   {
     if (pos.filename)
       ostr << *pos.filename << ':';
     return ostr << pos.line << '.' << pos.column;
   }

+]])

 
 

-]b4_namespace_close[
-#endif // not BISON_POSITION_HH]
-@output(b4_dir_prefix[]location.hh@)@
-b4_copyright([Locations for Bison parsers in C++])[
-
-/**
- ** \file location.hh
- ** Define the ]b4_namespace_ref[::location class.
- */
-
-#ifndef BISON_LOCATION_HH
-# define BISON_LOCATION_HH
-
-# include <iostream>
-# include <string>
-# include "position.hh"

 
 

-]b4_namespace_open[
-
-  /// Abstract a location.
+# b4_location_define
+# ------------------
+m4_define([b4_location_define],
+[[  /// Abstract a location.

   class location
   {
   public:
   class location
   {
   public:


@@ -195,9 +178,11 @@ b4_copyright([Locations for Bison parsers in C++])[
 
 ])[
     /// Initialization.
 
 ])[
     /// Initialization.

-    inline void initialize (]b4_percent_define_get([[filename_type]])[* fn)
+    void initialize (]b4_percent_define_get([[filename_type]])[* f = YY_NULLPTR,
+                     unsigned int l = ]b4_location_initial_line[u,
+                     unsigned int c = ]b4_location_initial_column[u)

     {
     {

-      begin.initialize (fn);
+      begin.initialize (f, l, c);

       end = begin;
     }
 
       end = begin;
     }
 


@@ -205,19 +190,19 @@ b4_copyright([Locations for Bison parsers in C++])[
      ** \{ */
   public:
     /// Reset initial location to final location.
      ** \{ */
   public:
     /// Reset initial location to final location.

-    inline void step ()
+    void step ()

     {
       begin = end;
     }
 
     /// Extend the current location to the COUNT next columns.
     {
       begin = end;
     }
 
     /// Extend the current location to the COUNT next columns.

-    inline void columns (unsigned int count = 1)
+    void columns (int count = 1)

     {
       end += count;
     }
 
     /// Extend the current location to the COUNT next lines.
     {
       end += count;
     }
 
     /// Extend the current location to the COUNT next lines.

-    inline void lines (unsigned int count = 1)
+    void lines (int count = 1)

     {
       end.lines (count);
     }
     {
       end.lines (count);
     }


@@ -231,28 +216,43 @@ b4_copyright([Locations for Bison parsers in C++])[
     position end;
   };
 
     position end;
   };
 

-  /// Join two location objects to create a location.
-  inline const location operator+ (const location& begin, const location& end)
+  /// Join two locations, in place.
+  inline location& operator+= (location& res, const location& end)

   {
   {

-    location res = begin;

     res.end = end.end;
     return res;
   }
 
     res.end = end.end;
     return res;
   }
 

-  /// Add two location objects.
-  inline const location operator+ (const location& begin, unsigned int width)
+  /// Join two locations.
+  inline location operator+ (location res, const location& end)

   {
   {

-    location res = begin;
-    res.columns (width);
-    return res;
+    return res += end;

   }
 
   }
 

-  /// Add and assign a location.
-  inline location& operator+= (location& res, unsigned int width)
+  /// Add \a width columns to the end position, in place.
+  inline location& operator+= (location& res, int width)

   {
     res.columns (width);
     return res;
   }
   {
     res.columns (width);
     return res;
   }

+
+  /// Add \a width columns to the end position.
+  inline location operator+ (location res, int width)
+  {
+    return res += width;
+  }
+
+  /// Subtract \a width columns to the end position, in place.
+  inline location& operator-= (location& res, int width)
+  {
+    return res += -width;
+  }
+
+  /// Subtract \a width columns to the end position.
+  inline location operator- (location res, int width)
+  {
+    return res -= width;
+  }

 ]b4_percent_define_flag_if([[define_location_comparison]], [[
   /// Compare two location objects.
   inline bool
 ]b4_percent_define_flag_if([[define_location_comparison]], [[
   /// Compare two location objects.
   inline bool


@@ -274,24 +274,67 @@ b4_copyright([Locations for Bison parsers in C++])[
    **
    ** Avoid duplicate information.
    */
    **
    ** Avoid duplicate information.
    */

-  inline std::ostream& operator<< (std::ostream& ostr, const location& loc)
+  template <typename YYChar>
+  inline std::basic_ostream<YYChar>&
+  operator<< (std::basic_ostream<YYChar>& ostr, const location& loc)

   {
   {

-    position last = loc.end - 1;
+    unsigned int end_col = 0 < loc.end.column ? loc.end.column - 1 : 0;

     ostr << loc.begin;
     ostr << loc.begin;

-    if (last.filename
-       && (!loc.begin.filename
-           || *loc.begin.filename != *last.filename))
-      ostr << '-' << last;
-    else if (loc.begin.line != last.line)
-      ostr << '-' << last.line  << '.' << last.column;
-    else if (loc.begin.column != last.column)
-      ostr << '-' << last.column;
+    if (loc.end.filename
+        && (!loc.begin.filename
+            || *loc.begin.filename != *loc.end.filename))
+      ostr << '-' << loc.end.filename << ':' << loc.end.line << '.' << end_col;
+    else if (loc.begin.line < loc.end.line)
+      ostr << '-' << loc.end.line << '.' << end_col;
+    else if (loc.begin.column < end_col)
+      ostr << '-' << end_col;

     return ostr;
   }
     return ostr;
   }

+]])
+
+
+b4_defines_if([
+b4_output_begin([b4_dir_prefix[]position.hh])
+b4_copyright([Positions for Bison parsers in C++])[
+
+/**
+ ** \file ]b4_dir_prefix[position.hh
+ ** Define the ]b4_namespace_ref[::position class.
+ */
+
+]b4_cpp_guard_open([b4_dir_prefix[]position.hh])[
+
+# include <algorithm> // std::max
+# include <iostream>
+# include <string>
+
+]b4_null_define[

 
 

+]b4_namespace_open[
+]b4_position_define[

 ]b4_namespace_close[
 ]b4_namespace_close[

+]b4_cpp_guard_close([b4_dir_prefix[]position.hh])
+b4_output_end()
+
+
+b4_output_begin([b4_dir_prefix[]location.hh])
+b4_copyright([Locations for Bison parsers in C++])[
+
+/**
+ ** \file ]b4_dir_prefix[location.hh
+ ** Define the ]b4_namespace_ref[::location class.
+ */
+
+]b4_cpp_guard_open([b4_dir_prefix[]location.hh])[
+
+# include "position.hh"
+
+]b4_namespace_open[
+]b4_location_define[
+]b4_namespace_close[
+]b4_cpp_guard_close([b4_dir_prefix[]location.hh])
+b4_output_end()
+])
+

 
 

-#endif // not BISON_LOCATION_HH]
-m4_divert_pop(0)
-m4_popdef([b4_copyright_years])dnl
-m4_changecom([#])
+m4_popdef([b4_copyright_years])