Fix some memory leaks, and fix a bug: state 0 was examined twice.

[bison.git] / src / print.c

diff --git a/src/print.c b/src/print.c
index 927d2beec7c5849230905fdb04c8363d08c7e3fc..7adb51b06016495469461e2b4b49e3a9cf1d894f 100644 (file)
--- a/src/print.c
+++ b/src/print.c
@@ -48,6 +48,19 @@ print_token (int extnum, int token)
 #endif
 
 \f
 #endif
 
 \f

+
+/*---------------------------------------.
+| *WIDTH := max (*WIDTH, strlen (STR)).  |
+`---------------------------------------*/
+
+static void
+max_length (size_t *width, const char *str)
+{
+  size_t len = strlen (str);
+  if (len > *width)
+    *width = len;
+}
+

 /*--------------------------------.
 | Report information on a state.  |
 `--------------------------------*/
 /*--------------------------------.
 | Report information on a state.  |
 `--------------------------------*/


@@ -58,6 +71,7 @@ print_core (FILE *out, state_t *state)
   int i;
   item_number_t *sitems = state->items;
   int snritems   = state->nitems;
   int i;
   item_number_t *sitems = state->items;
   int snritems   = state->nitems;

+  symbol_t *previous_lhs = NULL;

 
   /* Output all the items of a state, not only its kernel.  */
   if (report_flag & report_itemsets)
 
   /* Output all the items of a state, not only its kernel.  */
   if (report_flag & report_itemsets)


@@ -67,272 +81,357 @@ print_core (FILE *out, state_t *state)
       snritems = nritemset;
     }
 
       snritems = nritemset;
     }
 

-  if (snritems)
-    {
-      for (i = 0; i < snritems; i++)
-       {
-         item_number_t *sp;
-         item_number_t *sp1;
-         int rule;
+  if (!snritems)
+    return;

 
 

-         sp1 = sp = ritem + sitems[i];
+  fputc ('\n', out);

 
 

-         while (*sp >= 0)
-           sp++;
+  for (i = 0; i < snritems; i++)
+    {
+      item_number_t *sp;
+      item_number_t *sp1;
+      int rule;

 
 

-         rule = -(*sp);
-         fprintf (out, "    %s  ->  ", symbol_tag_get (rules[rule].lhs));
+      sp1 = sp = ritem + sitems[i];

 
 

-         for (sp = rules[rule].rhs; sp < sp1; sp++)
-           fprintf (out, "%s ", symbol_tag_get (symbols[*sp]));
+      while (*sp >= 0)
+       sp++;

 
 

-         fputc ('.', out);
+      rule = -(*sp);

 
 

-         for (/* Nothing */; *sp >= 0; ++sp)
-           fprintf (out, " %s", symbol_tag_get (symbols[*sp]));
+      rule_lhs_print (&rules[rule], previous_lhs, out);
+      previous_lhs = rules[rule].lhs;

 
 

-         /* Display the lookaheads?  */
-         if (report_flag & report_lookaheads)
-           state_rule_lookaheads_print (state, &rules[rule], out);
+      for (sp = rules[rule].rhs; sp < sp1; sp++)
+       fprintf (out, " %s", symbols[*sp]->tag);
+      fputs (" .", out);
+      for (/* Nothing */; *sp >= 0; ++sp)
+       fprintf (out, " %s", symbols[*sp]->tag);

 
 

-         fprintf (out, _("   (rule %d)"), rule - 1);
-         fputc ('\n', out);
-       }
+      /* Display the lookaheads?  */
+      if (report_flag & report_lookaheads)
+       state_rule_lookaheads_print (state, &rules[rule], out);

 
       fputc ('\n', out);
     }
 }
 
 
 
       fputc ('\n', out);
     }
 }
 
 

+/*----------------------------------------------------------------.
+| Report the shifts iff DISPLAY_SHIFTS_P or the gotos of STATE on |
+| OUT.                                                            |
+`----------------------------------------------------------------*/
+

 static void
 static void

-print_shifts (FILE *out, state_t *state)
+print_transitions (state_t *state, FILE *out, bool display_transitions_p)

 {
 {

+  transitions_t *transitions = state->transitions;
+  size_t width = 0;

   int i;
   int i;

-  shifts_t *shiftp = state->shifts;

 
 

-  for (i = 0; i < shiftp->nshifts && SHIFT_IS_SHIFT (shiftp, i); i++)
-    if (!SHIFT_IS_DISABLED (shiftp, i))
+  /* Compute the width of the lookaheads column.  */
+  for (i = 0; i < transitions->num; i++)
+    if (!TRANSITION_IS_DISABLED (transitions, i)
+       && TRANSITION_IS_SHIFT (transitions, i) == display_transitions_p)

       {
       {

-       state_number_t state1 = shiftp->shifts[i];
-       symbol_number_t symbol = states[state1]->accessing_symbol;
-       fprintf (out,
-                _("    %-4s\tshift, and go to state %d\n"),
-                symbol_tag_get (symbols[symbol]), state1);
+       symbol_t *symbol = symbols[TRANSITION_SYMBOL (transitions, i)];
+       max_length (&width, symbol->tag);

       }
 
       }
 

-  if (i > 0)
-    fputc ('\n', out);
+  /* Nothing to report. */
+  if (!width)
+    return;
+
+  fputc ('\n', out);
+  width += 2;
+
+  /* Report lookaheads and shifts.  */
+  for (i = 0; i < transitions->num; i++)
+    if (!TRANSITION_IS_DISABLED (transitions, i)
+       && TRANSITION_IS_SHIFT (transitions, i) == display_transitions_p)
+      {
+       symbol_t *symbol = symbols[TRANSITION_SYMBOL (transitions, i)];
+       const char *tag = symbol->tag;
+       state_number_t state1 = transitions->states[i];
+       int j;
+
+       fprintf (out, "    %s", tag);
+       for (j = width - strlen (tag); j > 0; --j)
+         fputc (' ', out);
+       if (display_transitions_p)
+         fprintf (out, _("shift, and go to state %d\n"), state1);
+       else
+         fprintf (out, _("go to state %d\n"), state1);
+      }

 }
 
 
 }
 
 

+/*------------------------------------------------------------.
+| Report the explicit errors of STATE raised from %nonassoc.  |
+`------------------------------------------------------------*/
+

 static void
 print_errs (FILE *out, state_t *state)
 {
   errs_t *errp = state->errs;
 static void
 print_errs (FILE *out, state_t *state)
 {
   errs_t *errp = state->errs;

+  size_t width = 0;

   int i;
 
   int i;
 

-  for (i = 0; i < errp->nerrs; ++i)
-    if (errp->errs[i])
-      fprintf (out, _("    %-4s\terror (nonassociative)\n"),
-              symbol_tag_get (symbols[errp->errs[i]]));
+  /* Compute the width of the lookaheads column.  */
+  for (i = 0; i < errp->num; ++i)
+    if (errp->symbols[i])
+      max_length (&width, symbols[errp->symbols[i]]->tag);

 
 

-  if (i > 0)
-    fputc ('\n', out);
+  /* Nothing to report. */
+  if (!width)
+    return;
+
+  fputc ('\n', out);
+  width += 2;
+
+  /* Report lookaheads and errors.  */
+  for (i = 0; i < errp->num; ++i)
+    if (errp->symbols[i])
+      {
+       const char *tag = symbols[errp->symbols[i]]->tag;
+       int j;
+       fprintf (out, "    %s", tag);
+       for (j = width - strlen (tag); j > 0; --j)
+         fputc (' ', out);
+       fputs (_("error (nonassociative)\n"), out);
+      }

 }
 
 
 }
 
 

-static void
-print_gotos (FILE *out, state_t *state)
+/*----------------------------------------------------------.
+| Return the default rule of this STATE if it has one, NULL |
+| otherwise.                                                |
+`----------------------------------------------------------*/
+
+static rule_t *
+state_default_rule (state_t *state)

 {
 {

+  reductions_t *redp = state->reductions;
+  rule_t *default_rule = NULL;
+  int cmax = 0;

   int i;
   int i;

-  shifts_t *shiftp = state->shifts;

 
 

-  for (i = 0; i < shiftp->nshifts && SHIFT_IS_SHIFT (shiftp, i); i++)
-    /* Skip token shifts.  */;
+  /* No need for a lookahead.  */
+  if (state->consistent)
+    return &rules[redp->rules[0]];

 
 

-  if (i < shiftp->nshifts)
+  /* 1. Each reduction is possibly masked by the lookaheads on which
+     we shift (S/R conflicts)...  */
+  bitset_zero (shiftset);
+  {
+    transitions_t *transitions = state->transitions;
+    for (i = 0; i < transitions->num && TRANSITION_IS_SHIFT (transitions, i); i++)
+      if (!TRANSITION_IS_DISABLED (transitions, i))
+       {
+         /* If this state has a shift for the error token, don't use a
+            default rule.  */
+         if (TRANSITION_IS_ERROR (transitions, i))
+           return NULL;
+         bitset_set (shiftset, TRANSITION_SYMBOL (transitions, i));
+       }
+  }
+
+  /* 2. Each reduction is possibly masked by the lookaheads on which
+     we raise an error (due to %nonassoc).  */
+  {
+    errs_t *errp = state->errs;
+    for (i = 0; i < errp->num; i++)
+      if (errp->symbols[i])
+       bitset_set (shiftset, errp->symbols[i]);
+  }
+
+  for (i = 0; i < state->nlookaheads; ++i)

     {
     {

-      for (; i < shiftp->nshifts; i++)
-       if (!SHIFT_IS_DISABLED (shiftp, i))
-         {
-           state_number_t state1 = shiftp->shifts[i];
-           symbol_number_t symbol = states[state1]->accessing_symbol;
-           fprintf (out, _("    %-4s\tgo to state %d\n"),
-                    symbol_tag_get (symbols[symbol]), state1);
-         }
+      int count = 0;

 
 

-      fputc ('\n', out);
+      /* How many non-masked lookaheads are there for this reduction?
+        */
+      bitset_andn (lookaheadset, state->lookaheads[i], shiftset);
+      count = bitset_count (lookaheadset);
+
+      if (count > cmax)
+       {
+         cmax = count;
+         default_rule = state->lookaheads_rule[i];
+       }
+
+      /* 3. And finally, each reduction is possibly masked by previous
+        reductions (in R/R conflicts, we keep the first reductions).
+        */
+      bitset_or (shiftset, shiftset, state->lookaheads[i]);

     }
     }

+
+  return default_rule;

 }
 
 }
 

+
+/*--------------------------------------------------------------------.
+| Report a reduction of RULE on LOOKAHEADS (which can be `default').  |
+| If not ENABLED, the rule is masked by a shift or a reduce (S/R and  |
+| R/R conflicts).                                                     |
+`--------------------------------------------------------------------*/
+
+static void
+print_reduction (FILE *out, size_t width,
+                const char *lookahead,
+                rule_t *rule, bool enabled)
+{
+  int j;
+  fprintf (out, "    %s", lookahead);
+  for (j = width - strlen (lookahead); j > 0; --j)
+    fputc (' ', out);
+  if (!enabled)
+    fputc ('[', out);
+  fprintf (out, _("reduce using rule %d (%s)"),
+          rule->number - 1, rule->lhs->tag);
+  if (!enabled)
+    fputc (']', out);
+  fputc ('\n', out);
+}
+
+
+/*----------------------------------------------------.
+| Report on OUT the reduction actions of this STATE.  |
+`----------------------------------------------------*/
+

 static void
 print_reductions (FILE *out, state_t *state)
 {
 static void
 print_reductions (FILE *out, state_t *state)
 {

-  int i;
-  shifts_t *shiftp = state->shifts;
+  transitions_t *transitions = state->transitions;

   reductions_t *redp = state->reductions;
   reductions_t *redp = state->reductions;

-  errs_t *errp = state->errs;
-  int nodefault = 0;
+  rule_t *default_rule = NULL;
+  size_t width = 0;
+  int i, j;

 
 

-  if (redp->nreds == 0)
+  if (redp->num == 0)

     return;
 
     return;
 

-  if (state->consistent)
-    {
-      int rule = redp->rules[0];
-      symbol_number_t symbol = rules[rule].lhs->number;
-      fprintf (out, _("    $default\treduce using rule %d (%s)\n\n"),
-              rule - 1, symbol_tag_get (symbols[symbol]));
-      return;
-    }
+  default_rule = state_default_rule (state);

 
   bitset_zero (shiftset);
 
   bitset_zero (shiftset);

-
-  for (i = 0; i < shiftp->nshifts && SHIFT_IS_SHIFT (shiftp, i); i++)
-    if (!SHIFT_IS_DISABLED (shiftp, i))
-      {
-       /* if this state has a shift for the error token, don't use a
-          default rule.  */
-       if (SHIFT_IS_ERROR (shiftp, i))
-         nodefault = 1;
-       bitset_set (shiftset, SHIFT_SYMBOL (shiftp, i));
-      }
-
-  for (i = 0; i < errp->nerrs; i++)
-    if (errp->errs[i])
-      bitset_set (shiftset, errp->errs[i]);
-
-  if (state->nlookaheads == 1 && !nodefault)
+  for (i = 0; i < transitions->num && TRANSITION_IS_SHIFT (transitions, i); i++)
+    if (!TRANSITION_IS_DISABLED (transitions, i))
+      bitset_set (shiftset, TRANSITION_SYMBOL (transitions, i));
+
+  /* Compute the width of the lookaheads column.  */
+  if (default_rule)
+    width = strlen (_("$default"));
+  for (i = 0; i < ntokens; i++)

     {
     {

-      rule_t *default_rule = state->lookaheads_rule[0];
-
-      bitset_and (lookaheadset, state->lookaheads[0], shiftset);
-
-      for (i = 0; i < ntokens; i++)
-       if (bitset_test (lookaheadset, i))
-         fprintf (out, _("    %-4s\t[reduce using rule %d (%s)]\n"),
-                  symbol_tag_get (symbols[i]),
-                  default_rule->number - 1,
-                  symbol_tag_get_n (default_rule->lhs, 1));
+      int count = bitset_test (shiftset, i);

 
 

-      fprintf (out, _("    $default\treduce using rule %d (%s)\n\n"),
-              default_rule->number - 1,
-              symbol_tag_get (default_rule->lhs));
-    }
-  else if (state->nlookaheads >= 1)
-    {
-      int cmax = 0;
-      int default_LA = -1;
-      rule_t *default_rule = NULL;
-
-      if (!nodefault)
-       for (i = 0; i < state->nlookaheads; ++i)
+      for (j = 0; j < state->nlookaheads; ++j)
+       if (bitset_test (state->lookaheads[j], i))

          {
          {

-           int count = 0;
-           int j;
-
-           bitset_andn (lookaheadset, state->lookaheads[i], shiftset);
-
-           for (j = 0; j < ntokens; j++)
-             if (bitset_test (lookaheadset, j))
+           if (count == 0)
+             {
+               if (state->lookaheads_rule[j] != default_rule)
+                 max_length (&width, symbols[i]->tag);

                count++;
                count++;

-
-           if (count > cmax)
+             }
+           else

              {
              {

-               cmax = count;
-               default_LA = i;
-               default_rule = state->lookaheads_rule[i];
+               max_length (&width, symbols[i]->tag);

              }
              }

-
-           bitset_or (shiftset, shiftset, lookaheadset);

          }
          }

+    }

 
 

-      bitset_zero (shiftset);
+  /* Nothing to report. */
+  if (!width)
+    return;

 
 

-      for (i = 0; i < shiftp->nshifts && SHIFT_IS_SHIFT (shiftp, i); i++)
-       if (!SHIFT_IS_DISABLED (shiftp, i))
-         bitset_set (shiftset, SHIFT_SYMBOL (shiftp, i));
+  fputc ('\n', out);
+  width += 2;

 
 

-      for (i = 0; i < ntokens; i++)
-       {
-         int j;
-         int defaulted = 0;
-         int count = bitset_test (shiftset, i);
+  /* Report lookaheads (or $default) and reductions.  */
+  for (i = 0; i < ntokens; i++)
+    {
+      int defaulted = 0;
+      int count = bitset_test (shiftset, i);

 
 

-         for (j = 0; j < state->nlookaheads; ++j)
-           if (bitset_test (state->lookaheads[j], i))
+      for (j = 0; j < state->nlookaheads; ++j)
+       if (bitset_test (state->lookaheads[j], i))
+         {
+           if (count == 0)

              {
              {

-               if (count == 0)
-                 {
-                   if (j != default_LA)
-                     fprintf (out,
-                              _("    %-4s\treduce using rule %d (%s)\n"),
-                              symbol_tag_get (symbols[i]),
-                              state->lookaheads_rule[j]->number - 1,
-                              symbol_tag_get_n (state->lookaheads_rule[j]->lhs, 1));
-                   else
-                     defaulted = 1;
-
-                   count++;
-                 }
+               if (state->lookaheads_rule[j] != default_rule)
+                 print_reduction (out, width,
+                                  symbols[i]->tag,
+                                  state->lookaheads_rule[j], TRUE);

                else
                else

-                 {
-                   if (defaulted)
-                     fprintf (out,
-                              _("    %-4s\treduce using rule %d (%s)\n"),
-                              symbol_tag_get (symbols[i]),
-                              state->lookaheads_rule[default_LA]->number - 1,
-                              symbol_tag_get_n (state->lookaheads_rule[default_LA]->lhs, 1));
-                   defaulted = 0;
-                   fprintf (out,
-                            _("    %-4s\t[reduce using rule %d (%s)]\n"),
-                            symbol_tag_get (symbols[i]),
-                            state->lookaheads_rule[j]->number - 1,
-                            symbol_tag_get_n (state->lookaheads_rule[j]->lhs, 1));
-                 }
+                 defaulted = 1;
+               count++;

              }
              }

-       }
-
-      if (default_LA >= 0)
-       fprintf (out, _("    $default\treduce using rule %d (%s)\n"),
-                default_rule->number - 1,
-                symbol_tag_get (default_rule->lhs));
+           else
+             {
+               if (defaulted)
+                 print_reduction (out, width,
+                                  symbols[i]->tag,
+                                  default_rule, TRUE);
+               defaulted = 0;
+               print_reduction (out, width,
+                                symbols[i]->tag,
+                                state->lookaheads_rule[j], FALSE);
+             }
+         }

     }
     }

+
+  if (default_rule)
+    print_reduction (out, width,
+                    _("$default"), default_rule, TRUE);

 }
 
 
 }
 
 

+/*--------------------------------------------------------------.
+| Report on OUT all the actions (shifts, gotos, reductions, and |
+| explicit erros from %nonassoc) of STATE.                      |
+`--------------------------------------------------------------*/
+

 static void
 print_actions (FILE *out, state_t *state)
 {
   reductions_t *redp = state->reductions;
 static void
 print_actions (FILE *out, state_t *state)
 {
   reductions_t *redp = state->reductions;

-  shifts_t *shiftp = state->shifts;
+  transitions_t *transitions = state->transitions;

 
 

-  if (shiftp->nshifts == 0 && redp->nreds == 0)
+  if (transitions->num == 0 && redp->num == 0)

     {
     {

+      fputc ('\n', out);

       if (state->number == final_state->number)
       if (state->number == final_state->number)

-       fprintf (out, _("    $default\taccept\n"));
+       fprintf (out, _("    $default\taccept\n"));

       else
       else

-       fprintf (out, _("    NO ACTIONS\n"));
+       fprintf (out, _("    NO ACTIONS\n"));

       return;
     }
 
       return;
     }
 

-  print_shifts (out, state);
+  /* Print shifts.  */
+  print_transitions (state, out, TRUE);

   print_errs (out, state);
   print_reductions (out, state);
   print_errs (out, state);
   print_reductions (out, state);

-  print_gotos (out, state);
+  /* Print gotos.  */
+  print_transitions (state, out, FALSE);

 }
 
 }
 

+
+/*--------------------------------------.
+| Report all the data on STATE on OUT.  |
+`--------------------------------------*/
+

 static void
 print_state (FILE *out, state_t *state)
 {
 static void
 print_state (FILE *out, state_t *state)
 {

-  fprintf (out, _("state %d"), state->number);

   fputs ("\n\n", out);
   fputs ("\n\n", out);

+  fprintf (out, _("state %d"), state->number);
+  fputc ('\n', out);

   print_core (out, state);
   print_actions (out, state);
   if ((report_flag & report_solved_conflicts)
       && state->solved_conflicts)
     fputs (state->solved_conflicts, out);
   print_core (out, state);
   print_actions (out, state);
   if ((report_flag & report_solved_conflicts)
       && state->solved_conflicts)
     fputs (state->solved_conflicts, out);

-  fputs ("\n\n", out);

 }
 \f
 /*-----------------------------------------.
 }
 \f
 /*-----------------------------------------.


@@ -354,7 +453,6 @@ static void
 print_grammar (FILE *out)
 {
   symbol_number_t i;
 print_grammar (FILE *out)
 {
   symbol_number_t i;

-  item_number_t *rule;

   char buffer[90];
   int column = 0;
 
   char buffer[90];
   int column = 0;
 


@@ -365,8 +463,10 @@ print_grammar (FILE *out)
   for (i = 0; i < max_user_token_number + 1; i++)
     if (token_translations[i] != undeftoken->number)
       {
   for (i = 0; i < max_user_token_number + 1; i++)
     if (token_translations[i] != undeftoken->number)
       {

-       const char *tag = symbol_tag_get (symbols[token_translations[i]]);
-       int r;
+       const char *tag = symbols[token_translations[i]]->tag;
+       rule_number_t r;
+       item_number_t *rhsp;
+

        buffer[0] = 0;
        column = strlen (tag);
        fputs (tag, out);
        buffer[0] = 0;
        column = strlen (tag);
        fputs (tag, out);


@@ -374,8 +474,8 @@ print_grammar (FILE *out)
        sprintf (buffer, " (%d)", i);
 
        for (r = 1; r < nrules + 1; r++)
        sprintf (buffer, " (%d)", i);
 
        for (r = 1; r < nrules + 1; r++)

-         for (rule = rules[r].rhs; *rule >= 0; rule++)
-           if (item_number_as_symbol_number (*rule) == token_translations[i])
+         for (rhsp = rules[r].rhs; *rhsp >= 0; rhsp++)
+           if (item_number_as_symbol_number (*rhsp) == token_translations[i])

              {
                END_TEST (65);
                sprintf (buffer + strlen (buffer), " %d", r - 1);
              {
                END_TEST (65);
                sprintf (buffer + strlen (buffer), " %d", r - 1);


@@ -390,15 +490,16 @@ print_grammar (FILE *out)
   for (i = ntokens; i < nsyms; i++)
     {
       int left_count = 0, right_count = 0;
   for (i = ntokens; i < nsyms; i++)
     {
       int left_count = 0, right_count = 0;

-      int r;
-      const char *tag = symbol_tag_get (symbols[i]);
+      rule_number_t r;
+      const char *tag = symbols[i]->tag;

 
       for (r = 1; r < nrules + 1; r++)
        {
 
       for (r = 1; r < nrules + 1; r++)
        {

+         item_number_t *rhsp;

          if (rules[r].lhs->number == i)
            left_count++;
          if (rules[r].lhs->number == i)
            left_count++;

-         for (rule = rules[r].rhs; *rule >= 0; rule++)
-           if (item_number_as_symbol_number (*rule) == i)
+         for (rhsp = rules[r].rhs; *rhsp >= 0; rhsp++)
+           if (item_number_as_symbol_number (*rhsp) == i)

              {
                right_count++;
                break;
              {
                right_count++;
                break;


@@ -432,8 +533,9 @@ print_grammar (FILE *out)
          sprintf (buffer + strlen (buffer), _(" on right:"));
          for (r = 1; r < nrules + 1; r++)
            {
          sprintf (buffer + strlen (buffer), _(" on right:"));
          for (r = 1; r < nrules + 1; r++)
            {

-             for (rule = rules[r].rhs; *rule >= 0; rule++)
-               if (item_number_as_symbol_number (*rule) == i)
+             item_number_t *rhsp;
+             for (rhsp = rules[r].rhs; *rhsp >= 0; rhsp++)
+               if (item_number_as_symbol_number (*rhsp) == i)

                  {
                    END_TEST (65);
                    sprintf (buffer + strlen (buffer), " %d", r - 1);
                  {
                    END_TEST (65);
                    sprintf (buffer + strlen (buffer), " %d", r - 1);


@@ -443,7 +545,6 @@ print_grammar (FILE *out)
        }
       fprintf (out, "%s\n", buffer);
     }
        }
       fprintf (out, "%s\n", buffer);
     }

-  fputs ("\n\n", out);

 }
 \f
 void
 }
 \f
 void