tests: minor fixes/simplifications

[bison.git] / src / getargs.c

diff --git a/src/getargs.c b/src/getargs.c
index 7365ab7e2a20c49df9de4f6b77762b61a1e3bd7c..06e6e972be3ee13f26970fadac923dec92534e94 100644 (file)
--- a/src/getargs.c
+++ b/src/getargs.c
@@ -1,7 +1,7 @@
 /* Parse command line arguments for Bison.
 
 /* Parse command line arguments for Bison.
 

-   Copyright (C) 1984, 1986, 1989, 1992, 2000, 2001, 2002, 2003, 2004,
-   2005, 2006, 2007, 2008, 2009, 2010 Free Software Foundation, Inc.
+   Copyright (C) 1984, 1986, 1989, 1992, 2000-2012 Free Software
+   Foundation, Inc.

 
    This file is part of Bison, the GNU Compiler Compiler.
 
 
    This file is part of Bison, the GNU Compiler Compiler.
 


@@ -26,7 +26,6 @@
 #include <c-strcase.h>
 #include <configmake.h>
 #include <error.h>
 #include <c-strcase.h>
 #include <configmake.h>
 #include <error.h>

-#include <quotearg.h>

 
 /* Hack to get <getopt.h> to declare getopt with a prototype.  */
 #if lint && ! defined __GNU_LIBRARY__
 
 /* Hack to get <getopt.h> to declare getopt with a prototype.  */
 #if lint && ! defined __GNU_LIBRARY__


@@ -41,10 +40,13 @@
 # undef HACK_FOR___GNU_LIBRARY___PROTOTYPE
 #endif
 
 # undef HACK_FOR___GNU_LIBRARY___PROTOTYPE
 #endif
 

+#include <progname.h>
+

 #include "complain.h"
 #include "files.h"
 #include "getargs.h"
 #include "muscle-tab.h"
 #include "complain.h"
 #include "files.h"
 #include "getargs.h"
 #include "muscle-tab.h"

+#include "quote.h"

 #include "uniqstr.h"
 
 bool defines_flag;
 #include "uniqstr.h"
 
 bool defines_flag;


@@ -52,14 +54,15 @@ bool graph_flag;
 bool xml_flag;
 bool no_lines_flag;
 bool token_table_flag;
 bool xml_flag;
 bool no_lines_flag;
 bool token_table_flag;

-bool yacc_flag;        /* for -y */
+bool yacc_flag; /* for -y */

 
 bool nondeterministic_parser = false;
 bool glr_parser = false;
 
 int report_flag = report_none;
 int trace_flag = trace_none;
 
 bool nondeterministic_parser = false;
 bool glr_parser = false;
 
 int report_flag = report_none;
 int trace_flag = trace_none;

-int warnings_flag = warnings_none;
+int warnings_flag = warnings_conflicts_sr | warnings_conflicts_rr
+                    | warnings_other;

 
 static struct bison_language const valid_languages[] = {
   { "c", "c-skel.m4", ".c", ".h", true },
 
 static struct bison_language const valid_languages[] = {
   { "c", "c-skel.m4", ".c", ".h", true },


@@ -74,49 +77,52 @@ int language_prio = default_prio;
 struct bison_language const *language = &valid_languages[0];
 const char *include = NULL;
 
 struct bison_language const *language = &valid_languages[0];
 const char *include = NULL;
 

-char *program_name;
-

 
 /** Decode an option's set of keys.
  *
  *  \param option   option being decoded.
  *  \param keys     array of valid subarguments.
  *  \param values   array of corresponding (int) values.
 
 /** Decode an option's set of keys.
  *
  *  \param option   option being decoded.
  *  \param keys     array of valid subarguments.
  *  \param values   array of corresponding (int) values.

+ *  \param all      the all value.

  *  \param flags    the flags to update
  *  \param args     comma separated list of effective subarguments to decode.
  *                  If 0, then activate all the flags.
  *
  *  If VALUE != 0 then KEY sets flags and no-KEY clears them.
  *  \param flags    the flags to update
  *  \param args     comma separated list of effective subarguments to decode.
  *                  If 0, then activate all the flags.
  *
  *  If VALUE != 0 then KEY sets flags and no-KEY clears them.

- *  If VALUE == 0 then KEY clears all flags and no-KEY sets all flags.
- *  Thus no-none = all and no-all = none.
+ *  If VALUE == 0 then KEY clears all flags from \c all and no-KEY sets all
+ *  flags from \c all.  Thus no-none = all and no-all = none.

  */
 static void
 flags_argmatch (const char *option,
  */
 static void
 flags_argmatch (const char *option,

-               const char * const keys[], const int values[],
-               int *flags, char *args)
+                const char * const keys[], const int values[],
+                int all, int *flags, char *args)

 {
   if (args)
     {
       args = strtok (args, ",");
       while (args)
 {
   if (args)
     {
       args = strtok (args, ",");
       while (args)

-       {
-         int no = strncmp (args, "no-", 3) == 0 ? 3 : 0;
-         int value = XARGMATCH (option, args + no, keys, values);
-         if (value == 0)
-           if (no)
-             *flags = ~0;
-           else
-             *flags = 0;
-         else
-           if (no)
-             *flags &= ~value;
-           else
-             *flags |= value;
-         args = strtok (NULL, ",");
-       }
+        {
+          int no = STRPREFIX_LIT ("no-", args) ? 3 : 0;
+          int value = XARGMATCH (option, args + no, keys, values);
+          if (value == 0)
+            {
+              if (no)
+                *flags |= all;
+              else
+                *flags &= ~all;
+            }
+          else
+            {
+              if (no)
+                *flags &= ~value;
+              else
+                *flags |= value;
+            }
+          args = strtok (NULL, ",");
+        }

     }
   else
     }
   else

-    *flags = ~0;
+    *flags |= all;

 }
 
 /** Decode a set of sub arguments.
 }
 
 /** Decode a set of sub arguments.


@@ -126,11 +132,12 @@ flags_argmatch (const char *option,
  *
  *  \arg FlagName_args   the list of keys.
  *  \arg FlagName_types  the list of values.
  *
  *  \arg FlagName_args   the list of keys.
  *  \arg FlagName_types  the list of values.

+ *  \arg FlagName_all    the all value.

  *  \arg FlagName_flag   the flag to update.
  */
  *  \arg FlagName_flag   the flag to update.
  */

-#define FLAGS_ARGMATCH(FlagName, Args)                                 \
+#define FLAGS_ARGMATCH(FlagName, Args)                                  \

   flags_argmatch ("--" #FlagName, FlagName ## _args, FlagName ## _types, \
   flags_argmatch ("--" #FlagName, FlagName ## _args, FlagName ## _types, \

-                 &FlagName ## _flag, Args)
+                  FlagName ## _all, &FlagName ## _flag, Args)

 
 
 /*----------------------.
 
 
 /*----------------------.


@@ -224,6 +231,9 @@ static const char * const warnings_args[] =
   "none            - no warnings",
   "midrule-values  - unset or unused midrule values",
   "yacc            - incompatibilities with POSIX Yacc",
   "none            - no warnings",
   "midrule-values  - unset or unused midrule values",
   "yacc            - incompatibilities with POSIX Yacc",

+  "conflicts-sr    - S/R conflicts",
+  "conflicts-rr    - R/R conflicts",
+  "other           - all other warnings",

   "all             - all of the above",
   "error           - warnings are errors",
   0
   "all             - all of the above",
   "error           - warnings are errors",
   0


@@ -234,6 +244,9 @@ static const int warnings_types[] =
   warnings_none,
   warnings_midrule_values,
   warnings_yacc,
   warnings_none,
   warnings_midrule_values,
   warnings_yacc,

+  warnings_conflicts_sr,
+  warnings_conflicts_rr,
+  warnings_other,

   warnings_all,
   warnings_error
 };
   warnings_all,
   warnings_error
 };


@@ -252,18 +265,19 @@ usage (int status)
 {
   if (status != 0)
     fprintf (stderr, _("Try `%s --help' for more information.\n"),
 {
   if (status != 0)
     fprintf (stderr, _("Try `%s --help' for more information.\n"),

-            program_name);
+             program_name);

   else
     {
       /* For ../build-aux/cross-options.pl to work, use the format:
   else
     {
       /* For ../build-aux/cross-options.pl to work, use the format:

-               ^  -S, --long[=ARGS] (whitespace)
-        A --long option is required.
-        Otherwise, add exceptions to ../build-aux/cross-options.pl.  */
+                ^  -S, --long[=ARGS] (whitespace)
+         A --long option is required.
+         Otherwise, add exceptions to ../build-aux/cross-options.pl.  */

 
       printf (_("Usage: %s [OPTION]... FILE\n"), program_name);
       fputs (_("\
 Generate a deterministic LR or generalized LR (GLR) parser employing\n\
 
       printf (_("Usage: %s [OPTION]... FILE\n"), program_name);
       fputs (_("\
 Generate a deterministic LR or generalized LR (GLR) parser employing\n\

-LALR(1), IELR(1), or canonical LR(1) parser tables.\n\
+LALR(1), IELR(1), or canonical LR(1) parser tables.  IELR(1) and\n\
+canonical LR(1) support is experimental.\n\

 \n\
 "), stdout);
 
 \n\
 "), stdout);
 


@@ -323,6 +337,9 @@ Output:\n\
 Warning categories include:\n\
   `midrule-values'  unset or unused midrule values\n\
   `yacc'            incompatibilities with POSIX Yacc\n\
 Warning categories include:\n\
   `midrule-values'  unset or unused midrule values\n\
   `yacc'            incompatibilities with POSIX Yacc\n\

+  `conflicts-sr'    S/R conflicts (enabled by default)\n\
+  `conflicts-rr'    R/R conflicts (enabled by default)\n\
+  `other'           all other warnings (enabled by default)\n\

   `all'             all the warnings\n\
   `no-CATEGORY'     turn off warnings in CATEGORY\n\
   `none'            turn off all the warnings\n\
   `all'             all the warnings\n\
   `no-CATEGORY'     turn off warnings in CATEGORY\n\
   `none'            turn off all the warnings\n\


@@ -362,14 +379,14 @@ version (void)
   putc ('\n', stdout);
 
   fprintf (stdout,
   putc ('\n', stdout);
 
   fprintf (stdout,

-          _("Copyright (C) %d Free Software Foundation, Inc.\n"),
-          PACKAGE_COPYRIGHT_YEAR);
+           _("Copyright (C) %d Free Software Foundation, Inc.\n"),
+           PACKAGE_COPYRIGHT_YEAR);

 
   fputs (_("\
 This is free software; see the source for copying conditions.  There is NO\n\
 warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.\n\
 "),
 
   fputs (_("\
 This is free software; see the source for copying conditions.  There is NO\n\
 warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.\n\
 "),

-        stdout);
+         stdout);

 }
 
 
 }
 
 


@@ -398,20 +415,20 @@ language_argmatch (char const *arg, int prio, location loc)
     {
       int i;
       for (i = 0; valid_languages[i].language[0]; i++)
     {
       int i;
       for (i = 0; valid_languages[i].language[0]; i++)

-       if (c_strcasecmp (arg, valid_languages[i].language) == 0)
-         {
-           language_prio = prio;
-           language = &valid_languages[i];
-           return;
-         }
-      msg = _("invalid language `%s'");
+        if (c_strcasecmp (arg, valid_languages[i].language) == 0)
+          {
+            language_prio = prio;
+            language = &valid_languages[i];
+            return;
+          }
+      msg = _("%s: invalid language");

     }
   else if (language_prio == prio)
     msg = _("multiple language declarations are invalid");
   else
     return;
 
     }
   else if (language_prio == prio)
     msg = _("multiple language declarations are invalid");
   else
     return;
 

-  complain_at (loc, msg, arg);
+  complain_at (loc, msg, quotearg_colon (arg));

 }
 
 /*----------------------.
 }
 
 /*----------------------.


@@ -457,25 +474,25 @@ enum
 static struct option const long_options[] =
 {
   /* Operation modes. */
 static struct option const long_options[] =
 {
   /* Operation modes. */

-  { "help",            no_argument,      0,   'h' },
-  { "version",         no_argument,      0,   'V' },
-  { "print-localedir", no_argument,      0,   PRINT_LOCALEDIR_OPTION },
-  { "print-datadir",   no_argument,      0,   PRINT_DATADIR_OPTION   },
+  { "help",            no_argument,       0,   'h' },
+  { "version",         no_argument,       0,   'V' },
+  { "print-localedir", no_argument,       0,   PRINT_LOCALEDIR_OPTION },
+  { "print-datadir",   no_argument,       0,   PRINT_DATADIR_OPTION   },

   { "warnings",        optional_argument, 0,   'W' },
 
   /* Parser. */
   { "warnings",        optional_argument, 0,   'W' },
 
   /* Parser. */

-  { "name-prefix",   required_argument,          0,   'p' },
+  { "name-prefix",   required_argument,   0,   'p' },

   { "include",       required_argument,   0,   'I' },
 
   /* Output. */
   { "include",       required_argument,   0,   'I' },
 
   /* Output. */

-  { "file-prefix", required_argument,  0,   'b' },
-  { "output",     required_argument,   0,   'o' },
-  { "output-file", required_argument,  0,   'o' },
-  { "graph",      optional_argument,   0,   'g' },
+  { "file-prefix", required_argument,   0,   'b' },
+  { "output",      required_argument,   0,   'o' },
+  { "output-file", required_argument,   0,   'o' },
+  { "graph",       optional_argument,   0,   'g' },

   { "xml",         optional_argument,   0,   'x' },
   { "xml",         optional_argument,   0,   'x' },

-  { "report",     required_argument,   0,   'r' },
+  { "report",      required_argument,   0,   'r' },

   { "report-file", required_argument,   0,   REPORT_FILE_OPTION },
   { "report-file", required_argument,   0,   REPORT_FILE_OPTION },

-  { "verbose",    no_argument,         0,   'v' },
+  { "verbose",     no_argument,         0,   'v' },

 
   /* Hidden. */
   { "trace",         optional_argument,   0,     'T' },
 
   /* Hidden. */
   { "trace",         optional_argument,   0,     'T' },


@@ -485,13 +502,13 @@ static struct option const long_options[] =
 
   /* Operation modes.  */
   { "fixed-output-files", no_argument,  0,   'y' },
 
   /* Operation modes.  */
   { "fixed-output-files", no_argument,  0,   'y' },

-  { "yacc",              no_argument,  0,   'y' },
+  { "yacc",               no_argument,  0,   'y' },

 
   /* Parser.  */
 
   /* Parser.  */

-  { "debug",         no_argument,               0,   't' },
-  { "define",        required_argument,         0,   'D' },
+  { "debug",          no_argument,               0,   't' },
+  { "define",         required_argument,         0,   'D' },

   { "force-define",   required_argument,         0,   'F' },
   { "force-define",   required_argument,         0,   'F' },

-  { "locations",      no_argument,              0, LOCATIONS_OPTION },
+  { "locations",      no_argument,               0, LOCATIONS_OPTION },

   { "no-lines",       no_argument,               0,   'l' },
   { "raw",            no_argument,               0,     0 },
   { "skeleton",       required_argument,         0,   'S' },
   { "no-lines",       no_argument,               0,   'l' },
   { "raw",            no_argument,               0,     0 },
   { "skeleton",       required_argument,         0,   'S' },


@@ -528,21 +545,21 @@ getargs (int argc, char *argv[])
   int c;
 
   while ((c = getopt_long (argc, argv, short_options, long_options, NULL))
   int c;
 
   while ((c = getopt_long (argc, argv, short_options, long_options, NULL))

-        != -1)
+         != -1)

     switch (c)
       {
         /* ASCII Sorting for short options (i.e., upper case then
            lower case), and then long-only options.  */
 
       case 0:
     switch (c)
       {
         /* ASCII Sorting for short options (i.e., upper case then
            lower case), and then long-only options.  */
 
       case 0:

-       /* Certain long options cause getopt_long to return 0.  */
-       break;
+        /* Certain long options cause getopt_long to return 0.  */
+        break;

 
       case 'D': /* -DNAME[=VALUE]. */
       case 'F': /* -FNAME[=VALUE]. */
         {
           char* name = optarg;
 
       case 'D': /* -DNAME[=VALUE]. */
       case 'F': /* -FNAME[=VALUE]. */
         {
           char* name = optarg;

-          char* value = strchr (optarg, '=');
+          char* value = mbschr (optarg, '=');

           if (value)
             *value++ = 0;
           muscle_percent_define_insert (name, command_line_location (),
           if (value)
             *value++ = 0;
           muscle_percent_define_insert (name, command_line_location (),


@@ -550,40 +567,37 @@ getargs (int argc, char *argv[])
                                         c == 'D' ? MUSCLE_PERCENT_DEFINE_D
                                                  : MUSCLE_PERCENT_DEFINE_F);
         }
                                         c == 'D' ? MUSCLE_PERCENT_DEFINE_D
                                                  : MUSCLE_PERCENT_DEFINE_F);
         }

-       break;
+        break;

 
       case 'I':
 
       case 'I':

-       include = AS_FILE_NAME (optarg);
-       break;
+        include = AS_FILE_NAME (optarg);
+        break;

 
       case 'L':
 
       case 'L':

-       language_argmatch (optarg, command_line_prio,
-                          command_line_location ());
-       break;
+        language_argmatch (optarg, command_line_prio,
+                           command_line_location ());
+        break;

 
       case 'S':
 
       case 'S':

-       skeleton_arg (AS_FILE_NAME (optarg), command_line_prio,
-                     command_line_location ());
-       break;
+        skeleton_arg (AS_FILE_NAME (optarg), command_line_prio,
+                      command_line_location ());
+        break;

 
       case 'T':
 
       case 'T':

-       FLAGS_ARGMATCH (trace, optarg);
-       break;
+        FLAGS_ARGMATCH (trace, optarg);
+        break;

 
       case 'V':
 
       case 'V':

-       version ();
-       exit (EXIT_SUCCESS);
+        version ();
+        exit (EXIT_SUCCESS);

 
       case 'W':
 
       case 'W':

-       if (optarg)
-         FLAGS_ARGMATCH (warnings, optarg);
-       else
-         warnings_flag |= warnings_all;
-       break;
+        FLAGS_ARGMATCH (warnings, optarg);
+        break;

 
       case 'b':
 
       case 'b':

-       spec_file_prefix = AS_FILE_NAME (optarg);
-       break;
+        spec_file_prefix = AS_FILE_NAME (optarg);
+        break;

 
       case 'd':
         /* Here, the -d and --defines options are differentiated.  */
 
       case 'd':
         /* Here, the -d and --defines options are differentiated.  */


@@ -593,81 +607,81 @@ getargs (int argc, char *argv[])
         break;
 
       case 'g':
         break;
 
       case 'g':

-       graph_flag = true;
-       if (optarg)
-         spec_graph_file = xstrdup (AS_FILE_NAME (optarg));
-       break;
+        graph_flag = true;
+        if (optarg)
+          spec_graph_file = xstrdup (AS_FILE_NAME (optarg));
+        break;

 
       case 'h':
 
       case 'h':

-       usage (EXIT_SUCCESS);
+        usage (EXIT_SUCCESS);

 
       case 'k':
 
       case 'k':

-       token_table_flag = true;
-       break;
+        token_table_flag = true;
+        break;

 
       case 'l':
 
       case 'l':

-       no_lines_flag = true;
-       break;
+        no_lines_flag = true;
+        break;

 
       case 'o':
 
       case 'o':

-       spec_outfile = AS_FILE_NAME (optarg);
-       break;
+        spec_outfile = AS_FILE_NAME (optarg);
+        break;

 
       case 'p':
 
       case 'p':

-       spec_name_prefix = optarg;
-       break;
+        spec_name_prefix = optarg;
+        break;

 
       case 'r':
 
       case 'r':

-       FLAGS_ARGMATCH (report, optarg);
-       break;
+        FLAGS_ARGMATCH (report, optarg);
+        break;

 
       case 't':
         muscle_percent_define_insert ("parse.trace",
                                       command_line_location (), "",
                                       MUSCLE_PERCENT_DEFINE_D);
 
       case 't':
         muscle_percent_define_insert ("parse.trace",
                                       command_line_location (), "",
                                       MUSCLE_PERCENT_DEFINE_D);

-       break;
+        break;

 
       case 'v':
 
       case 'v':

-       report_flag |= report_states;
-       break;
+        report_flag |= report_states;
+        break;

 
       case 'x':
 
       case 'x':

-       xml_flag = true;
-       if (optarg)
-         spec_xml_file = xstrdup (AS_FILE_NAME (optarg));
-       break;
+        xml_flag = true;
+        if (optarg)
+          spec_xml_file = xstrdup (AS_FILE_NAME (optarg));
+        break;

 
       case 'y':
 
       case 'y':

-       yacc_flag = true;
-       break;
+        yacc_flag = true;
+        break;

 
       case LOCATIONS_OPTION:
         muscle_percent_define_ensure ("locations",
                                       command_line_location (), true);
 
       case LOCATIONS_OPTION:
         muscle_percent_define_ensure ("locations",
                                       command_line_location (), true);

-       break;
+        break;

 
       case PRINT_LOCALEDIR_OPTION:
 
       case PRINT_LOCALEDIR_OPTION:

-       printf ("%s\n", LOCALEDIR);
-       exit (EXIT_SUCCESS);
+        printf ("%s\n", LOCALEDIR);
+        exit (EXIT_SUCCESS);

 
       case PRINT_DATADIR_OPTION:
 
       case PRINT_DATADIR_OPTION:

-       printf ("%s\n", compute_pkgdatadir ());
-       exit (EXIT_SUCCESS);
+        printf ("%s\n", compute_pkgdatadir ());
+        exit (EXIT_SUCCESS);

 
       case REPORT_FILE_OPTION:
 
       case REPORT_FILE_OPTION:

-       spec_verbose_file = xstrdup (AS_FILE_NAME (optarg));
-       break;
+        spec_verbose_file = xstrdup (AS_FILE_NAME (optarg));
+        break;

 
       default:
 
       default:

-       usage (EXIT_FAILURE);
+        usage (EXIT_FAILURE);

       }
 
   if (argc - optind != 1)
     {
       if (argc - optind < 1)
       }
 
   if (argc - optind != 1)
     {
       if (argc - optind < 1)

-       error (0, 0, _("missing operand after `%s'"), argv[argc - 1]);
+        error (0, 0, _("%s: missing operand"), quotearg_colon (argv[argc - 1]));

       else
       else

-       error (0, 0, _("extra operand `%s'"), argv[optind + 1]);
+        error (0, 0, _("extra operand %s"), quote (argv[optind + 1]));

       usage (EXIT_FAILURE);
     }
 
       usage (EXIT_FAILURE);
     }