tests: minor refactoring

[bison.git] / src / complain.c

diff --git a/src/complain.c b/src/complain.c
index 1ad672ba599accbd5b7b03d570f54c299e027451..d43e623e933b6bac43b50dfecddeea65b7447061 100644 (file)
--- a/src/complain.c
+++ b/src/complain.c
@@ -1,10 +1,12 @@
 /* Declaration for error-reporting function for Bison.
 /* Declaration for error-reporting function for Bison.

-   Copyright (C) 2000, 2001, 2002  Free Software Foundation, Inc.

 
 

-   This program is free software; you can redistribute it and/or modify it
-   under the terms of the GNU General Public License as published by the
-   Free Software Foundation; either version 2, or (at your option) any
-   later version.
+   Copyright (C) 2000-2002, 2004-2006, 2009-2013 Free Software
+   Foundation, Inc.
+
+   This program is free software: you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation, either version 3 of the License, or
+   (at your option) any later version.

 
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
 
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of


@@ -12,199 +14,193 @@
    GNU General Public License for more details.
 
    You should have received a copy of the GNU General Public License
    GNU General Public License for more details.
 
    You should have received a copy of the GNU General Public License

-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307,
-   USA.  */
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */

 
 /* Based on error.c and error.h,
    written by David MacKenzie <djm@gnu.ai.mit.edu>.  */
 
 
 /* Based on error.c and error.h,
    written by David MacKenzie <djm@gnu.ai.mit.edu>.  */
 

+#include <config.h>

 #include "system.h"
 
 #include <stdarg.h>
 #include "system.h"
 
 #include <stdarg.h>

-#if ! (HAVE_VPRINTF || defined vfprintf)
-# define vfprintf(stream, message, args) _doprnt (message, args, stream)
-#endif
-
-#if STDC_HEADERS || _LIBC
-# include <stdlib.h>
-# include <string.h>
-#else
-void exit ();
-#endif
+#include <progname.h>

 
 #include "complain.h"
 
 #include "complain.h"

+#include "files.h"
+#include "getargs.h"
+#include "quote.h"

 
 

-#ifndef _
-# define _(String) String
-#endif
-
-#ifdef _LIBC
-/* In the GNU C library, there is a predefined variable for this.  */
-
-# define program_name program_invocation_name
-# include <errno.h>
-
-/* In GNU libc we want do not want to use the common name `error' directly.
-   Instead make it a weak alias.  */
-# define error __error
-# define error_at_line __error_at_line
-
-# ifdef USE_IN_LIBIO
-#  include <libio/iolibio.h>
-#  define fflush(s) _IO_fflush (s)
-# endif
-
-#else /* not _LIBC */
-
-/* The calling program should define program_name and set it to the
-   name of the executing program.  */
-extern char *program_name;
-
-# if HAVE_STRERROR
-#  ifndef HAVE_DECL_STRERROR
-"this configure-time declaration test was not run"
-#  endif
-#  if !HAVE_DECL_STRERROR && !defined strerror
-char *strerror (int);
-#  endif
-# else
-static char *
-private_strerror (int errnum)
-{
-  extern char *sys_errlist[];
-  extern int sys_nerr;
-
-  if (errnum > 0 && errnum <= sys_nerr)
-    return _(sys_errlist[errnum]);
-  return _("Unknown system error");
-}
-#  define strerror private_strerror
-# endif /* HAVE_STRERROR */
-#endif /* not _LIBC */
-
-/* This variable is set each time `warn' is called.  */
-bool warning_issued;
+warnings warnings_flag =
+  Wconflicts_sr | Wconflicts_rr | Wdeprecated  | Wother;

 
 

-/* This variable is set each time `complain' is called.  */
-bool complaint_issued;
+warnings errors_flag;

 
 

-\f
-/*--------------------------------.
-| Report a warning, and proceed.  |
-`--------------------------------*/
+err_status complaint_status = status_none;
+static unsigned *indent_ptr = 0;

 
 void
 
 void

-warn_at (location_t location, const char *message, ...)
+warnings_print_categories (warnings warn_flags)

 {
 {

-  va_list args;
-
-  fflush (stdout);
-  LOCATION_PRINT (stderr, location);
-  fputs (": ", stderr);
-  fputs (_("warning: "), stderr);
-
-  va_start (args, message);
-  vfprintf (stderr, message, args);
-  va_end (args);
-
-  warning_issued = true;
-  putc ('\n', stderr);
-  fflush (stderr);
+  if (! (warn_flags & silent))
+    {
+      char const *warn_names[] =
+        {
+          "midrule-values",
+          "yacc",
+          "conflicts-sr",
+          "conflicts-rr",
+          "deprecated",
+          "other"
+        };
+
+      bool any = false;
+      int i;
+      for (i = 0; i < ARRAY_CARDINALITY (warn_names); ++i)
+        if (warn_flags & 1 << i)
+          {
+            bool err = warn_flags & errors_flag;
+            fprintf (stderr, "%s-W", any ? ", " : " [");
+            fprintf (stderr, "%s%s", err ? "error=" : "" , warn_names[i]);
+            any = true;
+          }
+      if (any)
+        fprintf (stderr, "]");
+    }

 }
 
 }
 

+/** Report an error message.
+ *
+ * \param loc     the location, defaulting to the current file,
+ *                or the program name.
+ * \param flags   the category for this message.
+ * \param prefix  put before the message (e.g., "warning").
+ * \param message the error message, a printf format string.  Iff it
+ *                ends with ": ", then no trailing newline is printed,
+ *                and the caller should print the remaining
+ *                newline-terminated message to stderr.
+ * \param args    the arguments of the format string.
+ */
+static

 void
 void

-warn (const char *message, ...)
+error_message (const location *loc, warnings flags, const char *prefix,
+               const char *message, va_list args)

 {
 {

-  va_list args;
+  unsigned pos = 0;
+
+  if (loc)
+    pos += location_print (stderr, *loc);
+  else
+    pos += fprintf (stderr, "%s", current_file ? current_file : program_name);
+  pos += fprintf (stderr, ": ");
+
+  if (indent_ptr)
+    {
+      if (*indent_ptr)
+        prefix = NULL;
+      if (!*indent_ptr)
+        *indent_ptr = pos;
+      else if (*indent_ptr > pos)
+        fprintf (stderr, "%*s", *indent_ptr - pos, "");
+      indent_ptr = 0;
+    }
+
+  if (prefix)
+    fprintf (stderr, "%s: ", prefix);

 
 

-  fflush (stdout);
-  fprintf (stderr, "%s: %s", infile ? infile : program_name, _("warning: "));
-
-  va_start (args, message);

   vfprintf (stderr, message, args);
   vfprintf (stderr, message, args);

-  va_end (args);
-
-  warning_issued = true;
-  putc ('\n', stderr);
+  warnings_print_categories (flags);
+  {
+    size_t l = strlen (message);
+    if (l < 2 || message[l - 2] != ':' || message[l - 1] != ' ')
+      {
+        putc ('\n', stderr);
+        fflush (stderr);
+        if (loc && feature_flag & feature_caret && !(flags & no_caret))
+          location_caret (stderr, *loc);
+      }
+  }

   fflush (stderr);
 }
   fflush (stderr);
 }

-\f
-/*-----------------------------------------------------------.
-| An error has occurred, but we can proceed, and die later.  |
-`-----------------------------------------------------------*/

 
 

-void
-complain_at (location_t location, const char *message, ...)
+/** Raise a complaint. That can be a fatal error, a complaint or just a
+    warning.  */
+static inline void
+complains (const location *loc, warnings flags, const char *message,
+           va_list args)

 {
 {

-  va_list args;
-
-  fflush (stdout);
-  LOCATION_PRINT (stderr, location);
-  fputs (": ", stderr);
-
-  va_start (args, message);
-  vfprintf (stderr, message, args);
-  va_end (args);
-
-  complaint_issued = true;
-  putc ('\n', stderr);
-  fflush (stderr);
+  const char* prefix =
+    flags & fatal ? _("fatal error")
+    : flags & (errors_flag | complaint) ? _("error")
+    : _("warning");
+
+  if ((flags & complaint) && complaint_status < status_complaint)
+    complaint_status = status_complaint;
+  else if ((flags & (warnings_flag & errors_flag)) && ! complaint_status)
+    complaint_status = status_warning_as_error;
+  if (flags & (warnings_flag | fatal | complaint))
+    error_message (loc, flags, prefix, message, args);
+  if (flags & fatal)
+    exit (EXIT_FAILURE);

 }
 
 void
 }
 
 void

-complain (const char *message, ...)
+complain (location const *loc, warnings flags, const char *message, ...)

 {
   va_list args;
 {
   va_list args;

-
-  fflush (stdout);
-  fprintf (stderr, "%s: ", infile ? infile : program_name);
-

   va_start (args, message);
   va_start (args, message);

-  vfprintf (stderr, message, args);
+  complains (loc, flags, message, args);

   va_end (args);
   va_end (args);

-
-  complaint_issued = true;
-  putc ('\n', stderr);
-  fflush (stderr);

 }
 }

-\f
-/*-------------------------------------------------.
-| A severe error has occurred, we cannot proceed.  |
-`-------------------------------------------------*/

 
 void
 
 void

-fatal_at (location_t location, const char *message, ...)
+complain_indent (location const *loc, warnings flags, unsigned *indent,
+                 const char *message, ...)

 {
   va_list args;
 {
   va_list args;

-
-  fflush (stdout);
-  LOCATION_PRINT (stderr, location);
-  fputs (": ", stderr);
-  fputs (_("fatal error: "), stderr);
-
+  indent_ptr = indent;

   va_start (args, message);
   va_start (args, message);

-  vfprintf (stderr, message, args);
+  complains (loc, flags, message, args);

   va_end (args);
   va_end (args);

-  putc ('\n', stderr);
-  fflush (stderr);
-  exit (EXIT_FAILURE);

 }
 
 void
 }
 
 void

-fatal (const char *message, ...)
+complain_args (location const *loc, warnings w, unsigned *indent,
+               int argc, char *argv[])

 {
 {

-  va_list args;
+  switch (argc)
+  {
+  case 1:
+    complain_indent (loc, w, indent, "%s", _(argv[0]));
+    break;
+  case 2:
+    complain_indent (loc, w, indent, _(argv[0]), argv[1]);
+    break;
+  case 3:
+    complain_indent (loc, w, indent, _(argv[0]), argv[1], argv[2]);
+    break;
+  case 4:
+    complain_indent (loc, w, indent, _(argv[0]), argv[1], argv[2], argv[3]);
+    break;
+  case 5:
+    complain_indent (loc, w, indent, _(argv[0]), argv[1], argv[2], argv[3],
+                     argv[4]);
+    break;
+  default:
+    complain (loc, fatal, "too many arguments for complains");
+    break;
+  }

 
 

-  fflush (stdout);
-  fprintf (stderr, "%s: ", infile ? infile : program_name);
-
-  fputs (_("fatal error: "), stderr);
+}

 
 

-  va_start (args, message);
-  vfprintf (stderr, message, args);
-  va_end (args);
-  putc ('\n', stderr);
-  fflush (stderr);
-  exit (EXIT_FAILURE);
+void
+deprecated_directive (location const *loc, char const *old, char const *upd)
+{
+  if (feature_flag & feature_caret)
+    complain (loc, Wdeprecated,
+              _("deprecated directive, use %s"),
+              quote_n (1, upd));
+  else
+    complain (loc, Wdeprecated,
+              _("deprecated directive: %s, use %s"),
+              quote (old), quote_n (1, upd));

 }
 }