]> git.saurik.com Git - apt.git/commit - test/integration/test-bug-814139-pickup-of-different-cache-states
get dpkg lock in build-dep if cache was invalid again
authorDavid Kalnischkies <david@kalnischkies.de>
Wed, 10 Feb 2016 11:26:49 +0000 (12:26 +0100)
committerDavid Kalnischkies <david@kalnischkies.de>
Wed, 10 Feb 2016 12:03:00 +0000 (13:03 +0100)
commitb6f1b480164b454661ddd4fdd3968302c6a3ebf6
tree8f248eb30e77665d51788e7c4b807192187a524e
parenteda0c1ba43cd3ae0ed85aba2c31573f156cec9c4
get dpkg lock in build-dep if cache was invalid again

Regression introduced in a249b3e6fd798935a02b769149c9791a6fa6ef16, which
in the case of an invalid cache would build the first part unlocked and
later pick up the (still unlocked) cache for further processing, so the
system got never locked and apt would end up complaining about being
unable to release the lock at shutdown.

The far more common case of having a valid cache worked as expected and
hence covered up the problem – especially as tests who would have
noticed it are simulations only, which do not lock.

Closes: 814139
Reported-By: Balint Reczey <balint@balintreczey.hu>
Reported-By: Helmut Grohne <helmut@subdivi.de> on IRC
apt-pkg/cachefile.cc
apt-private/private-source.cc
test/integration/test-bug-814139-pickup-of-different-cache-states [new file with mode: 0755]