]> git.saurik.com Git - apt.git/commit
Do not read stderr from proxy autodetection scripts
authorJulian Andres Klode <jak@debian.org>
Sun, 2 Oct 2016 15:20:33 +0000 (17:20 +0200)
committerJulian Andres Klode <jak@debian.org>
Wed, 5 Oct 2016 19:53:39 +0000 (21:53 +0200)
commit78046276db89bed39cde785760cd5d0c694ddb1d
treefc7a0bd20add5e185859d7db1ad82492f87b74a1
parentf54a4774ea901f861de96b13a4d952b8ea6c2976
Do not read stderr from proxy autodetection scripts

This fixes a regression introduced in
  commit 8f858d560e3b7b475c623c4e242d1edce246025a

  don't leak FD in AutoProxyDetect command return parsing

which accidentally made the proxy autodetection code also read
the scripts output on stderr, not only on stdout when it switched
the code from popen() to Popen().

Reported-By: Tim Small <tim@seoss.co.uk>
(cherry picked from commit 0ecceb5bb9cc8727c117195945b7116aceb984fe)
apt-pkg/contrib/fileutl.cc
apt-pkg/contrib/fileutl.h
apt-pkg/contrib/proxy.cc
test/libapt/apt-proxy-script [new file with mode: 0755]
test/libapt/uri_test.cc