]> git.saurik.com Git - apt.git/commit
don't change owner/perms/times through file:// symlinks
authorDavid Kalnischkies <david@kalnischkies.de>
Tue, 5 Jul 2016 18:04:27 +0000 (20:04 +0200)
committerJulian Andres Klode <jak@debian.org>
Wed, 31 Aug 2016 11:49:37 +0000 (13:49 +0200)
commit366021988e2c7a7a6ca29d4f6876bb1e6c8b181f
treedb192adf2aa1f51a5d44702c9f25f2cc9e2b75bf
parent89d816a77ca314654a8bef8c88a287b04e2c8519
don't change owner/perms/times through file:// symlinks

If we have files in partial/ from a previous invocation or similar such
those could be symlinks created by file:// sources. The code is
expecting only real files through and happily changes owner,
modification times and permission on the file the symlink points to
which tend to be files we have no business in touching in this way.
Permissions of symlinks shouldn't be changed, changing owner is usually
pointless to, but just to be sure we pick the easy way out and use
lchown, check for symlinks before chmod/utimes.

Reported-By: Mattia Rizzolo on IRC
(cherry picked from commit 3465138575e1fd0d5892d9b6be1ae232eb873460)
apt-pkg/contrib/fileutl.cc
methods/aptmethod.h
methods/copy.cc
methods/store.cc
test/integration/framework
test/integration/test-apt-update-file
test/integration/test-apt-update-ims