]> git.saurik.com Git - apt.git/commit
don't change owner/perms/times through file:// symlinks
authorDavid Kalnischkies <david@kalnischkies.de>
Tue, 5 Jul 2016 18:04:27 +0000 (20:04 +0200)
committerDavid Kalnischkies <david@kalnischkies.de>
Wed, 6 Jul 2016 00:25:51 +0000 (02:25 +0200)
commit3465138575e1fd0d5892d9b6be1ae232eb873460
tree07f541a2c958f8b67b392da360bb38aa9fd9c59d
parent68151307d42ed64cd6258f94a0d748abe9efb8e0
don't change owner/perms/times through file:// symlinks

If we have files in partial/ from a previous invocation or similar such
those could be symlinks created by file:// sources. The code is
expecting only real files through and happily changes owner,
modification times and permission on the file the symlink points to
which tend to be files we have no business in touching in this way.
Permissions of symlinks shouldn't be changed, changing owner is usually
pointless to, but just to be sure we pick the easy way out and use
lchown, check for symlinks before chmod/utimes.

Reported-By: Mattia Rizzolo on IRC
apt-pkg/contrib/fileutl.cc
methods/aptmethod.h
methods/copy.cc
methods/store.cc
test/integration/framework
test/integration/test-apt-update-file
test/integration/test-apt-update-ims