]> git.saurik.com Git - apt.git/commit
Do not read stderr from proxy autodetection scripts
authorJulian Andres Klode <jak@debian.org>
Sun, 2 Oct 2016 15:20:33 +0000 (17:20 +0200)
committerJulian Andres Klode <jak@debian.org>
Tue, 4 Oct 2016 17:30:30 +0000 (19:30 +0200)
commit0ecceb5bb9cc8727c117195945b7116aceb984fe
tree76dd5b2e352b6255699956e21d4e6d02548bed06
parent1f7c56acc6b36b7869294941c8eba2b026eaaeb1
Do not read stderr from proxy autodetection scripts

This fixes a regression introduced in
  commit 8f858d560e3b7b475c623c4e242d1edce246025a

  don't leak FD in AutoProxyDetect command return parsing

which accidentally made the proxy autodetection code also read
the scripts output on stderr, not only on stdout when it switched
the code from popen() to Popen().

Reported-By: Tim Small <tim@seoss.co.uk>
apt-pkg/contrib/fileutl.cc
apt-pkg/contrib/fileutl.h
apt-pkg/contrib/proxy.cc
test/libapt/apt-proxy-script [new file with mode: 0755]
test/libapt/uri_test.cc