]> git.saurik.com Git - apt.git/commit - test/integration/test-bug-multiarch-upgrade
do not configure already unpacked packages needlessly
authorDavid Kalnischkies <david@kalnischkies.de>
Sat, 8 Mar 2014 16:29:46 +0000 (17:29 +0100)
committerDavid Kalnischkies <david@kalnischkies.de>
Thu, 13 Mar 2014 12:58:45 +0000 (13:58 +0100)
commit0caa5a4c6472d1b74444c4f38ced6c3b89fa50fe
tree1a98b30c971e28ea6086a769b906821c45822ad4
parent9d9d5e810751954594c793383b07ca526c647350
do not configure already unpacked packages needlessly

The unpack of a M-A:same package will force the unpack of all its
siblings directly to prevent that they could be separated by later
immediate actions. In commit 634985f8 a call to SmartConfigure was
introduced to configure these packages at the time the installation
order encounters them. Usually, the unpack order is already okay, so
that this 'earlier' unpack was not needed and if it wouldn't have been
done, the package would now only be unpacked, but by configuring the package
now we impose new requirements which must be satisfied. The code is
clever enough to handle this most of the time (it worked for 2 years!),
but it isn't needed and in very coupled cases this can fail.

Removing this call again removes this extra burden and so simplifies the
ordering as can be seen in the modified tests. Famous last words, but I
don't see a reason for this extra burden to exist hence the remove.

Closes: 740843
apt-pkg/packagemanager.cc
test/integration/framework
test/integration/test-bug-740843-versioned-up-down-breaks [new file with mode: 0755]
test/integration/test-bug-multiarch-upgrade
test/integration/test-ignore-provides-if-versioned-breaks
test/integration/test-ignore-provides-if-versioned-conflicts
test/integration/test-prevent-markinstall-multiarch-same-versionscrew
test/integration/test-very-tight-loop-configure-with-unpacking-new-packages