no longer passing tests due to the new write-on-volatile semantics modified/removed

diff --git a/tests/unit/basic.tcl b/tests/unit/basic.tcl
index f888cabcbc4efca0cc8425def6dbdefd4b84763f..a8f7feb0bddc5dda70f9488d1d6fa6ee3afd87aa 100644 (file)
--- a/tests/unit/basic.tcl
+++ b/tests/unit/basic.tcl
@@ -148,12 +148,11 @@ start_server {tags {"basic"}} {
         r get novar2
     } {foobared}
 
         r get novar2
     } {foobared}
 

-    test {SETNX will overwrite EXPIREing key} {
+    test {SETNX against volatile key} {

         r set x 10
         r expire x 10000
         r set x 10
         r expire x 10000

-        r setnx x 20
-        r get x
-    } {20}
+        list [r setnx x 20] [r get x]
+    } {0 10}

 
     test {EXISTS} {
         set res {}
 
     test {EXISTS} {
         set res {}


@@ -362,13 +361,6 @@ start_server {tags {"basic"}} {
         list [r msetnx x1 xxx y2 yyy] [r get x1] [r get y2]
     } {1 xxx yyy}
 
         list [r msetnx x1 xxx y2 yyy] [r get x1] [r get y2]
     } {1 xxx yyy}
 

-    test {MSETNX should remove all the volatile keys even on failure} {
-        r mset x 1 y 2 z 3
-        r expire y 10000
-        r expire z 10000
-        list [r msetnx x A y B z C] [r mget x y z]
-    } {0 {1 {} {}}}
-

     test {STRLEN against non existing key} {
         r strlen notakey
     } {0}
     test {STRLEN against non existing key} {
         r strlen notakey
     } {0}

diff --git a/tests/unit/expire.tcl b/tests/unit/expire.tcl
index b80975b6e19f032f668a62696b219b3341522d0a..5de907abb1223af8a21b01a3a0aa6d3c2e702748 100644 (file)
--- a/tests/unit/expire.tcl
+++ b/tests/unit/expire.tcl
@@ -1,12 +1,13 @@
 start_server {tags {"expire"}} {
 start_server {tags {"expire"}} {

-    test {EXPIRE - don't set timeouts multiple times} {
+    test {EXPIRE - set timeouts multiple times} {

         r set x foobar
         set v1 [r expire x 5]
         set v2 [r ttl x]
         set v3 [r expire x 10]
         set v4 [r ttl x]
         r set x foobar
         set v1 [r expire x 5]
         set v2 [r ttl x]
         set v3 [r expire x 10]
         set v4 [r ttl x]

+        r expire x 4

         list $v1 $v2 $v3 $v4
         list $v1 $v2 $v3 $v4

-    } {1 5 0 5}
+    } {1 5 1 10}

 
     test {EXPIRE - It should be still possible to read 'x'} {
         r get x
 
     test {EXPIRE - It should be still possible to read 'x'} {
         r get x


@@ -19,13 +20,13 @@ start_server {tags {"expire"}} {
         } {{} 0}
     }
 
         } {{} 0}
     }
 

-    test {EXPIRE - Delete on write policy} {
+    test {EXPIRE - write on expire should work} {

         r del x
         r lpush x foo
         r expire x 1000
         r lpush x bar
         r lrange x 0 -1
         r del x
         r lpush x foo
         r expire x 1000
         r lpush x bar
         r lrange x 0 -1

-    } {bar}
+    } {bar foo}

 
     test {EXPIREAT - Check for EXPIRE alike behavior} {
         r del x
 
     test {EXPIREAT - Check for EXPIRE alike behavior} {
         r del x