]> git.saurik.com Git - redis.git/blob - src/dscache.c
5570e9c5dba59f4019d7b579cfa6f6c93a3bf212
[redis.git] / src / dscache.c
1 #include "redis.h"
2
3 #include <fcntl.h>
4 #include <pthread.h>
5 #include <math.h>
6 #include <signal.h>
7
8 /* dscache.c - Disk store cache for disk store backend.
9 *
10 * When Redis is configured for using disk as backend instead of memory, the
11 * memory is used as a cache, so that recently accessed keys are taken in
12 * memory for fast read and write operations.
13 *
14 * Modified keys are marked to be flushed on disk, and will be flushed
15 * as long as the maxium configured flush time elapsed.
16 *
17 * This file implements the whole caching subsystem and contains further
18 * documentation. */
19
20 /* TODO:
21 *
22 * - The WATCH helper will be used to signal the cache system
23 * we need to flush a given key/dbid into disk, adding this key/dbid
24 * pair into a server.ds_cache_dirty linked list AND hash table (so that we
25 * don't add the same thing multiple times).
26 *
27 * - cron() checks if there are elements on this list. When there are things
28 * to flush, we create an IO Job for the I/O thread.
29 * NOTE: We disalbe object sharing when server.ds_enabled == 1 so objects
30 * that are referenced an IO job for flushing on disk are marked as
31 * o->storage == REDIS_DS_SAVING.
32 *
33 * - This is what we do on key lookup:
34 * 1) The key already exists in memory. object->storage == REDIS_DS_MEMORY
35 * or it is object->storage == REDIS_DS_DIRTY:
36 * We don't do nothing special, lookup, return value object pointer.
37 * 2) The key is in memory but object->storage == REDIS_DS_SAVING.
38 * When this happens we block waiting for the I/O thread to process
39 * this object. Then continue.
40 * 3) The key is not in memory. We block to load the key from disk.
41 * Of course the key may not be present at all on the disk store as well,
42 * in such case we just detect this condition and continue, returning
43 * NULL from lookup.
44 *
45 * - Preloading of needed keys:
46 * 1) As it was done with VM, also with this new system we try preloading
47 * keys a client is going to use. We block the client, load keys
48 * using the I/O thread, unblock the client. Same code as VM more or less.
49 *
50 * - Reclaiming memory.
51 * In cron() we detect our memory limit was reached. What we
52 * do is deleting keys that are REDIS_DS_MEMORY, using LRU.
53 *
54 * If this is not enough to return again under the memory limits we also
55 * start to flush keys that need to be synched on disk synchronously,
56 * removing it from the memory. We do this blocking as memory limit is a
57 * much "harder" barrirer in the new design.
58 *
59 * - IO thread operations are no longer stopped for sync loading/saving of
60 * things. When a key is found to be in the process of being saved
61 * we simply wait for the IO thread to end its work.
62 *
63 * Otherwise if there is to load a key without any IO thread operation
64 * just started it is blocking-loaded in the lookup function.
65 *
66 * - What happens when an object is destroyed?
67 *
68 * If o->storage == REDIS_DS_MEMORY then we simply destory the object.
69 * If o->storage == REDIS_DS_DIRTY we can still remove the object. It had
70 * changes not flushed on disk, but is being removed so
71 * who cares.
72 * if o->storage == REDIS_DS_SAVING then the object is being saved so
73 * it is impossible that its refcount == 1, must be at
74 * least two. When the object is saved the storage will
75 * be set back to DS_MEMORY.
76 *
77 * - What happens when keys are deleted?
78 *
79 * We simply schedule a key flush operation as usually, but when the
80 * IO thread will be created the object pointer will be set to NULL
81 * so the IO thread will know that the work to do is to delete the key
82 * from the disk store.
83 *
84 * - What happens with MULTI/EXEC?
85 *
86 * Good question.
87 */
88
89 /* Virtual Memory is composed mainly of two subsystems:
90 * - Blocking Virutal Memory
91 * - Threaded Virtual Memory I/O
92 * The two parts are not fully decoupled, but functions are split among two
93 * different sections of the source code (delimited by comments) in order to
94 * make more clear what functionality is about the blocking VM and what about
95 * the threaded (not blocking) VM.
96 *
97 * Redis VM design:
98 *
99 * Redis VM is a blocking VM (one that blocks reading swapped values from
100 * disk into memory when a value swapped out is needed in memory) that is made
101 * unblocking by trying to examine the command argument vector in order to
102 * load in background values that will likely be needed in order to exec
103 * the command. The command is executed only once all the relevant keys
104 * are loaded into memory.
105 *
106 * This basically is almost as simple of a blocking VM, but almost as parallel
107 * as a fully non-blocking VM.
108 */
109
110 void spawnIOThread(void);
111
112 /* =================== Virtual Memory - Blocking Side ====================== */
113
114 void dsInit(void) {
115 int pipefds[2];
116 size_t stacksize;
117
118 zmalloc_enable_thread_safeness(); /* we need thread safe zmalloc() */
119
120 redisLog(REDIS_NOTICE,"Initializing Disk Store at %s", server.ds_path);
121 /* Open Disk Store */
122 if (dsOpen() != REDIS_OK) {
123 redisLog(REDIS_WARNING,"Fatal error opening disk store. Exiting.");
124 exit(1);
125 };
126
127 /* Initialize threaded I/O for Object Cache */
128 server.io_newjobs = listCreate();
129 server.io_processing = listCreate();
130 server.io_processed = listCreate();
131 server.io_ready_clients = listCreate();
132 pthread_mutex_init(&server.io_mutex,NULL);
133 server.io_active_threads = 0;
134 if (pipe(pipefds) == -1) {
135 redisLog(REDIS_WARNING,"Unable to intialized DS: pipe(2): %s. Exiting."
136 ,strerror(errno));
137 exit(1);
138 }
139 server.io_ready_pipe_read = pipefds[0];
140 server.io_ready_pipe_write = pipefds[1];
141 redisAssert(anetNonBlock(NULL,server.io_ready_pipe_read) != ANET_ERR);
142 /* LZF requires a lot of stack */
143 pthread_attr_init(&server.io_threads_attr);
144 pthread_attr_getstacksize(&server.io_threads_attr, &stacksize);
145
146 /* Solaris may report a stacksize of 0, let's set it to 1 otherwise
147 * multiplying it by 2 in the while loop later will not really help ;) */
148 if (!stacksize) stacksize = 1;
149
150 while (stacksize < REDIS_THREAD_STACK_SIZE) stacksize *= 2;
151 pthread_attr_setstacksize(&server.io_threads_attr, stacksize);
152 /* Listen for events in the threaded I/O pipe */
153 if (aeCreateFileEvent(server.el, server.io_ready_pipe_read, AE_READABLE,
154 vmThreadedIOCompletedJob, NULL) == AE_ERR)
155 oom("creating file event");
156
157 /* Spawn our I/O thread */
158 spawnIOThread();
159 }
160
161 /* Compute how good candidate the specified object is for eviction.
162 * An higher number means a better candidate. */
163 double computeObjectSwappability(robj *o) {
164 /* actual age can be >= minage, but not < minage. As we use wrapping
165 * 21 bit clocks with minutes resolution for the LRU. */
166 return (double) estimateObjectIdleTime(o);
167 }
168
169 /* Try to free one entry from the diskstore object cache */
170 int cacheFreeOneEntry(void) {
171 int j, i;
172 struct dictEntry *best = NULL;
173 double best_swappability = 0;
174 redisDb *best_db = NULL;
175 robj *val;
176 sds key;
177
178 for (j = 0; j < server.dbnum; j++) {
179 redisDb *db = server.db+j;
180 /* Why maxtries is set to 100?
181 * Because this way (usually) we'll find 1 object even if just 1% - 2%
182 * are swappable objects */
183 int maxtries = 100;
184
185 if (dictSize(db->dict) == 0) continue;
186 for (i = 0; i < 5; i++) {
187 dictEntry *de;
188 double swappability;
189
190 if (maxtries) maxtries--;
191 de = dictGetRandomKey(db->dict);
192 val = dictGetEntryVal(de);
193 /* Only swap objects that are currently in memory.
194 *
195 * Also don't swap shared objects: not a good idea in general and
196 * we need to ensure that the main thread does not touch the
197 * object while the I/O thread is using it, but we can't
198 * control other keys without adding additional mutex. */
199 if (val->storage != REDIS_DS_MEMORY) {
200 if (maxtries) i--; /* don't count this try */
201 continue;
202 }
203 swappability = computeObjectSwappability(val);
204 if (!best || swappability > best_swappability) {
205 best = de;
206 best_swappability = swappability;
207 best_db = db;
208 }
209 }
210 }
211 if (best == NULL) {
212 /* FIXME: If there are objects marked as DS_DIRTY or DS_SAVING
213 * let's wait for this objects to be clear and retry...
214 *
215 * Object cache vm limit is considered an hard limit. */
216 return REDIS_ERR;
217 }
218 key = dictGetEntryKey(best);
219 val = dictGetEntryVal(best);
220
221 redisLog(REDIS_DEBUG,"Key selected for cache eviction: %s swappability:%f",
222 key, best_swappability);
223
224 /* Delete this key from memory */
225 {
226 robj *kobj = createStringObject(key,sdslen(key));
227 dbDelete(best_db,kobj);
228 decrRefCount(kobj);
229 }
230 return REDIS_OK;
231 }
232
233 /* Return true if it's safe to swap out objects in a given moment.
234 * Basically we don't want to swap objects out while there is a BGSAVE
235 * or a BGAEOREWRITE running in backgroud. */
236 int dsCanTouchDiskStore(void) {
237 return (server.bgsavechildpid == -1 && server.bgrewritechildpid == -1);
238 }
239
240 /* =================== Virtual Memory - Threaded I/O ======================= */
241
242 void freeIOJob(iojob *j) {
243 decrRefCount(j->key);
244 /* j->val can be NULL if the job is about deleting the key from disk. */
245 if (j->val) decrRefCount(j->val);
246 zfree(j);
247 }
248
249 /* Every time a thread finished a Job, it writes a byte into the write side
250 * of an unix pipe in order to "awake" the main thread, and this function
251 * is called. */
252 void vmThreadedIOCompletedJob(aeEventLoop *el, int fd, void *privdata,
253 int mask)
254 {
255 char buf[1];
256 int retval, processed = 0, toprocess = -1;
257 REDIS_NOTUSED(el);
258 REDIS_NOTUSED(mask);
259 REDIS_NOTUSED(privdata);
260
261 /* For every byte we read in the read side of the pipe, there is one
262 * I/O job completed to process. */
263 while((retval = read(fd,buf,1)) == 1) {
264 iojob *j;
265 listNode *ln;
266 struct dictEntry *de;
267
268 redisLog(REDIS_DEBUG,"Processing I/O completed job");
269
270 /* Get the processed element (the oldest one) */
271 lockThreadedIO();
272 redisAssert(listLength(server.io_processed) != 0);
273 if (toprocess == -1) {
274 toprocess = (listLength(server.io_processed)*REDIS_MAX_COMPLETED_JOBS_PROCESSED)/100;
275 if (toprocess <= 0) toprocess = 1;
276 }
277 ln = listFirst(server.io_processed);
278 j = ln->value;
279 listDelNode(server.io_processed,ln);
280 unlockThreadedIO();
281
282 /* Post process it in the main thread, as there are things we
283 * can do just here to avoid race conditions and/or invasive locks */
284 redisLog(REDIS_DEBUG,"COMPLETED Job type %s, key: %s",
285 (j->type == REDIS_IOJOB_LOAD) ? "load" : "save",
286 (unsigned char*)j->key->ptr);
287 de = dictFind(j->db->dict,j->key->ptr);
288 redisAssert(de != NULL);
289 if (j->type == REDIS_IOJOB_LOAD) {
290 /* Create the key-value pair in the in-memory database */
291 dbAdd(j->db,j->key,j->val);
292 /* Handle clients waiting for this key to be loaded. */
293 handleClientsBlockedOnSwappedKey(j->db,j->key);
294 freeIOJob(j);
295 } else if (j->type == REDIS_IOJOB_SAVE) {
296 redisAssert(j->val->storage == REDIS_DS_SAVING);
297 j->val->storage = REDIS_DS_MEMORY;
298 freeIOJob(j);
299 }
300 processed++;
301 if (processed == toprocess) return;
302 }
303 if (retval < 0 && errno != EAGAIN) {
304 redisLog(REDIS_WARNING,
305 "WARNING: read(2) error in vmThreadedIOCompletedJob() %s",
306 strerror(errno));
307 }
308 }
309
310 void lockThreadedIO(void) {
311 pthread_mutex_lock(&server.io_mutex);
312 }
313
314 void unlockThreadedIO(void) {
315 pthread_mutex_unlock(&server.io_mutex);
316 }
317
318 void *IOThreadEntryPoint(void *arg) {
319 iojob *j;
320 listNode *ln;
321 REDIS_NOTUSED(arg);
322
323 pthread_detach(pthread_self());
324 while(1) {
325 /* Get a new job to process */
326 lockThreadedIO();
327 if (listLength(server.io_newjobs) == 0) {
328 /* No new jobs in queue, exit. */
329 redisLog(REDIS_DEBUG,"Thread %ld exiting, nothing to do",
330 (long) pthread_self());
331 server.io_active_threads--;
332 unlockThreadedIO();
333 return NULL;
334 }
335 ln = listFirst(server.io_newjobs);
336 j = ln->value;
337 listDelNode(server.io_newjobs,ln);
338 /* Add the job in the processing queue */
339 listAddNodeTail(server.io_processing,j);
340 ln = listLast(server.io_processing); /* We use ln later to remove it */
341 unlockThreadedIO();
342 redisLog(REDIS_DEBUG,"Thread %ld: new job type %s: %p about key '%s'",
343 (long) pthread_self(),
344 (j->type == REDIS_IOJOB_LOAD) ? "load" : "save",
345 (void*)j, (char*)j->key->ptr);
346
347 /* Process the Job */
348 if (j->type == REDIS_IOJOB_LOAD) {
349 j->val = dsGet(j->db,j->key);
350 redisAssert(j->val != NULL);
351 } else if (j->type == REDIS_IOJOB_SAVE) {
352 if (j->val)
353 dsSet(j->db,j->key,j->val);
354 else
355 dsDel(j->db,j->key);
356 }
357
358 /* Done: insert the job into the processed queue */
359 redisLog(REDIS_DEBUG,"Thread %ld completed the job: %p (key %s)",
360 (long) pthread_self(), (void*)j, (char*)j->key->ptr);
361 lockThreadedIO();
362 listDelNode(server.io_processing,ln);
363 listAddNodeTail(server.io_processed,j);
364 unlockThreadedIO();
365
366 /* Signal the main thread there is new stuff to process */
367 redisAssert(write(server.io_ready_pipe_write,"x",1) == 1);
368 }
369 return NULL; /* never reached */
370 }
371
372 void spawnIOThread(void) {
373 pthread_t thread;
374 sigset_t mask, omask;
375 int err;
376
377 sigemptyset(&mask);
378 sigaddset(&mask,SIGCHLD);
379 sigaddset(&mask,SIGHUP);
380 sigaddset(&mask,SIGPIPE);
381 pthread_sigmask(SIG_SETMASK, &mask, &omask);
382 while ((err = pthread_create(&thread,&server.io_threads_attr,IOThreadEntryPoint,NULL)) != 0) {
383 redisLog(REDIS_WARNING,"Unable to spawn an I/O thread: %s",
384 strerror(err));
385 usleep(1000000);
386 }
387 pthread_sigmask(SIG_SETMASK, &omask, NULL);
388 server.io_active_threads++;
389 }
390
391 /* We need to wait for the last thread to exit before we are able to
392 * fork() in order to BGSAVE or BGREWRITEAOF. */
393 void waitEmptyIOJobsQueue(void) {
394 while(1) {
395 int io_processed_len;
396
397 lockThreadedIO();
398 if (listLength(server.io_newjobs) == 0 &&
399 listLength(server.io_processing) == 0 &&
400 server.io_active_threads == 0)
401 {
402 unlockThreadedIO();
403 return;
404 }
405 /* While waiting for empty jobs queue condition we post-process some
406 * finshed job, as I/O threads may be hanging trying to write against
407 * the io_ready_pipe_write FD but there are so much pending jobs that
408 * it's blocking. */
409 io_processed_len = listLength(server.io_processed);
410 unlockThreadedIO();
411 if (io_processed_len) {
412 vmThreadedIOCompletedJob(NULL,server.io_ready_pipe_read,
413 (void*)0xdeadbeef,0);
414 usleep(1000); /* 1 millisecond */
415 } else {
416 usleep(10000); /* 10 milliseconds */
417 }
418 }
419 }
420
421 /* This function must be called while with threaded IO locked */
422 void queueIOJob(iojob *j) {
423 redisLog(REDIS_DEBUG,"Queued IO Job %p type %d about key '%s'\n",
424 (void*)j, j->type, (char*)j->key->ptr);
425 listAddNodeTail(server.io_newjobs,j);
426 if (server.io_active_threads < server.vm_max_threads)
427 spawnIOThread();
428 }
429
430 void dsCreateIOJob(int type, redisDb *db, robj *key, robj *val) {
431 iojob *j;
432
433 j = zmalloc(sizeof(*j));
434 j->type = type;
435 j->db = db;
436 j->key = key;
437 incrRefCount(key);
438 j->val = val;
439 incrRefCount(val);
440
441 lockThreadedIO();
442 queueIOJob(j);
443 unlockThreadedIO();
444 }
445
446 /* ============ Virtual Memory - Blocking clients on missing keys =========== */
447
448 /* This function makes the clinet 'c' waiting for the key 'key' to be loaded.
449 * If the key is already in memory we don't need to block, regardless
450 * of the storage of the value object for this key:
451 *
452 * - If it's REDIS_DS_MEMORY we have the key in memory.
453 * - If it's REDIS_DS_DIRTY they key was modified, but still in memory.
454 * - if it's REDIS_DS_SAVING the key is being saved by an IO Job. When
455 * the client will lookup the key it will block if the key is still
456 * in this stage but it's more or less the best we can do.
457 * FIXME: we should try if it's actually better to suspend the client
458 * accessing an object that is being saved, and awake it only when
459 * the saving was completed.
460 *
461 * Otherwise if the key is not in memory, we block the client and start
462 * an IO Job to load it:
463 *
464 * the key is added to the io_keys list in the client structure, and also
465 * in the hash table mapping swapped keys to waiting clients, that is,
466 * server.io_waited_keys. */
467 int waitForSwappedKey(redisClient *c, robj *key) {
468 struct dictEntry *de;
469 list *l;
470
471 /* Return ASAP if the key is in memory */
472 de = dictFind(c->db->dict,key->ptr);
473 if (de != NULL) return 0;
474
475 /* Add the key to the list of keys this client is waiting for.
476 * This maps clients to keys they are waiting for. */
477 listAddNodeTail(c->io_keys,key);
478 incrRefCount(key);
479
480 /* Add the client to the swapped keys => clients waiting map. */
481 de = dictFind(c->db->io_keys,key);
482 if (de == NULL) {
483 int retval;
484
485 /* For every key we take a list of clients blocked for it */
486 l = listCreate();
487 retval = dictAdd(c->db->io_keys,key,l);
488 incrRefCount(key);
489 redisAssert(retval == DICT_OK);
490 } else {
491 l = dictGetEntryVal(de);
492 }
493 listAddNodeTail(l,c);
494
495 /* Are we already loading the key from disk? If not create a job */
496 if (de == NULL)
497 dsCreateIOJob(REDIS_IOJOB_LOAD,c->db,key,NULL);
498 return 1;
499 }
500
501 /* Preload keys for any command with first, last and step values for
502 * the command keys prototype, as defined in the command table. */
503 void waitForMultipleSwappedKeys(redisClient *c, struct redisCommand *cmd, int argc, robj **argv) {
504 int j, last;
505 if (cmd->vm_firstkey == 0) return;
506 last = cmd->vm_lastkey;
507 if (last < 0) last = argc+last;
508 for (j = cmd->vm_firstkey; j <= last; j += cmd->vm_keystep) {
509 redisAssert(j < argc);
510 waitForSwappedKey(c,argv[j]);
511 }
512 }
513
514 /* Preload keys needed for the ZUNIONSTORE and ZINTERSTORE commands.
515 * Note that the number of keys to preload is user-defined, so we need to
516 * apply a sanity check against argc. */
517 void zunionInterBlockClientOnSwappedKeys(redisClient *c, struct redisCommand *cmd, int argc, robj **argv) {
518 int i, num;
519 REDIS_NOTUSED(cmd);
520
521 num = atoi(argv[2]->ptr);
522 if (num > (argc-3)) return;
523 for (i = 0; i < num; i++) {
524 waitForSwappedKey(c,argv[3+i]);
525 }
526 }
527
528 /* Preload keys needed to execute the entire MULTI/EXEC block.
529 *
530 * This function is called by blockClientOnSwappedKeys when EXEC is issued,
531 * and will block the client when any command requires a swapped out value. */
532 void execBlockClientOnSwappedKeys(redisClient *c, struct redisCommand *cmd, int argc, robj **argv) {
533 int i, margc;
534 struct redisCommand *mcmd;
535 robj **margv;
536 REDIS_NOTUSED(cmd);
537 REDIS_NOTUSED(argc);
538 REDIS_NOTUSED(argv);
539
540 if (!(c->flags & REDIS_MULTI)) return;
541 for (i = 0; i < c->mstate.count; i++) {
542 mcmd = c->mstate.commands[i].cmd;
543 margc = c->mstate.commands[i].argc;
544 margv = c->mstate.commands[i].argv;
545
546 if (mcmd->vm_preload_proc != NULL) {
547 mcmd->vm_preload_proc(c,mcmd,margc,margv);
548 } else {
549 waitForMultipleSwappedKeys(c,mcmd,margc,margv);
550 }
551 }
552 }
553
554 /* Is this client attempting to run a command against swapped keys?
555 * If so, block it ASAP, load the keys in background, then resume it.
556 *
557 * The important idea about this function is that it can fail! If keys will
558 * still be swapped when the client is resumed, this key lookups will
559 * just block loading keys from disk. In practical terms this should only
560 * happen with SORT BY command or if there is a bug in this function.
561 *
562 * Return 1 if the client is marked as blocked, 0 if the client can
563 * continue as the keys it is going to access appear to be in memory. */
564 int blockClientOnSwappedKeys(redisClient *c, struct redisCommand *cmd) {
565 if (cmd->vm_preload_proc != NULL) {
566 cmd->vm_preload_proc(c,cmd,c->argc,c->argv);
567 } else {
568 waitForMultipleSwappedKeys(c,cmd,c->argc,c->argv);
569 }
570
571 /* If the client was blocked for at least one key, mark it as blocked. */
572 if (listLength(c->io_keys)) {
573 c->flags |= REDIS_IO_WAIT;
574 aeDeleteFileEvent(server.el,c->fd,AE_READABLE);
575 server.cache_blocked_clients++;
576 return 1;
577 } else {
578 return 0;
579 }
580 }
581
582 /* Remove the 'key' from the list of blocked keys for a given client.
583 *
584 * The function returns 1 when there are no longer blocking keys after
585 * the current one was removed (and the client can be unblocked). */
586 int dontWaitForSwappedKey(redisClient *c, robj *key) {
587 list *l;
588 listNode *ln;
589 listIter li;
590 struct dictEntry *de;
591
592 /* The key object might be destroyed when deleted from the c->io_keys
593 * list (and the "key" argument is physically the same object as the
594 * object inside the list), so we need to protect it. */
595 incrRefCount(key);
596
597 /* Remove the key from the list of keys this client is waiting for. */
598 listRewind(c->io_keys,&li);
599 while ((ln = listNext(&li)) != NULL) {
600 if (equalStringObjects(ln->value,key)) {
601 listDelNode(c->io_keys,ln);
602 break;
603 }
604 }
605 redisAssert(ln != NULL);
606
607 /* Remove the client form the key => waiting clients map. */
608 de = dictFind(c->db->io_keys,key);
609 redisAssert(de != NULL);
610 l = dictGetEntryVal(de);
611 ln = listSearchKey(l,c);
612 redisAssert(ln != NULL);
613 listDelNode(l,ln);
614 if (listLength(l) == 0)
615 dictDelete(c->db->io_keys,key);
616
617 decrRefCount(key);
618 return listLength(c->io_keys) == 0;
619 }
620
621 /* Every time we now a key was loaded back in memory, we handle clients
622 * waiting for this key if any. */
623 void handleClientsBlockedOnSwappedKey(redisDb *db, robj *key) {
624 struct dictEntry *de;
625 list *l;
626 listNode *ln;
627 int len;
628
629 de = dictFind(db->io_keys,key);
630 if (!de) return;
631
632 l = dictGetEntryVal(de);
633 len = listLength(l);
634 /* Note: we can't use something like while(listLength(l)) as the list
635 * can be freed by the calling function when we remove the last element. */
636 while (len--) {
637 ln = listFirst(l);
638 redisClient *c = ln->value;
639
640 if (dontWaitForSwappedKey(c,key)) {
641 /* Put the client in the list of clients ready to go as we
642 * loaded all the keys about it. */
643 listAddNodeTail(server.io_ready_clients,c);
644 }
645 }
646 }