]> git.saurik.com Git - bison.git/log
bison.git
14 years agoportability: `<' and `>' are not always defined on addresses.
Joel E. Denny [Tue, 29 Dec 2009 17:43:26 +0000 (12:43 -0500)] 
portability: `<' and `>' are not always defined on addresses.

Specifically, don't sort objects by their memory addresses when
they're not allocated in the same array or other object.  Though
I haven't found a test case where that fails on my platform, C
says the behavior is undefined.
* src/AnnotationList.c (AnnotationList__insertInto): Remove
FIXME.  Use new id field of InadequacyList nodes rather than
their memory addresses when sorting.
(AnnotationList__compute_from_inadequacies): Add
inadequacy_list_node_count argument to pass to
InadequacyList__new_conflict.
* src/AnnotationList.h
(AnnotationList__compute_from_inadequacies): Update prototype
and documentation for new argument.
* src/InadequacyList.c (InadequacyList__new_conflict): Add
node_count argument and use it to assign a unique ID.
* src/InadequacyList.h (InadequacyListNodeCount): New typedef.
(InadequacyList): Add id field.
(InadequacyList__new_conflict): Update prototype and
documentation for new argument.
* src/ielr.c (ielr_compute_annotation_lists): Update
AnnotationList__compute_from_inadequacies invocation.
(cherry picked from commit 2728ac7ecd663c4a60f94fe7ab7679a9e83ebcd0)

14 years agoFix handling of yychar manipulation in user semantic actions.
Joel E. Denny [Sun, 20 Dec 2009 07:22:53 +0000 (02:22 -0500)] 
Fix handling of yychar manipulation in user semantic actions.

The problem was that yacc.c didn't always update the yychar
translation afterwards.  However, other skeletons appear to be
fine.  glr.c appears to already translate yychar before every
use.  lalr1.cc does not define yychar and does not document its
replacement, yyla, for users.  It does provide yyclearin, but
that does not manipulate yyla and thus requires no translation
update.  In lalr1.java, yychar is out of scope during semantic
actions.
* NEWS (2.5): Document.
* data/yacc.c (YYBACKUP): Don't bother translating yychar into
yytoken here.
(yyparse, yypush_parse): Instead, translate before every use of
yytoken, and add comments explaining this approach.
* tests/actions.at (Destroying lookahead assigned by semantic
action): New test group checking that translation happens before
lookahead destructor calls at parser return.  Previously,
incorrect destructors were called.
* tests/conflicts.at (parse.error=verbose and consistent
errors): New test group checking that translation happens at
syntax error detection before the associated verbose error
message and the associated lookahead destructor calls.  While
the destructor call is fixed by this patch, the verbose error
message is currently incorrect due to another bug (see
comments in test group), so this is an expected failure for now.

14 years agoYYFAIL: warn about uses and remove from lalr1.java.
Joel E. Denny [Mon, 21 Dec 2009 19:58:48 +0000 (14:58 -0500)] 
YYFAIL: warn about uses and remove from lalr1.java.

* NEWS (2.5): Document.
* data/lalr1.java (parser::YYStack::YYFAIL): Rename to YYERRLAB,
and make it private.  Update all uses.
* src/scan-code.l (SC_RULE_ACTION): Implement warning.

14 years agoYYFAIL: deprecate.
Joel E. Denny [Mon, 21 Dec 2009 19:51:40 +0000 (14:51 -0500)] 
YYFAIL: deprecate.

* NEWS (2.4.2): Document deprecation and the phase-out plan.
* data/lalr1.java (parser::YYStack::YYFAIL): Add comment about
deprecation.
* data/yacc.c (YYFAIL): Likewise, and suppress warnings about
YYFAIL from GCC cpp's -Wunused-macros.
* doc/bison.texinfo (Java Action Features): Remove YYFAIL
documentation.
(LocalWords): Remove YYFAIL.

14 years agotests: cleanup.
Joel E. Denny [Sun, 20 Dec 2009 21:03:07 +0000 (16:03 -0500)] 
tests: cleanup.

* tests/c++.at (Syntax error discarding no lookahead): Don't
ignore stderr.  Instead, eliminate remaining warnings.

14 years agolalr1.cc: don't discard non-existent lookahead on syntax error.
Joel E. Denny [Sat, 19 Dec 2009 04:57:18 +0000 (23:57 -0500)] 
lalr1.cc: don't discard non-existent lookahead on syntax error.

* data/lalr1.cc (parser::parse): Check yyempty first.
* tests/c++.at (Syntax error discarding no lookahead): New test
group.

14 years agoCode cleanup.
Joel E. Denny [Thu, 17 Dec 2009 06:09:09 +0000 (01:09 -0500)] 
Code cleanup.

* src/symtab.c, src/symtab.h (symbol_class_get_string): Remove
function, which is no longer used.

14 years agoAdd gcc's -Wundef to test suite and fix another warning from it.
Joel E. Denny [Wed, 16 Dec 2009 18:19:19 +0000 (13:19 -0500)] 
Add gcc's -Wundef to test suite and fix another warning from it.

* NEWS (2.4.2): Update description of -Wundef fix.
* configure.ac (WARN_CXXFLAGS_TEST): New substitution.
(WARN_CFLAGS_TEST): New substitution.
* data/glr.c: Avoid warning about __STRICT_ANSI__.
* tests/atlocal.in (CFLAGS): Use WARN_CFLAGS_TEST instead of
WARN_CFLAGS.
(NO_WERROR_CFLAGS): Likewise.
(CXXFLAGS): Use WARN_CXXFLAGS_TEST instead of WARN_CXXFLAGS.

14 years ago* data/yacc.c: Reformat m4 a little.
Joel E. Denny [Wed, 16 Dec 2009 06:41:17 +0000 (01:41 -0500)] 
* data/yacc.c: Reformat m4 a little.

14 years agoDocument gcc -Wundef fix.
Joel E. Denny [Wed, 16 Dec 2009 06:14:44 +0000 (01:14 -0500)] 
Document gcc -Wundef fix.

* NEWS (2.4.2): Here.
* THANKS (Jonathan Nieder): Add.

14 years agoSimplify y.tab.c when location tracking is disabled.
Jonathan Nieder [Wed, 16 Dec 2009 04:07:46 +0000 (22:07 -0600)] 
Simplify y.tab.c when location tracking is disabled.

* data/yacc.c: Do not check YYLTYPE_IS_TRIVIAL if location
tracking is not enabled.  Instead, unconditionally define
YY_LOCATION_PRINT as a no-op for backward compatibility.

14 years agoAvoid warnings from gcc -Wundef y.tab.c.
Jonathan Nieder [Wed, 16 Dec 2009 04:03:18 +0000 (22:03 -0600)] 
Avoid warnings from gcc -Wundef y.tab.c.

* data/glr.c: Check if YYENABLE_NLS and YYLTYPE_IS_TRIVIAL are
defined before using them.
* data/lalr1.cc: Likewise.
* data/yacc.c: Likewise.

14 years agoautoconf: update to latest for fix of M4 detection.
Joel E. Denny [Tue, 15 Dec 2009 23:56:52 +0000 (18:56 -0500)] 
autoconf: update to latest for fix of M4 detection.

Reported by Eric Blake.
* submodules/autoconf: Update.

14 years agoportability: use -DGNULIB_POSIXCHECK.
Joel E. Denny [Tue, 15 Dec 2009 05:15:41 +0000 (00:15 -0500)] 
portability: use -DGNULIB_POSIXCHECK.

Reported by Eric Blake.  See discussions at
<http://lists.gnu.org/archive/html/bug-bison/2009-09/msg00008.html>
and
<http://lists.gnu.org/archive/html/bug-gnulib/2009-10/msg00108.html>.
* HACKING (Release checks): Suggest -DGNULIB_POSIXCHECK.
* bootstrap.conf (gnulib_modules): Add all the printf modules
suggested by -DGNULIB_POSIXCHECK.  Add realloc-posix as
suggested by -DGNULIB_POSIXCHECK for gnulib's own vasnprintf.c.
(excluded_files): Remove m4/printf-posix.m4.
* tests/atlocal.in (LIBS): As for LDADD in src/local.mk, add
lib/libbison.a so gnulib libraries can be linked.

14 years agognulib: update for fix of fprintf-posix, which we'll use soon.
Joel E. Denny [Tue, 15 Dec 2009 22:20:31 +0000 (17:20 -0500)] 
gnulib: update for fix of fprintf-posix, which we'll use soon.

* etc/prefix-gnulib-mk (prefix): Adjust regex for make file
targets so that gnulib's new arg-nonnull.h and link-warning.h
are matched.
* gnulib: Update.

14 years agoEnable assertion output and --disable-assert for configure.
Joel E. Denny [Mon, 14 Dec 2009 23:04:57 +0000 (18:04 -0500)] 
Enable assertion output and --disable-assert for configure.

* bootstrap.conf (gnulib_modules): Add assert module.
* src/system.h (aver): Define as assert, and summarize the
discussion on this issue.

14 years agoExpand GLR acronym in summary of Bison.
Joel E. Denny [Mon, 14 Dec 2009 21:04:00 +0000 (16:04 -0500)] 
Expand GLR acronym in summary of Bison.

Based on discussion with Akim Demaille starting at
<http://lists.gnu.org/archive/html/bison-patches/2009-04/msg00087.html>.
* doc/bison.texinfo (Introduction): Here.
* src/getargs.c (usage): Here.
(cherry picked from commit 51c7ca01e2c9cfb5c7a274bed0e14899adbd005c)

14 years ago Document named references.
Alex Rozenman [Sat, 14 Nov 2009 20:06:26 +0000 (22:06 +0200)] 
Document named references.

* doc/bison.texinfo (Actions): Add new example and xref to
Using Named References node.
(Using Named References): New node.

15 years agocleanup.
Joel E. Denny [Fri, 16 Oct 2009 23:27:12 +0000 (19:27 -0400)] 
cleanup.

* src/Sbitset.c (Sbitset__new_on_obstack): Use Sbitset instead
of char*.
(Sbitset__isEmpty): Use Sbitset instead of char*.
* src/Sbitset.h (Sbitset): Make it a pointer to unsigned char
instead of char.  This helps to avoid casting errors.
(Sbitset__or): Use Sbitset instead of char*.

15 years agoportability: don't assume 8-bit bytes.
Joel E. Denny [Fri, 16 Oct 2009 23:20:43 +0000 (19:20 -0400)] 
portability: don't assume 8-bit bytes.

That is, use CHAR_BIT and UCHAR_MAX instead of 8 and 0xff.
* src/Sbitset.h (Sbitset__nbytes): Here.
(Sbitset__byteAddress): Here.
(Sbitset__bit_mask): Here.
(Sbitset__last_byte_mask): Here.
(Sbitset__ones): Here.
(SBITSET__FOR_EACH): Here.

15 years agoportability: use va_start and va_end in the same function.
Joel E. Denny [Sun, 11 Oct 2009 20:15:39 +0000 (16:15 -0400)] 
portability: use va_start and va_end in the same function.

* src/complain.c (error_message): Move va_end from here...
(ERROR_MESSAGE): ... to here.

15 years ago* data/bison.m4: Update comments for rename to muscle-tab.h.
Joel E. Denny [Thu, 8 Oct 2009 21:08:01 +0000 (17:08 -0400)] 
* data/bison.m4: Update comments for rename to muscle-tab.h.
(cherry picked from commit 51f255a5308bb70a4f479196574f2049ed89d6d3)

15 years agoMinor code cleanup.
Joel E. Denny [Thu, 8 Oct 2009 03:09:43 +0000 (23:09 -0400)] 
Minor code cleanup.

* src/muscle-tab.c (MUSCLE_USER_NAME_CONVERT): Remove macro and
replace all uses with UNIQSTR_CONCAT.
* src/uniqstr.c (uniqstr_vsprintf): New function.
* src/uniqstr.h (uniqstr_vsprintf): Add prototype.
(UNIQSTR_CONCAT, UNIQSTR_GEN_FORMAT, UNIQSTR_GEN_FORMAT_): New
macros.

15 years ago* TODO (Complaint submessage indentation): New.
Joel E. Denny [Tue, 6 Oct 2009 16:47:47 +0000 (12:47 -0400)] 
* TODO (Complaint submessage indentation): New.

15 years agoMinor code cleanup.
Joel E. Denny [Mon, 5 Oct 2009 03:44:44 +0000 (23:44 -0400)] 
Minor code cleanup.

* src/parse-gram.y: Clean up sorting of declarations.
Use types to simplify %printer declarations where possible.
Provide %printer for BRACKETED_ID and symbol.prec.
* src/symtab.c: Whitespace change.

15 years agotests: skip tests of file names that platform does not support.
Joel E. Denny [Mon, 5 Oct 2009 02:59:18 +0000 (22:59 -0400)] 
tests: skip tests of file names that platform does not support.

Reported by Michael Raskin at
<http://lists.gnu.org/archive/html/bug-bison/2009-09/msg00001.html>.
* THANKS (Michael Raskin): Add.
* tests/output.at (AT_CHECK_OUTPUT_FILE_NAME): Fix.  Cygwin used
to fail at least for file names containing ":" or "\".
(cherry picked from commit 2ceb8c617cac934b45f101ab44508d72239c894b)

Conflicts:

THANKS

15 years agoyysyntax_error: avoid duplicate lookahead collection.
Joel E. Denny [Wed, 23 Sep 2009 21:39:39 +0000 (17:39 -0400)] 
yysyntax_error: avoid duplicate lookahead collection.

Except when memory reallocation is required, this change
eliminates the need to invoke yysyntax_error twice and thus to
repeat the collection of lookaheads.  It also prepares for
future extensions that will make those repetitions more
expensive and that will require additional memory management in
yysyntax_error.  Finally, it fixes an obscure bug already
exercised in the test suite.
* data/yacc.c (yysyntax_error): Add arguments for message
buffer variables stored in the parser.  Instead of size, return
status similar to yyparse status but indicating success of
message creation.  Other than the actual reallocation of the
message buffer, import and clean up memory management code
from...
(yyparse, yypush_parse): ... here.
* tests/regression.at (parse.error=verbose overflow): No longer
an expected failure.

15 years agoyysyntax_error: test memory management more.
Joel E. Denny [Wed, 23 Sep 2009 21:37:58 +0000 (17:37 -0400)] 
yysyntax_error: test memory management more.

* tests/atlocal.in (NO_WERROR_CFLAGS): New cpp macro.
* tests/regression.at (parse.error=verbose and
YYSTACK_USE_ALLOCA): New test group.
(parse.error=verbose overflow): New test group that reveals an
obscure bug.  Expected fail for now.

15 years agobenchmarks: use %debug consistently among grammars.
Joel E. Denny [Sun, 4 Oct 2009 18:33:28 +0000 (14:33 -0400)] 
benchmarks: use %debug consistently among grammars.

* etc/bench.pl.in (generate_grammar_triangular): Do not activate
%debug by default.  It can affect the timings even if yydebug=0.
(generate_grammar_calc): For consistency with other grammars,
use YYDEBUG environment variable to set yydebug.

15 years agoRemove dead code.
Joel E. Denny [Sat, 3 Oct 2009 15:53:05 +0000 (11:53 -0400)] 
Remove dead code.

* src/symtab.c (symbol_pack): Here because every symbol's number
is always defined by this time.

15 years agoAdd additional space after periods in NEWS.
Alex Rozenman [Sat, 3 Oct 2009 16:29:14 +0000 (18:29 +0200)] 
Add additional space after periods in NEWS.

* NEWS (2.5): here.

15 years agoUse the correct conversion specifier for size_t.
Joel E. Denny [Tue, 29 Sep 2009 10:54:38 +0000 (06:54 -0400)] 
Use the correct conversion specifier for size_t.

Reported by Jim Meyering.
* src/Sbitset.h (SBITSET__INDEX__CONVERSION_SPEC): New, "zu"
because Sbitset__Index is size_t.
* src/Sbitset.c (Sbitset__fprint): Use it instead of %d.

15 years agotests: don't abuse AT_BISON_CHECK.
Joel E. Denny [Sun, 27 Sep 2009 18:37:00 +0000 (14:37 -0400)] 
tests: don't abuse AT_BISON_CHECK.

* tests/regression.at (parse-gram.y: LALR = IELR): Move
additional shell commands outside of AT_BISON_CHECK.

15 years agotests: check that parse-gram.y's IELR and LALR are identical.
Joel E. Denny [Sat, 26 Sep 2009 18:49:20 +0000 (14:49 -0400)] 
tests: check that parse-gram.y's IELR and LALR are identical.

* tests/atlocal.in (abs_top_srcdir): New shell variable.
* tests/regression.at (parse-gram.y: LALR = IELR): New test
group.

15 years agoFormatting changes.
Akim Demaille [Wed, 23 Sep 2009 13:06:24 +0000 (15:06 +0200)] 
Formatting changes.

* doc/bison.texinfo: here.

15 years agoKeep sub-messages aligned. Fix strings for translation.
Alex Rozenman [Sat, 19 Sep 2009 09:59:33 +0000 (12:59 +0300)] 
Keep sub-messages aligned. Fix strings for translation.

* src/location.h: (location_print): Add return value.
* src/location.c: (location_print): Return number of printed
characters.
* src/complain.h: Two new functions (complain_at_indent,
warn_at_indent).
* src/complain.cpp: Implement the alignment mechanism. Add new
static variable (indent_ptr). Use and update it (error_message,
complain_at_indent, warn_at_indent).
* src/scan-code.l: Fix strings for translations. Use new *_indent
functions (parse_ref, show_sub_messages).
* NEWS (2.5): Add an announcement about named references.

15 years agotodo: short term
Akim Demaille [Thu, 17 Sep 2009 07:41:21 +0000 (09:41 +0200)] 
todo: short term

* TODO (syntax_error, variable names): New.

15 years agodoc: fixes.
Akim Demaille [Thu, 17 Sep 2009 07:40:42 +0000 (09:40 +0200)] 
doc: fixes.

* doc/bison.texinfo: here.
Reported by Alex Rozenman.

15 years agodoc: lalr1.cc and variants.
Akim Demaille [Wed, 16 Sep 2009 20:19:53 +0000 (22:19 +0200)] 
doc: lalr1.cc and variants.

* doc/bison.texinfo (Decl Summary): Document the "lex_symbol" and
"variant" %define variables.
(C++ Semantic Values): Split into...
(C++ Unions, C++ Variants): these.
The latter is new.
(C++ Parser Interface): Fix type names.
Document parser::syntax_error.
Document the fact that locations are not mandatory.
(C++ Scanner Interface): Split into...
(Split Symbols, Complete Symbols): these.
The later is new.
(Calc++ Parsing Driver): Use variants.
Add more comments.
Adjust style.
(Calc++ Parser): Declare all the tokens, no
longer accept raw characters.
Remove %union.
Adjust types and printers.
Remove destructors.
(Calc++ Scanner): Use make_<SYMBOL> functions.
Use strerror in error message.

15 years agodoc: spell checking.
Akim Demaille [Wed, 16 Sep 2009 20:18:57 +0000 (22:18 +0200)] 
doc: spell checking.

* doc/bison.texinfo: here.

15 years agodoc: comment changes.
Akim Demaille [Wed, 16 Sep 2009 20:11:33 +0000 (22:11 +0200)] 
doc: comment changes.

* doc/bison.texinfo: Comment changes.

15 years agolalr1.cc: factor the yytranslate_ invocation in make_SYMBOLS.
Akim Demaille [Wed, 9 Sep 2009 21:09:22 +0000 (23:09 +0200)] 
lalr1.cc: factor the yytranslate_ invocation in make_SYMBOLS.

* data/c++.m4, data/lalr1.cc (parser::symbol_type): Change the
constructor to take a token_type instead of the (internal) symbol
number.
Call yytranslate_.
* data/variant.hh (b4_symbol_constructor_define_): Therefore,
don't call yytranslate_ here.

15 years agoTODO: statistics.
Akim Demaille [Wed, 16 Sep 2009 15:18:31 +0000 (17:18 +0200)] 
TODO: statistics.

* TODO (Figures): New.

15 years agotests: clean up push.at test group titles.
Joel E. Denny [Sun, 13 Sep 2009 17:45:05 +0000 (13:45 -0400)] 
tests: clean up push.at test group titles.

* tests/push.at: Remove "Push Parsing: " from test group titles
because these are already under the banner "Push Parsing Tests".

15 years agoProvide an additional sub-message for clarity.
Alex Rozenman [Sat, 12 Sep 2009 08:48:56 +0000 (11:48 +0300)] 
Provide an additional sub-message for clarity.

Add "symbol not found in production" error message when
an "invalid reference" is detected in named references
resolution.

* src/scan-code.l: Update "invalid reference" case.
* tests/named-ref.at: Adjust test-cases.

15 years agoClean up yacc.c a little.
Joel E. Denny [Sun, 6 Sep 2009 20:59:04 +0000 (16:59 -0400)] 
Clean up yacc.c a little.

* data/yacc.c: Clean up M4 for readability, and make output
whitespace more consistent.  For the main parse function
comment, instead of saying "yyparse or yypush_parse", say either
"yyparse" or "yypush_parse" depending on which it actually is.

15 years agoFix --enable-gcc-warnings.
Joel E. Denny [Thu, 10 Sep 2009 04:12:07 +0000 (00:12 -0400)] 
Fix --enable-gcc-warnings.

* src/parse-gram.y (%printer <param>): Handle param_none.

15 years agolalr1.cc: syntax_error as exceptions.
Akim Demaille [Tue, 8 Sep 2009 20:00:13 +0000 (22:00 +0200)] 
lalr1.cc: syntax_error as exceptions.

It is common to use sort of factories in the user actions.  These
factories may check some "syntactic" constraints that are not
enforced by the grammar itself.  This is possible using YYERROR
within the action itself.  Provide the user with a means to throw
a syntax_error exception.

* data/c++.m4 (b4_public_types_declare, b4_public_types_define):
Declare and define yy::parser::syntax_error.
* data/lalr1.cc: Include stdexcept.
(yy::parser::parse): Wrap the user action within a try/catch.
* data/glr.cc: Include stdexcept.

15 years agolalr1.cc: add missing "inline".
Akim Demaille [Tue, 8 Sep 2009 19:59:33 +0000 (21:59 +0200)] 
lalr1.cc: add missing "inline".

* data/c++.m4 (b4_public_types_define): Add missing inline to
implementations provided in headers.

15 years ago%param: documentation.
Akim Demaille [Mon, 7 Sep 2009 06:05:43 +0000 (08:05 +0200)] 
%param: documentation.

* NEWS (2.6): Document %param, %lex-param, and %parse-param
changes.
* doc/bison.texinfo: Document that %lex-param and %parse-param
are n-ary.
Changes some examples to demonstrate it.
(Calc++ Parser): Use %param.

15 years agoRegen.
Akim Demaille [Wed, 9 Sep 2009 13:37:03 +0000 (15:37 +0200)] 
Regen.

15 years agostyle changes.
Akim Demaille [Wed, 9 Sep 2009 13:36:02 +0000 (15:36 +0200)] 
style changes.

* src/parse-gram.y (add_param): Scope changes.

15 years ago%parse: support several arguments.
Akim Demaille [Wed, 9 Sep 2009 13:35:49 +0000 (15:35 +0200)] 
%parse: support several arguments.

* src/parse-gram.y (current_param): New.
(param_type): Add param_none.
(params): New nonterminal.
Use it.

15 years agoRegen.
Akim Demaille [Wed, 9 Sep 2009 13:15:31 +0000 (15:15 +0200)] 
Regen.

15 years ago%param.
Akim Demaille [Thu, 3 Sep 2009 12:15:13 +0000 (14:15 +0200)] 
%param.

Provide a means to factor lex-param and parse-param common
declarations.

* src/parse-gram.y (param_type): New.
Define a %printer for it.
(add_param): Use it.
(%parse-param, %lex-param): Merge into...
(%parse): this new token.
Adjust the grammar to use it.
* src/scan-gram.l (RETURN_VALUE): New.
(RETURN_PERCENT_FLAG): Use it.
(RETURN_PERCENT_PARAM): New.
Use it to support %parse-param, %lex-param and %param.

15 years agoComplain about unused %define variables and %code qualifiers.
Joel E. Denny [Thu, 3 Sep 2009 20:04:10 +0000 (16:04 -0400)] 
Complain about unused %define variables and %code qualifiers.

* NEWS (2.5): Document.
* data/bison.m4 (b4_check_user_names): Complain instead of warn.
* doc/bison.texinfo (Decl Summary): Document complaint, and
improve %define documentation a little otherwise.
* tests/input.at (Reject unused %code qualifiers): Update.
(%define errors): Update.
(%define, --define, --force-define): Update.
(%define backward compatibility): Update.
(Unused %define api.pure): Update.
* tests/push.at (Push Parsing: Unsupported Skeletons): Update.

15 years agoUse aver not assert.
Joel E. Denny [Thu, 3 Sep 2009 17:59:07 +0000 (13:59 -0400)] 
Use aver not assert.

* src/output.c: Don't include assert.h.
(output_skeleton): Use aver not assert.
* src/system.h (aver): In documentation of why, add links to
Paul Eggert's explanations in the mailing lists.

15 years ago Use "Unresolved reference" error message when no symbols were found
Alex Rozenman [Sat, 5 Sep 2009 10:16:45 +0000 (13:16 +0300)] 
Use "Unresolved reference" error message when no symbols were found
in a symbolic reference resolution. Remove .expr and -expr from
the shown reference when the reference is unresolved.

* src/scan-code.l: Change the error message, adjust location columns,
rename variable "exact_mode" to "explicit_bracketing".
* tests/named-ref.at: Adjust existing tests and add a new one.

15 years agoAdjust synclines in src/parse-gram.[ch].
Akim Demaille [Thu, 3 Sep 2009 12:10:17 +0000 (14:10 +0200)] 
Adjust synclines in src/parse-gram.[ch].

* tests/bison.in: Do some magic (including working around issues
with ylwrap) when this wrapper is used to compile
src/parse-gram.y.

15 years agoDon't suppress warnings about unused parse.error.
Joel E. Denny [Thu, 3 Sep 2009 18:27:16 +0000 (14:27 -0400)] 
Don't suppress warnings about unused parse.error.

* data/bison.m4 (b4_error_verbose_flag): Don't examine value of
%define variable parse.error unless b4_error_verbose_flag is
actually expanded in a skeleton.

15 years agoNEWS: Internationalization.
Akim Demaille [Thu, 3 Sep 2009 09:03:14 +0000 (11:03 +0200)] 
NEWS: Internationalization.

* NEWS (2.4.2): Add "Internationalization" item.

15 years agobootstrap: fix/improve find_tool.
Akim Demaille [Thu, 3 Sep 2009 08:50:32 +0000 (10:50 +0200)] 
bootstrap: fix/improve find_tool.

* bootstrap (find_tool): Improve error messages.
Fix typo about find_tool_names.

15 years agoFix gcc 3.4.4 shadowing warning reported by Eric Blake.
Joel E. Denny [Sat, 29 Aug 2009 20:25:58 +0000 (16:25 -0400)] 
Fix gcc 3.4.4 shadowing warning reported by Eric Blake.

See
<http://lists.gnu.org/archive/html/bison-patches/2009-08/msg00093.html>.
* src/scan-code.h (code_props_rule_action_init): Rename
named_ref arg to name so it doesn't shadow named_ref type.  This
makes it consistent with the function definition in scan-code.l
anyway.

15 years ago%define: accept unquoted values.
Joel E. Denny [Fri, 28 Aug 2009 07:46:37 +0000 (03:46 -0400)] 
%define: accept unquoted values.

* NEWS (2.5): Group all %define changes together, and document
this one.  Remove quotes in IELR and canonical LR entry.
* doc/bison.texinfo: Remove quotes in most examples throughout.
(Decl Summary): Update %define documentation.
(Table of Symbols): Likewise.
* src/ielr.c (LrType): Update documentation.
* src/parse-gram.y (content.opt): Add production for ID.
* tests/actions.at: Remove quotes in most tests.
* tests/calc.at: Likewise.
* tests/existing.at: Likewise.
* tests/input.at: Likewise.
* tests/local.at: Likewise.
* tests/push.at: Likewise.
* tests/reduce.at: Likewise.
* tests/torture.at: Likewise.

15 years ago%define lr.type: make values lowercase IDs.
Joel E. Denny [Fri, 28 Aug 2009 04:57:06 +0000 (00:57 -0400)] 
%define lr.type: make values lowercase IDs.

That is, "LALR" => "lalr", "IELR" => "ielr", and
"canonical LR" => "canonical-lr".
* NEWS (2.5): Update documentation.
* doc/bison.texinfo (Decl Summary): Likewise.
* src/ielr.c (ielr): Use new values.
* src/ielr.h (ielr): Update documentation.
* src/reader.c (prepare_percent_define_front_end_variables): Use
and validate new values.
* tests/existing.at (AT_TEST_EXISTING_GRAMMAR): Update test
grammars.
* tests/reduce.at (AT_TEST_LR_TYPE): Likewise.

15 years agoscan-gram: avoid portability trap with ctype usage.
Eric Blake [Thu, 27 Aug 2009 16:56:53 +0000 (10:56 -0600)] 
scan-gram: avoid portability trap with ctype usage.

* src/scan-gram.l (<SC_ESCAPED_STRING,SC_ESCAPED_CHARACTER>):
Avoid compiler warning.

Signed-off-by: Eric Blake <ebb9@byu.net>
(cherry picked from commit bbbbe221d7c2ff2fff88f7a0c8dbfee73f2e8a58)

15 years agotests: use perl for printing special sequences to files.
Joel E. Denny [Thu, 27 Aug 2009 07:52:53 +0000 (03:52 -0400)] 
tests: use perl for printing special sequences to files.

And skip tests if perl is not available.  This is better than
playing tricks with shell portability.  Suggested by Akim
Demaille.
* tests/input.at (Bad character literals): Use it here for
omitting final newlines.
(Bad escapes in literals): Use it here for special characters.

15 years agotests: show a use of %define lr.default-reductions "consistent"
Joel E. Denny [Wed, 26 Aug 2009 18:15:53 +0000 (14:15 -0400)] 
tests: show a use of %define lr.default-reductions "consistent"

* tests/conflicts.at (%nonassoc and eof): Extend to test that it
prevents the omission of expected tokens for %error-verbose.

15 years agotests: portability fix.
Akim Demaille [Wed, 26 Aug 2009 09:53:18 +0000 (11:53 +0200)] 
tests: portability fix.

* tests/input.at (Bad escapes in literals): Don't expect "echo
'\0'" to output \ then 0.

15 years agoActually handle the yytable zero value correctly this time.
Joel E. Denny [Wed, 26 Aug 2009 06:40:38 +0000 (02:40 -0400)] 
Actually handle the yytable zero value correctly this time.

* data/bison.m4 (b4_integral_parser_tables_map): Don't mention
zero values in the YYTABLE comments.
* data/glr.c (yytable_value_is_error): Don't check for zero
value.
* data/lalr1.cc (yy_table_value_is_error_): Likewise.
* data/yacc.c (yytable_value_is_error): Likewise.
* data/lalr1.java (yy_table_value_is_error_): Likewise.
(yysyntax_error): Fix typo in code: use yytable_ not yycheck_.
* src/tables.h: In header comments, explain why it's useless to
check for a zero value in yytable.

15 years agoMore fixes related to last two patches.
Joel E. Denny [Tue, 25 Aug 2009 23:41:49 +0000 (19:41 -0400)] 
More fixes related to last two patches.

* data/bison.m4 (b4_integral_parser_tables_map): Fix YYTABLE
comments: zero indicates syntax error not default action.
* data/c.m4 (b4_table_value_equals): Comment that YYID must be
defined.
* data/glr.c (yyis_pact_ninf): Rename to...
(yypact_value_is_default): ... this.
(yyisDefaultedState): Update for rename.
(yyis_table_ninf): Rename to...
(yytable_value_is_error): ... this, and check for value zero
besides just YYTABLE_NINF.
(yygetLRActions): Check for default value from yypact.  It
appears that this check is always performed before this function
is invoked, and so adding the check here is probably redundant.
However, the code may evolve after this subtlety is forgotten.
Also, update for rename to yytable_value_is_error.  Because that
macro now checks for zero, a different but equivalent branch of
the if-then-else here is evaluated.
(yyreportSyntaxError): Update for rename to
yytable_value_is_error.  The zero condition was mishandled
before.
(yyrecoverSyntaxError): Update for renames.  No behavioral
changes.
* data/lalr1.cc, data/lalr1.java (yy_pact_value_is_default_):
New function.
(yy_table_value_is_error_): New function.
(parse): Use new functions where possible.  No behavioral
changes.
(yysyntax_error_, yysyntax_error): Use yy_table_value_is_error_.
The zero condition was mishandled before.
* data/yacc.c (yyis_pact_ninf): Rename to...
(yypact_value_is_default): ... this.
(yyis_table_ninf): Rename to...
(yytable_value_is_error): ... this, and check for value zero
besides just YYTABLE_NINF.
(yysyntax_error): Update for rename to yytable_value_is_error.
The zero condition was mishandled before.
(yyparse): Update for renames.  No behavioral changes.
* src/tables.h: Improve comments about yypact, yytable, etc.
more.  Most importantly, say yytable value of zero means syntax
error not default action.

15 years agoFix %error-verbose for conflicts resolved by %nonassoc.
Joel E. Denny [Tue, 25 Aug 2009 05:13:02 +0000 (01:13 -0400)] 
Fix %error-verbose for conflicts resolved by %nonassoc.

* NEWS (2.5): Document.
* data/glr.c (yyreportSyntaxError): Fix this by checking
yyis_table_ninf.
* data/yacc.c (yysyntax_error): Likewise.
* data/lalr1.cc (yysyntax_error_): Fix this by checking
yytable_ninf_.
* data/lalr1.java (yysyntax_error): Likewise.
* tests/conflicts.at (%nonassoc and eof): Update expected output
and remove FIXME.

15 years agoSome code and documentation improvements.
Joel E. Denny [Tue, 25 Aug 2009 05:12:37 +0000 (01:12 -0400)] 
Some code and documentation improvements.

* data/c.m4 (b4_table_value_equals): New macro to capture
some repeated code.
* data/glr.c (yyis_pact_ninf): Use it here.
(yyis_table_ninf): Likewise.
(yyreportSyntaxError): Improve internal comments.
* data/yacc.c (yyis_pact_ninf): New macro copied from glr.c.
Use it everywhere possible.
(yyis_table_ninf): Likewise.
(yysyntax_error): Improve internal comments.
* data/lalr1.cc (yysyntax_error_): Likewise.
* data/lalr1.java (yysyntax_error): Likewise.
* src/tables.h: Improve comments about yypact, yytable, etc.

15 years agoUse locale when quoting.
Joel E. Denny [Sat, 22 Aug 2009 00:09:54 +0000 (20:09 -0400)] 
Use locale when quoting.

* src/scan-gram.l (SC_ESCAPED_STRING, SC_ESCAPED_CHARACTER): Use
quote rather than implementing quoting here.

15 years agoMake previous patch more robust.
Eric Blake [Thu, 20 Aug 2009 22:54:07 +0000 (16:54 -0600)] 
Make previous patch more robust.

* src/output.c (ARRAY_CARDINALITY): New macro, copied from
argmatch.h.
(output_skeleton): Use it.
Suggested by Akim Demaille.

Signed-off-by: Eric Blake <ebb9@byu.net>
(cherry picked from commit 1266b636740f0c6719d8cc11a5d569084fa37009)

15 years agoImport latest m4/m4.m4.
Eric Blake [Thu, 20 Aug 2009 15:48:49 +0000 (09:48 -0600)] 
Import latest m4/m4.m4.

* submodules/autoconf: Update to autoconf 2.64.
* configure.ac (M4_GNU_OPTION): New define.
* src/output.c (output_skeleton): Use it to resolve FIXME.
* NEWS: Mention this.

Signed-off-by: Eric Blake <ebb9@byu.net>
(cherry picked from commit b9ad39c1fb2482e1513cdf9800b31e71b7986b39)

15 years agoFix complaints about escape sequences.
Joel E. Denny [Thu, 20 Aug 2009 00:37:28 +0000 (20:37 -0400)] 
Fix complaints about escape sequences.

Discussed starting at
<http://lists.gnu.org/archive/html/bison-patches/2009-08/msg00036.html>.
* src/scan-gram.l (SC_ESCAPED_STRING, SC_ESCAPED_CHARACTER):
For a \0 and similar escape sequences meaning the null
character, report an invalid escape sequence instead of an
invalid null character because the latter does not actually
appear in the user's input.
In all escape sequence complaints, don't escape the initial
backslash, and don't quote when the sequence appears at the end
of the complaint line unless there's whitespace that quotearg
won't escape.
Consistently say "invalid" not "unrecognized".
Consistently prefer "empty character literal" over "extra
characters in character literal" warning for invalid escape
sequences; that is, consistently discard those sequences.
* tests/input.at (Bad escapes in literals): New.

15 years agodoc: fixes.
Akim Demaille [Wed, 19 Aug 2009 12:51:50 +0000 (14:51 +0200)] 
doc: fixes.

* doc/bison.texinfo: Fix minor Texinfo errors.

15 years agotests: distcc compliance.
Akim Demaille [Wed, 19 Aug 2009 12:39:27 +0000 (14:39 +0200)] 
tests: distcc compliance.

* tests/synclines.at (AT_SYNCLINES_COMPILE): Discard distcc's
error messages from the output.

15 years agovariables: simplify the upgrade of namespace into api.namespace.
Akim Demaille [Wed, 19 Aug 2009 12:24:15 +0000 (14:24 +0200)] 
variables: simplify the upgrade of namespace into api.namespace.

This patch simplifies "variables: rename namespace as api.namespace",
commit 67501061076ba46355cfd9f9361c7eed861b389c.
Suggested by Joel E. Denny in
http://lists.gnu.org/archive/html/bison-patches/2009-07/msg00006.html

* src/muscle-tab.c (muscle_percent_variable_update): New.
(muscle_percent_define_insert): Use it in replacement of the
previous tr invocation.
Remove variable_tr, no longer needed.
* data/bison.m4 (b4_percent_define_copy_, b4_percent_define_copy):
Remove.
* data/c++.m4: No longer handle namespace -> api.namespace.
* tests/input.at (%define backward compatibility): Check that
namespace is treated as api.namespace.

15 years ago2009-08-19 Akim Demaille <demaille@gostai.com>
Akim Demaille [Wed, 19 Aug 2009 11:34:48 +0000 (13:34 +0200)] 
2009-08-19  Akim Demaille  <demaille@gostai.com>

doc: %initial-action to initialize yylloc.
Reported by Bill Allombert.
* doc/bison.texinfo: Set fill-column to 76.
(Location Type): Document the use of %initial-action to initialize
yylloc.

15 years agolalr1.cc: use state_type.
Akim Demaille [Sun, 16 Aug 2009 05:38:40 +0000 (07:38 +0200)] 
lalr1.cc: use state_type.

* data/lalr1.cc (yysyntax_error_): Use state_type.
Move argument names into yy*.

15 years agolalr1.cc: get rid of yyparse's yystate.
Akim Demaille [Sun, 16 Aug 2009 05:36:39 +0000 (07:36 +0200)] 
lalr1.cc: get rid of yyparse's yystate.

yystate and yystack_[0].state are equal, keep only the latter.
The former was also used as a temporary variable to compute the
post-reduction state.  Move this computation into an auxiliary
function.

* data/glr.c (yyLRgotoState): Fuse variable definition and first
assignment.
* data/lalr1.cc (yy_lr_goto_state_): New.
(yyparse): Use it.
Replace remaining uses of yystate by yystate_[0].state.
Remove the former.

15 years agolalr1.cc: destroy $$ when YYERROR is called.
Akim Demaille [Wed, 12 Aug 2009 16:00:40 +0000 (18:00 +0200)] 
lalr1.cc: destroy $$ when YYERROR is called.

* data/lalr1.cc (yyreduce): Compute the resulting state before
running the user action so that yylhs is a valid symbol.
(yyerrorlab): Since yylhs is complete (it knows its type), we can
simply call yy_destroy_ to destroy $$ on YYERROR invocations.
* tests/c++.at (AT_CHECK_VARIANTS): Test YYERROR with variants.

15 years agomaint: update for gnulib's recent update-copyright changes
Joel E. Denny [Tue, 18 Aug 2009 22:29:54 +0000 (18:29 -0400)] 
maint: update for gnulib's recent update-copyright changes

* gnulib: Update.
* .x-update-copyright (COPYING): Add as it's no longer implied
when .x-update-copyright is present.
* cfg.mk (update-copyright-local): Remove, now ignored.
(update-copyright): Declare update-b4-copyright as a dependency.

15 years agobuild: require gettext 0.17.
Akim Demaille [Mon, 17 Aug 2009 08:51:08 +0000 (10:51 +0200)] 
build: require gettext 0.17.

Suggested by Bruno Haible.
http://lists.gnu.org/archive/html/bug-bison/2009-08/msg00009.html

* configure.ac: require gettext 0.17 to ensure compatibility with
gnulib.

15 years agobuild: lower gettext requirements.
Akim Demaille [Mon, 17 Aug 2009 07:22:41 +0000 (09:22 +0200)] 
build: lower gettext requirements.

Bison was uselessly requiring the formatstring macros from
gettext, which resulted in mo files not being installed on systems
that perfectly supported Bison mo files.  Lower the requirement.
http://lists.gnu.org/archive/html/bug-bison/2009-08/msg00006.html

* configure.ac: Require need-ngettext instead of
need-formatstring-macros.
Reported by Martin Jabocs.
Suggested by Bruno Haible.
* INSTALL: Restructure.
(Internationalization): New.
(cherry picked from commit b9e42bb439643b6b193ba44696c370bbb35d2ec0)

15 years agognulib: update.
Akim Demaille [Mon, 17 Aug 2009 08:42:12 +0000 (10:42 +0200)] 
gnulib: update.

* gnulib: Update to newest.

15 years agomaint: fix use of copyright year intervals.
Joel E. Denny [Fri, 14 Aug 2009 21:05:06 +0000 (17:05 -0400)] 
maint: fix use of copyright year intervals.

* gnulib: Update.
* bootstrap.conf (gnulib_modules): Update getopt to getopt-gnu
as now recommended in gnulib/NEWS.
* build-aux/update-b4-copyright: Fix.
* cfg.mk (update-copyright-env): Configure update-copyright.
(cherry picked from commit 75ac158b82be1fab5157b140287368165a50ec82)

15 years agoMake it easier to write deterministic tests.
Joel E. Denny [Sun, 9 Aug 2009 00:19:01 +0000 (20:19 -0400)] 
Make it easier to write deterministic tests.

Continues Akim's work from his 2009-06-10 commits.
* src/reader.c (check_and_convert_grammar): Don't add any
symbols after the first symbols_do invocation.
* src/symtab.c (symbols_sorted): New static global.
(user_token_number_redeclaration): Update comments.
(symbol_from_uniqstr): If a new symbol is being created, assert
that symbols_sorted hasn't been allocated yet.
(symbols_free): Free symbols_sorted.
(symbols_cmp, symbols_cmp_qsort): New functions.
(symbols_do): Sort symbol_table into symbols_sorted on first
invocation.
* tests/input.at (Numbered tokens): Recombine tests now that the
output should be deterministic across multiple numbers.

15 years agotests: GCC 4.5 compliance.
Akim Demaille [Wed, 12 Aug 2009 14:18:12 +0000 (16:18 +0200)] 
tests: GCC 4.5 compliance.

* tests/synclines.at (AT_SYNCLINES_COMPILE): Adjust to GCC 4.5's
messages about #error.

15 years agobuild: fix the generation of the documentation.
Akim Demaille [Wed, 12 Aug 2009 12:47:08 +0000 (14:47 +0200)] 
build: fix the generation of the documentation.

Some of our targets use "bison --help", but they can't depend on
"bison" itself (to avoid additional requirements on the user), so
they used to call "make src/bison" in the commands.  Then
concurrent builds may fail: one make might be aiming one of its
jobs at compiling src/bison, and another job at generating the man
page.  If the latter is faster than the former, then we have two
makes that concurrently try to compile src/bison.

This might also be a more convincing explanation for the failure
described in the patch "build: fix paths".

* Makefile.am (SUFFIXES): Initialize.
* build-aux/move-if-change: New, symlink to gnulib's.
* build-aux/local.mk: Ship it.
* doc/common.x: Remove, merged into...
* doc/bison.x: here.
* doc/local.mk (doc/bison.help): New.
($(CROSS_OPTIONS_TEXI)): Depend on it.
Use src/bison.
(.x.1): Replace with...
(doc/bison.1): this explicit, simpler, target.
(common_dep): Remove, inlined where appropriate.
(SUFFIXES, PREPATH): Remove, unused.

15 years agognulib: improve prefixing.
Akim Demaille [Wed, 1 Jul 2009 09:53:29 +0000 (11:53 +0200)] 
gnulib: improve prefixing.

* configure.ac (gl_PREFIXED_LIBOBJS): Don't rename it, rather,
change the value of...
(gl_LIBOBJS): this.
Adjust more variables.
* etc/prefix-gnulib-mk (prefix_assignment): Don't rename
gl_LIBOBJS.
(prefix): Also transform rules whose targets have slashes.
Use $prefix liberally.
Map @MKDIR_P@ to $(MKDIR_P).
Prefix directories that are mkdir'd.

15 years agobuild: fix paths.
Akim Demaille [Wed, 1 Jul 2009 10:19:09 +0000 (12:19 +0200)] 
build: fix paths.

When using $(top_builddir) inconsistently, Make (including GNU
Make) is sometimes confused.  As a result it may want to build
lib/libbison.la and $(top_builddir)/lib/libbison.la (the same
file, different names) concurrently, which, amusingly enough,
might end with:

  ranlib lib/libbison.a
  ranlib lib/libbison.a
  make[2]: *** [lib/libbison.a] Segmentation fault

on OS X.

* doc/local.mk, src/local.mk: Do not use $(top_builddir) when not
needed.

15 years agodistcheck: fix.
Akim Demaille [Wed, 1 Jul 2009 10:19:18 +0000 (12:19 +0200)] 
distcheck: fix.

* examples/calc++/Makefile.am: (EXTRA_DIST): Ship calc.stamp.

15 years ago* tests/local.mk (TESTSUITE_AT): Add named-refs.at.
Joel E. Denny [Tue, 11 Aug 2009 03:39:43 +0000 (23:39 -0400)] 
* tests/local.mk (TESTSUITE_AT): Add named-refs.at.
(cherry picked from commit 36dfe4662ef5eb96073034b9eb80113b0c2a204e)

Conflicts:

tests/Makefile.am

15 years agoMiscellaneous code readability improvements.
Joel E. Denny [Tue, 11 Aug 2009 01:43:07 +0000 (21:43 -0400)] 
Miscellaneous code readability improvements.

* src/reader.c (reader): Move %define front-end variable
defaults and checking into...
(prepare_percent_define_front_end_variables): ... this new
function.

* src/scan-gram.l (INITIAL): For consistency with string
literals, don't store open quote on character literal.  It's
discarded before returning anyway.
(SC_ESCAPED_CHARACTER): Similarly, don't store close quote.
Make length test more readable, and make the character stored
for an empty literal more obvious while consistent with the
previous behavior.

* src/symtab.c, src/symtab.h: Rename USER_NUMBER_ALIAS to
USER_NUMBER_HAS_STRING_ALIAS throughout.
* src/symtab.c (symbol_make_alias): Remove comment from symtab.c
that is repeated in symtab.h.  Improve argument names to make it
clear which side of the symbol-string alias pair is which.
(symbol_check_alias_consistency): Improve local variable names
for the same purpose.
* src/symtab.h (struct symbol): Make comments about aliases
clearer.
(symbol_make_alias): Improve comments and argument name.
* src/output.c (token_definitions_output): Update for rename to
USER_NUMBER_HAS_STRING_ALIAS and improve comments about aliases.

15 years ago Convert "misleading reference" messages to warnings.
Alex Rozenman [Sat, 8 Aug 2009 15:10:23 +0000 (18:10 +0300)] 
Convert "misleading reference" messages to warnings.

* src/scan-code.l: New function 'show_sub_messages', more
factoring.
* tests/named-ref.at: Adjust tests.

15 years agomaint: run "make update-copyright"
Joel E. Denny [Thu, 6 Aug 2009 22:57:50 +0000 (18:57 -0400)] 
maint: run "make update-copyright"

15 years agomaint: make update-b4-copyright easier to use
Joel E. Denny [Thu, 6 Aug 2009 15:34:09 +0000 (11:34 -0400)] 
maint: make update-b4-copyright easier to use

* build-aux/update-b4-copyright: In warnings, report line
numbers rather than character positions.
* cfg.mk (update-copyright-local): Set to update-b4-copyright so
that update-copyright runs it.
* gnulib: Update.