]> git.saurik.com Git - bison.git/commit
tests: enable -Wsign-compare and fix corresponding warnings
authorAkim Demaille <akim@lrde.epita.fr>
Fri, 19 Apr 2013 15:13:07 +0000 (17:13 +0200)
committerAkim Demaille <akim@lrde.epita.fr>
Fri, 19 Apr 2013 15:13:07 +0000 (17:13 +0200)
commit7ba01e111c878291d8677db124eb4d7aef7c9541
treec8d8468add55e6182b0dda3beb7594beab7dd943
parent6ce4b4ff1b761a0408cf94abb308fac9b55edd3d
tests: enable -Wsign-compare and fix corresponding warnings

-Wsign-compare was disabled for bison's own code, following gnulib's
approach.  However, the generated parsers should not trigger such
warnings.

Reported by Efi Fogel.
http://lists.gnu.org/archive/html/help-bison/2013-04/msg00018.html

See also http://stackoverflow.com/questions/16101062 for the weird
"-(unsigned)i" piece of code.

* configure.ac (warn_tests): Enable -Wsign-compare.
* data/location.cc (position::add_): New.
(position::lines, position::columns): Use it.
* tests/actions.at (AT_CHECK_PRINTER_AND_DESTRUCTOR): Fix signedness issues.
THANKS
configure.ac
data/location.cc
tests/actions.at