]> git.saurik.com Git - apple/xnu.git/blobdiff - bsd/net/bpf.c
xnu-3247.10.11.tar.gz
[apple/xnu.git] / bsd / net / bpf.c
index e370dfc5ed2d12bbb4c1aad57c0ebc14cc8f150f..f98100d2b739f8cbee0d93c998f3b97a49c9aa5c 100644 (file)
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2000-2010 Apple Inc. All rights reserved.
+ * Copyright (c) 2000-2014 Apple Inc. All rights reserved.
  *
  * @APPLE_OSREFERENCE_LICENSE_HEADER_START@
  * 
 #include <sys/file_internal.h>
 #include <sys/event.h>
 
-#if defined(sparc) && BSD < 199103
-#include <sys/stream.h>
-#endif
 #include <sys/poll.h>
 
 #include <sys/socket.h>
+#include <sys/socketvar.h>
 #include <sys/vnode.h>
 
 #include <net/if.h>
 #include <net/bpfdesc.h>
 
 #include <netinet/in.h>
+#include <netinet/in_pcb.h>
+#include <netinet/in_var.h>
+#include <netinet/ip_var.h>
+#include <netinet/tcp.h>
+#include <netinet/tcp_var.h>
+#include <netinet/udp.h>
+#include <netinet/udp_var.h>
 #include <netinet/if_ether.h>
 #include <sys/kernel.h>
 #include <sys/sysctl.h>
 
 #include <miscfs/devfs/devfs.h>
 #include <net/dlil.h>
+#include <net/pktap.h>
 
 #include <kern/locks.h>
 #include <kern/thread_call.h>
 
 extern int tvtohz(struct timeval *);
 
-/*
- * Older BSDs don't have kernel malloc.
- */
-#if BSD < 199103
-extern bcopy();
-static caddr_t bpf_alloc();
-#include <net/bpf_compat.h>
-#define BPF_BUFSIZE (MCLBYTES-8)
-#define UIOMOVE(cp, len, code, uio) uiomove(cp, len, code, uio)
-#else
 #define BPF_BUFSIZE 4096
 #define UIOMOVE(cp, len, code, uio) uiomove(cp, len, uio)
-#endif
 
 
 #define PRINET  26                     /* interruptible */
@@ -156,6 +151,18 @@ SYSCTL_INT(_debug, OID_AUTO, bpf_maxbufsize, CTLFLAG_RW | CTLFLAG_LOCKED,
 static unsigned int bpf_maxdevices = 256;
 SYSCTL_UINT(_debug, OID_AUTO, bpf_maxdevices, CTLFLAG_RW | CTLFLAG_LOCKED,
        &bpf_maxdevices, 0, "");
+/*
+ * bpf_wantpktap controls the defaul visibility of DLT_PKTAP
+ * For OS X is off by default so process need to use the ioctl BPF_WANT_PKTAP
+ * explicitly to be able to use DLT_PKTAP.
+ */
+static unsigned int bpf_wantpktap = 0;
+SYSCTL_UINT(_debug, OID_AUTO, bpf_wantpktap, CTLFLAG_RW | CTLFLAG_LOCKED,
+       &bpf_wantpktap, 0, "");
+
+static int bpf_debug = 0;
+SYSCTL_INT(_debug, OID_AUTO, bpf_debug, CTLFLAG_RW | CTLFLAG_LOCKED,
+       &bpf_debug, 0, "");
 
 /*
  *  bpf_iflist is the list of interfaces; each corresponds to an ifnet
@@ -177,37 +184,36 @@ static struct bpf_d       **bpf_dtab = NULL;
 static unsigned int bpf_dtab_size = 0;
 static unsigned int    nbpfilter = 0;
 
-static lck_mtx_t               *bpf_mlock;
+decl_lck_mtx_data(static, bpf_mlock_data);
+static lck_mtx_t               *bpf_mlock = &bpf_mlock_data;
 static lck_grp_t               *bpf_mlock_grp;
 static lck_grp_attr_t  *bpf_mlock_grp_attr;
 static lck_attr_t              *bpf_mlock_attr;
 
-/*
- * Mark a descriptor free by making it point to itself.
- * This is probably cheaper than marking with a constant since
- * the address should be in a register anyway.
- */
+static mbuf_tag_id_t bpf_mtag_id;
 #endif /* __APPLE__ */
 
 static int     bpf_allocbufs(struct bpf_d *);
 static errno_t bpf_attachd(struct bpf_d *d, struct bpf_if *bp);
-static void    bpf_detachd(struct bpf_d *d);
+static int     bpf_detachd(struct bpf_d *d, int);
 static void    bpf_freed(struct bpf_d *);
 static void    bpf_mcopy(const void *, void *, size_t);
 static int     bpf_movein(struct uio *, int,
                    struct mbuf **, struct sockaddr *, int *);
 static int     bpf_setif(struct bpf_d *, ifnet_t ifp, u_int32_t dlt);
-static void bpf_timed_out(void *, void *);
-static void bpf_wakeup(struct bpf_d *);
-static void    catchpacket(struct bpf_d *, u_char *, u_int,
-                   u_int, void (*)(const void *, void *, size_t));
+static void    bpf_timed_out(void *, void *);
+static void    bpf_wakeup(struct bpf_d *);
+static void    catchpacket(struct bpf_d *, u_char *, struct mbuf *, u_int,
+                   u_int, int, void (*)(const void *, void *, size_t));
 static void    reset_d(struct bpf_d *);
-static int bpf_setf(struct bpf_d *, u_int bf_len, user_addr_t bf_insns);
-static int     bpf_getdltlist(struct bpf_d *, struct bpf_dltlist *,
-    struct proc *);
+static int     bpf_setf(struct bpf_d *, u_int, user_addr_t, u_long);
+static int     bpf_getdltlist(struct bpf_d *, caddr_t, struct proc *);
 static int     bpf_setdlt(struct bpf_d *, u_int);
+static int     bpf_set_traffic_class(struct bpf_d *, int);
+static void    bpf_set_packet_service_class(struct mbuf *, int);
 
-/*static  void *bpf_devfs_token[MAXBPFILTER];*/
+static void    bpf_acquire_d(struct bpf_d *);
+static void    bpf_release_d(struct bpf_d *);
 
 static  int bpf_devsw_installed;
 
@@ -222,8 +228,8 @@ static int bpf_tap_callback(struct ifnet *ifp, struct mbuf *m);
        d_close_t           bpfclose;
        d_read_t            bpfread;
        d_write_t           bpfwrite;
-    ioctl_fcn_t            bpfioctl;
-    select_fcn_t       bpfselect;
+       ioctl_fcn_t         bpfioctl;
+       select_fcn_t        bpfselect;
 
 
 /* Darwin's cdevsw struct differs slightly from BSDs */
@@ -234,15 +240,15 @@ static struct cdevsw bpf_cdevsw = {
        /* read */          bpfread,
        /* write */         bpfwrite,
        /* ioctl */         bpfioctl,
-       /* stop */              eno_stop,
-       /* reset */             eno_reset,
-       /* tty */               NULL,
-       /* select */    bpfselect,
-       /* mmap */              eno_mmap,
-       /* strategy*/   eno_strat,
-       /* getc */              eno_getc,
-       /* putc */              eno_putc,
-       /* type */              0
+       /* stop */          eno_stop,
+       /* reset */         eno_reset,
+       /* tty */           NULL,
+       /* select */        bpfselect,
+       /* mmap */          eno_mmap,
+       /* strategy*/       eno_strat,
+       /* getc */          eno_getc,
+       /* putc */          eno_putc,
+       /* type */          0
 };
 
 #define SOCKADDR_HDR_LEN          offsetof(struct sockaddr, sa_data)
@@ -316,7 +322,7 @@ bpf_movein(struct uio *uio, int linktype, struct mbuf **mp, struct sockaddr *soc
                sa_family = AF_IEEE80211;
                hlen = 0;
                break;
-       
+
        case DLT_IEEE802_11_RADIO:
                sa_family = AF_IEEE80211;
                hlen = 0;
@@ -360,13 +366,8 @@ bpf_movein(struct uio *uio, int linktype, struct mbuf **mp, struct sockaddr *soc
        if (m == 0)
                return (ENOBUFS);
        if ((unsigned)len > MHLEN) {
-#if BSD >= 199103
                MCLGET(m, M_WAIT);
                if ((m->m_flags & M_EXT) == 0) {
-#else
-               MCLGET(m);
-               if (m->m_len != MCLBYTES) {
-#endif
                        error = ENOBUFS;
                        goto bad;
                }
@@ -381,11 +382,7 @@ bpf_movein(struct uio *uio, int linktype, struct mbuf **mp, struct sockaddr *soc
        if (hlen != 0) {
                m->m_pkthdr.len -= hlen;
                m->m_len -= hlen;
-#if BSD >= 199103
                m->m_data += hlen; /* XXX */
-#else
-               m->m_off += hlen;
-#endif
                error = UIOMOVE((caddr_t)sockp->sa_data, hlen, UIO_WRITE, uio);
                if (error)
                        goto bad;
@@ -418,8 +415,9 @@ bpf_movein(struct uio *uio, int linktype, struct mbuf **mp, struct sockaddr *soc
 #ifdef __APPLE__
 
 /*
- * The dynamic addition of a new device node must block all processes that are opening 
- * the last device so that no process will get an unexpected ENOENT 
+ * The dynamic addition of a new device node must block all processes that
+ * are opening the last device so that no process will get an unexpected
+ * ENOENT 
  */
 static void
 bpf_make_dev_t(int maj)
@@ -492,16 +490,31 @@ bpf_attachd(struct bpf_d *d, struct bpf_if *bp)
        d->bd_bif = bp;
        d->bd_next = bp->bif_dlist;
        bp->bif_dlist = d;
-       
+
+       /*
+        * Take a reference on the device even if an error is returned
+        * because we keep the device in the interface's list of listeners
+        */
+       bpf_acquire_d(d);
+
        if (first) {
                /* Find the default bpf entry for this ifp */
                if (bp->bif_ifp->if_bpf == NULL) {
-                       struct bpf_if   *primary;
+                       struct bpf_if   *tmp, *primary = NULL;
                        
-                       for (primary = bpf_iflist; primary && primary->bif_ifp != bp->bif_ifp;
-                                primary = primary->bif_next)
-                               ;
-               
+                       for (tmp = bpf_iflist; tmp; tmp = tmp->bif_next) {
+                               if (tmp->bif_ifp != bp->bif_ifp)
+                                       continue;
+                               primary = tmp;
+                               /*
+                                * Make DLT_PKTAP only if process knows how
+                                * to deal with it, otherwise find another one
+                                */
+                               if (tmp->bif_dlt == DLT_PKTAP &&
+                                       !(d->bd_flags & BPF_WANT_PKTAP))
+                                       continue;
+                               break;
+                       }
                        bp->bif_ifp->if_bpf = primary;
                }
                
@@ -513,22 +526,50 @@ bpf_attachd(struct bpf_d *d, struct bpf_if *bp)
                        error = bp->bif_tap(bp->bif_ifp, bp->bif_dlt, BPF_TAP_INPUT_OUTPUT);
        }
 
+       /*
+        * Reset the detach flags in case we previously detached an interface
+        */
+       d->bd_flags &= ~(BPF_DETACHING | BPF_DETACHED);
+
+       if (bp->bif_ifp->if_bpf != NULL &&
+               bp->bif_ifp->if_bpf->bif_dlt == DLT_PKTAP)
+               d->bd_flags |= BPF_FINALIZE_PKTAP;
+       else
+               d->bd_flags &= ~BPF_FINALIZE_PKTAP;
+
        return error;
 }
 
 /*
  * Detach a file from its interface.
+ *
+ * Return 1 if was closed by some thread, 0 otherwise
  */
-static void
-bpf_detachd(struct bpf_d *d)
+static int
+bpf_detachd(struct bpf_d *d, int closing)
 {
        struct bpf_d **p;
        struct bpf_if *bp;
        struct ifnet  *ifp;
 
+       /*
+        * Some other thread already detached
+        */
+       if ((d->bd_flags & (BPF_DETACHED | BPF_DETACHING)) != 0)
+               goto done;
+       /*
+        * This thread is doing the detach
+        */
+       d->bd_flags |= BPF_DETACHING;
+
        ifp = d->bd_bif->bif_ifp;
        bp = d->bd_bif;
-       
+
+       if (bpf_debug != 0)
+               printf("%s: %llx %s%s\n",
+                   __func__, (uint64_t)VM_KERNEL_ADDRPERM(d),
+                   if_name(ifp), closing ? " closing" : "");
+
        /* Remove d from the interface's descriptor list. */
        p = &bp->bif_dlist;
        while (*p != d) {
@@ -568,10 +609,37 @@ bpf_detachd(struct bpf_d *d)
                         * take it out.
                         * Most likely the network interface is gone.
                         */
-                       printf("bpf: ifnet_set_promiscuous failed");
+                       printf("%s: ifnet_set_promiscuous failed\n", __func__);
                }
                lck_mtx_lock(bpf_mlock);
        }
+
+       /*
+        * Wake up other thread that are waiting for this thread to finish
+        * detaching
+        */
+       d->bd_flags &= ~BPF_DETACHING;
+       d->bd_flags |= BPF_DETACHED;
+       /*
+        * Note that We've kept the reference because we may have dropped
+        * the lock when turning off promiscuous mode
+        */
+       bpf_release_d(d);
+
+done:
+       /*
+        * When closing makes sure no other thread refer to the bpf_d
+        */
+       if (bpf_debug != 0)
+               printf("%s: %llx done\n",
+                   __func__, (uint64_t)VM_KERNEL_ADDRPERM(d));
+       /*
+        * Let the caller know the bpf_d is closed
+        */
+       if ((d->bd_flags & BPF_CLOSING))
+               return (1);
+       else
+               return (0);
 }
 
 
@@ -589,9 +657,9 @@ bpf_start_timer(struct bpf_d *d)
                tv.tv_sec = d->bd_rtout / hz;
                tv.tv_usec = (d->bd_rtout % hz) * tick;
 
-               clock_interval_to_deadline((uint64_t)tv.tv_sec * USEC_PER_SEC + tv.tv_usec,
-                               NSEC_PER_USEC,
-                               &deadline);
+               clock_interval_to_deadline(
+                   (uint64_t)tv.tv_sec * USEC_PER_SEC + tv.tv_usec,
+                   NSEC_PER_USEC, &deadline);
                /*
                 * The state is BPF_IDLE, so the timer hasn't 
                 * been started yet, and hasn't gone off yet;
@@ -626,7 +694,42 @@ bpf_stop_timer(struct bpf_d *d)
        return (thread_call_cancel(d->bd_thread_call));
 }
 
+void
+bpf_acquire_d(struct bpf_d *d)
+{
+       void *lr_saved =  __builtin_return_address(0);
+
+       lck_mtx_assert(bpf_mlock, LCK_MTX_ASSERT_OWNED);
+
+       d->bd_refcnt += 1;
+
+       d->bd_ref_lr[d->bd_next_ref_lr] = lr_saved;
+       d->bd_next_ref_lr = (d->bd_next_ref_lr + 1) % BPF_REF_HIST;
+}
+
+void
+bpf_release_d(struct bpf_d *d)
+{
+       void *lr_saved =  __builtin_return_address(0);
+
+       lck_mtx_assert(bpf_mlock, LCK_MTX_ASSERT_OWNED);
+
+       if (d->bd_refcnt <= 0)
+               panic("%s: %p refcnt <= 0", __func__, d);
+
+       d->bd_refcnt -= 1;
 
+       d->bd_unref_lr[d->bd_next_unref_lr] = lr_saved;
+       d->bd_next_unref_lr = (d->bd_next_unref_lr + 1) % BPF_REF_HIST;
+
+       if (d->bd_refcnt == 0) {
+               /* Assert the device is detached */
+               if ((d->bd_flags & BPF_DETACHED) == 0)
+                       panic("%s: %p BPF_DETACHED not set", __func__, d);
+
+               _FREE(d, M_DEVBUF);
+       }
+}
 
 /*
  * Open ethernet device.  Returns ENXIO for illegal minor device number,
@@ -670,7 +773,8 @@ bpfopen(dev_t dev, int flags, __unused int fmt,
                lck_mtx_unlock(bpf_mlock);
                return (EBUSY);
        }
-       d = (struct bpf_d *)_MALLOC(sizeof(struct bpf_d), M_DEVBUF, M_WAIT);
+       d = (struct bpf_d *)_MALLOC(sizeof(struct bpf_d), M_DEVBUF,
+           M_WAIT | M_ZERO);
        if (d == NULL) {
                /* this really is a catastrophic failure */
                printf("bpfopen: malloc bpf_d failed\n");
@@ -678,27 +782,28 @@ bpfopen(dev_t dev, int flags, __unused int fmt,
                lck_mtx_unlock(bpf_mlock);
                return ENOMEM;
        }
-       bzero(d, sizeof(struct bpf_d));
-       
-       /*
-        * It is not necessary to take the BPF lock here because no other 
-        * thread can access the device until it is marked opened...
-        */
-       
+
        /* Mark "in use" and do most initialization. */
+       bpf_acquire_d(d);
        d->bd_bufsize = bpf_bufsize;
        d->bd_sig = SIGIO;
        d->bd_seesent = 1;
        d->bd_oflags = flags;
        d->bd_state = BPF_IDLE;
-    d->bd_thread_call = thread_call_allocate(bpf_timed_out, d);
-
+       d->bd_traffic_class = SO_TC_BE;
+       d->bd_flags |= BPF_DETACHED;
+       if (bpf_wantpktap)
+               d->bd_flags |= BPF_WANT_PKTAP;
+       else
+               d->bd_flags &= ~BPF_WANT_PKTAP;
+       d->bd_thread_call = thread_call_allocate(bpf_timed_out, d);
        if (d->bd_thread_call == NULL) {
                printf("bpfopen: malloc thread call failed\n");
                bpf_dtab[minor(dev)] = NULL;
+               bpf_release_d(d);
                lck_mtx_unlock(bpf_mlock);
-               _FREE(d, M_DEVBUF);
-               return ENOMEM;
+
+               return (ENOMEM);
        }
 #if CONFIG_MACF_NET
        mac_bpfdesc_label_init(d);
@@ -728,7 +833,17 @@ bpfclose(dev_t dev, __unused int flags, __unused int fmt,
        if (d == 0 || d == (void *)1) {
                lck_mtx_unlock(bpf_mlock);
                return (ENXIO);
-       }       
+       }
+
+       /*
+        * Other threads may call bpd_detachd() if we drop the bpf_mlock
+        */
+       d->bd_flags |= BPF_CLOSING;
+
+       if (bpf_debug != 0)
+               printf("%s: %llx\n",
+                   __func__, (uint64_t)VM_KERNEL_ADDRPERM(d));
+
        bpf_dtab[minor(dev)] = (void *)1;               /* Mark closing */
 
        /*
@@ -786,20 +901,25 @@ bpfclose(dev_t dev, __unused int flags, __unused int fmt,
        }
 
        if (d->bd_bif)
-               bpf_detachd(d);
+               bpf_detachd(d, 1);
        selthreadclear(&d->bd_sel);
 #if CONFIG_MACF_NET
        mac_bpfdesc_label_destroy(d);
 #endif
        thread_call_free(d->bd_thread_call);
+
+       while (d->bd_hbuf_read)
+               msleep((caddr_t)d, bpf_mlock, PRINET, "bpf_reading", NULL);
+
        bpf_freed(d);
 
        /* Mark free in same context as bpfopen comes to check */
        bpf_dtab[minor(dev)] = NULL;                    /* Mark closed */
+
+       bpf_release_d(d);
+
        lck_mtx_unlock(bpf_mlock);
-       
-       _FREE(d, M_DEVBUF);
-       
+
        return (0);
 }
 
@@ -823,10 +943,14 @@ bpf_sleep(struct bpf_d *d, int pri, const char *wmesg, int timo)
  * Zero the length of the new store buffer.
  */
 #define ROTATE_BUFFERS(d) \
+       if (d->bd_hbuf_read) \
+               panic("rotating bpf buffers during read"); \
        (d)->bd_hbuf = (d)->bd_sbuf; \
        (d)->bd_hlen = (d)->bd_slen; \
+       (d)->bd_hcnt = (d)->bd_scnt; \
        (d)->bd_sbuf = (d)->bd_fbuf; \
        (d)->bd_slen = 0; \
+       (d)->bd_scnt = 0; \
        (d)->bd_fbuf = NULL;
 /*
  *  bpfread - read next chunk of packets from buffers
@@ -835,22 +959,27 @@ int
 bpfread(dev_t dev, struct uio *uio, int ioflag)
 {
        struct bpf_d *d;
-       int timed_out;
+       caddr_t hbuf; 
+       int timed_out, hbuf_len;
        int error;
+       int flags;
 
        lck_mtx_lock(bpf_mlock);
 
        d = bpf_dtab[minor(dev)];
-       if (d == 0 || d == (void *)1) {
+       if (d == 0 || d == (void *)1 || (d->bd_flags & BPF_CLOSING) != 0) {
                lck_mtx_unlock(bpf_mlock);
                return (ENXIO);
        }
 
+       bpf_acquire_d(d);
+
        /*
         * Restrict application to use a buffer the same size as
         * as kernel buffers.
         */
        if (uio_resid(uio) != d->bd_bufsize) {
+               bpf_release_d(d);
                lck_mtx_unlock(bpf_mlock);
                return (EINVAL);
        }
@@ -861,6 +990,14 @@ bpfread(dev_t dev, struct uio *uio, int ioflag)
        timed_out = (d->bd_state == BPF_TIMED_OUT);
        d->bd_state = BPF_IDLE;
 
+       while (d->bd_hbuf_read) 
+               msleep((caddr_t)d, bpf_mlock, PRINET, "bpf_reading", NULL);
+
+       if ((d->bd_flags & BPF_CLOSING) != 0) {
+               bpf_release_d(d);
+               lck_mtx_unlock(bpf_mlock);
+               return (ENXIO);
+       }
        /*
         * If the hold buffer is empty, then do a timed sleep, which
         * ends when the timeout expires or when enough packets
@@ -889,10 +1026,12 @@ bpfread(dev_t dev, struct uio *uio, int ioflag)
                 * it before using it again.
                 */
                if (d->bd_bif == NULL) {
+                       bpf_release_d(d);
                        lck_mtx_unlock(bpf_mlock);
                        return (ENXIO);
                }
                if (ioflag & IO_NDELAY) {
+                       bpf_release_d(d);
                        lck_mtx_unlock(bpf_mlock);
                        return (EWOULDBLOCK);
                }
@@ -901,12 +1040,42 @@ bpfread(dev_t dev, struct uio *uio, int ioflag)
                /*
                 * Make sure device is still opened
                 */
-               d = bpf_dtab[minor(dev)];
-               if (d == 0 || d == (void *)1) {
+               if ((d->bd_flags & BPF_CLOSING) != 0) {
+                       bpf_release_d(d);
                        lck_mtx_unlock(bpf_mlock);
                        return (ENXIO);
                }
+
+               while (d->bd_hbuf_read)
+                       msleep((caddr_t)d, bpf_mlock, PRINET, "bpf_reading", NULL);
+
+               if ((d->bd_flags & BPF_CLOSING) != 0) {
+                       bpf_release_d(d);
+                       lck_mtx_unlock(bpf_mlock);
+                       return (ENXIO);
+               }
+
                if (error == EINTR || error == ERESTART) {
+                       if (d->bd_hbuf) {
+                               /*
+                                * Because we msleep, the hold buffer might
+                                * be filled when we wake up.  Avoid rotating
+                                * in this case.
+                                */
+                               break;
+                       }
+                       if (d->bd_slen) {
+                               /*
+                                * Sometimes we may be interrupted often and
+                                * the sleep above will not timeout.
+                                * Regardless, we should rotate the buffers
+                                * if there's any new data pending and
+                                * return it.
+                                */
+                               ROTATE_BUFFERS(d);
+                               break;
+                       }
+                       bpf_release_d(d);
                        lck_mtx_unlock(bpf_mlock);
                        return (error);
                }
@@ -925,6 +1094,7 @@ bpfread(dev_t dev, struct uio *uio, int ioflag)
                                break;
 
                        if (d->bd_slen == 0) {
+                               bpf_release_d(d);
                                lck_mtx_unlock(bpf_mlock);
                                return (0);
                        }
@@ -936,18 +1106,120 @@ bpfread(dev_t dev, struct uio *uio, int ioflag)
         * At this point, we know we have something in the hold slot.
         */
 
+       /*
+        * Set the hold buffer read. So we do not 
+        * rotate the buffers until the hold buffer
+        * read is complete. Also to avoid issues resulting
+        * from page faults during disk sleep (<rdar://problem/13436396>).
+        */
+       d->bd_hbuf_read = 1;
+       hbuf = d->bd_hbuf;
+       hbuf_len = d->bd_hlen;
+       flags = d->bd_flags;
+       lck_mtx_unlock(bpf_mlock);
+
+#ifdef __APPLE__
+       /*
+        * Before we move data to userland, we fill out the extended
+        * header fields.
+        */
+       if (flags & BPF_EXTENDED_HDR) {
+               char *p;
+
+               p = hbuf;
+               while (p < hbuf + hbuf_len) {
+                       struct bpf_hdr_ext *ehp;
+                       uint32_t flowid;
+                       struct so_procinfo soprocinfo;
+                       int found = 0;
+
+                       ehp = (struct bpf_hdr_ext *)(void *)p;
+                       if ((flowid = ehp->bh_flowid)) {
+                               if (ehp->bh_proto == IPPROTO_TCP)
+                                       found = inp_findinpcb_procinfo(&tcbinfo,
+                                           flowid, &soprocinfo);
+                               else if (ehp->bh_proto == IPPROTO_UDP)
+                                       found = inp_findinpcb_procinfo(&udbinfo,
+                                           flowid, &soprocinfo);
+                               if (found == 1) {
+                                       ehp->bh_pid = soprocinfo.spi_pid;
+                                       proc_name(ehp->bh_pid, ehp->bh_comm, MAXCOMLEN);
+                               }
+                               ehp->bh_flowid = 0;
+                       }
+                       if (flags & BPF_FINALIZE_PKTAP) {
+                               struct pktap_header *pktaphdr;
+                               
+                               pktaphdr = (struct pktap_header *)(void *)
+                                   (p + BPF_WORDALIGN(ehp->bh_hdrlen));
+
+                               if (pktaphdr->pth_flags & PTH_FLAG_DELAY_PKTAP)
+                                       pktap_finalize_proc_info(pktaphdr);
+
+                               if (pktaphdr->pth_flags & PTH_FLAG_TSTAMP) {
+                                       ehp->bh_tstamp.tv_sec =
+                                               pktaphdr->pth_tstamp.tv_sec;
+                                       ehp->bh_tstamp.tv_usec =
+                                               pktaphdr->pth_tstamp.tv_usec;
+                               }
+                       }
+                       p += BPF_WORDALIGN(ehp->bh_hdrlen + ehp->bh_caplen);
+               }
+       } else if (flags & BPF_FINALIZE_PKTAP) {
+               char *p;
+
+               p = hbuf;
+               while (p < hbuf + hbuf_len) {
+                       struct bpf_hdr *hp;
+                       struct pktap_header *pktaphdr;
+                       
+                       hp = (struct bpf_hdr *)(void *)p;
+                       pktaphdr = (struct pktap_header *)(void *)
+                           (p + BPF_WORDALIGN(hp->bh_hdrlen));
+
+                       if (pktaphdr->pth_flags & PTH_FLAG_DELAY_PKTAP)
+                               pktap_finalize_proc_info(pktaphdr);
+
+                       if (pktaphdr->pth_flags & PTH_FLAG_TSTAMP) {
+                               hp->bh_tstamp.tv_sec =
+                                       pktaphdr->pth_tstamp.tv_sec;
+                               hp->bh_tstamp.tv_usec =
+                                       pktaphdr->pth_tstamp.tv_usec;
+                       }
+
+                       p += BPF_WORDALIGN(hp->bh_hdrlen + hp->bh_caplen);
+               }
+       }
+#endif
+
        /*
         * Move data from hold buffer into user space.
         * We know the entire buffer is transferred since
         * we checked above that the read buffer is bpf_bufsize bytes.
         */
-       error = UIOMOVE(d->bd_hbuf, d->bd_hlen, UIO_READ, uio);
-
+       error = UIOMOVE(hbuf, hbuf_len, UIO_READ, uio);
+       
+       lck_mtx_lock(bpf_mlock);
+       /*
+        * Make sure device is still opened
+        */
+       if ((d->bd_flags & BPF_CLOSING) != 0) {
+               bpf_release_d(d);
+               lck_mtx_unlock(bpf_mlock);
+               return (ENXIO);
+       }
+       
+       d->bd_hbuf_read = 0;
        d->bd_fbuf = d->bd_hbuf;
        d->bd_hbuf = NULL;
        d->bd_hlen = 0;
+       d->bd_hcnt = 0;
+       wakeup((caddr_t)d);
+
+       bpf_release_d(d);
        lck_mtx_unlock(bpf_mlock);
        return (error);
+
 }
 
 
@@ -965,20 +1237,9 @@ bpf_wakeup(struct bpf_d *d)
        if (d->bd_async && d->bd_sig && d->bd_sigio)
                pgsigio(d->bd_sigio, d->bd_sig);
 
-#if BSD >= 199103
        selwakeup(&d->bd_sel);
-       KNOTE(&d->bd_sel.si_note, 1);
-#ifndef __APPLE__
-       /* XXX */
-       d->bd_sel.si_pid = 0;
-#endif
-#else
-       if (d->bd_selproc) {
-               selwakeup(d->bd_selproc, (int)d->bd_selcoll);
-               d->bd_selcoll = 0;
-               d->bd_selproc = 0;
-       }
-#endif
+       if ((d->bd_flags & BPF_KNOTE))
+               KNOTE(&d->bd_sel.si_note, 1);
 }
 
 
@@ -1023,17 +1284,21 @@ bpfwrite(dev_t dev, struct uio *uio, __unused int ioflag)
        int error;
        char              dst_buf[SOCKADDR_HDR_LEN + MAX_DATALINK_HDR_LEN];
        int datlen = 0;
-    int bif_dlt;
-    int bd_hdrcmplt;
+       int bif_dlt;
+       int bd_hdrcmplt;
 
        lck_mtx_lock(bpf_mlock);
 
        d = bpf_dtab[minor(dev)];
-       if (d == 0 || d == (void *)1) {
+       if (d == 0 || d == (void *)1 || (d->bd_flags & BPF_CLOSING) != 0) {
                lck_mtx_unlock(bpf_mlock);
                return (ENXIO);
        }
+
+       bpf_acquire_d(d);
+
        if (d->bd_bif == 0) {
+               bpf_release_d(d);
                lck_mtx_unlock(bpf_mlock);
                return (ENXIO);
        }
@@ -1041,49 +1306,56 @@ bpfwrite(dev_t dev, struct uio *uio, __unused int ioflag)
        ifp = d->bd_bif->bif_ifp;
 
        if ((ifp->if_flags & IFF_UP) == 0) {
+               bpf_release_d(d);
                lck_mtx_unlock(bpf_mlock);
                return (ENETDOWN);
        }
        if (uio_resid(uio) == 0) {
+               bpf_release_d(d);
                lck_mtx_unlock(bpf_mlock);
                return (0);
        }
        ((struct sockaddr *)dst_buf)->sa_len = sizeof(dst_buf);
 
-   /*
-    * fix for PR-6849527
-    * geting variables onto stack before dropping lock for bpf_movein()
-    */
-    bif_dlt = (int)d->bd_bif->bif_dlt;
-    bd_hdrcmplt  = d->bd_hdrcmplt;
+       /*
+        * fix for PR-6849527
+        * geting variables onto stack before dropping lock for bpf_movein()
+        */
+       bif_dlt = (int)d->bd_bif->bif_dlt;
+       bd_hdrcmplt  = d->bd_hdrcmplt;
+
        /* bpf_movein allocating mbufs; drop lock */
-    lck_mtx_unlock(bpf_mlock);
+       lck_mtx_unlock(bpf_mlock);
 
        error = bpf_movein(uio, bif_dlt, &m, 
-    bd_hdrcmplt ? NULL : (struct sockaddr *)dst_buf,
-    &datlen);
-       
-    if (error) {
+       bd_hdrcmplt ? NULL : (struct sockaddr *)dst_buf,
+       &datlen);
+
+       /* take the lock again */
+       lck_mtx_lock(bpf_mlock);
+       if (error) {
+               bpf_release_d(d);
+               lck_mtx_unlock(bpf_mlock);
                return (error);
        }
 
-       /* taking the lock again and verifying whether device is open */
-    lck_mtx_lock(bpf_mlock);
-       d = bpf_dtab[minor(dev)];
-       if (d == 0 || d == (void *)1) {
+       /* verify the device is still open */
+       if ((d->bd_flags & BPF_CLOSING) != 0) {
+               bpf_release_d(d);
                lck_mtx_unlock(bpf_mlock);
                m_freem(m);
                return (ENXIO);
        }
 
        if (d->bd_bif == NULL) {
+               bpf_release_d(d);
                lck_mtx_unlock(bpf_mlock);
                m_free(m);
                return (ENXIO);
        }
 
        if ((unsigned)datlen > ifp->if_mtu) {
+               bpf_release_d(d);
                lck_mtx_unlock(bpf_mlock);
                m_freem(m);
                return (EMSGSIZE);
@@ -1093,21 +1365,28 @@ bpfwrite(dev_t dev, struct uio *uio, __unused int ioflag)
 #if CONFIG_MACF_NET
        mac_mbuf_label_associate_bpfdesc(d, m);
 #endif
+
+       bpf_set_packet_service_class(m, d->bd_traffic_class);
+
        lck_mtx_unlock(bpf_mlock);
 
+       /*
+        * The driver frees the mbuf.
+        */
        if (d->bd_hdrcmplt) {
                if (d->bd_bif->bif_send)
                        error = d->bd_bif->bif_send(ifp, d->bd_bif->bif_dlt, m);
                else
-                       error = dlil_output(ifp, 0, m, NULL, NULL, 1);
-       }
-       else {
-               error = dlil_output(ifp, PF_INET, m, NULL, (struct sockaddr *)dst_buf, 0);
+                       error = dlil_output(ifp, 0, m, NULL, NULL, 1, NULL);
+       } else {
+               error = dlil_output(ifp, PF_INET, m, NULL,
+                   (struct sockaddr *)dst_buf, 0, NULL);
        }
 
-       /*
-        * The driver frees the mbuf.
-        */
+       lck_mtx_lock(bpf_mlock);
+       bpf_release_d(d);
+       lck_mtx_unlock(bpf_mlock);
+
        return (error);
 }
 
@@ -1118,6 +1397,9 @@ bpfwrite(dev_t dev, struct uio *uio, __unused int ioflag)
 static void
 reset_d(struct bpf_d *d)
 {
+       if (d->bd_hbuf_read)
+               panic("resetting buffers during read");
+
        if (d->bd_hbuf) {
                /* Free the hold buffer. */
                d->bd_fbuf = d->bd_hbuf;
@@ -1125,6 +1407,8 @@ reset_d(struct bpf_d *d)
        }
        d->bd_slen = 0;
        d->bd_hlen = 0;
+       d->bd_scnt = 0;
+       d->bd_hcnt = 0;
        d->bd_rcount = 0;
        d->bd_dcount = 0;
 }
@@ -1148,6 +1432,11 @@ reset_d(struct bpf_d *d)
  *  BIOCSHDRCMPLT      Set "header already complete" flag
  *  BIOCGSEESENT       Get "see packets sent" flag
  *  BIOCSSEESENT       Set "see packets sent" flag
+ *  BIOCSETTC          Set traffic class.
+ *  BIOCGETTC          Get traffic class.
+ *  BIOCSEXTHDR                Set "extended header" flag
+ *  BIOCSHEADDROP      Drop head of the buffer if user is not reading
+ *  BIOCGHEADDROP      Get "head-drop" flag
  */
 /* ARGSUSED */
 int
@@ -1156,15 +1445,19 @@ bpfioctl(dev_t dev, u_long cmd, caddr_t addr, __unused int flags,
 {
        struct bpf_d *d;
        int error = 0;
+       u_int int_arg;
+       struct ifreq ifr;
 
        lck_mtx_lock(bpf_mlock);
 
        d = bpf_dtab[minor(dev)];
-       if (d == 0 || d == (void *)1) {
+       if (d == 0 || d == (void *)1 || (d->bd_flags & BPF_CLOSING) != 0) {
                lck_mtx_unlock(bpf_mlock);
                return (ENXIO);
        }
 
+       bpf_acquire_d(d);
+
        if (d->bd_state == BPF_WAITING)
                bpf_stop_timer(d);
        d->bd_state = BPF_IDLE;
@@ -1178,19 +1471,19 @@ bpfioctl(dev_t dev, u_long cmd, caddr_t addr, __unused int flags,
        /*
         * Check for read packet available.
         */
-       case FIONREAD:
+       case FIONREAD:                  /* int */
                {
                        int n;
 
                        n = d->bd_slen;
-                       if (d->bd_hbuf)
+                       if (d->bd_hbuf && d->bd_hbuf_read == 0)
                                n += d->bd_hlen;
 
-                       *(int *)addr = n;
+                       bcopy(&n, addr, sizeof (n));
                        break;
                }
 
-       case SIOCGIFADDR:
+       case SIOCGIFADDR:               /* struct ifreq */
                {
                        struct ifnet *ifp;
 
@@ -1206,44 +1499,49 @@ bpfioctl(dev_t dev, u_long cmd, caddr_t addr, __unused int flags,
        /*
         * Get buffer len [for read()].
         */
-       case BIOCGBLEN:
-               *(u_int *)addr = d->bd_bufsize;
+       case BIOCGBLEN:                 /* u_int */
+               bcopy(&d->bd_bufsize, addr, sizeof (u_int));
                break;
 
        /*
         * Set buffer length.
         */
-       case BIOCSBLEN:
-#if BSD < 199103
-               error = EINVAL;
-#else
+       case BIOCSBLEN:                 /* u_int */
                if (d->bd_bif != 0)
                        error = EINVAL;
                else {
-                       u_int size = *(u_int *)addr;
+                       u_int size;
+
+                       bcopy(addr, &size, sizeof (size));
 
                        if (size > bpf_maxbufsize)
-                               *(u_int *)addr = size = bpf_maxbufsize;
+                               size = bpf_maxbufsize;
                        else if (size < BPF_MINBUFSIZE)
-                               *(u_int *)addr = size = BPF_MINBUFSIZE;
+                               size = BPF_MINBUFSIZE;
+                       bcopy(&size, addr, sizeof (size));
                        d->bd_bufsize = size;
                }
-#endif
                break;
 
        /*
         * Set link layer read filter.
         */
-       case BIOCSETF32: {
-               struct bpf_program32 *prg32 = (struct bpf_program32 *)addr;
-               error = bpf_setf(d, prg32->bf_len,
-                   CAST_USER_ADDR_T(prg32->bf_insns));
+       case BIOCSETF32:
+       case BIOCSETFNR32: {            /* struct bpf_program32 */
+               struct bpf_program32 prg32;
+
+               bcopy(addr, &prg32, sizeof (prg32));
+               error = bpf_setf(d, prg32.bf_len,
+                   CAST_USER_ADDR_T(prg32.bf_insns), cmd);
                break;
        }
 
-       case BIOCSETF64: {
-               struct bpf_program64 *prg64 = (struct bpf_program64 *)addr;
-               error = bpf_setf(d, prg64->bf_len, prg64->bf_insns);
+       case BIOCSETF64:
+       case BIOCSETFNR64: {            /* struct bpf_program64 */
+               struct bpf_program64 prg64;
+
+               bcopy(addr, &prg64, sizeof (prg64));
+               error = bpf_setf(d, prg64.bf_len, prg64.bf_insns, cmd);
                break;
        }
 
@@ -1251,6 +1549,13 @@ bpfioctl(dev_t dev, u_long cmd, caddr_t addr, __unused int flags,
         * Flush read packet buffer.
         */
        case BIOCFLUSH:
+               while (d->bd_hbuf_read) {
+                       msleep((caddr_t)d, bpf_mlock, PRINET, "bpf_reading", NULL);
+               }
+               if ((d->bd_flags & BPF_CLOSING) != 0) {
+                       error = ENXIO;
+                       break;
+               }
                reset_d(d);
                break;
 
@@ -1277,56 +1582,61 @@ bpfioctl(dev_t dev, u_long cmd, caddr_t addr, __unused int flags,
        /*
         * Get device parameters.
         */
-       case BIOCGDLT:
+       case BIOCGDLT:                  /* u_int */
                if (d->bd_bif == 0)
                        error = EINVAL;
                else
-                       *(u_int *)addr = d->bd_bif->bif_dlt;
+                       bcopy(&d->bd_bif->bif_dlt, addr, sizeof (u_int));
                break;
 
        /*
         * Get a list of supported data link types.
         */
-       case BIOCGDLTLIST:
+       case BIOCGDLTLIST:              /* struct bpf_dltlist */
                if (d->bd_bif == NULL) {
                        error = EINVAL;
                } else {
-                       error = bpf_getdltlist(d,
-                           (struct bpf_dltlist *)addr, p);
+                       error = bpf_getdltlist(d, addr, p);
                }
                break;
 
        /*
         * Set data link type.
         */
-       case BIOCSDLT:
-                       if (d->bd_bif == NULL)
-                                       error = EINVAL;
-                       else
-                                       error = bpf_setdlt(d, *(u_int *)addr);
-                       break;
+       case BIOCSDLT:                  /* u_int */
+               if (d->bd_bif == NULL) {
+                       error = EINVAL;
+               } else {
+                       u_int dlt;
+
+                       bcopy(addr, &dlt, sizeof (dlt));
+                       error = bpf_setdlt(d, dlt);
+               }
+               break;
 
        /*
         * Get interface name.
         */
-       case BIOCGETIF:
+       case BIOCGETIF:                 /* struct ifreq */
                if (d->bd_bif == 0)
                        error = EINVAL;
                else {
                        struct ifnet *const ifp = d->bd_bif->bif_ifp;
-                       struct ifreq *const ifr = (struct ifreq *)addr;
 
-                       snprintf(ifr->ifr_name, sizeof(ifr->ifr_name),
-                           "%s%d", ifp->if_name, ifp->if_unit);
+                       snprintf(((struct ifreq *)(void *)addr)->ifr_name,
+                           sizeof (ifr.ifr_name), "%s", if_name(ifp));
                }
                break;
 
        /*
         * Set interface.
         */
-       case BIOCSETIF: {
+       case BIOCSETIF: {               /* struct ifreq */
                ifnet_t ifp;
-               ifp = ifunit(((struct ifreq *)addr)->ifr_name);
+
+               bcopy(addr, &ifr, sizeof (ifr));
+               ifr.ifr_name[IFNAMSIZ - 1] = '\0';
+               ifp = ifunit(ifr.ifr_name);
                if (ifp == NULL)
                        error = ENXIO;
                else
@@ -1337,122 +1647,145 @@ bpfioctl(dev_t dev, u_long cmd, caddr_t addr, __unused int flags,
        /*
         * Set read timeout.
         */
-        case BIOCSRTIMEOUT32:
-                {
-                       struct user32_timeval *_tv = (struct user32_timeval *)addr;
-                       struct timeval tv;
+       case BIOCSRTIMEOUT32: {         /* struct user32_timeval */
+               struct user32_timeval _tv;
+               struct timeval tv;
 
-                       tv.tv_sec  = _tv->tv_sec;
-                       tv.tv_usec = _tv->tv_usec;
+               bcopy(addr, &_tv, sizeof (_tv));
+               tv.tv_sec  = _tv.tv_sec;
+               tv.tv_usec = _tv.tv_usec;
 
-                        /*
-                        * Subtract 1 tick from tvtohz() since this isn't
-                        * a one-shot timer.
-                        */
-                       if ((error = itimerfix(&tv)) == 0)
-                               d->bd_rtout = tvtohz(&tv) - 1;
-                       break;
-                }
-
-        case BIOCSRTIMEOUT64:
-                {
-                       struct user64_timeval *_tv = (struct user64_timeval *)addr;
-                       struct timeval tv;
-                        
-                       tv.tv_sec  = _tv->tv_sec;
-                       tv.tv_usec = _tv->tv_usec;
-                        
-                       /*
-                        * Subtract 1 tick from tvtohz() since this isn't
-                        * a one-shot timer.
-                        */
-                       if ((error = itimerfix(&tv)) == 0)
-                               d->bd_rtout = tvtohz(&tv) - 1;
-                       break;
-                }
-       
-        /*
+               /*
+                * Subtract 1 tick from tvtohz() since this isn't
+                * a one-shot timer.
+                */
+               if ((error = itimerfix(&tv)) == 0)
+                       d->bd_rtout = tvtohz(&tv) - 1;
+               break;
+       }
+
+       case BIOCSRTIMEOUT64: {         /* struct user64_timeval */
+               struct user64_timeval _tv;
+               struct timeval tv;
+
+               bcopy(addr, &_tv, sizeof (_tv));
+               tv.tv_sec  = _tv.tv_sec;
+               tv.tv_usec = _tv.tv_usec;
+
+               /*
+                * Subtract 1 tick from tvtohz() since this isn't
+                * a one-shot timer.
+                */
+               if ((error = itimerfix(&tv)) == 0)
+                       d->bd_rtout = tvtohz(&tv) - 1;
+               break;
+       }
+
+       /*
         * Get read timeout.
         */
-       case BIOCGRTIMEOUT32:
-               {
-                       struct user32_timeval *tv = (struct user32_timeval *)addr;
+       case BIOCGRTIMEOUT32: {         /* struct user32_timeval */
+               struct user32_timeval tv;
 
-                       tv->tv_sec = d->bd_rtout / hz;
-                       tv->tv_usec = (d->bd_rtout % hz) * tick;
-                       break;
-                }
+               bzero(&tv, sizeof (tv));
+               tv.tv_sec = d->bd_rtout / hz;
+               tv.tv_usec = (d->bd_rtout % hz) * tick;
+               bcopy(&tv, addr, sizeof (tv));
+               break;
+       }
 
-       case BIOCGRTIMEOUT64:
-               {
-                       struct user64_timeval *tv = (struct user64_timeval *)addr;
+       case BIOCGRTIMEOUT64: {         /* struct user64_timeval */
+               struct user64_timeval tv;
 
-                       tv->tv_sec = d->bd_rtout / hz;
-                       tv->tv_usec = (d->bd_rtout % hz) * tick;
-                       break;
-                }
+               bzero(&tv, sizeof (tv));
+               tv.tv_sec = d->bd_rtout / hz;
+               tv.tv_usec = (d->bd_rtout % hz) * tick;
+               bcopy(&tv, addr, sizeof (tv));
+               break;
+       }
 
        /*
         * Get packet stats.
         */
-       case BIOCGSTATS:
-               {
-                       struct bpf_stat *bs = (struct bpf_stat *)addr;
+       case BIOCGSTATS: {              /* struct bpf_stat */
+               struct bpf_stat bs;
 
-                       bs->bs_recv = d->bd_rcount;
-                       bs->bs_drop = d->bd_dcount;
-                       break;
-               }
+               bzero(&bs, sizeof (bs));
+               bs.bs_recv = d->bd_rcount;
+               bs.bs_drop = d->bd_dcount;
+               bcopy(&bs, addr, sizeof (bs));
+               break;
+       }
 
        /*
         * Set immediate mode.
         */
-       case BIOCIMMEDIATE:
-               d->bd_immediate = *(u_int *)addr;
+       case BIOCIMMEDIATE:             /* u_int */
+               d->bd_immediate = *(u_int *)(void *)addr;
                break;
 
-       case BIOCVERSION:
-               {
-                       struct bpf_version *bv = (struct bpf_version *)addr;
+       case BIOCVERSION: {             /* struct bpf_version */
+               struct bpf_version bv;
 
-                       bv->bv_major = BPF_MAJOR_VERSION;
-                       bv->bv_minor = BPF_MINOR_VERSION;
-                       break;
-               }
+               bzero(&bv, sizeof (bv));
+               bv.bv_major = BPF_MAJOR_VERSION;
+               bv.bv_minor = BPF_MINOR_VERSION;
+               bcopy(&bv, addr, sizeof (bv));
+               break;
+       }
 
        /*
         * Get "header already complete" flag
         */
-       case BIOCGHDRCMPLT:
-               *(u_int *)addr = d->bd_hdrcmplt;
+       case BIOCGHDRCMPLT:             /* u_int */
+               bcopy(&d->bd_hdrcmplt, addr, sizeof (u_int));
                break;
 
        /*
         * Set "header already complete" flag
         */
-       case BIOCSHDRCMPLT:
-               d->bd_hdrcmplt = *(u_int *)addr ? 1 : 0;
+       case BIOCSHDRCMPLT:             /* u_int */
+               bcopy(addr, &int_arg, sizeof (int_arg));
+               d->bd_hdrcmplt = int_arg ? 1 : 0;
                break;
 
        /*
         * Get "see sent packets" flag
         */
-       case BIOCGSEESENT:
-               *(u_int *)addr = d->bd_seesent;
+       case BIOCGSEESENT:              /* u_int */
+               bcopy(&d->bd_seesent, addr, sizeof (u_int));
                break;
 
        /*
         * Set "see sent packets" flag
         */
-       case BIOCSSEESENT:
-               d->bd_seesent = *(u_int *)addr;
+       case BIOCSSEESENT:              /* u_int */
+               bcopy(addr, &d->bd_seesent, sizeof (u_int));
                break;
 
-       case FIONBIO:           /* Non-blocking I/O */
+       /*
+        * Set traffic service class
+        */
+       case BIOCSETTC: {               /* int */
+               int tc;
+
+               bcopy(addr, &tc, sizeof (int));
+               error = bpf_set_traffic_class(d, tc);
+               break;
+       }
+
+       /*
+        * Get traffic service class
+        */
+       case BIOCGETTC:                 /* int */
+               bcopy(&d->bd_traffic_class, addr, sizeof (int));
+               break;
+
+       case FIONBIO:           /* Non-blocking I/O; int */
                break;
 
-       case FIOASYNC:          /* Send signal on receive packets */
-               d->bd_async = *(int *)addr;
+       case FIOASYNC:          /* Send signal on receive packets; int */
+               bcopy(addr, &d->bd_async, sizeof (int));
                break;
 #ifndef __APPLE__
        case FIOSETOWN:
@@ -1473,23 +1806,78 @@ bpfioctl(dev_t dev, u_long cmd, caddr_t addr, __unused int flags,
                *(int *)addr = -fgetown(d->bd_sigio);
                break;
 #endif
-       case BIOCSRSIG:         /* Set receive signal */
-               {
-                       u_int sig;
+       case BIOCSRSIG: {       /* Set receive signal; u_int */
+               u_int sig;
 
-                       sig = *(u_int *)addr;
+               bcopy(addr, &sig, sizeof (u_int));
 
-                       if (sig >= NSIG)
-                               error = EINVAL;
-                       else
-                               d->bd_sig = sig;
+               if (sig >= NSIG)
+                       error = EINVAL;
+               else
+                       d->bd_sig = sig;
+               break;
+       }
+       case BIOCGRSIG:                 /* u_int */
+               bcopy(&d->bd_sig, addr, sizeof (u_int));
+               break;
+#ifdef __APPLE__
+       case BIOCSEXTHDR:               /* u_int */
+               bcopy(addr, &int_arg, sizeof (int_arg));
+               if (int_arg)
+                       d->bd_flags |= BPF_EXTENDED_HDR;
+               else
+                       d->bd_flags &= ~BPF_EXTENDED_HDR;
+               break;
+
+       case BIOCGIFATTACHCOUNT: {              /* struct ifreq */
+               ifnet_t ifp;
+               struct bpf_if *bp;
+
+               bcopy(addr, &ifr, sizeof (ifr));
+               ifr.ifr_name[IFNAMSIZ - 1] = '\0';
+               ifp = ifunit(ifr.ifr_name);
+               if (ifp == NULL) {
+                       error = ENXIO;
                        break;
                }
-       case BIOCGRSIG:
-               *(u_int *)addr = d->bd_sig;
+               ifr.ifr_intval = 0;
+               for (bp = bpf_iflist; bp != 0; bp = bp->bif_next) {
+                       struct bpf_d *bpf_d;
+                       
+                       if (bp->bif_ifp == NULL || bp->bif_ifp != ifp)
+                               continue;
+                       for (bpf_d = bp->bif_dlist; bpf_d; bpf_d = bpf_d->bd_next) {
+                               ifr.ifr_intval += 1;
+                       }
+               }
+               bcopy(&ifr, addr, sizeof (ifr));
                break;
        }
-       
+       case BIOCGWANTPKTAP:                    /* u_int */
+               int_arg = d->bd_flags & BPF_WANT_PKTAP ? 1 : 0;
+               bcopy(&int_arg, addr, sizeof (int_arg));
+               break;
+
+       case BIOCSWANTPKTAP:                    /* u_int */
+                bcopy(addr, &int_arg, sizeof (int_arg));
+                if (int_arg)
+                        d->bd_flags |= BPF_WANT_PKTAP;
+                else
+                        d->bd_flags &= ~BPF_WANT_PKTAP;
+               break;
+#endif
+
+       case BIOCSHEADDROP:
+               bcopy(addr, &int_arg, sizeof (int_arg));
+               d->bd_headdrop = int_arg ? 1 : 0;
+               break;
+
+       case BIOCGHEADDROP:
+               bcopy(&d->bd_headdrop, addr, sizeof (int));
+               break;
+       }
+
+       bpf_release_d(d);
        lck_mtx_unlock(bpf_mlock);
 
        return (error);
@@ -1500,11 +1888,18 @@ bpfioctl(dev_t dev, u_long cmd, caddr_t addr, __unused int flags,
  * free it and replace it.  Returns EINVAL for bogus requests.
  */
 static int
-bpf_setf(struct bpf_d *d, u_int bf_len, user_addr_t bf_insns)
+bpf_setf(struct bpf_d *d, u_int bf_len, user_addr_t bf_insns,
+    u_long cmd)
 {
        struct bpf_insn *fcode, *old;
        u_int flen, size;
 
+       while (d->bd_hbuf_read) 
+               msleep((caddr_t)d, bpf_mlock, PRINET, "bpf_reading", NULL);
+
+       if ((d->bd_flags & BPF_CLOSING) != 0)
+               return (ENXIO);
+       
        old = d->bd_filter;
        if (bf_insns == USER_ADDR_NULL) {
                if (bf_len != 0)
@@ -1528,7 +1923,10 @@ bpf_setf(struct bpf_d *d, u_int bf_len, user_addr_t bf_insns)
        if (copyin(bf_insns, (caddr_t)fcode, size) == 0 &&
            bpf_validate(fcode, (int)flen)) {
                d->bd_filter = fcode;
-               reset_d(d);
+       
+               if (cmd == BIOCSETF32 || cmd == BIOCSETF64)
+                       reset_d(d);
+       
                if (old != 0)
                        FREE((caddr_t)old, M_DEVBUF);
 
@@ -1548,7 +1946,13 @@ bpf_setif(struct bpf_d *d, ifnet_t theywant, u_int32_t dlt)
 {
        struct bpf_if *bp;
        int error;
-       
+
+       while (d->bd_hbuf_read)
+               msleep((caddr_t)d, bpf_mlock, PRINET, "bpf_reading", NULL);
+
+       if ((d->bd_flags & BPF_CLOSING) != 0)
+               return (ENXIO);
+
        /*
         * Look through attached interfaces for the named one.
         */
@@ -1557,6 +1961,13 @@ bpf_setif(struct bpf_d *d, ifnet_t theywant, u_int32_t dlt)
 
                if (ifp == 0 || ifp != theywant || (dlt != 0 && dlt != bp->bif_dlt))
                        continue;
+               /*
+                * If the process knows how to deal with DLT_PKTAP, use it
+                * by default
+                */
+               if (dlt == 0 && bp->bif_dlt == DLT_PKTAP &&
+                       !(d->bd_flags & BPF_WANT_PKTAP))
+                       continue;
                /*
                 * We found the requested interface.
                 * Allocate the packet buffers if we need to.
@@ -1569,15 +1980,15 @@ bpf_setif(struct bpf_d *d, ifnet_t theywant, u_int32_t dlt)
                                return (error);
                }
                if (bp != d->bd_bif) {
-                       if (d->bd_bif)
                                /*
                                 * Detach if attached to something else.
                                 */
-                               bpf_detachd(d);
-
-                       if (bpf_attachd(d, bp) != 0) {
-                               return ENXIO;
+                       if (d->bd_bif) {
+                               if (bpf_detachd(d, 0) != 0)
+                                       return (ENXIO);
                        }
+                       if (bpf_attachd(d, bp) != 0)
+                               return (ENXIO);
                }
                reset_d(d);
                return (0);
@@ -1592,37 +2003,49 @@ bpf_setif(struct bpf_d *d, ifnet_t theywant, u_int32_t dlt)
  * Get a list of available data link type of the interface.
  */
 static int
-bpf_getdltlist(struct bpf_d *d, struct bpf_dltlist *bfl, struct proc *p)
+bpf_getdltlist(struct bpf_d *d, caddr_t addr, struct proc *p)
 {
        u_int           n;
        int             error;
        struct ifnet    *ifp;
        struct bpf_if   *bp;
        user_addr_t     dlist;
+       struct bpf_dltlist bfl;
 
+       bcopy(addr, &bfl, sizeof (bfl));
        if (proc_is64bit(p)) {
-               dlist = (user_addr_t)bfl->bfl_u.bflu_pad;
+               dlist = (user_addr_t)bfl.bfl_u.bflu_pad;
        } else {
-               dlist = CAST_USER_ADDR_T(bfl->bfl_u.bflu_list);
+               dlist = CAST_USER_ADDR_T(bfl.bfl_u.bflu_list);
        }
 
        ifp = d->bd_bif->bif_ifp;
        n = 0;
        error = 0;
+
        for (bp = bpf_iflist; bp; bp = bp->bif_next) {
                if (bp->bif_ifp != ifp)
                        continue;
+               /* 
+                * Return DLT_PKTAP only to processes that know how to handle it
+                */
+               if (bp->bif_dlt == DLT_PKTAP && !(d->bd_flags & BPF_WANT_PKTAP))
+                       continue;
                if (dlist != USER_ADDR_NULL) {
-                       if (n >= bfl->bfl_len) {
+                       if (n >= bfl.bfl_len) {
                                return (ENOMEM);
                        }
                        error = copyout(&bp->bif_dlt, dlist,
                            sizeof (bp->bif_dlt));
+                       if (error != 0)
+                               break;
                        dlist += sizeof (bp->bif_dlt);
                }
                n++;
        }
-       bfl->bfl_len = n;
+       bfl.bfl_len = n;
+       bcopy(&bfl, addr, sizeof (bfl));
+
        return (error);
 }
 
@@ -1631,8 +2054,6 @@ bpf_getdltlist(struct bpf_d *d, struct bpf_dltlist *bfl, struct proc *p)
  */
 static int
 bpf_setdlt(struct bpf_d *d, uint32_t dlt)
-       
-
 {
        int error, opromisc;
        struct ifnet *ifp;
@@ -1640,6 +2061,13 @@ bpf_setdlt(struct bpf_d *d, uint32_t dlt)
        
        if (d->bd_bif->bif_dlt == dlt)
                return (0);
+       
+       while (d->bd_hbuf_read)
+               msleep((caddr_t)d, bpf_mlock, PRINET, "bpf_reading", NULL);
+
+       if ((d->bd_flags & BPF_CLOSING) != 0)
+               return (ENXIO);
+
        ifp = d->bd_bif->bif_ifp;
        for (bp = bpf_iflist; bp; bp = bp->bif_next) {
                if (bp->bif_ifp == ifp && bp->bif_dlt == dlt)
@@ -1647,7 +2075,8 @@ bpf_setdlt(struct bpf_d *d, uint32_t dlt)
        }
        if (bp != NULL) {
                opromisc = d->bd_promisc;
-               bpf_detachd(d);
+               if (bpf_detachd(d, 0) != 0)
+                       return (ENXIO);
                error = bpf_attachd(d, bp);
                if (error) {
                        printf("bpf_setdlt: bpf_attachd %s%d failed (%d)\n",
@@ -1659,16 +2088,41 @@ bpf_setdlt(struct bpf_d *d, uint32_t dlt)
                        lck_mtx_unlock(bpf_mlock);
                        error = ifnet_set_promiscuous(bp->bif_ifp, 1);
                        lck_mtx_lock(bpf_mlock);
-                       if (error)
-                               printf("bpf_setdlt: ifpromisc %s%d failed (%d)\n",
-                                          ifnet_name(bp->bif_ifp), ifnet_unit(bp->bif_ifp), error);
-                       else
+                       if (error) {
+                               printf("%s: ifpromisc %s%d failed (%d)\n",
+                                   __func__, ifnet_name(bp->bif_ifp),
+                                   ifnet_unit(bp->bif_ifp), error);
+                       } else {
                                d->bd_promisc = 1;
+                       }
                }
        }
        return (bp == NULL ? EINVAL : 0);
 }
 
+static int
+bpf_set_traffic_class(struct bpf_d *d, int tc)
+{
+       int error = 0;
+
+       if (!SO_VALID_TC(tc))
+               error = EINVAL;
+       else
+               d->bd_traffic_class = tc;
+
+       return (error);
+}
+
+static void
+bpf_set_packet_service_class(struct mbuf *m, int tc)
+{
+       if (!(m->m_flags & M_PKTHDR))
+               return;
+
+       VERIFY(SO_VALID_TC(tc));
+       (void) m_set_service_class(m, so_tc2msc(tc));
+}
+
 /*
  * Support for select()
  *
@@ -1684,12 +2138,24 @@ bpfselect(dev_t dev, int which, void * wql, struct proc *p)
        lck_mtx_lock(bpf_mlock);
 
        d = bpf_dtab[minor(dev)];
-       if (d == 0 || d == (void *)1) {
+       if (d == 0 || d == (void *)1 || (d->bd_flags & BPF_CLOSING) != 0) {
                lck_mtx_unlock(bpf_mlock);
                return (ENXIO);
        }
 
+       bpf_acquire_d(d);
+
        if (d->bd_bif == NULL) {
+               bpf_release_d(d);
+               lck_mtx_unlock(bpf_mlock);
+               return (ENXIO);
+       }
+
+       while (d->bd_hbuf_read) 
+               msleep((caddr_t)d, bpf_mlock, PRINET, "bpf_reading", NULL);
+
+       if ((d->bd_flags & BPF_CLOSING) != 0) {
+               bpf_release_d(d);
                lck_mtx_unlock(bpf_mlock);
                return (ENXIO);
        }
@@ -1716,7 +2182,9 @@ bpfselect(dev_t dev, int which, void * wql, struct proc *p)
                        break;
        }
 
+       bpf_release_d(d);
        lck_mtx_unlock(bpf_mlock);
+
        return (ret);
 }
 
@@ -1754,7 +2222,7 @@ bpfkqfilter(dev_t dev, struct knote *kn)
        lck_mtx_lock(bpf_mlock);
 
        d = bpf_dtab[minor(dev)];
-       if (d == 0 || d == (void *)1) {
+       if (d == 0 || d == (void *)1 || (d->bd_flags & BPF_CLOSING) != 0) {
                lck_mtx_unlock(bpf_mlock);
                return (ENXIO);
        }
@@ -1767,8 +2235,10 @@ bpfkqfilter(dev_t dev, struct knote *kn)
        kn->kn_hook = d;
        kn->kn_fop = &bpfread_filtops;
        KNOTE_ATTACH(&d->bd_sel.si_note, kn);
+       d->bd_flags |= BPF_KNOTE;
+
        lck_mtx_unlock(bpf_mlock);
-       return 0;
+       return (0);
 }
 
 static void
@@ -1777,7 +2247,10 @@ filt_bpfdetach(struct knote *kn)
        struct bpf_d *d = (struct bpf_d *)kn->kn_hook;
 
        lck_mtx_lock(bpf_mlock);
-       KNOTE_DETACH(&d->bd_sel.si_note, kn);
+       if (d->bd_flags & BPF_KNOTE) {
+               KNOTE_DETACH(&d->bd_sel.si_note, kn);
+               d->bd_flags &= ~BPF_KNOTE;
+       }
        lck_mtx_unlock(bpf_mlock);
 }
 
@@ -1789,7 +2262,7 @@ filt_bpfread(struct knote *kn, long hint)
 
        if (hint == 0)
                lck_mtx_lock(bpf_mlock);
-
+       
        if (d->bd_immediate) {
                /*
                 * If there's data in the hold buffer, it's the 
@@ -1805,7 +2278,8 @@ filt_bpfread(struct knote *kn, long hint)
                 * If there's no data in either buffer, we're not 
                 * ready to read.
                 */
-               kn->kn_data = (d->bd_hlen == 0 ? d->bd_slen : d->bd_hlen);
+               kn->kn_data = ((d->bd_hlen == 0  || d->bd_hbuf_read) 
+                   ? d->bd_slen : d->bd_hlen);
                int64_t lowwat = 1;
                if (kn->kn_sfflags & NOTE_LOWAT)
                {
@@ -1831,7 +2305,7 @@ filt_bpfread(struct knote *kn, long hint)
                 * no data in the hold buffer and the timer hasn't 
                 * expired, we're not ready to read.
                 */
-               kn->kn_data = (d->bd_hlen == 0 && d->bd_state == BPF_TIMED_OUT ? 
+               kn->kn_data = ((d->bd_hlen == 0 || d->bd_hbuf_read) && d->bd_state == BPF_TIMED_OUT ? 
                                d->bd_slen : d->bd_hlen);
                ready = (kn->kn_data > 0);
        }
@@ -1843,17 +2317,6 @@ filt_bpfread(struct knote *kn, long hint)
        return (ready);
 }
 
-static inline void*
-_cast_non_const(const void * ptr) {
-       union {
-               const void*             cval;
-               void*                   val;
-       } ret;
-       
-       ret.cval = ptr;
-       return (ret.val);
-}
-
 /*
  * Copy data from an mbuf chain into a buffer.  This code is derived
  * from m_copydata in sys/uipc_mbuf.c.
@@ -1861,7 +2324,7 @@ _cast_non_const(const void * ptr) {
 static void
 bpf_mcopy(const void *src_arg, void *dst_arg, size_t len)
 {
-       struct mbuf *m = _cast_non_const(src_arg);
+       struct mbuf *m = (struct mbuf *)(uintptr_t)(src_arg);
        u_int count;
        u_char *dst;
 
@@ -1884,9 +2347,10 @@ bpf_tap_imp(
        mbuf_t          m,
        void*           hdr,
        size_t          hlen,
-       int                     outbound)
+       int             outbound)
 {
        struct bpf_if *bp;
+       struct mbuf *savedm = m;
 
        /*
         * It's possible that we get here after the bpf descriptor has been
@@ -1937,7 +2401,7 @@ bpf_tap_imp(
                        hack_hdr.mh_type = m->m_type;
                        hack_hdr.mh_flags = 0;
                        
-                       m = (mbuf_t)&hack_hdr;
+                       __IGNORE_WCASTALIGN(m = (mbuf_t)&hack_hdr);
                }
 
                for (m0 = m; m0 != 0; m0 = m0->m_next)
@@ -1953,7 +2417,8 @@ bpf_tap_imp(
                                if (mac_bpfdesc_check_receive(d, bp->bif_ifp) != 0)
                                        continue;
 #endif
-                               catchpacket(d, (u_char *)m, pktlen, slen, bpf_mcopy);
+                               catchpacket(d, (u_char *)m, savedm, pktlen,
+                                   slen, outbound, bpf_mcopy);
                        }
                }
        }
@@ -1999,13 +2464,22 @@ static int bpf_tap_callback(struct ifnet *ifp, struct mbuf *m)
  * pkt is really an mbuf.
  */
 static void
-catchpacket(struct bpf_d *d, u_char *pkt, u_int pktlen, u_int snaplen, 
+catchpacket(struct bpf_d *d, u_char *pkt, struct mbuf *m, u_int pktlen,
+       u_int snaplen, int outbound,
        void (*cpfn)(const void *, void *, size_t))
 {
        struct bpf_hdr *hp;
+       struct bpf_hdr_ext *ehp;
        int totlen, curlen;
-       int hdrlen = d->bd_bif->bif_hdrlen;
+       int hdrlen, caplen;
        int do_wakeup = 0;
+       u_char *payload;
+       struct timeval tv;
+       struct m_tag *mt = NULL;
+       struct bpf_mtag *bt = NULL;
+
+       hdrlen = (d->bd_flags & BPF_EXTENDED_HDR) ? d->bd_bif->bif_exthdrlen :
+           d->bd_bif->bif_hdrlen;
        /*
         * Figure out how many bytes to move.  If the packet is
         * greater or equal to the snapshot length, transfer that
@@ -2027,14 +2501,23 @@ catchpacket(struct bpf_d *d, u_char *pkt, u_int pktlen, u_int snaplen,
                 * pending reads.
                 */
                if (d->bd_fbuf == NULL) {
+                       if (d->bd_headdrop == 0) {
+                               /*
+                                * We haven't completed the previous read yet,
+                                * so drop the packet.
+                                */
+                               ++d->bd_dcount;
+                               return;
+                       }
                        /*
-                        * We haven't completed the previous read yet,
-                        * so drop the packet.
+                        * Drop the hold buffer as it contains older packets
                         */
-                       ++d->bd_dcount;
-                       return;
+                       d->bd_dcount += d->bd_hcnt;
+                       d->bd_fbuf = d->bd_hbuf;
+                       ROTATE_BUFFERS(d);
+               } else {
+                       ROTATE_BUFFERS(d);
                }
-               ROTATE_BUFFERS(d);
                do_wakeup = 1;
                curlen = 0;
        }
@@ -2049,18 +2532,58 @@ catchpacket(struct bpf_d *d, u_char *pkt, u_int pktlen, u_int snaplen,
        /*
         * Append the bpf header.
         */
-       hp = (struct bpf_hdr *)(d->bd_sbuf + curlen);
-       struct timeval tv;
        microtime(&tv);
-       hp->bh_tstamp.tv_sec = tv.tv_sec;
-       hp->bh_tstamp.tv_usec = tv.tv_usec;
-       hp->bh_datalen = pktlen;
-       hp->bh_hdrlen = hdrlen;
+       if (d->bd_flags & BPF_EXTENDED_HDR) {
+               ehp = (struct bpf_hdr_ext *)(void *)(d->bd_sbuf + curlen);
+               memset(ehp, 0, sizeof(*ehp));
+               ehp->bh_tstamp.tv_sec = tv.tv_sec;
+               ehp->bh_tstamp.tv_usec = tv.tv_usec;
+               ehp->bh_datalen = pktlen;
+               ehp->bh_hdrlen = hdrlen;
+               ehp->bh_caplen = totlen - hdrlen;
+               mt = m_tag_locate(m, bpf_mtag_id, 0, NULL);
+               if (mt && mt->m_tag_len >= sizeof(*bt)) {
+                       bt = (struct bpf_mtag *)(mt + 1);
+                       ehp->bh_pid = bt->bt_pid;
+                       strlcpy(ehp->bh_comm, bt->bt_comm,
+                           sizeof(ehp->bh_comm));
+                       ehp->bh_svc = so_svc2tc(bt->bt_svc);
+                       if (bt->bt_direction == BPF_MTAG_DIR_OUT)
+                               ehp->bh_flags |= BPF_HDR_EXT_FLAGS_DIR_OUT;
+                       else
+                               ehp->bh_flags |= BPF_HDR_EXT_FLAGS_DIR_IN;
+                       m_tag_delete(m, mt);
+               } else if (outbound) {
+                       /* only do lookups on non-raw INPCB */
+                       if ((m->m_pkthdr.pkt_flags & (PKTF_FLOW_ID|
+                           PKTF_FLOW_LOCALSRC|PKTF_FLOW_RAWSOCK)) ==
+                           (PKTF_FLOW_ID|PKTF_FLOW_LOCALSRC) &&
+                           m->m_pkthdr.pkt_flowsrc == FLOWSRC_INPCB) {
+                               ehp->bh_flowid = m->m_pkthdr.pkt_flowid;
+                               ehp->bh_proto = m->m_pkthdr.pkt_proto;
+                       }
+                       ehp->bh_svc = so_svc2tc(m->m_pkthdr.pkt_svc);
+                       ehp->bh_flags |= BPF_HDR_EXT_FLAGS_DIR_OUT;
+               } else
+                       ehp->bh_flags |= BPF_HDR_EXT_FLAGS_DIR_IN;
+               payload = (u_char *)ehp + hdrlen;
+               caplen = ehp->bh_caplen;
+       } else {
+               hp = (struct bpf_hdr *)(void *)(d->bd_sbuf + curlen);
+               hp->bh_tstamp.tv_sec = tv.tv_sec;
+               hp->bh_tstamp.tv_usec = tv.tv_usec;
+               hp->bh_datalen = pktlen;
+               hp->bh_hdrlen = hdrlen;
+               hp->bh_caplen = totlen - hdrlen;
+               payload = (u_char *)hp + hdrlen;
+               caplen = hp->bh_caplen;
+       }
        /*
         * Copy the packet data into the store buffer and update its length.
         */
-       (*cpfn)(pkt, (u_char *)hp + hdrlen, (hp->bh_caplen = totlen - hdrlen));
+       (*cpfn)(pkt, payload, caplen);
        d->bd_slen = curlen + totlen;
+       d->bd_scnt += 1;
 
        if (do_wakeup)
                bpf_wakeup(d);
@@ -2083,6 +2606,8 @@ bpf_allocbufs(struct bpf_d *d)
        }
        d->bd_slen = 0;
        d->bd_hlen = 0;
+       d->bd_scnt = 0;
+       d->bd_hcnt = 0;
        return (0);
 }
 
@@ -2098,9 +2623,12 @@ bpf_freed(struct bpf_d *d)
         * been detached from its interface and it yet hasn't been marked
         * free.
         */
+       if (d->bd_hbuf_read)
+               panic("bpf buffer freed during read");
+
        if (d->bd_sbuf != 0) {
                FREE(d->bd_sbuf, M_DEVBUF);
-               if (d->bd_hbuf != 0)
+               if (d->bd_hbuf != 0) 
                        FREE(d->bd_hbuf, M_DEVBUF);
                if (d->bd_fbuf != 0)
                        FREE(d->bd_fbuf, M_DEVBUF);
@@ -2132,7 +2660,8 @@ bpf_attach(
        struct bpf_if *bp_temp;
        struct bpf_if *bp_first = NULL;
        
-       bp_new = (struct bpf_if *) _MALLOC(sizeof(*bp_new), M_DEVBUF, M_WAIT);
+       bp_new = (struct bpf_if *) _MALLOC(sizeof(*bp_new), M_DEVBUF,
+           M_WAIT | M_ZERO);
        if (bp_new == 0)
                panic("bpfattach");
 
@@ -2149,14 +2678,13 @@ bpf_attach(
        }
        
        if (bp_temp != NULL) {
-               printf("bpfattach - %s%d with dlt %d is already attached\n",
-                       ifp->if_name, ifp->if_unit, dlt);
+               printf("bpfattach - %s with dlt %d is already attached\n",
+                       if_name(ifp), dlt);
                FREE(bp_new, M_DEVBUF);
                lck_mtx_unlock(bpf_mlock);
                return EEXIST;
        }
        
-       bzero(bp_new, sizeof(*bp_new));
        bp_new->bif_ifp = ifp;
        bp_new->bif_dlt = dlt;
        bp_new->bif_send = send;
@@ -2180,6 +2708,8 @@ bpf_attach(
         * performance reasons and to alleviate alignment restrictions).
         */
        bp_new->bif_hdrlen = BPF_WORDALIGN(hdrlen + SIZEOF_BPF_HDR) - hdrlen;
+       bp_new->bif_exthdrlen = BPF_WORDALIGN(hdrlen +
+           sizeof(struct bpf_hdr_ext)) - hdrlen;
        
        /* Take a reference on the interface */
        ifnet_reference(ifp);
@@ -2188,7 +2718,7 @@ bpf_attach(
 
 #ifndef __APPLE__
        if (bootverbose)
-               printf("bpf: %s%d attached\n", ifp->if_name, ifp->if_unit);
+               printf("bpf: %s attached\n", if_name(ifp));
 #endif
 
        return 0;
@@ -2204,42 +2734,49 @@ void
 bpfdetach(struct ifnet *ifp)
 {
        struct bpf_if   *bp, *bp_prev, *bp_next;
-       struct bpf_if   *bp_free = NULL;
        struct bpf_d    *d;
 
-       
+       if (bpf_debug != 0)
+               printf("%s: %s\n",
+                   __func__, if_name(ifp));
+
        lck_mtx_lock(bpf_mlock);
 
-       /* Locate BPF interface information */
+       /*
+        * Build the list of devices attached to that interface
+        * that we need to free while keeping the lock to maintain
+        * the integrity of the interface list
+        */
        bp_prev = NULL;
        for (bp = bpf_iflist; bp != NULL; bp = bp_next) {
                bp_next = bp->bif_next;
+
                if (ifp != bp->bif_ifp) {
                        bp_prev = bp;
                        continue;
                }
-               
-               while ((d = bp->bif_dlist) != NULL) {
-                       bpf_detachd(d);
-                       bpf_wakeup(d);
-               }
-       
-               if (bp_prev) {
+               /* Unlink from the interface list */
+               if (bp_prev)
                        bp_prev->bif_next = bp->bif_next;
-               } else {
+               else
                        bpf_iflist = bp->bif_next;
+
+               /* Detach the devices attached to the interface */
+               while ((d = bp->bif_dlist) != NULL) {
+                       /*
+                        * Take an extra reference to prevent the device
+                        * from being freed when bpf_detachd() releases
+                        * the reference for the interface list
+                        */
+                       bpf_acquire_d(d);
+                       bpf_detachd(d, 0);
+                       bpf_wakeup(d);
+                       bpf_release_d(d);
                }
-               
-               bp->bif_next = bp_free;
-               bp_free = bp;
-               
                ifnet_release(ifp);
        }
 
        lck_mtx_unlock(bpf_mlock);
-
-       FREE(bp, M_DEVBUF);
-
 }
 
 void
@@ -2251,25 +2788,12 @@ bpf_init(__unused void *unused)
 
        if (bpf_devsw_installed == 0) {
                bpf_devsw_installed = 1;
-
-        bpf_mlock_grp_attr = lck_grp_attr_alloc_init();
-
-        bpf_mlock_grp = lck_grp_alloc_init("bpf", bpf_mlock_grp_attr);
-
-        bpf_mlock_attr = lck_attr_alloc_init();
-
-        bpf_mlock = lck_mtx_alloc_init(bpf_mlock_grp, bpf_mlock_attr);
-
-               if (bpf_mlock == 0) {
-                       printf("bpf_init: failed to allocate bpf_mlock\n");
-                       bpf_devsw_installed = 0;
-                       return;
-               }
-               
+               bpf_mlock_grp_attr = lck_grp_attr_alloc_init();
+               bpf_mlock_grp = lck_grp_alloc_init("bpf", bpf_mlock_grp_attr);
+               bpf_mlock_attr = lck_attr_alloc_init();
+               lck_mtx_init(bpf_mlock, bpf_mlock_grp, bpf_mlock_attr);
                maj = cdevsw_add(CDEV_MAJOR, &bpf_cdevsw);
                if (maj == -1) {
-                       if (bpf_mlock)
-                               lck_mtx_free(bpf_mlock, bpf_mlock_grp);
                        if (bpf_mlock_attr)
                                lck_attr_free(bpf_mlock_attr);
                        if (bpf_mlock_grp)
@@ -2288,6 +2812,8 @@ bpf_init(__unused void *unused)
 
                for (i = 0 ; i < NBPFILTER; i++)
                        bpf_make_dev_t(maj);
+
+               VERIFY(mbuf_tag_id_find(BPF_CONTROL_NAME, &bpf_mtag_id) == 0);
        }
 #else
        cdevsw_add(&bpf_cdevsw);