xnu-792.25.20.tar.gz

[apple/xnu.git] / bsd / miscfs / union / union_subr.c

diff --git a/bsd/miscfs/union/union_subr.c b/bsd/miscfs/union/union_subr.c
index 6aa953ee66683109db19dbb65f82d26e95406d29..7ff6930f35db1db09996f98795a20ff1d6e21719 100644 (file)
--- a/bsd/miscfs/union/union_subr.c
+++ b/bsd/miscfs/union/union_subr.c
@@ -876,7 +876,6 @@ union_vn_create(vpp, un, p)
        struct proc *p;
 {
        struct vnode *vp;
-       kauth_cred_t cred = p->p_ucred;
        struct vnode_attr vat;
        struct vnode_attr *vap = &vat;
        struct vfs_context context;
@@ -889,7 +888,7 @@ union_vn_create(vpp, un, p)
        *vpp = NULLVP;
 
        context.vc_proc = p;
-       context.vc_ucred = p->p_ucred;
+       context.vc_ucred = kauth_cred_proc_ref(p);
 
        /*
         * Build a new componentname structure (for the same
@@ -913,12 +912,15 @@ union_vn_create(vpp, un, p)
        cn.cn_consume = 0;
 
        vnode_get(un->un_dirvp);
-       if (error = relookup(un->un_dirvp, &vp, &cn))
+       if (error = relookup(un->un_dirvp, &vp, &cn)) {
+               kauth_cred_unref(&context.vc_ucred);
                return (error);
+       }
        vnode_put(un->un_dirvp);
 
        if (vp) {
                vnode_put(un->un_dirvp);
+               kauth_cred_unref(&context.vc_ucred);
                vnode_put(vp);
                return (EEXIST);
        }
@@ -940,11 +942,14 @@ union_vn_create(vpp, un, p)
        VATTR_SET(vap, va_type, VREG);
        VATTR_SET(vap, va_mode, cmode);
 
-       if (error = vn_create(un->un_dirvp, &vp, &cn, vap, 0, &context))
+       if (error = vn_create(un->un_dirvp, &vp, &cn, vap, 0, &context)) {
+               kauth_cred_unref(&context.vc_ucred);
                return (error);
+       }
 
        if (error = VNOP_OPEN(vp, fmode, &context)) {
                vnode_put(vp);
+               kauth_cred_unref(&context.vc_ucred);
                return (error);
        }
 
@@ -953,6 +958,7 @@ union_vn_create(vpp, un, p)
                panic("union: v_writecount");
        vnode_unlock(vp);
        *vpp = vp;
+       kauth_cred_unref(&context.vc_ucred);
        return (0);
 }