xnu-7195.50.7.100.1.tar.gz

[apple/xnu.git] / bsd / netinet / dhcp_options.c

diff --git a/bsd/netinet/dhcp_options.c b/bsd/netinet/dhcp_options.c
index 8dccba9fd4e9433d4413448c4d6902962fe4d871..2e2d4581d4ac0647a3f23d2fe22941d565adc47f 100644 (file)
--- a/bsd/netinet/dhcp_options.c
+++ b/bsd/netinet/dhcp_options.c
@@ -1,3 +1,30 @@
+/*
+ * Copyright (c) 2002-2019 Apple Inc. All rights reserved.
+ *
+ * @APPLE_OSREFERENCE_LICENSE_HEADER_START@
+ *
+ * This file contains Original Code and/or Modifications of Original Code
+ * as defined in and that are subject to the Apple Public Source License
+ * Version 2.0 (the 'License'). You may not use this file except in
+ * compliance with the License. The rights granted to you under the License
+ * may not be used to create, or enable the creation or redistribution of,
+ * unlawful or unlicensed copies of an Apple operating system, or to
+ * circumvent, violate, or enable the circumvention or violation of, any
+ * terms of an Apple operating system software license agreement.
+ *
+ * Please obtain a copy of the License at
+ * http://www.opensource.apple.com/apsl/ and read it before using this file.
+ *
+ * The Original Code and all software distributed under the License are
+ * distributed on an 'AS IS' basis, WITHOUT WARRANTY OF ANY KIND, EITHER
+ * EXPRESS OR IMPLIED, AND APPLE HEREBY DISCLAIMS ALL SUCH WARRANTIES,
+ * INCLUDING WITHOUT LIMITATION, ANY WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE, QUIET ENJOYMENT OR NON-INFRINGEMENT.
+ * Please see the License for the specific language governing rights and
+ * limitations under the License.
+ *
+ * @APPLE_OSREFERENCE_LICENSE_HEADER_END@
+ */

 /*
  * dhcp_options.c
  * - routines to parse and access dhcp options
 /*
  * dhcp_options.c
  * - routines to parse and access dhcp options


@@ -6,45 +33,67 @@
  *   that are encoded using the RFC 2132 encoding
  */
 
  *   that are encoded using the RFC 2132 encoding
  */
 

-/* 
+/*

  * Modification History
  *
  * March 15, 2002      Dieter Siegmund (dieter@apple)
  * - imported from bootp project
  */
 
  * Modification History
  *
  * March 15, 2002      Dieter Siegmund (dieter@apple)
  * - imported from bootp project
  */
 

+#include <string.h>

 #include <sys/types.h>
 #include <sys/param.h>
 #include <netinet/in.h>
 #include <sys/malloc.h>
 #include <sys/types.h>
 #include <sys/param.h>
 #include <netinet/in.h>
 #include <sys/malloc.h>

-

 #include <netinet/dhcp.h>
 #include <netinet/dhcp_options.h>
 
 #include <netinet/dhcp.h>
 #include <netinet/dhcp_options.h>
 

+#ifndef TEST_DHCP_OPTIONS
+#include <libkern/libkern.h>
+
+#ifdef  DHCP_DEBUG
+#define dprintf(x) printf x;
+#else   /* !DHCP_DEBUG */
+#define dprintf(x)
+#endif  /* DHCP_DEBUG */
+

 static __inline__ void
 my_free(void * ptr)
 {
 static __inline__ void
 my_free(void * ptr)
 {

-    _FREE(ptr, M_TEMP);
+       _FREE(ptr, M_TEMP);

 }
 
 static __inline__ void *
 my_malloc(int size)
 {
 }
 
 static __inline__ void *
 my_malloc(int size)
 {

-    void * data;
-    MALLOC(data, void *, size, M_TEMP, M_WAITOK);
-    return (data);
+       void * data;
+       MALLOC(data, void *, size, M_TEMP, M_WAITOK);
+       return data;

 }
 
 static __inline__ void *
 my_realloc(void * oldptr, int oldsize, int newsize)
 {
 }
 
 static __inline__ void *
 my_realloc(void * oldptr, int oldsize, int newsize)
 {

-    void * data;
+       void * data;

 
 

-    MALLOC(data, void *, newsize, M_TEMP, M_WAITOK);
-    bcopy(oldptr, data, oldsize);
-    my_free(oldptr);
-    return (data);
+       MALLOC(data, void *, newsize, M_TEMP, M_WAITOK);
+       bcopy(oldptr, data, oldsize);
+       my_free(oldptr);
+       return data;

 }
 }

+#else
+/*
+ * To build:
+ * xcrun -sdk macosx.internal cc -DTEST_DHCP_OPTIONS -o /tmp/dhcp_options dhcp_options.c -I ..
+ */
+#include <stdlib.h>
+#include <unistd.h>
+#include <stdio.h>
+#define my_free free
+#define my_malloc malloc
+#define my_realloc(ptr, old_size, new_size) realloc(ptr, new_size)
+#define dprintf(x) printf x;
+#endif

 
 /*
  * Functions: ptrlist_*
 
 /*
  * Functions: ptrlist_*


@@ -52,143 +101,150 @@ my_realloc(void * oldptr, int oldsize, int newsize)
  *   A dynamically growable array of pointers.
  */
 
  *   A dynamically growable array of pointers.
  */
 

-#define PTRLIST_NUMBER         16
+#define PTRLIST_NUMBER          16

 
 static void
 ptrlist_init(ptrlist_t * list)
 {
 
 static void
 ptrlist_init(ptrlist_t * list)
 {

-    bzero(list, sizeof(*list));
-    return;
+       bzero(list, sizeof(*list));
+       return;

 }
 
 static void
 ptrlist_free(ptrlist_t * list)
 {
 }
 
 static void
 ptrlist_free(ptrlist_t * list)
 {

-    if (list->array)
-       my_free(list->array);
-    ptrlist_init(list);
-    return;
+       if (list->array) {
+               my_free(list->array);
+       }
+       ptrlist_init(list);
+       return;

 }
 
 static int
 ptrlist_count(ptrlist_t * list)
 {
 }
 
 static int
 ptrlist_count(ptrlist_t * list)
 {

-    if (list == NULL || list->array == NULL)
-       return (0);
+       if (list == NULL || list->array == NULL) {
+               return 0;
+       }

 
 

-    return (list->count);
+       return list->count;

 }
 
 }
 

-static void *
+static const void *

 ptrlist_element(ptrlist_t * list, int i)
 {
 ptrlist_element(ptrlist_t * list, int i)
 {

-    if (list->array == NULL)
-       return (NULL);
-    if (i < list->count)
-       return (list->array[i]);
-    return (NULL);
+       if (list->array == NULL) {
+               return NULL;
+       }
+       if (i < list->count) {
+               return list->array[i];
+       }
+       return NULL;

 }
 
 
 static boolean_t
 ptrlist_grow(ptrlist_t * list)
 {
 }
 
 
 static boolean_t
 ptrlist_grow(ptrlist_t * list)
 {

-    if (list->array == NULL) {
-       if (list->size == 0)
-           list->size = PTRLIST_NUMBER;
-       list->count = 0;
-       list->array = my_malloc(sizeof(*list->array) * list->size);
-    }
-    else if (list->size == list->count) {
-#ifdef DEBUG
-       printf("doubling %d to %d\n", list->size, list->size * 2);
-#endif /* DEBUG */
-       list->array = my_realloc(list->array, 
-                                sizeof(*list->array) * list->size,
-                                sizeof(*list->array) * list->size * 2);
-       list->size *= 2;
-    }
-    if (list->array == NULL)
-       return (FALSE);
-    return (TRUE);
+       if (list->array == NULL) {
+               if (list->size == 0) {
+                       list->size = PTRLIST_NUMBER;
+               }
+               list->count = 0;
+               list->array = my_malloc(sizeof(*list->array) * list->size);
+       } else if (list->size == list->count) {
+               dprintf(("doubling %d to %d\n", list->size, list->size * 2));
+               list->array = my_realloc(list->array,
+                   sizeof(*list->array) * list->size,
+                   sizeof(*list->array) * list->size * 2);
+               list->size *= 2;
+       }
+       if (list->array == NULL) {
+               return FALSE;
+       }
+       return TRUE;

 }
 
 static boolean_t
 }
 
 static boolean_t

-ptrlist_add(ptrlist_t * list, void * element)
+ptrlist_add(ptrlist_t * list, const void * element)

 {
 {

-    if (ptrlist_grow(list) == FALSE)
-       return (FALSE);
+       if (ptrlist_grow(list) == FALSE) {
+               return FALSE;
+       }

 
 

-    list->array[list->count++] = element;
-    return (TRUE);
+       list->array[list->count++] = element;
+       return TRUE;

 }
 
 /* concatenates extra onto list */
 static boolean_t
 ptrlist_concat(ptrlist_t * list, ptrlist_t * extra)
 {
 }
 
 /* concatenates extra onto list */
 static boolean_t
 ptrlist_concat(ptrlist_t * list, ptrlist_t * extra)
 {

-    if (extra->count == 0)
-       return (TRUE);
-
-    if ((extra->count + list->count) > list->size) {
-       int old_size = list->size;
-
-       list->size = extra->count + list->count;
-       if (list->array == NULL)
-           list->array = my_malloc(sizeof(*list->array) * list->size);
-       else
-           list->array = my_realloc(list->array, old_size,
-                                    sizeof(*list->array) * list->size);
-    }
-    if (list->array == NULL)
-       return (FALSE);
-    bcopy(extra->array, list->array + list->count, 
-         extra->count * sizeof(*list->array));
-    list->count += extra->count;
-    return (TRUE);
+       if (extra->count == 0) {
+               return TRUE;
+       }
+
+       if ((extra->count + list->count) > list->size) {
+               int old_size = list->size;
+
+               list->size = extra->count + list->count;
+               if (list->array == NULL) {
+                       list->array = my_malloc(sizeof(*list->array) * list->size);
+               } else {
+                       list->array = my_realloc(list->array, old_size,
+                           sizeof(*list->array) * list->size);
+               }
+       }
+       if (list->array == NULL) {
+               return FALSE;
+       }
+       bcopy(extra->array, list->array + list->count,
+           extra->count * sizeof(*list->array));
+       list->count += extra->count;
+       return TRUE;

 }
 
 
 /*
 }
 
 
 /*

- * Functions: dhcpol_* 
+ * Functions: dhcpol_*

  *
  * Purpose:
  *   Routines to parse/access existing options buffers.
  */
 boolean_t
  *
  * Purpose:
  *   Routines to parse/access existing options buffers.
  */
 boolean_t

-dhcpol_add(dhcpol_t * list, void * element)
+dhcpol_add(dhcpol_t * list, const void * element)

 {
 {

-    return (ptrlist_add((ptrlist_t *)list, element));
+       return ptrlist_add((ptrlist_t *)list, element);

 }
 
 int
 dhcpol_count(dhcpol_t * list)
 {
 }
 
 int
 dhcpol_count(dhcpol_t * list)
 {

-    return (ptrlist_count((ptrlist_t *)list));
+       return ptrlist_count((ptrlist_t *)list);

 }
 
 }
 

-void *
+const void *

 dhcpol_element(dhcpol_t * list, int i)
 {
 dhcpol_element(dhcpol_t * list, int i)
 {

-    return (ptrlist_element((ptrlist_t *)list, i));
+       return ptrlist_element((ptrlist_t *)list, i);

 }
 
 void
 dhcpol_init(dhcpol_t * list)
 {
 }
 
 void
 dhcpol_init(dhcpol_t * list)
 {

-    ptrlist_init((ptrlist_t *)list);
+       ptrlist_init((ptrlist_t *)list);

 }
 
 void
 dhcpol_free(dhcpol_t * list)
 {
 }
 
 void
 dhcpol_free(dhcpol_t * list)
 {

-    ptrlist_free((ptrlist_t *)list);
+       ptrlist_free((ptrlist_t *)list);

 }
 
 boolean_t
 dhcpol_concat(dhcpol_t * list, dhcpol_t * extra)
 {
 }
 
 boolean_t
 dhcpol_concat(dhcpol_t * list, dhcpol_t * extra)
 {

-    return (ptrlist_concat((ptrlist_t *)list, (ptrlist_t *)extra));
+       return ptrlist_concat((ptrlist_t *)list, (ptrlist_t *)extra);

 }
 
 /*
 }
 
 /*


@@ -201,52 +257,52 @@ dhcpol_concat(dhcpol_t * list, dhcpol_t * extra)
  *   the end tag.
  */
 boolean_t
  *   the end tag.
  */
 boolean_t

-dhcpol_parse_buffer(dhcpol_t * list, void * buffer, int length,
-                   unsigned char * err)
+dhcpol_parse_buffer(dhcpol_t * list, const void * buffer, int length)

 {
 {

-    int                        len;
-    unsigned char *    scan;
-    unsigned char      tag;
-
-    if (err)
-       err[0] = '\0';
-
-    dhcpol_init(list);
-
-    len = length;
-    tag = dhcptag_pad_e;
-    for (scan = (unsigned char *)buffer; tag != dhcptag_end_e && len > 0; ) {
-
-       tag = scan[DHCP_TAG_OFFSET];
-
-       switch (tag) {
-         case dhcptag_end_e:
-             dhcpol_add(list, scan); /* remember that it was terminated */
-             scan++;
-             len--;
-             break;
-         case dhcptag_pad_e: /* ignore pad */
-             scan++;
-             len--;
-             break;
-         default: {
-             unsigned char     option_len = scan[DHCP_LEN_OFFSET];
-           
-             dhcpol_add(list, scan);
-             len -= (option_len + 2);
-             scan += (option_len + 2);
-             break;
-         }
+       int                 len;
+       const uint8_t *     scan;
+       uint8_t             tag;
+
+       dhcpol_init(list);
+
+       len = length;
+       tag = dhcptag_pad_e;
+       for (scan = (const uint8_t *)buffer;
+           tag != dhcptag_end_e && len > DHCP_TAG_OFFSET;) {
+               tag = scan[DHCP_TAG_OFFSET];
+
+               switch (tag) {
+               case dhcptag_end_e:
+                       /* remember that it was terminated */
+                       dhcpol_add(list, scan);
+                       scan++;
+                       len--;
+                       break;
+               case dhcptag_pad_e: /* ignore pad */
+                       scan++;
+                       len--;
+                       break;
+               default:
+                       if (len > DHCP_LEN_OFFSET) {
+                               uint8_t       option_len;
+
+                               option_len = scan[DHCP_LEN_OFFSET];
+                               dhcpol_add(list, scan);
+                               len -= (option_len + DHCP_OPTION_OFFSET);
+                               scan += (option_len + DHCP_OPTION_OFFSET);
+                       } else {
+                               len = -1;
+                       }
+                       break;
+               }

        }
        }

-    }
-    if (len < 0) {
-       /* ran off the end */
-       if (err)
-           sprintf(err, "parse failed near tag %d", tag);
-       dhcpol_free(list);
-       return (FALSE);
-    }
-    return (TRUE);
+       if (len < 0) {
+               /* ran off the end */
+               dprintf(("dhcp_options: parse failed near tag %d\n", tag));
+               dhcpol_free(list);
+               return FALSE;
+       }
+       return TRUE;

 }
 
 /*
 }
 
 /*


@@ -256,75 +312,38 @@ dhcpol_parse_buffer(dhcpol_t * list, void * buffer, int length,
  *   Finds the first occurence of the given option, and returns its
  *   length and the option data pointer.
  *
  *   Finds the first occurence of the given option, and returns its
  *   length and the option data pointer.
  *

- *   The optional start parameter allows this function to 
+ *   The optional start parameter allows this function to

  *   return the next start point so that successive
  *   calls will retrieve the next occurence of the option.
  *   Before the first call, *start should be set to 0.
  */
  *   return the next start point so that successive
  *   calls will retrieve the next occurence of the option.
  *   Before the first call, *start should be set to 0.
  */

-void *
+const void *

 dhcpol_find(dhcpol_t * list, int tag, int * len_p, int * start)
 {
 dhcpol_find(dhcpol_t * list, int tag, int * len_p, int * start)
 {

-    int        i = 0;
-
-    if (tag == dhcptag_end_e || tag == dhcptag_pad_e)
-       return (NULL);
-
-    if (start)
-       i = *start;
-
-    for (; i < dhcpol_count(list); i++) {
-       unsigned char * option = dhcpol_element(list, i);
-       
-       if (option[DHCP_TAG_OFFSET] == tag) {
-           if (len_p)
-               *len_p = option[DHCP_LEN_OFFSET];
-           if (start)
-               *start = i + 1;
-           return (option + DHCP_OPTION_OFFSET);
+       int         i = 0;
+
+       if (tag == dhcptag_end_e || tag == dhcptag_pad_e) {
+               return NULL;

        }
        }

-    }
-    return (NULL);
-}

 
 

-/*
- * Function: dhcpol_get
- * 
- * Purpose:
- *   Accumulate all occurences of the given option into a
- *   malloc'd buffer, and return its length.  Used to get
- *   all occurrences of a particular option in a single
- *   data area.
- * Note:
- *   Use _FREE(val, M_TEMP) to free the returned data area.
- */
-void *
-dhcpol_get(dhcpol_t * list, int tag, int * len_p)
-{
-    int        i;
-    char *     data = NULL;
-    int                data_len = 0;
-
-    if (tag == dhcptag_end_e || tag == dhcptag_pad_e)
-       return (NULL);
-
-    for (i = 0; i < dhcpol_count(list); i++) {
-       unsigned char * option = dhcpol_element(list, i);
-       
-       if (option[DHCP_TAG_OFFSET] == tag) {
-           int len = option[DHCP_LEN_OFFSET];
-
-           if (data_len == 0) {
-               data = my_malloc(len);
-           }
-           else {
-               data = my_realloc(data, data_len, data_len + len);
-           }
-           bcopy(option + DHCP_OPTION_OFFSET, data + data_len, len);
-           data_len += len;
+       if (start) {
+               i = *start;

        }
        }

-    }
-    *len_p = data_len;
-    return (data);
+
+       for (; i < dhcpol_count(list); i++) {
+               const uint8_t *         option = dhcpol_element(list, i);
+
+               if (option[DHCP_TAG_OFFSET] == tag) {
+                       if (len_p) {
+                               *len_p = option[DHCP_LEN_OFFSET];
+                       }
+                       if (start) {
+                               *start = i + 1;
+                       }
+                       return option + DHCP_OPTION_OFFSET;
+               }
+       }
+       return NULL;

 }
 
 /*
 }
 
 /*


@@ -339,205 +358,138 @@ dhcpol_get(dhcpol_t * list, int tag, int * len_p)
  *    then parses pkt->dp_sname if specified.
  */
 boolean_t
  *    then parses pkt->dp_sname if specified.
  */
 boolean_t

-dhcpol_parse_packet(dhcpol_t * options, struct dhcp * pkt, int len,
-                   unsigned char * err)
+dhcpol_parse_packet(dhcpol_t * options, const struct dhcp * pkt, int len)

 {
 {

-    char               rfc_magic[4] = RFC_OPTIONS_MAGIC;
-
-    dhcpol_init(options);      /* make sure it's empty */
+       char                rfc_magic[4] = RFC_OPTIONS_MAGIC;

 
 

-    if (err)
-       err[0] = '\0';
+       dhcpol_init(options);   /* make sure it's empty */

 
 

-    if (len < (sizeof(*pkt) + RFC_MAGIC_SIZE)) {
-       if (err) {
-           sprintf(err, "packet is too short: %d < %d",
-                   len, (int)sizeof(*pkt) + RFC_MAGIC_SIZE);
+       if (len < (sizeof(*pkt) + RFC_MAGIC_SIZE)) {
+               dprintf(("dhcp_options: packet is too short: %d < %d\n",
+                   len, (int)sizeof(*pkt) + RFC_MAGIC_SIZE));
+               return FALSE;

        }
        }

-       return (FALSE);
-    }
-    if (bcmp(pkt->dp_options, rfc_magic, RFC_MAGIC_SIZE)) {
-       if (err)
-           sprintf(err, "missing magic number");
-       return (FALSE);
-    }
-    if (dhcpol_parse_buffer(options, pkt->dp_options + RFC_MAGIC_SIZE,
-                           len - sizeof(*pkt) - RFC_MAGIC_SIZE, err) == FALSE)
-       return (FALSE);
-    { /* get overloaded options */
-       unsigned char * overload;
-       int             overload_len;
-
-       overload = (unsigned char *)
-           dhcpol_find(options, dhcptag_option_overload_e, 
-                               &overload_len, NULL);
-       if (overload && overload_len == 1) { /* has overloaded options */
-           dhcpol_t    extra;
-
-           dhcpol_init(&extra);
-           if (*overload == DHCP_OVERLOAD_FILE
-               || *overload == DHCP_OVERLOAD_BOTH) {
-               if (dhcpol_parse_buffer(&extra, pkt->dp_file, 
-                                        sizeof(pkt->dp_file), NULL)) {
-                   dhcpol_concat(options, &extra);
-                   dhcpol_free(&extra);
-               }
-           }
-           if (*overload == DHCP_OVERLOAD_SNAME
-               || *overload == DHCP_OVERLOAD_BOTH) {
-               if (dhcpol_parse_buffer(&extra, pkt->dp_sname, 
-                                        sizeof(pkt->dp_sname), NULL)) {
-                   dhcpol_concat(options, &extra);
-                   dhcpol_free(&extra);
-               }
-           }
-       }
-    }
-    return (TRUE);
-}
-
-/*
- * Function: dhcpol_parse_vendor
- *
- * Purpose:
- *   Given a set of options, find the vendor specific option(s)
- *   and parse all of them into a single option list.
- *  
- * Return value:
- *   TRUE if vendor specific options existed and were parsed succesfully,
- *   FALSE otherwise.
- */
-boolean_t
-dhcpol_parse_vendor(dhcpol_t * vendor, dhcpol_t * options,
-                   unsigned char * err)
-{
-    dhcpol_t           extra;
-    boolean_t          ret = FALSE;
-    int                start = 0;
-
-    if (err)
-       err[0] = '\0';
-
-    dhcpol_init(vendor);
-    dhcpol_init(&extra);
-
-    for (;;) {
-       void *          data;
-       int             len;
-
-       data = dhcpol_find(options, dhcptag_vendor_specific_e, &len, &start);
-       if (data == NULL) {
-           break; /* out of for */
+       if (bcmp(pkt->dp_options, rfc_magic, RFC_MAGIC_SIZE)) {
+               dprintf(("dhcp_options: missing magic number\n"));
+               return FALSE;

        }
        }

-
-       if (dhcpol_parse_buffer(&extra, data, len, err) == FALSE) {
-           goto failed;
+       if (dhcpol_parse_buffer(options, pkt->dp_options + RFC_MAGIC_SIZE,
+           len - sizeof(*pkt) - RFC_MAGIC_SIZE) == FALSE) {
+               return FALSE;

        }
        }

-
-       if (dhcpol_concat(vendor, &extra) == FALSE) {
-           if (err)
-               sprintf(err, "dhcpol_concat() failed at %d\n", start);
-           goto failed;
+       { /* get overloaded options */
+               const uint8_t * overload;
+               int             overload_len;
+
+               overload = dhcpol_find(options, dhcptag_option_overload_e,
+                   &overload_len, NULL);
+               if (overload && overload_len == 1) { /* has overloaded options */
+                       dhcpol_t    extra;
+
+                       dhcpol_init(&extra);
+                       if (*overload == DHCP_OVERLOAD_FILE
+                           || *overload == DHCP_OVERLOAD_BOTH) {
+                               if (dhcpol_parse_buffer(&extra, pkt->dp_file,
+                                   sizeof(pkt->dp_file))) {
+                                       dhcpol_concat(options, &extra);
+                                       dhcpol_free(&extra);
+                               }
+                       }
+                       if (*overload == DHCP_OVERLOAD_SNAME
+                           || *overload == DHCP_OVERLOAD_BOTH) {
+                               if (dhcpol_parse_buffer(&extra, pkt->dp_sname,
+                                   sizeof(pkt->dp_sname))) {
+                                       dhcpol_concat(options, &extra);
+                                       dhcpol_free(&extra);
+                               }
+                       }
+               }

        }
        }

-       dhcpol_free(&extra);
-       ret = TRUE;
-    }
-    if (ret == FALSE) {
-       if (err)
-           strcpy(err, "missing vendor specific options");
-    }
-    return (ret);
-
- failed:
-    dhcpol_free(vendor);
-    dhcpol_free(&extra);
-    return (FALSE);
+       return TRUE;

 }
 
 #ifdef TEST_DHCP_OPTIONS
 char test_empty[] = {
 }
 
 #ifdef TEST_DHCP_OPTIONS
 char test_empty[] = {

-    99, 130, 83, 99,
-    255,
+       99, 130, 83, 99,
+       255,
+};
+
+char test_short[] = {
+       99, 130, 83, 99,
+       1,

 };
 
 char test_simple[] = {
 };
 
 char test_simple[] = {

-    99, 130, 83, 99,
-    1, 4, 255, 255, 252, 0,
-    3, 4, 17, 202, 40, 1,
-    255,
+       99, 130, 83, 99,
+       1, 4, 255, 255, 252, 0,
+       3, 4, 17, 202, 40, 1,
+       255,

 };
 
 char test_vendor[] = {
 };
 
 char test_vendor[] = {

-    99, 130, 83, 99,
-    1, 4, 255, 255, 252, 0,
-    3, 4, 17, 202, 40, 1,
-    43, 6, 1, 4, 1, 2, 3, 4,
-    43, 6, 1, 4, 1, 2, 3, 4,
-    255,
+       99, 130, 83, 99,
+       1, 4, 255, 255, 252, 0,
+       3, 4, 17, 202, 40, 1,
+       43, 6, 1, 4, 1, 2, 3, 4,
+       43, 6, 1, 4, 1, 2, 3, 4,
+       255,

 };
 
 char test_no_end[] = {
 };
 
 char test_no_end[] = {

-    0x63, 0x82, 0x53, 0x63, 0x35, 0x01, 0x05, 0x36, 
-    0x04, 0xc0, 0xa8, 0x01, 0x01, 0x33, 0x04, 0x80,
-    0x00, 0x80, 0x00, 0x01, 0x04, 0xff, 0xff, 0xff,
-    0x00, 0x03, 0x04, 0xc0, 0xa8, 0x01, 0x01, 0x06,
-    0x0c, 0x18, 0x1a, 0xa3, 0x21, 0x18, 0x1a, 0xa3,
-    0x20, 0x18, 0x5e, 0xa3, 0x21, 0x00, 0x00, 0x00,
-    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
-    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
+       0x63, 0x82, 0x53, 0x63, 0x35, 0x01, 0x05, 0x36,
+       0x04, 0xc0, 0xa8, 0x01, 0x01, 0x33, 0x04, 0x80,
+       0x00, 0x80, 0x00, 0x01, 0x04, 0xff, 0xff, 0xff,
+       0x00, 0x03, 0x04, 0xc0, 0xa8, 0x01, 0x01, 0x06,
+       0x0c, 0x18, 0x1a, 0xa3, 0x21, 0x18, 0x1a, 0xa3,
+       0x20, 0x18, 0x5e, 0xa3, 0x21, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00

 };
 
 };
 

-char test_too_short[] = {
-    0x1 
+char test_no_magic[] = {
+       0x1

 };
 struct test {
 };
 struct test {

-    char *             name;
-    char *             data;
-    int                        len;
-    boolean_t          result;
+       char *              name;
+       char *              data;
+       int                 len;
+       boolean_t           result;

 };
 
 struct test tests[] = {
 };
 
 struct test tests[] = {

-    { "empty", test_empty, sizeof(test_empty), TRUE },
-    { "simple", test_simple, sizeof(test_simple), TRUE },
-    { "vendor", test_vendor, sizeof(test_vendor), TRUE },
-    { "no_end", test_no_end, sizeof(test_no_end), TRUE },
-    { "too_short", test_too_short, sizeof(test_too_short), FALSE },
-    { NULL, NULL, 0, FALSE },
+       { .name = "empty", .data = test_empty, .len = sizeof(test_empty), .result = TRUE },
+       { .name = "simple", .data = test_simple, .len = sizeof(test_simple), .result = TRUE },
+       { .name = "vendor", .data = test_vendor, .len = sizeof(test_vendor), .result = TRUE },
+       { .name = "no_end", .data = test_no_end, .len = sizeof(test_no_end), .result = TRUE },
+       { .name = "no magic", .data = test_no_magic, .len = sizeof(test_no_magic), .result = FALSE },
+       { .name = "short", .data = test_short, .len = sizeof(test_short), .result =  FALSE },
+       { .name = NULL, .data = NULL, .len = 0, .result = FALSE },

 };
 
 
 static char buf[2048];
 
 int
 };
 
 
 static char buf[2048];
 
 int

-main()
+main(void)

 {
 {

-    int        i;
-    dhcpol_t   options;
-    char       error[256];
-    struct dhcp * pkt = (struct dhcp *)buf;
-
-    dhcpol_init(&options);
-
-    for (i = 0; tests[i].name; i++) {
-       printf("\nTest %d: ", i);
-       bcopy(tests[i].data, pkt->dp_options, tests[i].len);
-       if (dhcpol_parse_packet(&options, pkt, 
-                               sizeof(*pkt) + tests[i].len,
-                               error) != tests[i].result) {
-           printf("test '%s' FAILED\n", tests[i].name);
-           if (tests[i].result == TRUE) {
-               printf("error message returned was %s\n", error);
-           }
-       }
-       else {
-           printf("test '%s' PASSED\n", tests[i].name);
-           if (tests[i].result == FALSE) {
-               printf("error message returned was %s\n", error);
-           }
+       int         i;
+       dhcpol_t    options;
+       struct dhcp * pkt = (struct dhcp *)buf;
+
+       dhcpol_init(&options);
+
+       for (i = 0; tests[i].name; i++) {
+               printf("\nTest %d: ", i);
+               bcopy(tests[i].data, pkt->dp_options, tests[i].len);
+               if (dhcpol_parse_packet(&options, pkt,
+                   sizeof(*pkt) + tests[i].len)
+                   != tests[i].result) {
+                       printf("test '%s' FAILED\n", tests[i].name);
+               } else {
+                       printf("test '%s' PASSED\n", tests[i].name);
+               }
+               dhcpol_free(&options);

        }
        }

-       dhcpol_free(&options);
-    }
-    exit(0);
+       exit(0);

 }
 #endif /* TEST_DHCP_OPTIONS */
 }
 #endif /* TEST_DHCP_OPTIONS */