]> git.saurik.com Git - apple/xnu.git/blobdiff - bsd/kern/process_policy.c
xnu-6153.11.26.tar.gz
[apple/xnu.git] / bsd / kern / process_policy.c
index ffbd70e98f78dcf63e91a09644dc961bcc255444..f8f8f1f8ba91ecfc45fd317d61548270b9e4607c 100644 (file)
@@ -2,7 +2,7 @@
  * Copyright (c) 2005-2016 Apple Computer, Inc. All rights reserved.
  *
  * @APPLE_OSREFERENCE_LICENSE_HEADER_START@
- * 
+ *
  * This file contains Original Code and/or Modifications of Original Code
  * as defined in and that are subject to the Apple Public Source License
  * Version 2.0 (the 'License'). You may not use this file except in
  * unlawful or unlicensed copies of an Apple operating system, or to
  * circumvent, violate, or enable the circumvention or violation of, any
  * terms of an Apple operating system software license agreement.
- * 
+ *
  * Please obtain a copy of the License at
  * http://www.opensource.apple.com/apsl/ and read it before using this file.
- * 
+ *
  * The Original Code and all software distributed under the License are
  * distributed on an 'AS IS' basis, WITHOUT WARRANTY OF ANY KIND, EITHER
  * EXPRESS OR IMPLIED, AND APPLE HEREBY DISCLAIMS ALL SUCH WARRANTIES,
@@ -22,7 +22,7 @@
  * FITNESS FOR A PARTICULAR PURPOSE, QUIET ENJOYMENT OR NON-INFRINGEMENT.
  * Please see the License for the specific language governing rights and
  * limitations under the License.
- * 
+ *
  * @APPLE_OSREFERENCE_LICENSE_HEADER_END@
  */
 
@@ -34,6 +34,7 @@
 #include <sys/systm.h>
 #include <sys/kernel.h>
 #include <sys/malloc.h>
+#include <sys/priv.h>
 #include <sys/proc_internal.h>
 #include <sys/proc.h>
 #include <sys/kauth.h>
@@ -43,8 +44,6 @@
 #include <sys/vm.h>
 #include <sys/user.h>
 
-#include <security/audit/audit.h>
-
 #include <mach/machine.h>
 #include <mach/mach_types.h>
 #include <mach/vm_param.h>
 #include <kern/ipc_misc.h>
 #include <vm/vm_protos.h>
 
+#if CONFIG_EMBEDDED
+#include <sys/kern_memorystatus.h>
+#endif /* CONFIG_EMBEDDED */
+
+#if CONFIG_MACF
+#include <security/mac.h>
+#include <security/mac_framework.h>
+#endif /* CONFIG_MACF */
+
 static int handle_lowresource(int scope, int action, int policy, int policy_subtype, user_addr_t attrp, proc_t proc, uint64_t target_threadid);
 static int handle_cpuuse(int action, user_addr_t attrp, proc_t proc, uint64_t target_threadid);
 static int handle_apptype(int scope, int action, int policy, int policy_subtype, user_addr_t attrp, proc_t proc, uint64_t target_threadid);
@@ -80,14 +88,17 @@ static int handle_boost(int scope, int action, int policy, int policy_subtype, u
 extern kern_return_t task_suspend(task_t);
 extern kern_return_t task_resume(task_t);
 
+#if CONFIG_EMBEDDED
+static int handle_applifecycle(int scope, int action, int policy, int policy_subtype, user_addr_t attrp, proc_t proc, uint64_t target_threadid);
+#endif /* CONFIG_EMBEDDED */
 
 /***************************** process_policy ********************/
 
 /*
- *int process_policy(int scope, int action, int policy, int policy_subtype, 
- *                   proc_policy_attribute_t * attrp, pid_t target_pid, 
+ * int process_policy(int scope, int action, int policy, int policy_subtype,
+ *                   proc_policy_attribute_t * attrp, pid_t target_pid,
  *                   uint64_t target_threadid)
- *{ int process_policy(int scope, int action, int policy, int policy_subtype, 
+ *{ int process_policy(int scope, int action, int policy, int policy_subtype,
  * user_addr_t attrp, pid_t target_pid, uint64_t target_threadid); }
  */
 
@@ -104,30 +115,45 @@ process_policy(__unused struct proc *p, struct process_policy_args * uap, __unus
        pid_t target_pid = uap->target_pid;
        uint64_t target_threadid = uap->target_threadid;
        proc_t target_proc = PROC_NULL;
+#if CONFIG_MACF || !CONFIG_EMBEDDED
        proc_t curp = current_proc();
+#endif
        kauth_cred_t my_cred;
+#if CONFIG_EMBEDDED
+       kauth_cred_t target_cred;
+#endif
 
        if ((scope != PROC_POLICY_SCOPE_PROCESS) && (scope != PROC_POLICY_SCOPE_THREAD)) {
-               return(EINVAL);
+               return EINVAL;
        }
 
-       if (target_pid == 0 || target_pid == proc_selfpid())
+       if (target_pid == 0 || target_pid == proc_selfpid()) {
                target_proc = proc_self();
-       else
+       } else {
                target_proc = proc_find(target_pid);
+       }
 
-       if (target_proc == PROC_NULL)
-               return(ESRCH);
+       if (target_proc == PROC_NULL) {
+               return ESRCH;
+       }
 
        my_cred = kauth_cred_get();
 
-       /* 
+#if CONFIG_EMBEDDED
+       target_cred = kauth_cred_proc_ref(target_proc);
+
+       if (!kauth_cred_issuser(my_cred) && kauth_cred_getruid(my_cred) &&
+           kauth_cred_getuid(my_cred) != kauth_cred_getuid(target_cred) &&
+           kauth_cred_getruid(my_cred) != kauth_cred_getuid(target_cred))
+#else
+       /*
         * Resoure starvation control can be used by unpriv resource owner but priv at the time of ownership claim. This is
         * checked in low resource handle routine. So bypass the checks here.
         */
-       if ((policy != PROC_POLICY_RESOURCE_STARVATION) && 
-               (policy != PROC_POLICY_APPTYPE) && 
-               (!kauth_cred_issuser(my_cred) && curp != p))
+       if ((policy != PROC_POLICY_RESOURCE_STARVATION) &&
+           (policy != PROC_POLICY_APPTYPE) &&
+           (!kauth_cred_issuser(my_cred) && curp != target_proc))
+#endif
        {
                error = EPERM;
                goto out;
@@ -135,58 +161,74 @@ process_policy(__unused struct proc *p, struct process_policy_args * uap, __unus
 
 #if CONFIG_MACF
        switch (policy) {
-               case PROC_POLICY_BOOST:
-               case PROC_POLICY_RESOURCE_USAGE:
-                       /* These policies do their own appropriate mac checks */
-                       break;
-               default:
-                       error = mac_proc_check_sched(curp, target_proc);
-                       if (error) goto out;
-                       break;
+       case PROC_POLICY_BOOST:
+       case PROC_POLICY_RESOURCE_USAGE:
+#if CONFIG_EMBEDDED
+       case PROC_POLICY_APPTYPE:
+       case PROC_POLICY_APP_LIFECYCLE:
+#endif
+               /* These policies do their own appropriate mac checks */
+               break;
+       default:
+               error = mac_proc_check_sched(curp, target_proc);
+               if (error) {
+                       goto out;
+               }
+               break;
        }
 #endif /* CONFIG_MACF */
 
-       switch(policy) {
-               case PROC_POLICY_BACKGROUND:
-                       error = ENOTSUP;
-                       break;
-               case PROC_POLICY_HARDWARE_ACCESS:
+       switch (policy) {
+       case PROC_POLICY_BACKGROUND:
+               error = ENOTSUP;
+               break;
+       case PROC_POLICY_HARDWARE_ACCESS:
+               error = ENOTSUP;
+               break;
+       case PROC_POLICY_RESOURCE_STARVATION:
+               error = handle_lowresource(scope, action, policy, policy_subtype, attrp, target_proc, target_threadid);
+               break;
+       case PROC_POLICY_RESOURCE_USAGE:
+               switch (policy_subtype) {
+               case PROC_POLICY_RUSAGE_NONE:
+               case PROC_POLICY_RUSAGE_WIREDMEM:
+               case PROC_POLICY_RUSAGE_VIRTMEM:
+               case PROC_POLICY_RUSAGE_DISK:
+               case PROC_POLICY_RUSAGE_NETWORK:
+               case PROC_POLICY_RUSAGE_POWER:
                        error = ENOTSUP;
-                       break;
-               case PROC_POLICY_RESOURCE_STARVATION:
-                       error = handle_lowresource(scope, action, policy, policy_subtype, attrp, target_proc, target_threadid);
-                       break;
-               case PROC_POLICY_RESOURCE_USAGE:
-                       switch(policy_subtype) {
-                               case PROC_POLICY_RUSAGE_NONE:
-                               case PROC_POLICY_RUSAGE_WIREDMEM:
-                               case PROC_POLICY_RUSAGE_VIRTMEM:
-                               case PROC_POLICY_RUSAGE_DISK:
-                               case PROC_POLICY_RUSAGE_NETWORK:
-                               case PROC_POLICY_RUSAGE_POWER:
-                                       return(ENOTSUP);
-                               default:
-                                       return(EINVAL);
-                               case PROC_POLICY_RUSAGE_CPU:
-                                       break;
-                       }
-
-                       error = handle_cpuuse(action, attrp, target_proc, target_threadid);
-                       break;
-               case PROC_POLICY_APPTYPE:
-                       error = handle_apptype(scope, action, policy, policy_subtype, attrp, target_proc, target_threadid);
-                       break;
-               case PROC_POLICY_BOOST:
-                       error = handle_boost(scope, action, policy, policy_subtype, attrp, target_proc, target_threadid);
-                       break;
+                       goto out;
                default:
                        error = EINVAL;
+                       goto out;
+               case PROC_POLICY_RUSAGE_CPU:
                        break;
+               }
+
+               error = handle_cpuuse(action, attrp, target_proc, target_threadid);
+               break;
+#if CONFIG_EMBEDDED
+       case PROC_POLICY_APP_LIFECYCLE:
+               error = handle_applifecycle(scope, action, policy, policy_subtype, attrp, target_proc, target_threadid);
+               break;
+#endif /* CONFIG_EMBEDDED */
+       case PROC_POLICY_APPTYPE:
+               error = handle_apptype(scope, action, policy, policy_subtype, attrp, target_proc, target_threadid);
+               break;
+       case PROC_POLICY_BOOST:
+               error = handle_boost(scope, action, policy, policy_subtype, attrp, target_proc, target_threadid);
+               break;
+       default:
+               error = EINVAL;
+               break;
        }
 
 out:
        proc_rele(target_proc);
-       return(error);
+#if CONFIG_EMBEDDED
+       kauth_cred_unref(&target_cred);
+#endif
+       return error;
 }
 
 static int
@@ -194,265 +236,364 @@ handle_lowresource(__unused int scope, int action, __unused int policy, int poli
 {
        int error = 0;
 
-       switch(policy_subtype) {
-               case PROC_POLICY_RS_NONE:
-               case PROC_POLICY_RS_VIRTUALMEM:
-                       break;
-               default:
-                       return(EINVAL); 
+       switch (policy_subtype) {
+       case PROC_POLICY_RS_NONE:
+       case PROC_POLICY_RS_VIRTUALMEM:
+               break;
+       default:
+               return EINVAL;
        }
-       
-       if (action == PROC_POLICY_ACTION_RESTORE)
+
+       if (action == PROC_POLICY_ACTION_RESTORE) {
                error = proc_resetpcontrol(proc_pid(proc));
-       else
+       } else {
                error = EINVAL;
+       }
 
-       return(error);
+       return error;
 }
 
 
-static int 
+static int
 handle_cpuuse(int action, user_addr_t attrp, proc_t proc, __unused uint64_t target_threadid)
 {
-       proc_policy_cpuusage_attr_t     cpuattr;
-#if CONFIG_MACF
-       proc_t                          curp = current_proc();
+       proc_policy_cpuusage_attr_t     cpuattr = { };
+#if CONFIG_MACF || !CONFIG_EMBEDDED
+       proc_t                          curp = current_proc();
+#endif
+       Boolean                         privileged = FALSE;
+       Boolean                         canEnable = FALSE;
+       uint64_t                        interval = -1ULL;
+       int                             error = 0;
+       uint8_t                         percentage;
+
+#if !CONFIG_EMBEDDED
+       /* On macOS, tasks can only set and clear their own CPU limits. */
+       if ((action == PROC_POLICY_ACTION_APPLY || action == PROC_POLICY_ACTION_RESTORE)
+           && curp != proc) {
+               return EPERM;
+       }
+       /* No privilege required on macOS. */
+       privileged = TRUE;
 #endif
-       int                             entitled = FALSE;
-       Boolean                         canEnable = FALSE;
-       uint64_t                        interval = -1ULL;       
-       int                             error = 0;
-       uint8_t                         percentage;
 
 #if CONFIG_MACF
-       /*
-        * iOS only allows processes to override their own CPU usage monitor
-        * parameters if they have com.apple.private.kernel.override-cpumon.
-        *
-        * Until rdar://24799462 improves our scheme, we are also using the
-        * same entitlement to indicate which processes can resume monitoring
-        * when they otherwise wouldn't be able to.
-        */
-       entitled = (mac_proc_check_cpumon(curp) == 0) ? TRUE : FALSE;
-       canEnable = (entitled && action == PROC_POLICY_ACTION_ENABLE);
+       /* Is caller privileged to set less-restrictive scheduling parameters? */
+       if (!privileged) {
+               privileged = (priv_check_cred(kauth_cred_get(), PRIV_PROC_CPUMON_OVERRIDE, 0) == 0);
+       }
+       canEnable = (privileged && action == PROC_POLICY_ACTION_ENABLE);
 
        if (!canEnable && curp != proc) {
-               /* can the current process change scheduling parameters? */
+               /*
+                * Can the current process change scheduling parameters for
+                * the target process?
+                */
                error = mac_proc_check_sched(curp, proc);
-               if (error)      return error;
+               if (error) {
+                       return error;
+               }
        }
 #endif
 
        switch (action) {
-               case PROC_POLICY_ACTION_GET: 
-                       error = proc_get_task_ruse_cpu(proc->task, &cpuattr.ppattr_cpu_attr,
-                                        &percentage,
-                                        &cpuattr.ppattr_cpu_attr_interval,
-                                        &cpuattr.ppattr_cpu_attr_deadline);
-                       if (error == 0) {
-                               cpuattr.ppattr_cpu_percentage = percentage;
-                               cpuattr.ppattr_cpu_attr_interval /= NSEC_PER_SEC;
-                               error = copyout((proc_policy_cpuusage_attr_t *)&cpuattr, (user_addr_t)attrp, sizeof(proc_policy_cpuusage_attr_t));
-                       }
-                       break;
+       case PROC_POLICY_ACTION_GET:
+               error = proc_get_task_ruse_cpu(proc->task, &cpuattr.ppattr_cpu_attr,
+                   &percentage,
+                   &cpuattr.ppattr_cpu_attr_interval,
+                   &cpuattr.ppattr_cpu_attr_deadline);
+               if (error == 0) {
+                       cpuattr.ppattr_cpu_percentage = percentage;
+                       cpuattr.ppattr_cpu_attr_interval /= NSEC_PER_SEC;
+                       error = copyout((proc_policy_cpuusage_attr_t *)&cpuattr, (user_addr_t)attrp, sizeof(proc_policy_cpuusage_attr_t));
+               }
+               break;
+
+       case PROC_POLICY_ACTION_APPLY:
+       case PROC_POLICY_ACTION_SET:
+               error = copyin((user_addr_t)attrp, (proc_policy_cpuusage_attr_t *)&cpuattr, sizeof(proc_policy_cpuusage_attr_t));
+               if (error != 0) {
+                       return error;
+               }
+
+               /*
+                * The process_policy API uses seconds as the units for the interval,
+                * but the mach task policy SPI uses nanoseconds. Do the conversion,
+                * but preserve -1 as it has special meaning.
+                */
+               if (cpuattr.ppattr_cpu_attr_interval != -1ULL) {
+                       interval = cpuattr.ppattr_cpu_attr_interval * NSEC_PER_SEC;
+               } else {
+                       interval = -1ULL;
+               }
+
+               error = proc_set_task_ruse_cpu(proc->task, cpuattr.ppattr_cpu_attr,
+                   cpuattr.ppattr_cpu_percentage,
+                   interval,
+                   cpuattr.ppattr_cpu_attr_deadline,
+                   privileged);
+               break;
+
+       /* restore process to prior state */
+       case PROC_POLICY_ACTION_RESTORE:
+               error = proc_clear_task_ruse_cpu(proc->task, privileged);
+               break;
+
+       /* re-enable suspended monitor */
+       case PROC_POLICY_ACTION_ENABLE:
+               error = task_resume_cpumon(proc->task);
+               break;
+
+       case PROC_POLICY_ACTION_REMOVE:
+
+       default:
+               error = EINVAL;
+               break;
+       }
 
-               case PROC_POLICY_ACTION_APPLY: 
-               case PROC_POLICY_ACTION_SET: 
-                       error = copyin((user_addr_t)attrp, (proc_policy_cpuusage_attr_t *)&cpuattr, sizeof(proc_policy_cpuusage_attr_t));
-                       if (error != 0) {
-                               return (error);
-                       }
-
-                       /*
-                        * The process_policy API uses seconds as the units for the interval,
-                        * but the mach task policy SPI uses nanoseconds. Do the conversion,
-                        * but preserve -1 as it has special meaning.
-                        */
-                       if (cpuattr.ppattr_cpu_attr_interval != -1ULL) {
-                               interval = cpuattr.ppattr_cpu_attr_interval * NSEC_PER_SEC;
-                       } else {
-                               interval = -1ULL;
-                       }
-
-                       error = proc_set_task_ruse_cpu(proc->task, cpuattr.ppattr_cpu_attr, 
-                                       cpuattr.ppattr_cpu_percentage, 
-                                       interval, 
-                                       cpuattr.ppattr_cpu_attr_deadline,
-                                       entitled); 
-                       break;
+       return error;
+}
 
-               /* restore process to prior state */
-               case PROC_POLICY_ACTION_RESTORE:
-                       error = proc_clear_task_ruse_cpu(proc->task, entitled);
-                       break;
+#if CONFIG_EMBEDDED
+static int
+handle_applifecycle(__unused int scope,
+    int action,
+    __unused int policy,
+    int policy_subtype,
+    user_addr_t attrp,
+    proc_t proc,
+    uint64_t target_threadid)
+{
+       int error = 0;
+       int state = 0;
 
-               /* re-enable suspended monitor */
-               case PROC_POLICY_ACTION_ENABLE:
-                       error = task_resume_cpumon(proc->task);
-                       break;
+       switch (policy_subtype) {
+       case PROC_POLICY_APPLIFE_NONE:
+               error = 0;
+               break;
 
-               case PROC_POLICY_ACTION_REMOVE:
+       case PROC_POLICY_APPLIFE_STATE:
+               /* appstate is no longer supported */
+               error = ENOTSUP;
+               break;
 
-               default:
+       case PROC_POLICY_APPLIFE_DEVSTATUS:
+#if CONFIG_MACF
+               /* ToDo - this should be a generic check, since we could potentially hang other behaviours here. */
+               error = mac_proc_check_suspend_resume(current_proc(), MAC_PROC_CHECK_HIBERNATE);
+               if (error) {
+                       error = EPERM;
+                       goto out;
+               }
+#endif
+#if CONFIG_MEMORYSTATUS
+               if (action == PROC_POLICY_ACTION_APPLY) {
+                       /* Used as a freeze hint */
+                       memorystatus_on_inactivity(proc);
+
+                       /* in future use devicestatus for pid_socketshutdown() */
+                       error = 0;
+               } else
+#endif
+               {
                        error = EINVAL;
-                       break;
+               }
+               break;
 
+       case PROC_POLICY_APPLIFE_PIDBIND:
+#if CONFIG_MACF
+               error = mac_proc_check_suspend_resume(current_proc(), MAC_PROC_CHECK_PIDBIND);
+               if (error) {
+                       error = EPERM;
+                       goto out;
+               }
+#endif
+               error = copyin((user_addr_t)attrp, (int  *)&state, sizeof(int));
+               if (error != 0) {
+                       goto out;
+               }
+               if (action == PROC_POLICY_ACTION_APPLY) {
+                       /* bind the thread in target_thread in current process to target_proc */
+                       error = proc_lf_pidbind(current_task(), target_threadid, proc->task, state);
+               } else {
+                       error = EINVAL;
+               }
+               break;
+       default:
+               error = EINVAL;
+               break;
        }
-                               
-       return(error);
-}
 
+out:
+       return error;
+}
+#endif /* CONFIG_EMBEDDED */
 
 static int
 handle_apptype(         int scope,
-                        int action,
-               __unused int policy,
-                        int policy_subtype,
-               __unused user_addr_t attrp,
-                        proc_t target_proc,
-               __unused uint64_t target_threadid)
+    int action,
+    __unused int policy,
+    int policy_subtype,
+    __unused user_addr_t attrp,
+    proc_t target_proc,
+    __unused uint64_t target_threadid)
 {
        int error = 0;
 
-       if (scope != PROC_POLICY_SCOPE_PROCESS)
-               return (EINVAL);
+       if (scope != PROC_POLICY_SCOPE_PROCESS) {
+               return EINVAL;
+       }
 
        /* Temporary compatibility with old importance donation interface until libproc is moved to new boost calls */
        switch (policy_subtype) {
-               case PROC_POLICY_IOS_DONATEIMP:
-                       if (action != PROC_POLICY_ACTION_ENABLE)
-                               return (EINVAL);
-                       if (target_proc != current_proc())
-                               return (EINVAL);
-                       
-                       /* PROCESS ENABLE APPTYPE DONATEIMP */
-                       task_importance_mark_donor(target_proc->task, TRUE);
+       case PROC_POLICY_IOS_DONATEIMP:
+               if (action != PROC_POLICY_ACTION_ENABLE) {
+                       return EINVAL;
+               }
+               if (target_proc != current_proc()) {
+                       return EINVAL;
+               }
 
-                       return(0);
+               /* PROCESS ENABLE APPTYPE DONATEIMP */
+               task_importance_mark_donor(target_proc->task, TRUE);
 
-               case PROC_POLICY_IOS_HOLDIMP:
-                       if (action != PROC_POLICY_ACTION_ENABLE)
-                               return (EINVAL);
-                       if (target_proc != current_proc())
-                               return (EINVAL);
+               return 0;
 
-                       /* PROCESS ENABLE APPTYPE HOLDIMP */
-                       error = task_importance_hold_legacy_external_assertion(current_task(), 1);
+       case PROC_POLICY_IOS_HOLDIMP:
+               if (action != PROC_POLICY_ACTION_ENABLE) {
+                       return EINVAL;
+               }
+               if (target_proc != current_proc()) {
+                       return EINVAL;
+               }
 
-                       return(error);
+               /* PROCESS ENABLE APPTYPE HOLDIMP */
+               error = task_importance_hold_legacy_external_assertion(current_task(), 1);
 
-               case PROC_POLICY_IOS_DROPIMP:
-                       if (action != PROC_POLICY_ACTION_ENABLE)
-                               return (EINVAL);
-                       if (target_proc != current_proc())
-                               return (EINVAL);
+               return error;
 
-                       /* PROCESS ENABLE APPTYPE DROPIMP */
-                       error = task_importance_drop_legacy_external_assertion(current_task(), 1);
+       case PROC_POLICY_IOS_DROPIMP:
+               if (action != PROC_POLICY_ACTION_ENABLE) {
+                       return EINVAL;
+               }
+               if (target_proc != current_proc()) {
+                       return EINVAL;
+               }
 
-                       return(error);
+               /* PROCESS ENABLE APPTYPE DROPIMP */
+               error = task_importance_drop_legacy_external_assertion(current_task(), 1);
 
-               default:
-                       /* continue to TAL handling */
-                       break;
+               return error;
+
+       default:
+               /* continue to TAL handling */
+               break;
        }
 
-       if (policy_subtype != PROC_POLICY_OSX_APPTYPE_TAL)
-               return (EINVAL);
+       if (policy_subtype != PROC_POLICY_OSX_APPTYPE_TAL) {
+               return EINVAL;
+       }
 
        /* need to be super user to do this */
-       if (kauth_cred_issuser(kauth_cred_get()) == 0)
-               return (EPERM);
+       if (kauth_cred_issuser(kauth_cred_get()) == 0) {
+               return EPERM;
+       }
 
-       if (proc_task_is_tal(target_proc->task) == FALSE)
-               return (EINVAL);
+       if (proc_task_is_tal(target_proc->task) == FALSE) {
+               return EINVAL;
+       }
 
        switch (action) {
-               case PROC_POLICY_ACTION_ENABLE:
-                       /* PROCESS ENABLE APPTYPE TAL */
-                       proc_set_task_policy(target_proc->task,
-                                            TASK_POLICY_ATTRIBUTE, TASK_POLICY_TAL,
-                                            TASK_POLICY_ENABLE);
-                       break;
-               case PROC_POLICY_ACTION_DISABLE:
-                       /* PROCESS DISABLE APPTYPE TAL */
-                       proc_set_task_policy(target_proc->task,
-                                            TASK_POLICY_ATTRIBUTE, TASK_POLICY_TAL,
-                                            TASK_POLICY_DISABLE);
-                       break;
-               default:
-                       return (EINVAL);
+       case PROC_POLICY_ACTION_ENABLE:
+               /* PROCESS ENABLE APPTYPE TAL */
+               proc_set_task_policy(target_proc->task,
+                   TASK_POLICY_ATTRIBUTE, TASK_POLICY_TAL,
+                   TASK_POLICY_ENABLE);
+               break;
+       case PROC_POLICY_ACTION_DISABLE:
+               /* PROCESS DISABLE APPTYPE TAL */
+               proc_set_task_policy(target_proc->task,
+                   TASK_POLICY_ATTRIBUTE, TASK_POLICY_TAL,
+                   TASK_POLICY_DISABLE);
+               break;
+       default:
+               return EINVAL;
        }
 
-       return(0);
+       return 0;
 }
 
 static int
 handle_boost(int scope,
-             int action,
+    int action,
     __unused int policy,
-             int policy_subtype,
+    int policy_subtype,
     __unused user_addr_t attrp,
-             proc_t target_proc,
+    proc_t target_proc,
     __unused uint64_t target_threadid)
 {
        int error = 0;
 
        assert(policy == PROC_POLICY_BOOST);
 
-       if (scope != PROC_POLICY_SCOPE_PROCESS)
-               return (EINVAL);
-
-       if (target_proc != current_proc())
-               return (EINVAL);
-
-       switch(policy_subtype) {
-               case PROC_POLICY_IMP_IMPORTANT:
-                       if (task_is_importance_receiver_type(target_proc->task) == FALSE)
-                               return (EINVAL);
-
-                       switch (action) {
-                               case PROC_POLICY_ACTION_HOLD:
-                                       /* PROCESS HOLD BOOST IMPORTANT */
-                                       error = task_importance_hold_legacy_external_assertion(current_task(), 1);
-                                       break;
-                               case PROC_POLICY_ACTION_DROP:
-                                       /* PROCESS DROP BOOST IMPORTANT */
-                                       error = task_importance_drop_legacy_external_assertion(current_task(), 1);
-                                       break;
-                               default:
-                                       error = (EINVAL);
-                                       break;
-                       }
+       if (scope != PROC_POLICY_SCOPE_PROCESS) {
+               return EINVAL;
+       }
+
+       if (target_proc != current_proc()) {
+               return EINVAL;
+       }
+
+       switch (policy_subtype) {
+       case PROC_POLICY_IMP_IMPORTANT:
+               if (task_is_importance_receiver_type(target_proc->task) == FALSE) {
+                       return EINVAL;
+               }
+
+               switch (action) {
+               case PROC_POLICY_ACTION_HOLD:
+                       /* PROCESS HOLD BOOST IMPORTANT */
+                       error = task_importance_hold_legacy_external_assertion(current_task(), 1);
+                       break;
+               case PROC_POLICY_ACTION_DROP:
+                       /* PROCESS DROP BOOST IMPORTANT */
+                       error = task_importance_drop_legacy_external_assertion(current_task(), 1);
                        break;
+               default:
+                       error = (EINVAL);
+                       break;
+               }
+               break;
 
-               case PROC_POLICY_IMP_DONATION:
+       case PROC_POLICY_IMP_DONATION:
 #if CONFIG_MACF
-                       error = mac_proc_check_sched(current_proc(), target_proc);
-                       if (error) return error;
+               error = mac_proc_check_sched(current_proc(), target_proc);
+               if (error) {
+                       return error;
+               }
 #endif
-                       switch (action) {
-                               case PROC_POLICY_ACTION_SET:
-                                       /* PROCESS SET BOOST DONATION */
-                                       task_importance_mark_donor(target_proc->task, TRUE);
-                                       break;
-                               default:
-                                       error = (EINVAL);
-                                       break;
-                       }
+               switch (action) {
+               case PROC_POLICY_ACTION_SET:
+                       /* PROCESS SET BOOST DONATION */
+                       task_importance_mark_donor(target_proc->task, TRUE);
                        break;
-
                default:
                        error = (EINVAL);
                        break;
+               }
+               break;
+
+       default:
+               error = (EINVAL);
+               break;
        }
 
-       return(error);
+       return error;
 }
 
 
-/* 
- * KPI to determine if a pid is currently backgrounded. 
+/*
+ * KPI to determine if a pid is currently backgrounded.
  * Returns ESRCH if pid cannot be found or has started exiting.
  * Returns EINVAL if state is NULL.
  * Sets *state to 1 if pid is backgrounded, and 0 otherwise.
@@ -462,22 +603,24 @@ proc_pidbackgrounded(pid_t pid, uint32_t* state)
 {
        proc_t target_proc = PROC_NULL;
 
-       if (state == NULL)
-               return(EINVAL); 
+       if (state == NULL) {
+               return EINVAL;
+       }
 
        target_proc = proc_find(pid);
 
-       if (target_proc == PROC_NULL)
-               return(ESRCH);
+       if (target_proc == PROC_NULL) {
+               return ESRCH;
+       }
 
-       if ( proc_get_effective_task_policy(target_proc->task, TASK_POLICY_DARWIN_BG) ) {
+       if (proc_get_effective_task_policy(target_proc->task, TASK_POLICY_DARWIN_BG)) {
                *state = 1;
        } else {
                *state = 0;
        }
 
        proc_rele(target_proc);
-       return (0);
+       return 0;
 }
 
 /*
@@ -491,14 +634,14 @@ proc_get_originatorbgstate(uint32_t *is_backgrounded)
 {
        uint32_t bgstate;
        proc_t p = current_proc();
-       uint32_t flagsp;
+       uint32_t flagsp = 0;
        kern_return_t kr;
        pid_t pid;
        int ret;
        thread_t thread = current_thread();
 
        bgstate = proc_get_effective_thread_policy(thread, TASK_POLICY_DARWIN_BG);
-       
+
        /* If current thread or task backgrounded, return background */
        if (bgstate) {
                *is_backgrounded = 1;
@@ -518,12 +661,13 @@ proc_get_originatorbgstate(uint32_t *is_backgrounded)
         */
        kr = thread_get_current_voucher_origin_pid(&pid);
        if (kr != KERN_SUCCESS) {
-               if (kr == KERN_INVALID_TASK)
+               if (kr == KERN_INVALID_TASK) {
                        return ESRCH;
-               else if (kr == KERN_INVALID_VALUE)
+               } else if (kr == KERN_INVALID_VALUE) {
                        return ENOATTR;
-               else
+               } else {
                        return EINVAL;
+               }
        }
 
        ret = proc_pidbackgrounded(pid, is_backgrounded);
@@ -535,29 +679,29 @@ proc_apply_resource_actions(void * bsdinfo, __unused int type, int action)
 {
        proc_t p = (proc_t)bsdinfo;
 
-       switch(action) {
-               case PROC_POLICY_RSRCACT_THROTTLE:
-                       /* no need to do anything */
-                       break;
+       switch (action) {
+       case PROC_POLICY_RSRCACT_THROTTLE:
+               /* no need to do anything */
+               break;
 
-               case PROC_POLICY_RSRCACT_SUSPEND:
-                       task_suspend(p->task);
-                       break;
+       case PROC_POLICY_RSRCACT_SUSPEND:
+               task_suspend(p->task);
+               break;
 
-               case PROC_POLICY_RSRCACT_TERMINATE:
-                       psignal(p, SIGKILL);
-                       break;
+       case PROC_POLICY_RSRCACT_TERMINATE:
+               psignal(p, SIGKILL);
+               break;
 
-               case PROC_POLICY_RSRCACT_NOTIFY_KQ:
-                       /* not implemented */
-                       break;
-               
-               case PROC_POLICY_RSRCACT_NOTIFY_EXC:
-                       panic("shouldn't be applying exception notification to process!");
-                       break;
+       case PROC_POLICY_RSRCACT_NOTIFY_KQ:
+               /* not implemented */
+               break;
+
+       case PROC_POLICY_RSRCACT_NOTIFY_EXC:
+               panic("shouldn't be applying exception notification to process!");
+               break;
        }
 
-       return(0);
+       return 0;
 }
 
 int
@@ -565,20 +709,18 @@ proc_restore_resource_actions(void * bsdinfo, __unused int type, int action)
 {
        proc_t p = (proc_t)bsdinfo;
 
-       switch(action) {
-               case PROC_POLICY_RSRCACT_THROTTLE:
-               case PROC_POLICY_RSRCACT_TERMINATE:
-               case PROC_POLICY_RSRCACT_NOTIFY_KQ:
-               case PROC_POLICY_RSRCACT_NOTIFY_EXC:
-                       /* no need to do anything */
-                       break;
-
-               case PROC_POLICY_RSRCACT_SUSPEND:
-                       task_resume(p->task);
-                       break;
-
+       switch (action) {
+       case PROC_POLICY_RSRCACT_THROTTLE:
+       case PROC_POLICY_RSRCACT_TERMINATE:
+       case PROC_POLICY_RSRCACT_NOTIFY_KQ:
+       case PROC_POLICY_RSRCACT_NOTIFY_EXC:
+               /* no need to do anything */
+               break;
+
+       case PROC_POLICY_RSRCACT_SUSPEND:
+               task_resume(p->task);
+               break;
        }
 
-       return(0);
+       return 0;
 }
-