#include "internal.h"
#include "kern/kern_trace.h"
-extern int __unix_conforming;
-
#ifndef BUILDING_VARIANT /* [ */
#ifdef PLOCKSTAT
/* This function is never called and exists to provide never-fired dtrace
* probes so that user d scripts don't get errors.
*/
-PTHREAD_NOEXPORT PTHREAD_USED
-void
+OS_USED static void
+_plockstat_never_fired(void);
+static void
_plockstat_never_fired(void)
{
PLOCKSTAT_MUTEX_SPIN(NULL);
#define PTHREAD_MUTEX_INIT_UNUSED 1
-PTHREAD_NOEXPORT PTHREAD_WEAK // prevent inlining of return value into callers
-int _pthread_mutex_lock_slow(pthread_mutex_t *omutex, bool trylock);
+#if !VARIANT_DYLD
-PTHREAD_NOEXPORT PTHREAD_WEAK // prevent inlining of return value into callers
-int _pthread_mutex_unlock_slow(pthread_mutex_t *omutex);
+int __pthread_mutex_default_opt_policy = _PTHREAD_MTX_OPT_POLICY_DEFAULT;
+bool __pthread_mutex_use_ulock = _PTHREAD_MTX_OPT_ULOCK_DEFAULT;
+bool __pthread_mutex_ulock_adaptive_spin = _PTHREAD_MTX_OPT_ADAPTIVE_DEFAULT;
+
+static inline bool
+_pthread_mutex_policy_validate(int policy)
+{
+ return (policy >= 0 && policy < _PTHREAD_MUTEX_POLICY_LAST);
+}
-PTHREAD_NOEXPORT PTHREAD_WEAK // prevent inlining of return value into callers
-int _pthread_mutex_corruption_abort(_pthread_mutex *mutex);
+static inline int
+_pthread_mutex_policy_to_opt(int policy)
+{
+ switch (policy) {
+ case PTHREAD_MUTEX_POLICY_FAIRSHARE_NP:
+ return _PTHREAD_MTX_OPT_POLICY_FAIRSHARE;
+ case PTHREAD_MUTEX_POLICY_FIRSTFIT_NP:
+ return _PTHREAD_MTX_OPT_POLICY_FIRSTFIT;
+ default:
+ __builtin_unreachable();
+ }
+}
+void
+_pthread_mutex_global_init(const char *envp[],
+ struct _pthread_registration_data *registration_data)
+{
+ int opt = _PTHREAD_MTX_OPT_POLICY_DEFAULT;
+ if (registration_data->mutex_default_policy) {
+ int policy = registration_data->mutex_default_policy &
+ _PTHREAD_REG_DEFAULT_POLICY_MASK;
+ if (_pthread_mutex_policy_validate(policy)) {
+ opt = _pthread_mutex_policy_to_opt(policy);
+ }
+ }
-PTHREAD_ALWAYS_INLINE
-static inline int _pthread_mutex_init(_pthread_mutex *mutex,
- const pthread_mutexattr_t *attr, uint32_t static_type);
+ const char *envvar = _simple_getenv(envp, "PTHREAD_MUTEX_DEFAULT_POLICY");
+ if (envvar) {
+ int policy = envvar[0] - '0';
+ if (_pthread_mutex_policy_validate(policy)) {
+ opt = _pthread_mutex_policy_to_opt(policy);
+ }
+ }
-#define DEBUG_TRACE_POINTS 0
+ if (opt != __pthread_mutex_default_opt_policy) {
+ __pthread_mutex_default_opt_policy = opt;
+ }
+
+ bool use_ulock = _PTHREAD_MTX_OPT_ULOCK_DEFAULT;
+ if (_os_xbs_chrooted) {
+ use_ulock = false;
+ } else {
+ envvar = _simple_getenv(envp, "PTHREAD_MUTEX_USE_ULOCK");
+ if (envvar) {
+ use_ulock = (envvar[0] == '1');
+ } else if (registration_data->mutex_default_policy) {
+ use_ulock = registration_data->mutex_default_policy &
+ _PTHREAD_REG_DEFAULT_USE_ULOCK;
+ }
+ }
+
+ if (use_ulock != __pthread_mutex_use_ulock) {
+ __pthread_mutex_use_ulock = use_ulock;
+ }
+
+ bool adaptive_spin = _PTHREAD_MTX_OPT_ADAPTIVE_DEFAULT;
+ envvar = _simple_getenv(envp, "PTHREAD_MUTEX_ADAPTIVE_SPIN");
+ if (envvar) {
+ adaptive_spin = (envvar[0] == '1');
+ } else if (registration_data->mutex_default_policy) {
+ adaptive_spin = registration_data->mutex_default_policy &
+ _PTHREAD_REG_DEFAULT_USE_ADAPTIVE_SPIN;
+ }
+
+ if (adaptive_spin != __pthread_mutex_ulock_adaptive_spin) {
+ __pthread_mutex_ulock_adaptive_spin = adaptive_spin;
+ }
+}
+
+#endif // !VARIANT_DYLD
-#if DEBUG_TRACE_POINTS
-#include <sys/kdebug.h>
-#define DEBUG_TRACE(x, a, b, c, d) kdebug_trace(TRACE_##x, a, b, c, d)
-#else
-#define DEBUG_TRACE(x, a, b, c, d) do { } while(0)
-#endif
+
+OS_ALWAYS_INLINE
+static inline int _pthread_mutex_init(pthread_mutex_t *mutex,
+ const pthread_mutexattr_t *attr, uint32_t static_type);
typedef union mutex_seq {
uint32_t seq[2];
#error MUTEX_GETSEQ_ADDR assumes little endian layout of 2 32-bit sequence words
#endif
-PTHREAD_ALWAYS_INLINE
+OS_ALWAYS_INLINE
static inline void
-MUTEX_GETSEQ_ADDR(_pthread_mutex *mutex, mutex_seq **seqaddr)
+MUTEX_GETSEQ_ADDR(pthread_mutex_t *mutex, mutex_seq **seqaddr)
{
// 64-bit aligned address inside m_seq array (&m_seq[0] for aligned mutex)
// We don't require more than byte alignment on OS X. rdar://22278325
- *seqaddr = (void *)(((uintptr_t)mutex->m_seq + 0x7ul) & ~0x7ul);
+ *seqaddr = (void *)(((uintptr_t)mutex->psynch.m_seq + 0x7ul) & ~0x7ul);
}
-PTHREAD_ALWAYS_INLINE
+OS_ALWAYS_INLINE
static inline void
-MUTEX_GETTID_ADDR(_pthread_mutex *mutex, uint64_t **tidaddr)
+MUTEX_GETTID_ADDR(pthread_mutex_t *mutex, uint64_t **tidaddr)
{
// 64-bit aligned address inside m_tid array (&m_tid[0] for aligned mutex)
// We don't require more than byte alignment on OS X. rdar://22278325
- *tidaddr = (void*)(((uintptr_t)mutex->m_tid + 0x7ul) & ~0x7ul);
+ *tidaddr = (void*)(((uintptr_t)mutex->psynch.m_tid + 0x7ul) & ~0x7ul);
}
-PTHREAD_ALWAYS_INLINE
+OS_ALWAYS_INLINE
static inline void
mutex_seq_load(mutex_seq *seqaddr, mutex_seq *oldseqval)
{
oldseqval->seq_LU = seqaddr->seq_LU;
}
-PTHREAD_ALWAYS_INLINE
-static inline void
-mutex_seq_atomic_load_relaxed(mutex_seq *seqaddr, mutex_seq *oldseqval)
-{
- oldseqval->seq_LU = os_atomic_load(&seqaddr->atomic_seq_LU, relaxed);
-}
-
#define mutex_seq_atomic_load(seqaddr, oldseqval, m) \
mutex_seq_atomic_load_##m(seqaddr, oldseqval)
-PTHREAD_ALWAYS_INLINE
+OS_ALWAYS_INLINE OS_USED
static inline bool
mutex_seq_atomic_cmpxchgv_relaxed(mutex_seq *seqaddr, mutex_seq *oldseqval,
mutex_seq *newseqval)
newseqval->seq_LU, &oldseqval->seq_LU, relaxed);
}
-PTHREAD_ALWAYS_INLINE
+OS_ALWAYS_INLINE OS_USED
static inline bool
mutex_seq_atomic_cmpxchgv_acquire(mutex_seq *seqaddr, mutex_seq *oldseqval,
mutex_seq *newseqval)
newseqval->seq_LU, &oldseqval->seq_LU, acquire);
}
-PTHREAD_ALWAYS_INLINE
+OS_ALWAYS_INLINE OS_USED
static inline bool
mutex_seq_atomic_cmpxchgv_release(mutex_seq *seqaddr, mutex_seq *oldseqval,
mutex_seq *newseqval)
*/
PTHREAD_NOEXPORT_VARIANT
int
-pthread_mutex_init(pthread_mutex_t *omutex, const pthread_mutexattr_t *attr)
+pthread_mutex_init(pthread_mutex_t *mutex, const pthread_mutexattr_t *attr)
{
#if 0
/* conformance tests depend on not having this behavior */
if (_pthread_mutex_check_signature(mutex))
return EBUSY;
#endif
- _pthread_mutex *mutex = (_pthread_mutex *)omutex;
- _PTHREAD_LOCK_INIT(mutex->lock);
+ _pthread_lock_init(&mutex->lock);
return (_pthread_mutex_init(mutex, attr, 0x7));
}
-PTHREAD_NOEXPORT_VARIANT
+
int
pthread_mutex_getprioceiling(const pthread_mutex_t *omutex, int *prioceiling)
{
int res = EINVAL;
- _pthread_mutex *mutex = (_pthread_mutex *)omutex;
+ pthread_mutex_t *mutex = (pthread_mutex_t *)omutex;
if (_pthread_mutex_check_signature(mutex)) {
- _PTHREAD_LOCK(mutex->lock);
+ _pthread_lock_lock(&mutex->lock);
*prioceiling = mutex->prioceiling;
res = 0;
- _PTHREAD_UNLOCK(mutex->lock);
+ _pthread_lock_unlock(&mutex->lock);
}
return res;
}
-PTHREAD_NOEXPORT_VARIANT
int
-pthread_mutex_setprioceiling(pthread_mutex_t *omutex, int prioceiling,
+pthread_mutex_setprioceiling(pthread_mutex_t *mutex, int prioceiling,
int *old_prioceiling)
{
int res = EINVAL;
- _pthread_mutex *mutex = (_pthread_mutex *)omutex;
if (_pthread_mutex_check_signature(mutex)) {
- _PTHREAD_LOCK(mutex->lock);
+ _pthread_lock_lock(&mutex->lock);
if (prioceiling >= -999 && prioceiling <= 999) {
*old_prioceiling = mutex->prioceiling;
mutex->prioceiling = (int16_t)prioceiling;
res = 0;
}
- _PTHREAD_UNLOCK(mutex->lock);
+ _pthread_lock_unlock(&mutex->lock);
}
return res;
}
-
int
pthread_mutexattr_getprioceiling(const pthread_mutexattr_t *attr,
int *prioceiling)
return res;
}
+int
+pthread_mutexattr_getpolicy_np(const pthread_mutexattr_t *attr, int *policy)
+{
+ int res = EINVAL;
+ if (attr->sig == _PTHREAD_MUTEX_ATTR_SIG) {
+ switch (attr->opt) {
+ case _PTHREAD_MTX_OPT_POLICY_FAIRSHARE:
+ *policy = PTHREAD_MUTEX_POLICY_FAIRSHARE_NP;
+ res = 0;
+ break;
+ case _PTHREAD_MTX_OPT_POLICY_FIRSTFIT:
+ *policy = PTHREAD_MUTEX_POLICY_FIRSTFIT_NP;
+ res = 0;
+ break;
+ }
+ }
+ return res;
+}
+
int
pthread_mutexattr_gettype(const pthread_mutexattr_t *attr, int *type)
{
{
attr->prioceiling = _PTHREAD_DEFAULT_PRIOCEILING;
attr->protocol = _PTHREAD_DEFAULT_PROTOCOL;
- attr->policy = _PTHREAD_MUTEX_POLICY_FAIRSHARE;
+ attr->opt = __pthread_mutex_default_opt_policy;
attr->type = PTHREAD_MUTEX_DEFAULT;
attr->sig = _PTHREAD_MUTEX_ATTR_SIG;
attr->pshared = _PTHREAD_DEFAULT_PSHARED;
int res = EINVAL;
if (attr->sig == _PTHREAD_MUTEX_ATTR_SIG) {
switch (protocol) {
- case PTHREAD_PRIO_NONE:
- case PTHREAD_PRIO_INHERIT:
- case PTHREAD_PRIO_PROTECT:
- attr->protocol = protocol;
- res = 0;
- break;
+ case PTHREAD_PRIO_NONE:
+ case PTHREAD_PRIO_INHERIT:
+ case PTHREAD_PRIO_PROTECT:
+ attr->protocol = protocol;
+ res = 0;
+ break;
}
}
return res;
{
int res = EINVAL;
if (attr->sig == _PTHREAD_MUTEX_ATTR_SIG) {
+ // <rdar://problem/35844519> the first-fit implementation was broken
+ // pre-Liberty so this mapping exists to ensure that the old first-fit
+ // define (2) is no longer valid when used on older systems.
switch (policy) {
- case _PTHREAD_MUTEX_POLICY_FAIRSHARE:
- case _PTHREAD_MUTEX_POLICY_FIRSTFIT:
- attr->policy = policy;
- res = 0;
- break;
+ case PTHREAD_MUTEX_POLICY_FAIRSHARE_NP:
+ attr->opt = _PTHREAD_MTX_OPT_POLICY_FAIRSHARE;
+ res = 0;
+ break;
+ case PTHREAD_MUTEX_POLICY_FIRSTFIT_NP:
+ attr->opt = _PTHREAD_MTX_OPT_POLICY_FIRSTFIT;
+ res = 0;
+ break;
}
}
return res;
int res = EINVAL;
if (attr->sig == _PTHREAD_MUTEX_ATTR_SIG) {
switch (type) {
- case PTHREAD_MUTEX_NORMAL:
- case PTHREAD_MUTEX_ERRORCHECK:
- case PTHREAD_MUTEX_RECURSIVE:
- //case PTHREAD_MUTEX_DEFAULT:
- attr->type = type;
- res = 0;
- break;
+ case PTHREAD_MUTEX_NORMAL:
+ case PTHREAD_MUTEX_ERRORCHECK:
+ case PTHREAD_MUTEX_RECURSIVE:
+ //case PTHREAD_MUTEX_DEFAULT:
+ attr->type = type;
+ res = 0;
+ break;
}
}
return res;
pthread_mutexattr_setpshared(pthread_mutexattr_t *attr, int pshared)
{
int res = EINVAL;
-#if __DARWIN_UNIX03
- if (__unix_conforming == 0) {
- __unix_conforming = 1;
- }
-#endif /* __DARWIN_UNIX03 */
-
if (attr->sig == _PTHREAD_MUTEX_ATTR_SIG) {
-#if __DARWIN_UNIX03
if (( pshared == PTHREAD_PROCESS_PRIVATE) ||
(pshared == PTHREAD_PROCESS_SHARED))
-#else /* __DARWIN_UNIX03 */
- if ( pshared == PTHREAD_PROCESS_PRIVATE)
-#endif /* __DARWIN_UNIX03 */
{
attr->pshared = pshared;
res = 0;
return res;
}
-PTHREAD_NOEXPORT PTHREAD_NOINLINE PTHREAD_NORETURN
+OS_NOINLINE
int
-_pthread_mutex_corruption_abort(_pthread_mutex *mutex)
+_pthread_mutex_corruption_abort(pthread_mutex_t *mutex)
+{
+ PTHREAD_CLIENT_CRASH(0, "pthread_mutex corruption: mutex owner changed "
+ "in the middle of lock/unlock");
+}
+
+
+OS_NOINLINE
+static int
+_pthread_mutex_check_init_slow(pthread_mutex_t *mutex)
+{
+ int res = EINVAL;
+
+ if (_pthread_mutex_check_signature_init(mutex)) {
+ _pthread_lock_lock(&mutex->lock);
+ if (_pthread_mutex_check_signature_init(mutex)) {
+ // initialize a statically initialized mutex to provide
+ // compatibility for misbehaving applications.
+ // (unlock should not be the first operation on a mutex)
+ res = _pthread_mutex_init(mutex, NULL, (mutex->sig & 0xf));
+ } else if (_pthread_mutex_check_signature(mutex)) {
+ res = 0;
+ }
+ _pthread_lock_unlock(&mutex->lock);
+ } else if (_pthread_mutex_check_signature(mutex)) {
+ res = 0;
+ }
+ if (res != 0) {
+ PLOCKSTAT_MUTEX_ERROR((pthread_mutex_t *)mutex, res);
+ }
+ return res;
+}
+
+OS_ALWAYS_INLINE
+static inline int
+_pthread_mutex_check_init(pthread_mutex_t *mutex)
+{
+ int res = 0;
+ if (!_pthread_mutex_check_signature(mutex)) {
+ return _pthread_mutex_check_init_slow(mutex);
+ }
+ return res;
+}
+
+OS_ALWAYS_INLINE
+static inline bool
+_pthread_mutex_is_fairshare(pthread_mutex_t *mutex)
+{
+ return (mutex->mtxopts.options.policy == _PTHREAD_MTX_OPT_POLICY_FAIRSHARE);
+}
+
+OS_ALWAYS_INLINE
+static inline bool
+_pthread_mutex_is_firstfit(pthread_mutex_t *mutex)
+{
+ return (mutex->mtxopts.options.policy == _PTHREAD_MTX_OPT_POLICY_FIRSTFIT);
+}
+
+OS_ALWAYS_INLINE
+static inline bool
+_pthread_mutex_is_recursive(pthread_mutex_t *mutex)
+{
+ return (mutex->mtxopts.options.type == PTHREAD_MUTEX_RECURSIVE);
+}
+
+OS_ALWAYS_INLINE
+static int
+_pthread_mutex_lock_handle_options(pthread_mutex_t *mutex, bool trylock,
+ uint64_t *tidaddr)
{
- PTHREAD_ABORT("pthread_mutex corruption: mutex owner changed in the "
- "middle of lock/unlock");
+ if (mutex->mtxopts.options.type == PTHREAD_MUTEX_NORMAL) {
+ // NORMAL does not do EDEADLK checking
+ return 0;
+ }
+
+ uint64_t selfid = _pthread_threadid_self_np_direct();
+ if (os_atomic_load_wide(tidaddr, relaxed) == selfid) {
+ if (_pthread_mutex_is_recursive(mutex)) {
+ if (mutex->mtxopts.options.lock_count < USHRT_MAX) {
+ mutex->mtxopts.options.lock_count += 1;
+ return mutex->mtxopts.options.lock_count;
+ } else {
+ return -EAGAIN;
+ }
+ } else if (trylock) { /* PTHREAD_MUTEX_ERRORCHECK */
+ // <rdar://problem/16261552> as per OpenGroup, trylock cannot
+ // return EDEADLK on a deadlock, it should return EBUSY.
+ return -EBUSY;
+ } else { /* PTHREAD_MUTEX_ERRORCHECK */
+ return -EDEADLK;
+ }
+ }
+
+ // Not recursive, or recursive but first lock.
+ return 0;
}
+OS_ALWAYS_INLINE
+static int
+_pthread_mutex_unlock_handle_options(pthread_mutex_t *mutex, uint64_t *tidaddr)
+{
+ if (mutex->mtxopts.options.type == PTHREAD_MUTEX_NORMAL) {
+ // NORMAL does not do EDEADLK checking
+ return 0;
+ }
+
+ uint64_t selfid = _pthread_threadid_self_np_direct();
+ if (os_atomic_load_wide(tidaddr, relaxed) != selfid) {
+ return -EPERM;
+ } else if (_pthread_mutex_is_recursive(mutex) &&
+ --mutex->mtxopts.options.lock_count) {
+ return 1;
+ }
+ return 0;
+}
/*
* Sequence numbers and TID:
/*
* Drop the mutex unlock references from cond_wait or mutex_unlock.
*/
-PTHREAD_ALWAYS_INLINE
+OS_ALWAYS_INLINE
static inline int
-_pthread_mutex_unlock_updatebits(_pthread_mutex *mutex, uint32_t *flagsp,
- uint32_t **pmtxp, uint32_t *mgenp, uint32_t *ugenp)
+_pthread_mutex_fairshare_unlock_updatebits(pthread_mutex_t *mutex,
+ uint32_t *flagsp, uint32_t **pmtxp, uint32_t *mgenp, uint32_t *ugenp)
{
- bool firstfit = (mutex->mtxopts.options.policy ==
- _PTHREAD_MUTEX_POLICY_FIRSTFIT);
uint32_t flags = mutex->mtxopts.value;
flags &= ~_PTHREAD_MTX_OPT_NOTIFY; // no notification by default
MUTEX_GETTID_ADDR(mutex, &tidaddr);
uint64_t oldtid, newtid;
- if (mutex->mtxopts.options.type != PTHREAD_MUTEX_NORMAL) {
- uint64_t selfid = _pthread_selfid_direct();
- if (os_atomic_load(tidaddr, relaxed) != selfid) {
- PLOCKSTAT_MUTEX_ERROR((pthread_mutex_t *)mutex, EPERM);
- return EPERM;
- } else if (mutex->mtxopts.options.type == PTHREAD_MUTEX_RECURSIVE &&
- --mutex->mtxopts.options.lock_count) {
- PLOCKSTAT_MUTEX_RELEASE((pthread_mutex_t *)mutex, 1);
- if (flagsp != NULL) {
- *flagsp = flags;
- }
- return 0;
+ int res = _pthread_mutex_unlock_handle_options(mutex, tidaddr);
+ if (res > 0) {
+ // Valid recursive unlock
+ if (flagsp) {
+ *flagsp = flags;
}
+ PLOCKSTAT_MUTEX_RELEASE((pthread_mutex_t *)mutex, 1);
+ return 0;
+ } else if (res < 0) {
+ PLOCKSTAT_MUTEX_ERROR((pthread_mutex_t *)mutex, -res);
+ return -res;
}
- bool clearprepost, clearnotify, spurious;
+ bool clearnotify, spurious;
do {
newseq = oldseq;
- oldtid = os_atomic_load(tidaddr, relaxed);
+ oldtid = os_atomic_load_wide(tidaddr, relaxed);
- clearprepost = false;
clearnotify = false;
spurious = false;
clearnotify = true;
newtid = 0; // clear owner
} else {
- if (firstfit) {
- // reset E bit so another can acquire meanwhile
- newseq.lgenval &= ~PTH_RWL_EBIT;
- newtid = 0;
- } else {
- newtid = PTHREAD_MTX_TID_SWITCHING;
- }
+ newtid = PTHREAD_MTX_TID_SWITCHING;
// need to signal others waiting for mutex
flags |= _PTHREAD_MTX_OPT_NOTIFY;
}
if (clearnotify || spurious) {
flags &= ~_PTHREAD_MTX_OPT_NOTIFY;
- if (firstfit && (newseq.lgenval & PTH_RWL_PBIT)) {
- clearprepost = true;
- newseq.lgenval &= ~PTH_RWL_PBIT;
- }
}
} while (!mutex_seq_atomic_cmpxchgv(seqaddr, &oldseq, &newseq, release));
- if (clearprepost) {
- __psynch_cvclrprepost(mutex, newseq.lgenval, newseq.ugenval, 0, 0,
- newseq.lgenval, flags | _PTHREAD_MTX_OPT_MUTEX);
- }
+ PTHREAD_TRACE(psynch_mutex_unlock_updatebits, mutex, oldseq.lgenval,
+ newseq.lgenval, oldtid);
if (mgenp != NULL) {
*mgenp = newseq.lgenval;
return 0;
}
-PTHREAD_NOEXPORT PTHREAD_NOINLINE
-int
-_pthread_mutex_droplock(_pthread_mutex *mutex, uint32_t *flagsp,
- uint32_t **pmtxp, uint32_t *mgenp, uint32_t *ugenp)
-{
- return _pthread_mutex_unlock_updatebits(mutex, flagsp, pmtxp, mgenp, ugenp);
-}
-
-PTHREAD_ALWAYS_INLINE
+OS_ALWAYS_INLINE
static inline int
-_pthread_mutex_lock_updatebits(_pthread_mutex *mutex, uint64_t selfid)
+_pthread_mutex_fairshare_lock_updatebits(pthread_mutex_t *mutex, uint64_t selfid)
{
- int res = 0;
- bool firstfit = (mutex->mtxopts.options.policy ==
- _PTHREAD_MUTEX_POLICY_FIRSTFIT);
- bool isebit = false, updated = false;
+ bool firstfit = _pthread_mutex_is_firstfit(mutex);
+ bool gotlock = true;
mutex_seq *seqaddr;
MUTEX_GETSEQ_ADDR(mutex, &seqaddr);
uint64_t *tidaddr;
MUTEX_GETTID_ADDR(mutex, &tidaddr);
- uint64_t oldtid;
do {
- if (firstfit && isebit && updated) {
- mutex_seq_atomic_load(seqaddr, &oldseq, relaxed);
- }
newseq = oldseq;
- oldtid = os_atomic_load(tidaddr, relaxed);
-
- if (isebit && !(oldseq.lgenval & PTH_RWL_EBIT)) {
- // E bit was set on first pass through the loop but is no longer
- // set. Apparently we spin until it arrives.
- // XXX: verify this is desired behavior.
- continue;
- }
-
- if (isebit) {
- // first fit mutex now has the E bit set. Return 1.
- res = 1;
- break;
- }
if (firstfit) {
- isebit = (oldseq.lgenval & PTH_RWL_EBIT);
- } else if ((oldseq.lgenval & (PTH_RWL_KBIT|PTH_RWL_EBIT)) ==
- (PTH_RWL_KBIT|PTH_RWL_EBIT)) {
- // fairshare mutex and the bits are already set, just update tid
+ // firstfit locks can have the lock stolen out from under a locker
+ // between the unlock from the kernel and this lock path. When this
+ // happens, we still want to set the K bit before leaving the loop
+ // (or notice if the lock unlocks while we try to update).
+ gotlock = !is_rwl_ebit_set(oldseq.lgenval);
+ } else if ((oldseq.lgenval & (PTH_RWL_KBIT | PTH_RWL_EBIT)) ==
+ (PTH_RWL_KBIT | PTH_RWL_EBIT)) {
+ // bit are already set, just update the owner tidaddr
break;
}
- // either first fit or no E bit set
- // update the bits
newseq.lgenval |= PTH_RWL_KBIT | PTH_RWL_EBIT;
+ } while (!mutex_seq_atomic_cmpxchgv(seqaddr, &oldseq, &newseq,
+ acquire));
- // Retry if CAS fails, or if it succeeds with firstfit and E bit
- // already set
- } while (!(updated = mutex_seq_atomic_cmpxchgv(seqaddr, &oldseq, &newseq,
- relaxed)) || (firstfit && isebit));
-
- if (res == 0) {
- if (!os_atomic_cmpxchg(tidaddr, oldtid, selfid, relaxed)) {
- // we own this mutex, nobody should be updating it except us
- return _pthread_mutex_corruption_abort(mutex);
- }
- }
-
- return res;
-}
-
-PTHREAD_NOINLINE
-static int
-_pthread_mutex_markprepost(_pthread_mutex *mutex, uint32_t updateval)
-{
- mutex_seq *seqaddr;
- MUTEX_GETSEQ_ADDR(mutex, &seqaddr);
-
- mutex_seq oldseq, newseq;
- mutex_seq_load(seqaddr, &oldseq);
-
- bool clearprepost;
- do {
- clearprepost = false;
- newseq = oldseq;
-
- /* update the bits */
- if ((oldseq.lgenval & PTHRW_COUNT_MASK) ==
- (oldseq.ugenval & PTHRW_COUNT_MASK)) {
- clearprepost = true;
- newseq.lgenval &= ~PTH_RWL_PBIT;
- } else {
- newseq.lgenval |= PTH_RWL_PBIT;
- }
- } while (!mutex_seq_atomic_cmpxchgv(seqaddr, &oldseq, &newseq, relaxed));
-
- if (clearprepost) {
- __psynch_cvclrprepost(mutex, newseq.lgenval, newseq.ugenval, 0, 0,
- newseq.lgenval, mutex->mtxopts.value | _PTHREAD_MTX_OPT_MUTEX);
- }
-
- return 0;
-}
-
-PTHREAD_NOINLINE
-static int
-_pthread_mutex_check_init_slow(pthread_mutex_t *omutex)
-{
- int res = EINVAL;
- _pthread_mutex *mutex = (_pthread_mutex *)omutex;
-
- if (_pthread_mutex_check_signature_init(mutex)) {
- _PTHREAD_LOCK(mutex->lock);
- if (_pthread_mutex_check_signature_init(mutex)) {
- // initialize a statically initialized mutex to provide
- // compatibility for misbehaving applications.
- // (unlock should not be the first operation on a mutex)
- res = _pthread_mutex_init(mutex, NULL, (mutex->sig & 0xf));
- } else if (_pthread_mutex_check_signature(mutex)) {
- res = 0;
- }
- _PTHREAD_UNLOCK(mutex->lock);
- } else if (_pthread_mutex_check_signature(mutex)) {
- res = 0;
- }
- if (res != 0) {
- PLOCKSTAT_MUTEX_ERROR(omutex, res);
+ if (gotlock) {
+ os_atomic_store_wide(tidaddr, selfid, relaxed);
}
- return res;
-}
-PTHREAD_ALWAYS_INLINE
-static inline int
-_pthread_mutex_check_init(pthread_mutex_t *omutex)
-{
- int res = 0;
- _pthread_mutex *mutex = (_pthread_mutex *)omutex;
+ PTHREAD_TRACE(psynch_mutex_lock_updatebits, mutex, oldseq.lgenval,
+ newseq.lgenval, 0);
- if (!_pthread_mutex_check_signature(mutex)) {
- return _pthread_mutex_check_init_slow(omutex);
- }
- return res;
+ // failing to take the lock in firstfit returns 1 to force the caller
+ // to wait in the kernel
+ return gotlock ? 0 : 1;
}
-PTHREAD_NOINLINE
+OS_NOINLINE
static int
-_pthread_mutex_lock_wait(pthread_mutex_t *omutex, mutex_seq newseq,
+_pthread_mutex_fairshare_lock_wait(pthread_mutex_t *mutex, mutex_seq newseq,
uint64_t oldtid)
{
- _pthread_mutex *mutex = (_pthread_mutex *)omutex;
-
uint64_t *tidaddr;
MUTEX_GETTID_ADDR(mutex, &tidaddr);
- uint64_t selfid = _pthread_selfid_direct();
+ uint64_t selfid = _pthread_threadid_self_np_direct();
- PLOCKSTAT_MUTEX_BLOCK(omutex);
+ PLOCKSTAT_MUTEX_BLOCK((pthread_mutex_t *)mutex);
do {
uint32_t updateval;
do {
- updateval = __psynch_mutexwait(omutex, newseq.lgenval,
+ updateval = __psynch_mutexwait(mutex, newseq.lgenval,
newseq.ugenval, oldtid, mutex->mtxopts.value);
- oldtid = os_atomic_load(tidaddr, relaxed);
+ oldtid = os_atomic_load_wide(tidaddr, relaxed);
} while (updateval == (uint32_t)-1);
// returns 0 on succesful update; in firstfit it may fail with 1
- } while (_pthread_mutex_lock_updatebits(mutex, selfid) == 1);
- PLOCKSTAT_MUTEX_BLOCKED(omutex, BLOCK_SUCCESS_PLOCKSTAT);
+ } while (_pthread_mutex_fairshare_lock_updatebits(mutex, selfid) == 1);
+ PLOCKSTAT_MUTEX_BLOCKED((pthread_mutex_t *)mutex, BLOCK_SUCCESS_PLOCKSTAT);
return 0;
}
-PTHREAD_NOEXPORT PTHREAD_NOINLINE
+OS_NOINLINE
int
-_pthread_mutex_lock_slow(pthread_mutex_t *omutex, bool trylock)
+_pthread_mutex_fairshare_lock_slow(pthread_mutex_t *mutex, bool trylock)
{
int res, recursive = 0;
- _pthread_mutex *mutex = (_pthread_mutex *)omutex;
-
- res = _pthread_mutex_check_init(omutex);
- if (res != 0) return res;
mutex_seq *seqaddr;
MUTEX_GETSEQ_ADDR(mutex, &seqaddr);
uint64_t *tidaddr;
MUTEX_GETTID_ADDR(mutex, &tidaddr);
- uint64_t oldtid, selfid = _pthread_selfid_direct();
-
- if (mutex->mtxopts.options.type != PTHREAD_MUTEX_NORMAL) {
- if (os_atomic_load(tidaddr, relaxed) == selfid) {
- if (mutex->mtxopts.options.type == PTHREAD_MUTEX_RECURSIVE) {
- if (mutex->mtxopts.options.lock_count < USHRT_MAX) {
- mutex->mtxopts.options.lock_count++;
- recursive = 1;
- res = 0;
- } else {
- res = EAGAIN;
- }
- } else if (trylock) { /* PTHREAD_MUTEX_ERRORCHECK */
- // <rdar://problem/16261552> as per OpenGroup, trylock cannot
- // return EDEADLK on a deadlock, it should return EBUSY.
- res = EBUSY;
- } else { /* PTHREAD_MUTEX_ERRORCHECK */
- res = EDEADLK;
- }
- goto out;
- }
+ uint64_t oldtid, selfid = _pthread_threadid_self_np_direct();
+
+ res = _pthread_mutex_lock_handle_options(mutex, trylock, tidaddr);
+ if (res > 0) {
+ recursive = 1;
+ res = 0;
+ goto out;
+ } else if (res < 0) {
+ res = -res;
+ goto out;
}
bool gotlock;
do {
newseq = oldseq;
- oldtid = os_atomic_load(tidaddr, relaxed);
+ oldtid = os_atomic_load_wide(tidaddr, relaxed);
gotlock = ((oldseq.lgenval & PTH_RWL_EBIT) == 0);
}
} while (!mutex_seq_atomic_cmpxchgv(seqaddr, &oldseq, &newseq, acquire));
+ PTHREAD_TRACE(psynch_mutex_lock_updatebits, mutex, oldseq.lgenval,
+ newseq.lgenval, 0);
+
if (gotlock) {
- os_atomic_store(tidaddr, selfid, relaxed);
+ os_atomic_store_wide(tidaddr, selfid, relaxed);
res = 0;
- DEBUG_TRACE(psynch_mutex_ulock, omutex, lgenval, ugenval, selfid);
+ PTHREAD_TRACE(psynch_mutex_ulock, mutex, newseq.lgenval,
+ newseq.ugenval, selfid);
} else if (trylock) {
res = EBUSY;
- DEBUG_TRACE(psynch_mutex_utrylock_failed, omutex, lgenval, ugenval,
- oldtid);
+ PTHREAD_TRACE(psynch_mutex_utrylock_failed, mutex, newseq.lgenval,
+ newseq.ugenval, oldtid);
} else {
- res = _pthread_mutex_lock_wait(omutex, newseq, oldtid);
+ PTHREAD_TRACE(psynch_mutex_ulock | DBG_FUNC_START, mutex,
+ newseq.lgenval, newseq.ugenval, oldtid);
+ res = _pthread_mutex_fairshare_lock_wait(mutex, newseq, oldtid);
+ PTHREAD_TRACE(psynch_mutex_ulock | DBG_FUNC_END, mutex,
+ newseq.lgenval, newseq.ugenval, oldtid);
}
- if (res == 0 && mutex->mtxopts.options.type == PTHREAD_MUTEX_RECURSIVE) {
+ if (res == 0 && _pthread_mutex_is_recursive(mutex)) {
mutex->mtxopts.options.lock_count = 1;
}
out:
#if PLOCKSTAT
if (res == 0) {
- PLOCKSTAT_MUTEX_ACQUIRE(omutex, recursive, 0);
+ PLOCKSTAT_MUTEX_ACQUIRE((pthread_mutex_t *)mutex, recursive, 0);
} else {
- PLOCKSTAT_MUTEX_ERROR(omutex, res);
+ PLOCKSTAT_MUTEX_ERROR((pthread_mutex_t *)mutex, res);
}
#endif
return res;
}
-PTHREAD_ALWAYS_INLINE
+OS_NOINLINE
static inline int
-_pthread_mutex_lock(pthread_mutex_t *omutex, bool trylock)
+_pthread_mutex_fairshare_lock(pthread_mutex_t *mutex, bool trylock)
{
-#if PLOCKSTAT || DEBUG_TRACE_POINTS
- if (PLOCKSTAT_MUTEX_ACQUIRE_ENABLED() || PLOCKSTAT_MUTEX_ERROR_ENABLED() ||
- DEBUG_TRACE_POINTS) {
- return _pthread_mutex_lock_slow(omutex, trylock);
+#if ENABLE_USERSPACE_TRACE
+ return _pthread_mutex_fairshare_lock_slow(mutex, trylock);
+#elif PLOCKSTAT
+ if (PLOCKSTAT_MUTEX_ACQUIRE_ENABLED() || PLOCKSTAT_MUTEX_ERROR_ENABLED()) {
+ return _pthread_mutex_fairshare_lock_slow(mutex, trylock);
}
#endif
- _pthread_mutex *mutex = (_pthread_mutex *)omutex;
- if (os_unlikely(!_pthread_mutex_check_signature_fast(mutex))) {
- return _pthread_mutex_lock_slow(omutex, trylock);
- }
uint64_t *tidaddr;
MUTEX_GETTID_ADDR(mutex, &tidaddr);
- uint64_t selfid = _pthread_selfid_direct();
+ uint64_t selfid = _pthread_threadid_self_np_direct();
mutex_seq *seqaddr;
MUTEX_GETSEQ_ADDR(mutex, &seqaddr);
mutex_seq_load(seqaddr, &oldseq);
if (os_unlikely(oldseq.lgenval & PTH_RWL_EBIT)) {
- return _pthread_mutex_lock_slow(omutex, trylock);
+ return _pthread_mutex_fairshare_lock_slow(mutex, trylock);
}
bool gotlock;
newseq.lgenval += PTHRW_INC;
newseq.lgenval |= PTH_RWL_EBIT | PTH_RWL_KBIT;
} else {
- return _pthread_mutex_lock_slow(omutex, trylock);
+ return _pthread_mutex_fairshare_lock_slow(mutex, trylock);
}
} while (os_unlikely(!mutex_seq_atomic_cmpxchgv(seqaddr, &oldseq, &newseq,
acquire)));
if (os_likely(gotlock)) {
- os_atomic_store(tidaddr, selfid, relaxed);
+ os_atomic_store_wide(tidaddr, selfid, relaxed);
return 0;
} else if (trylock) {
return EBUSY;
}
}
-PTHREAD_NOEXPORT_VARIANT
-int
-pthread_mutex_lock(pthread_mutex_t *mutex)
-{
- return _pthread_mutex_lock(mutex, false);
-}
-
-PTHREAD_NOEXPORT_VARIANT
-int
-pthread_mutex_trylock(pthread_mutex_t *mutex)
-{
- return _pthread_mutex_lock(mutex, true);
-}
-
-/*
- * Unlock a mutex.
- * TODO: Priority inheritance stuff
- */
-
-PTHREAD_NOINLINE
+OS_NOINLINE
static int
-_pthread_mutex_unlock_drop(pthread_mutex_t *omutex, mutex_seq newseq,
+_pthread_mutex_fairshare_unlock_drop(pthread_mutex_t *mutex, mutex_seq newseq,
uint32_t flags)
{
int res;
- _pthread_mutex *mutex = (_pthread_mutex *)omutex;
-
uint32_t updateval;
uint64_t *tidaddr;
MUTEX_GETTID_ADDR(mutex, &tidaddr);
- updateval = __psynch_mutexdrop(omutex, newseq.lgenval, newseq.ugenval,
- os_atomic_load(tidaddr, relaxed), flags);
+ PTHREAD_TRACE(psynch_mutex_uunlock | DBG_FUNC_START, mutex, newseq.lgenval,
+ newseq.ugenval, os_atomic_load_wide(tidaddr, relaxed));
+
+ updateval = __psynch_mutexdrop(mutex, newseq.lgenval, newseq.ugenval,
+ os_atomic_load_wide(tidaddr, relaxed), flags);
+
+ PTHREAD_TRACE(psynch_mutex_uunlock | DBG_FUNC_END, mutex, updateval, 0, 0);
if (updateval == (uint32_t)-1) {
res = errno;
res = 0;
}
if (res != 0) {
- PTHREAD_ABORT("__psynch_mutexdrop failed with error %d", res);
+ PTHREAD_INTERNAL_CRASH(res, "__psynch_mutexdrop failed");
}
return res;
- } else if ((mutex->mtxopts.options.policy == _PTHREAD_MUTEX_POLICY_FIRSTFIT)
- && (updateval & PTH_RWL_PBIT)) {
- return _pthread_mutex_markprepost(mutex, updateval);
}
return 0;
}
-PTHREAD_NOEXPORT PTHREAD_NOINLINE
+OS_NOINLINE
int
-_pthread_mutex_unlock_slow(pthread_mutex_t *omutex)
+_pthread_mutex_fairshare_unlock_slow(pthread_mutex_t *mutex)
{
int res;
- _pthread_mutex *mutex = (_pthread_mutex *)omutex;
mutex_seq newseq;
uint32_t flags;
- // Initialize static mutexes for compatibility with misbehaving
- // applications (unlock should not be the first operation on a mutex).
- res = _pthread_mutex_check_init(omutex);
- if (res != 0) return res;
-
- res = _pthread_mutex_unlock_updatebits(mutex, &flags, NULL, &newseq.lgenval,
- &newseq.ugenval);
+ res = _pthread_mutex_fairshare_unlock_updatebits(mutex, &flags, NULL,
+ &newseq.lgenval, &newseq.ugenval);
if (res != 0) return res;
if ((flags & _PTHREAD_MTX_OPT_NOTIFY) != 0) {
- return _pthread_mutex_unlock_drop(omutex, newseq, flags);
+ return _pthread_mutex_fairshare_unlock_drop(mutex, newseq, flags);
} else {
uint64_t *tidaddr;
MUTEX_GETTID_ADDR(mutex, &tidaddr);
- DEBUG_TRACE(psynch_mutex_uunlock, omutex, mtxgen, mtxugen,
- os_atomic_load(tidaddr, relaxed));
+ PTHREAD_TRACE(psynch_mutex_uunlock, mutex, newseq.lgenval,
+ newseq.ugenval, os_atomic_load_wide(tidaddr, relaxed));
}
return 0;
}
-PTHREAD_NOEXPORT_VARIANT
-int
-pthread_mutex_unlock(pthread_mutex_t *omutex)
+OS_NOINLINE
+static int
+_pthread_mutex_fairshare_unlock(pthread_mutex_t *mutex)
{
-#if PLOCKSTAT || DEBUG_TRACE_POINTS
- if (PLOCKSTAT_MUTEX_RELEASE_ENABLED() || PLOCKSTAT_MUTEX_ERROR_ENABLED() ||
- DEBUG_TRACE_POINTS) {
- return _pthread_mutex_unlock_slow(omutex);
+#if ENABLE_USERSPACE_TRACE
+ return _pthread_mutex_fairshare_unlock_slow(mutex);
+#elif PLOCKSTAT
+ if (PLOCKSTAT_MUTEX_RELEASE_ENABLED() || PLOCKSTAT_MUTEX_ERROR_ENABLED()) {
+ return _pthread_mutex_fairshare_unlock_slow(mutex);
}
#endif
- _pthread_mutex *mutex = (_pthread_mutex *)omutex;
- if (os_unlikely(!_pthread_mutex_check_signature_fast(mutex))) {
- return _pthread_mutex_unlock_slow(omutex);
- }
uint64_t *tidaddr;
MUTEX_GETTID_ADDR(mutex, &tidaddr);
// is no stale ownership information. If the CAS of the seqaddr
// fails, we may loop, but it's still valid for the owner to be
// SWITCHING/0
- os_atomic_store(tidaddr, 0, relaxed);
+ os_atomic_store_wide(tidaddr, 0, relaxed);
do {
newseq = oldseq;
if (os_likely((oldseq.lgenval & PTHRW_COUNT_MASK) ==
(newseq.ugenval & PTHRW_COUNT_MASK))) {
- // our unlock sequence matches to lock sequence, so if the
- // CAS is successful, the mutex is unlocked
+ // if we succeed in performing the CAS we can be sure of a fast
+ // path (only needing the CAS) unlock, if:
+ // a. our lock and unlock sequence are equal
+ // b. we don't need to clear an unlock prepost from the kernel
// do not reset Ibit, just K&E
newseq.lgenval &= ~(PTH_RWL_KBIT | PTH_RWL_EBIT);
} else {
- return _pthread_mutex_unlock_slow(omutex);
+ return _pthread_mutex_fairshare_unlock_slow(mutex);
}
} while (os_unlikely(!mutex_seq_atomic_cmpxchgv(seqaddr, &oldseq, &newseq,
release)));
return 0;
}
+#pragma mark ulock
-PTHREAD_ALWAYS_INLINE
-static inline int
-_pthread_mutex_init(_pthread_mutex *mutex, const pthread_mutexattr_t *attr,
- uint32_t static_type)
+OS_ALWAYS_INLINE
+static inline uint32_t
+_pthread_mutex_ulock_self_owner_value(void)
{
- mutex->mtxopts.value = 0;
- mutex->mtxopts.options.mutex = 1;
- if (attr) {
- if (attr->sig != _PTHREAD_MUTEX_ATTR_SIG) {
- return EINVAL;
- }
- mutex->prioceiling = (int16_t)attr->prioceiling;
- mutex->mtxopts.options.protocol = attr->protocol;
- mutex->mtxopts.options.policy = attr->policy;
- mutex->mtxopts.options.type = attr->type;
- mutex->mtxopts.options.pshared = attr->pshared;
+ mach_port_t self_port = _pthread_mach_thread_self_direct();
+ return self_port & _PTHREAD_MUTEX_ULOCK_OWNER_MASK;
+}
+
+OS_NOINLINE
+static int
+_pthread_mutex_ulock_lock_slow(pthread_mutex_t *mutex, uint32_t self_ownerval,
+ uint32_t state)
+{
+ bool success = false, kernel_waiters = false;
+
+ uint32_t wait_op = UL_UNFAIR_LOCK | ULF_NO_ERRNO;
+ if (__pthread_mutex_ulock_adaptive_spin) {
+ wait_op |= ULF_WAIT_ADAPTIVE_SPIN;
+ }
+
+ PLOCKSTAT_MUTEX_BLOCK((pthread_mutex_t *)mutex);
+ do {
+ bool owner_dead = false;
+
+ do {
+ uint32_t current_ownerval = state & _PTHREAD_MUTEX_ULOCK_OWNER_MASK;
+ if (os_unlikely(owner_dead)) {
+ // TODO: PTHREAD_STRICT candidate
+ //
+ // For a non-recursive mutex, this indicates that it's really
+ // being used as a semaphore: even though we're the current
+ // owner, in reality we're expecting another thread to 'unlock'
+ // this mutex on our behalf later.
+ //
+ // __ulock_wait(2) doesn't permit you to wait for yourself, so
+ // we need to first swap our ownership for the anonymous owner
+ current_ownerval =
+ MACH_PORT_DEAD & _PTHREAD_MUTEX_ULOCK_OWNER_MASK;
+ owner_dead = false;
+ }
+ uint32_t new_state =
+ current_ownerval | _PTHREAD_MUTEX_ULOCK_WAITERS_BIT;
+ success = os_atomic_cmpxchgv(&mutex->ulock.uval, state, new_state,
+ &state, relaxed);
+ if (!success) {
+ continue;
+ }
+
+ int rc = __ulock_wait(wait_op, &mutex->ulock, new_state, 0);
+
+ PTHREAD_TRACE(ulmutex_lock_wait, mutex, new_state, rc, 0);
+
+ if (os_unlikely(rc < 0)) {
+ switch (-rc) {
+ case EINTR:
+ case EFAULT:
+ break;
+ case EOWNERDEAD:
+ owner_dead = true;
+ continue;
+ default:
+ PTHREAD_INTERNAL_CRASH(rc, "ulock_wait failure");
+ }
+ } else if (rc > 0) {
+ kernel_waiters = true;
+ }
+
+ state = os_atomic_load(&mutex->ulock.uval, relaxed);
+ } while (state != _PTHREAD_MUTEX_ULOCK_UNLOCKED_VALUE);
+
+ uint32_t locked_state = self_ownerval;
+ if (kernel_waiters) {
+ locked_state |= _PTHREAD_MUTEX_ULOCK_WAITERS_BIT;
+ }
+
+ success = os_atomic_cmpxchgv(&mutex->ulock.uval, state, locked_state,
+ &state, acquire);
+ } while (!success);
+ PLOCKSTAT_MUTEX_BLOCKED((pthread_mutex_t *)mutex, BLOCK_SUCCESS_PLOCKSTAT);
+
+ return 0;
+}
+
+PTHREAD_NOEXPORT_VARIANT
+int
+_pthread_mutex_ulock_lock(pthread_mutex_t *mutex, bool trylock)
+{
+ uint32_t unlocked = _PTHREAD_MUTEX_ULOCK_UNLOCKED_VALUE;
+ uint32_t locked = _pthread_mutex_ulock_self_owner_value();
+ uint32_t state;
+
+ bool success = os_atomic_cmpxchgv(&mutex->ulock.uval, unlocked, locked,
+ &state, acquire);
+
+ if (trylock) {
+ PTHREAD_TRACE(ulmutex_trylock, mutex, locked, state, success);
} else {
- switch (static_type) {
- case 1:
- mutex->mtxopts.options.type = PTHREAD_MUTEX_ERRORCHECK;
- break;
- case 2:
- mutex->mtxopts.options.type = PTHREAD_MUTEX_RECURSIVE;
- break;
- case 3:
- /* firstfit fall thru */
- case 7:
- mutex->mtxopts.options.type = PTHREAD_MUTEX_DEFAULT;
+ PTHREAD_TRACE(ulmutex_lock, mutex, locked, state, success);
+ }
+
+ int rc = 0;
+ if (!success) {
+ if (trylock) {
+ rc = EBUSY;
+ } else {
+ rc = _pthread_mutex_ulock_lock_slow(mutex, locked, state);
+ }
+ }
+
+ if (rc) {
+ PLOCKSTAT_MUTEX_ERROR((pthread_mutex_t *)mutex, rc);
+ } else {
+ PLOCKSTAT_MUTEX_ACQUIRE((pthread_mutex_t *)mutex, /* recursive */ 0, 0);
+ }
+
+ return rc;
+}
+
+OS_NOINLINE
+static int
+_pthread_mutex_ulock_unlock_slow(pthread_mutex_t *mutex, uint32_t self_ownerval,
+ uint32_t orig_state)
+{
+ if (os_unlikely(orig_state == _PTHREAD_MUTEX_ULOCK_UNLOCKED_VALUE)) {
+ // XXX This is illegal, but psynch permitted it...
+ // TODO: PTHREAD_STRICT candidate
+ return 0;
+ }
+
+ uint32_t wake_flags = 0;
+
+ uint32_t orig_ownerval = orig_state & _PTHREAD_MUTEX_ULOCK_OWNER_MASK;
+ bool orig_waiters = orig_state & _PTHREAD_MUTEX_ULOCK_WAITERS_BIT;
+ if (os_unlikely(orig_ownerval != self_ownerval)) {
+ // XXX This is illegal, but psynch permitted it...
+ // TODO: PTHREAD_STRICT candidate
+ if (!orig_waiters) {
+ return 0;
+ }
+
+ wake_flags |= ULF_WAKE_ALLOW_NON_OWNER;
+ } else if (os_unlikely(!orig_waiters)) {
+ PTHREAD_INTERNAL_CRASH(0, "unlock_slow without orig_waiters");
+ }
+
+ for (;;) {
+ int rc = __ulock_wake(UL_UNFAIR_LOCK | ULF_NO_ERRNO | wake_flags,
+ &mutex->ulock, 0);
+
+ PTHREAD_TRACE(ulmutex_unlock_wake, mutex, rc, 0, 0);
+
+ if (os_unlikely(rc < 0)) {
+ switch (-rc) {
+ case EINTR:
+ continue;
+ case ENOENT:
break;
default:
- return EINVAL;
+ PTHREAD_INTERNAL_CRASH(-rc, "ulock_wake failure");
+ }
}
+ break;
+ }
- mutex->prioceiling = _PTHREAD_DEFAULT_PRIOCEILING;
- mutex->mtxopts.options.protocol = _PTHREAD_DEFAULT_PROTOCOL;
- if (static_type != 3) {
- mutex->mtxopts.options.policy = _PTHREAD_MUTEX_POLICY_FAIRSHARE;
+ return 0;
+}
+
+PTHREAD_NOEXPORT_VARIANT
+int
+_pthread_mutex_ulock_unlock(pthread_mutex_t *mutex)
+{
+ uint32_t locked_uncontended = _pthread_mutex_ulock_self_owner_value();
+ uint32_t unlocked = _PTHREAD_MUTEX_ULOCK_UNLOCKED_VALUE;
+ uint32_t state = os_atomic_xchg(&mutex->ulock.uval, unlocked, release);
+
+ PTHREAD_TRACE(ulmutex_unlock, mutex, locked_uncontended, state, 0);
+
+ int rc = 0;
+ if (state != locked_uncontended) {
+ rc = _pthread_mutex_ulock_unlock_slow(mutex, locked_uncontended,
+ state);
+ }
+
+ if (rc) {
+ PLOCKSTAT_MUTEX_ERROR((pthread_mutex_t *)mutex, rc);
+ } else {
+ PLOCKSTAT_MUTEX_RELEASE((pthread_mutex_t *)mutex, /* recursive */ 0);
+ }
+
+ return rc;
+}
+
+#pragma mark firstfit
+
+OS_ALWAYS_INLINE
+static inline int
+_pthread_mutex_firstfit_unlock_updatebits(pthread_mutex_t *mutex,
+ uint32_t *flagsp, uint32_t **mutexp, uint32_t *lvalp, uint32_t *uvalp)
+{
+ uint32_t flags = mutex->mtxopts.value & ~_PTHREAD_MTX_OPT_NOTIFY;
+ bool kernel_wake;
+
+ mutex_seq *seqaddr;
+ MUTEX_GETSEQ_ADDR(mutex, &seqaddr);
+
+ mutex_seq oldseq, newseq;
+ mutex_seq_load(seqaddr, &oldseq);
+
+ uint64_t *tidaddr;
+ MUTEX_GETTID_ADDR(mutex, &tidaddr);
+ uint64_t oldtid;
+
+ int res = _pthread_mutex_unlock_handle_options(mutex, tidaddr);
+ if (res > 0) {
+ // Valid recursive unlock
+ if (flagsp) {
+ *flagsp = flags;
+ }
+ PLOCKSTAT_MUTEX_RELEASE((pthread_mutex_t *)mutex, 1);
+ return 0;
+ } else if (res < 0) {
+ PLOCKSTAT_MUTEX_ERROR((pthread_mutex_t *)mutex, -res);
+ return -res;
+ }
+
+ do {
+ newseq = oldseq;
+ oldtid = os_atomic_load_wide(tidaddr, relaxed);
+ // More than one kernel waiter means we need to do a wake.
+ kernel_wake = diff_genseq(oldseq.lgenval, oldseq.ugenval) > 0;
+ newseq.lgenval &= ~PTH_RWL_EBIT;
+
+ if (kernel_wake) {
+ // Going to the kernel post-unlock removes a single waiter unlock
+ // from the mutex counts.
+ newseq.ugenval += PTHRW_INC;
+ }
+
+ if (oldtid != 0) {
+ if (!os_atomic_cmpxchg(tidaddr, oldtid, 0, relaxed)) {
+ return _pthread_mutex_corruption_abort(mutex);
+ }
+ }
+ } while (!mutex_seq_atomic_cmpxchgv(seqaddr, &oldseq, &newseq, release));
+
+ PTHREAD_TRACE(psynch_ffmutex_unlock_updatebits, mutex, oldseq.lgenval,
+ newseq.lgenval, newseq.ugenval);
+
+ if (kernel_wake) {
+ // We choose to return this out via flags because the condition
+ // variable also uses this to determine whether to do a kernel wake
+ // when beginning a cvwait.
+ flags |= _PTHREAD_MTX_OPT_NOTIFY;
+ }
+ if (lvalp) {
+ *lvalp = newseq.lgenval;
+ }
+ if (uvalp) {
+ *uvalp = newseq.ugenval;
+ }
+ if (mutexp) {
+ *mutexp = (uint32_t *)mutex;
+ }
+ if (flagsp) {
+ *flagsp = flags;
+ }
+ return 0;
+}
+
+OS_NOINLINE
+static int
+_pthread_mutex_firstfit_wake(pthread_mutex_t *mutex, mutex_seq newseq,
+ uint32_t flags)
+{
+ PTHREAD_TRACE(psynch_ffmutex_wake, mutex, newseq.lgenval, newseq.ugenval,
+ 0);
+ int res = __psynch_mutexdrop(mutex, newseq.lgenval, newseq.ugenval, 0,
+ flags);
+
+ if (res == -1) {
+ res = errno;
+ if (res == EINTR) {
+ res = 0;
+ }
+ if (res != 0) {
+ PTHREAD_INTERNAL_CRASH(res, "__psynch_mutexdrop failed");
+ }
+ return res;
+ }
+ return 0;
+}
+
+OS_NOINLINE
+int
+_pthread_mutex_firstfit_unlock_slow(pthread_mutex_t *mutex)
+{
+ mutex_seq newseq;
+ uint32_t flags;
+ int res;
+
+ res = _pthread_mutex_firstfit_unlock_updatebits(mutex, &flags, NULL,
+ &newseq.lgenval, &newseq.ugenval);
+ if (res != 0) return res;
+
+ if (flags & _PTHREAD_MTX_OPT_NOTIFY) {
+ return _pthread_mutex_firstfit_wake(mutex, newseq, flags);
+ }
+ return 0;
+}
+
+OS_ALWAYS_INLINE
+static bool
+_pthread_mutex_firstfit_lock_updatebits(pthread_mutex_t *mutex, uint64_t selfid,
+ mutex_seq *newseqp)
+{
+ bool gotlock;
+
+ mutex_seq *seqaddr;
+ MUTEX_GETSEQ_ADDR(mutex, &seqaddr);
+
+ mutex_seq oldseq, newseq;
+ mutex_seq_load(seqaddr, &oldseq);
+
+ uint64_t *tidaddr;
+ MUTEX_GETTID_ADDR(mutex, &tidaddr);
+
+ PTHREAD_TRACE(psynch_ffmutex_lock_updatebits | DBG_FUNC_START, mutex,
+ oldseq.lgenval, oldseq.ugenval, 0);
+
+ do {
+ newseq = oldseq;
+ gotlock = is_rwl_ebit_clear(oldseq.lgenval);
+
+ if (gotlock) {
+ // If we see the E-bit cleared, we should just attempt to take it.
+ newseq.lgenval |= PTH_RWL_EBIT;
} else {
- mutex->mtxopts.options.policy = _PTHREAD_MUTEX_POLICY_FIRSTFIT;
+ // If we failed to get the lock then we need to put ourselves back
+ // in the queue of waiters. The previous unlocker that woke us out
+ // of the kernel consumed the S-count for our previous wake. So
+ // take another ticket on L and go back in the kernel to sleep.
+ newseq.lgenval += PTHRW_INC;
}
- mutex->mtxopts.options.pshared = _PTHREAD_DEFAULT_PSHARED;
+ } while (!mutex_seq_atomic_cmpxchgv(seqaddr, &oldseq, &newseq, acquire));
+
+ if (gotlock) {
+ os_atomic_store_wide(tidaddr, selfid, relaxed);
}
- mutex->priority = 0;
+
+ PTHREAD_TRACE(psynch_ffmutex_lock_updatebits | DBG_FUNC_END, mutex,
+ newseq.lgenval, newseq.ugenval, 0);
+
+ if (newseqp) {
+ *newseqp = newseq;
+ }
+ return gotlock;
+}
+
+OS_NOINLINE
+static int
+_pthread_mutex_firstfit_lock_wait(pthread_mutex_t *mutex, mutex_seq newseq,
+ uint64_t oldtid)
+{
+ uint64_t *tidaddr;
+ MUTEX_GETTID_ADDR(mutex, &tidaddr);
+ uint64_t selfid = _pthread_threadid_self_np_direct();
+
+ PLOCKSTAT_MUTEX_BLOCK((pthread_mutex_t *)mutex);
+ do {
+ uint32_t uval;
+ do {
+ PTHREAD_TRACE(psynch_ffmutex_wait | DBG_FUNC_START, mutex,
+ newseq.lgenval, newseq.ugenval, mutex->mtxopts.value);
+ uval = __psynch_mutexwait(mutex, newseq.lgenval, newseq.ugenval,
+ oldtid, mutex->mtxopts.value);
+ PTHREAD_TRACE(psynch_ffmutex_wait | DBG_FUNC_END, mutex,
+ uval, 0, 0);
+ oldtid = os_atomic_load_wide(tidaddr, relaxed);
+ } while (uval == (uint32_t)-1);
+ } while (!_pthread_mutex_firstfit_lock_updatebits(mutex, selfid, &newseq));
+ PLOCKSTAT_MUTEX_BLOCKED((pthread_mutex_t *)mutex, BLOCK_SUCCESS_PLOCKSTAT);
+
+ return 0;
+}
+
+OS_NOINLINE
+int
+_pthread_mutex_firstfit_lock_slow(pthread_mutex_t *mutex, bool trylock)
+{
+ int res, recursive = 0;
mutex_seq *seqaddr;
MUTEX_GETSEQ_ADDR(mutex, &seqaddr);
+ mutex_seq oldseq, newseq;
+ mutex_seq_load(seqaddr, &oldseq);
+
uint64_t *tidaddr;
MUTEX_GETTID_ADDR(mutex, &tidaddr);
+ uint64_t oldtid, selfid = _pthread_threadid_self_np_direct();
-#if PTHREAD_MUTEX_INIT_UNUSED
- if ((uint32_t*)tidaddr != mutex->m_tid) {
- mutex->mtxopts.options.misalign = 1;
- __builtin_memset(mutex->m_tid, 0xff, sizeof(mutex->m_tid));
+ res = _pthread_mutex_lock_handle_options(mutex, trylock, tidaddr);
+ if (res > 0) {
+ recursive = 1;
+ res = 0;
+ goto out;
+ } else if (res < 0) {
+ res = -res;
+ goto out;
+ }
+
+ PTHREAD_TRACE(psynch_ffmutex_lock_updatebits | DBG_FUNC_START, mutex,
+ oldseq.lgenval, oldseq.ugenval, 0);
+
+ bool gotlock;
+ do {
+ newseq = oldseq;
+ oldtid = os_atomic_load_wide(tidaddr, relaxed);
+
+ gotlock = is_rwl_ebit_clear(oldseq.lgenval);
+ if (trylock && !gotlock) {
+ // We still want to perform the CAS here, even though it won't
+ // do anything so that it fails if someone unlocked while we were
+ // in the loop
+ } else if (gotlock) {
+ // In first-fit, getting the lock simply adds the E-bit
+ newseq.lgenval |= PTH_RWL_EBIT;
+ } else {
+ // Failed to get the lock, increment the L-val and go to
+ // the kernel to sleep
+ newseq.lgenval += PTHRW_INC;
+ }
+ } while (!mutex_seq_atomic_cmpxchgv(seqaddr, &oldseq, &newseq, acquire));
+
+ PTHREAD_TRACE(psynch_ffmutex_lock_updatebits | DBG_FUNC_END, mutex,
+ newseq.lgenval, newseq.ugenval, 0);
+
+ if (gotlock) {
+ os_atomic_store_wide(tidaddr, selfid, relaxed);
+ res = 0;
+ PTHREAD_TRACE(psynch_mutex_ulock, mutex, newseq.lgenval,
+ newseq.ugenval, selfid);
+ } else if (trylock) {
+ res = EBUSY;
+ PTHREAD_TRACE(psynch_mutex_utrylock_failed, mutex, newseq.lgenval,
+ newseq.ugenval, oldtid);
+ } else {
+ PTHREAD_TRACE(psynch_mutex_ulock | DBG_FUNC_START, mutex,
+ newseq.lgenval, newseq.ugenval, oldtid);
+ res = _pthread_mutex_firstfit_lock_wait(mutex, newseq, oldtid);
+ PTHREAD_TRACE(psynch_mutex_ulock | DBG_FUNC_END, mutex,
+ newseq.lgenval, newseq.ugenval, oldtid);
+ }
+
+ if (res == 0 && _pthread_mutex_is_recursive(mutex)) {
+ mutex->mtxopts.options.lock_count = 1;
}
- __builtin_memset(mutex->m_mis, 0xff, sizeof(mutex->m_mis));
-#endif // PTHREAD_MUTEX_INIT_UNUSED
- *tidaddr = 0;
- *seqaddr = (mutex_seq){ };
+
+out:
+#if PLOCKSTAT
+ if (res == 0) {
+ PLOCKSTAT_MUTEX_ACQUIRE((pthread_mutex_t *)mutex, recursive, 0);
+ } else {
+ PLOCKSTAT_MUTEX_ERROR((pthread_mutex_t *)mutex, res);
+ }
+#endif
+ return res;
+}
+
+#pragma mark fast path
+
+OS_NOINLINE
+int
+_pthread_mutex_droplock(pthread_mutex_t *mutex, uint32_t *flagsp,
+ uint32_t **pmtxp, uint32_t *mgenp, uint32_t *ugenp)
+{
+ if (_pthread_mutex_is_fairshare(mutex)) {
+ return _pthread_mutex_fairshare_unlock_updatebits(mutex, flagsp,
+ pmtxp, mgenp, ugenp);
+ }
+ return _pthread_mutex_firstfit_unlock_updatebits(mutex, flagsp, pmtxp,
+ mgenp, ugenp);
+}
+
+OS_NOINLINE
+int
+_pthread_mutex_lock_init_slow(pthread_mutex_t *mutex, bool trylock)
+{
+ int res;
+
+ res = _pthread_mutex_check_init(mutex);
+ if (res != 0) return res;
+
+ if (os_unlikely(_pthread_mutex_is_fairshare(mutex))) {
+ return _pthread_mutex_fairshare_lock_slow(mutex, trylock);
+ } else if (os_unlikely(_pthread_mutex_uses_ulock(mutex))) {
+ return _pthread_mutex_ulock_lock(mutex, trylock);
+ }
+ return _pthread_mutex_firstfit_lock_slow(mutex, trylock);
+}
+
+OS_NOINLINE
+static int
+_pthread_mutex_unlock_init_slow(pthread_mutex_t *mutex)
+{
+ int res;
+
+ // Initialize static mutexes for compatibility with misbehaving
+ // applications (unlock should not be the first operation on a mutex).
+ res = _pthread_mutex_check_init(mutex);
+ if (res != 0) return res;
+
+ if (os_unlikely(_pthread_mutex_is_fairshare(mutex))) {
+ return _pthread_mutex_fairshare_unlock_slow(mutex);
+ } else if (os_unlikely(_pthread_mutex_uses_ulock(mutex))) {
+ return _pthread_mutex_ulock_unlock(mutex);
+ }
+ return _pthread_mutex_firstfit_unlock_slow(mutex);
+}
+
+PTHREAD_NOEXPORT_VARIANT
+int
+pthread_mutex_unlock(pthread_mutex_t *mutex)
+{
+ if (os_unlikely(!_pthread_mutex_check_signature_fast(mutex))) {
+ return _pthread_mutex_unlock_init_slow(mutex);
+ }
+
+ if (os_unlikely(_pthread_mutex_is_fairshare(mutex))) {
+ return _pthread_mutex_fairshare_unlock(mutex);
+ }
+
+ if (os_unlikely(_pthread_mutex_uses_ulock(mutex))) {
+ return _pthread_mutex_ulock_unlock(mutex);
+ }
+
+#if ENABLE_USERSPACE_TRACE
+ return _pthread_mutex_firstfit_unlock_slow(mutex);
+#elif PLOCKSTAT
+ if (PLOCKSTAT_MUTEX_RELEASE_ENABLED() || PLOCKSTAT_MUTEX_ERROR_ENABLED()) {
+ return _pthread_mutex_firstfit_unlock_slow(mutex);
+ }
+#endif
+
+ /*
+ * This is the first-fit fast path. The fairshare fast-ish path is in
+ * _pthread_mutex_firstfit_unlock()
+ */
+ uint64_t *tidaddr;
+ MUTEX_GETTID_ADDR(mutex, &tidaddr);
+
+ mutex_seq *seqaddr;
+ MUTEX_GETSEQ_ADDR(mutex, &seqaddr);
+
+ mutex_seq oldseq, newseq;
+ mutex_seq_load(seqaddr, &oldseq);
+
+ // We're giving up the mutex one way or the other, so go ahead and
+ // update the owner to 0 so that once the CAS below succeeds, there
+ // is no stale ownership information. If the CAS of the seqaddr
+ // fails, we may loop, but it's still valid for the owner to be
+ // SWITCHING/0
+ os_atomic_store_wide(tidaddr, 0, relaxed);
+
+ do {
+ newseq = oldseq;
+
+ if (diff_genseq(oldseq.lgenval, oldseq.ugenval) == 0) {
+ // No outstanding waiters in kernel, we can simply drop the E-bit
+ // and return.
+ newseq.lgenval &= ~PTH_RWL_EBIT;
+ } else {
+ return _pthread_mutex_firstfit_unlock_slow(mutex);
+ }
+ } while (os_unlikely(!mutex_seq_atomic_cmpxchgv(seqaddr, &oldseq, &newseq,
+ release)));
+
+ return 0;
+}
+
+OS_ALWAYS_INLINE
+static inline int
+_pthread_mutex_firstfit_lock(pthread_mutex_t *mutex, bool trylock)
+{
+ /*
+ * This is the first-fit fast path. The fairshare fast-ish path is in
+ * _pthread_mutex_fairshare_lock()
+ */
+ uint64_t *tidaddr;
+ MUTEX_GETTID_ADDR(mutex, &tidaddr);
+ uint64_t selfid = _pthread_threadid_self_np_direct();
+
+ mutex_seq *seqaddr;
+ MUTEX_GETSEQ_ADDR(mutex, &seqaddr);
+
+ mutex_seq oldseq, newseq;
+ mutex_seq_load(seqaddr, &oldseq);
+
+ if (os_unlikely(!trylock && (oldseq.lgenval & PTH_RWL_EBIT))) {
+ return _pthread_mutex_firstfit_lock_slow(mutex, trylock);
+ }
+
+ bool gotlock;
+ do {
+ newseq = oldseq;
+ gotlock = is_rwl_ebit_clear(oldseq.lgenval);
+
+ if (trylock && !gotlock) {
+#if __LP64__
+ // The sequence load is atomic, so we can bail here without writing
+ // it and avoid some unnecessary coherence traffic - rdar://57259033
+ os_atomic_thread_fence(acquire);
+ return EBUSY;
+#else
+ // A trylock on a held lock will fail immediately. But since
+ // we did not load the sequence words atomically, perform a
+ // no-op CAS64 to ensure that nobody has unlocked concurrently.
+#endif
+ } else if (os_likely(gotlock)) {
+ // In first-fit, getting the lock simply adds the E-bit
+ newseq.lgenval |= PTH_RWL_EBIT;
+ } else {
+ return _pthread_mutex_firstfit_lock_slow(mutex, trylock);
+ }
+ } while (os_unlikely(!mutex_seq_atomic_cmpxchgv(seqaddr, &oldseq, &newseq,
+ acquire)));
+
+ if (os_likely(gotlock)) {
+ os_atomic_store_wide(tidaddr, selfid, relaxed);
+ return 0;
+ } else if (trylock) {
+ return EBUSY;
+ } else {
+ __builtin_trap();
+ }
+}
+
+OS_ALWAYS_INLINE
+static inline int
+_pthread_mutex_lock(pthread_mutex_t *mutex, bool trylock)
+{
+ if (os_unlikely(!_pthread_mutex_check_signature_fast(mutex))) {
+ return _pthread_mutex_lock_init_slow(mutex, trylock);
+ }
+
+ if (os_unlikely(_pthread_mutex_is_fairshare(mutex))) {
+ return _pthread_mutex_fairshare_lock(mutex, trylock);
+ }
+
+ if (os_unlikely(_pthread_mutex_uses_ulock(mutex))) {
+ return _pthread_mutex_ulock_lock(mutex, trylock);
+ }
+
+#if ENABLE_USERSPACE_TRACE
+ return _pthread_mutex_firstfit_lock_slow(mutex, trylock);
+#elif PLOCKSTAT
+ if (PLOCKSTAT_MUTEX_ACQUIRE_ENABLED() || PLOCKSTAT_MUTEX_ERROR_ENABLED()) {
+ return _pthread_mutex_firstfit_lock_slow(mutex, trylock);
+ }
+#endif
+
+ return _pthread_mutex_firstfit_lock(mutex, trylock);
+}
+
+PTHREAD_NOEXPORT_VARIANT
+int
+pthread_mutex_lock(pthread_mutex_t *mutex)
+{
+ return _pthread_mutex_lock(mutex, false);
+}
+
+PTHREAD_NOEXPORT_VARIANT
+int
+pthread_mutex_trylock(pthread_mutex_t *mutex)
+{
+ return _pthread_mutex_lock(mutex, true);
+}
+
+
+OS_ALWAYS_INLINE
+static inline int
+_pthread_mutex_init(pthread_mutex_t *mutex, const pthread_mutexattr_t *attr,
+ uint32_t static_type)
+{
+ mutex->mtxopts.value = 0;
+ mutex->mtxopts.options.mutex = 1;
+ if (attr) {
+ if (attr->sig != _PTHREAD_MUTEX_ATTR_SIG) {
+ return EINVAL;
+ }
+ mutex->prioceiling = (int16_t)attr->prioceiling;
+ mutex->mtxopts.options.protocol = attr->protocol;
+ mutex->mtxopts.options.policy = attr->opt;
+ mutex->mtxopts.options.type = attr->type;
+ mutex->mtxopts.options.pshared = attr->pshared;
+ } else {
+ switch (static_type) {
+ case 1:
+ mutex->mtxopts.options.type = PTHREAD_MUTEX_ERRORCHECK;
+ break;
+ case 2:
+ mutex->mtxopts.options.type = PTHREAD_MUTEX_RECURSIVE;
+ break;
+ case 3:
+ /* firstfit fall thru */
+ case 7:
+ mutex->mtxopts.options.type = PTHREAD_MUTEX_DEFAULT;
+ break;
+ default:
+ return EINVAL;
+ }
+
+ mutex->prioceiling = _PTHREAD_DEFAULT_PRIOCEILING;
+ mutex->mtxopts.options.protocol = _PTHREAD_DEFAULT_PROTOCOL;
+ if (static_type != 3) {
+ mutex->mtxopts.options.policy = __pthread_mutex_default_opt_policy;
+ } else {
+ mutex->mtxopts.options.policy = _PTHREAD_MTX_OPT_POLICY_FIRSTFIT;
+ }
+ mutex->mtxopts.options.pshared = _PTHREAD_DEFAULT_PSHARED;
+ }
+
+ mutex->priority = 0;
+
long sig = _PTHREAD_MUTEX_SIG;
if (mutex->mtxopts.options.type == PTHREAD_MUTEX_NORMAL &&
- mutex->mtxopts.options.policy == _PTHREAD_MUTEX_POLICY_FAIRSHARE) {
+ (_pthread_mutex_is_fairshare(mutex) ||
+ _pthread_mutex_is_firstfit(mutex))) {
// rdar://18148854 _pthread_mutex_lock & pthread_mutex_unlock fastpath
sig = _PTHREAD_MUTEX_SIG_fast;
}
+ // Criteria for ulock eligility:
+ // - not ERRORCHECK or RECURSIVE
+ // - not FAIRSHARE
+ // - not PROCESS_SHARED
+ // - checkfix for rdar://21813573 not active
+ //
+ // All of these should be addressed eventually.
+ if (mutex->mtxopts.options.type == PTHREAD_MUTEX_NORMAL &&
+ mutex->mtxopts.options.policy == _PTHREAD_MTX_OPT_POLICY_FIRSTFIT &&
+ mutex->mtxopts.options.pshared == PTHREAD_PROCESS_PRIVATE &&
+ sig == _PTHREAD_MUTEX_SIG_fast) {
+ mutex->mtxopts.options.ulock = __pthread_mutex_use_ulock;
+ } else {
+ mutex->mtxopts.options.ulock = false;
+ }
+
+ if (mutex->mtxopts.options.ulock) {
+#if PTHREAD_MUTEX_INIT_UNUSED
+ __builtin_memset(&mutex->psynch, 0xff, sizeof(mutex->psynch));
+#endif // PTHREAD_MUTEX_INIT_UNUSED
+
+ mutex->ulock = _PTHREAD_MUTEX_ULOCK_UNLOCKED;
+ } else {
+ mutex_seq *seqaddr;
+ MUTEX_GETSEQ_ADDR(mutex, &seqaddr);
+
+ uint64_t *tidaddr;
+ MUTEX_GETTID_ADDR(mutex, &tidaddr);
+
+#if PTHREAD_MUTEX_INIT_UNUSED
+ if ((uint32_t*)tidaddr != mutex->psynch.m_tid) {
+ // TODO: PTHREAD_STRICT candidate
+ mutex->mtxopts.options.misalign = 1;
+ __builtin_memset(mutex->psynch.m_tid, 0xff,
+ sizeof(mutex->psynch.m_tid));
+ }
+ __builtin_memset(mutex->psynch.m_mis, 0xff, sizeof(mutex->psynch.m_mis));
+#endif // PTHREAD_MUTEX_INIT_UNUSED
+ *tidaddr = 0;
+ *seqaddr = (mutex_seq){ };
+ }
+
#if PTHREAD_MUTEX_INIT_UNUSED
// For detecting copied mutexes and smashes during debugging
uint32_t sig32 = (uint32_t)sig;
*(sig32_ptr + 1) = *(sig32_val + 1);
os_atomic_store(sig32_ptr, *sig32_val, release);
#else
- os_atomic_store2o(mutex, sig, sig, release);
+ os_atomic_store(&mutex->sig, sig, release);
#endif
return 0;
PTHREAD_NOEXPORT_VARIANT
int
-pthread_mutex_destroy(pthread_mutex_t *omutex)
+pthread_mutex_destroy(pthread_mutex_t *mutex)
{
- _pthread_mutex *mutex = (_pthread_mutex *)omutex;
-
int res = EINVAL;
- _PTHREAD_LOCK(mutex->lock);
+ _pthread_lock_lock(&mutex->lock);
if (_pthread_mutex_check_signature(mutex)) {
- mutex_seq *seqaddr;
- MUTEX_GETSEQ_ADDR(mutex, &seqaddr);
-
- mutex_seq seq;
- mutex_seq_load(seqaddr, &seq);
-
- uint64_t *tidaddr;
- MUTEX_GETTID_ADDR(mutex, &tidaddr);
+ // TODO: PTHREAD_STRICT candidate
+ res = EBUSY;
- if ((os_atomic_load(tidaddr, relaxed) == 0) &&
- (seq.lgenval & PTHRW_COUNT_MASK) ==
- (seq.ugenval & PTHRW_COUNT_MASK)) {
- mutex->sig = _PTHREAD_NO_SIG;
+ if (_pthread_mutex_uses_ulock(mutex) &&
+ mutex->ulock.uval == _PTHREAD_MUTEX_ULOCK_UNLOCKED_VALUE) {
res = 0;
} else {
- res = EBUSY;
+ mutex_seq *seqaddr;
+ MUTEX_GETSEQ_ADDR(mutex, &seqaddr);
+
+ mutex_seq seq;
+ mutex_seq_load(seqaddr, &seq);
+
+ uint64_t *tidaddr;
+ MUTEX_GETTID_ADDR(mutex, &tidaddr);
+
+ if ((os_atomic_load_wide(tidaddr, relaxed) == 0) &&
+ (seq.lgenval & PTHRW_COUNT_MASK) ==
+ (seq.ugenval & PTHRW_COUNT_MASK)) {
+ res = 0;
+ }
}
} else if (_pthread_mutex_check_signature_init(mutex)) {
- mutex->sig = _PTHREAD_NO_SIG;
res = 0;
}
- _PTHREAD_UNLOCK(mutex->lock);
+
+ if (res == 0) {
+ mutex->sig = _PTHREAD_NO_SIG;
+ }
+
+ _pthread_lock_unlock(&mutex->lock);
return res;
}
int
pthread_mutexattr_destroy(pthread_mutexattr_t *attr)
{
-#if __DARWIN_UNIX03
- if (__unix_conforming == 0) {
- __unix_conforming = 1;
- }
if (attr->sig != _PTHREAD_MUTEX_ATTR_SIG) {
return EINVAL;
}
-#endif /* __DARWIN_UNIX03 */
attr->sig = _PTHREAD_NO_SIG;
return 0;
projects / apple / libpthread.git / blobdiff