JavaScriptCore-7601.1.46.3.tar.gz

[apple/javascriptcore.git] / runtime / GetterSetter.cpp

diff --git a/runtime/GetterSetter.cpp b/runtime/GetterSetter.cpp
index 3de956ac6624633d05732c034e97b6ee88a78522..2cd66e5cd42fd01db52de0d76bcf4d2191ef7cb9 100644 (file)
--- a/runtime/GetterSetter.cpp
+++ b/runtime/GetterSetter.cpp
@@ -1,7 +1,7 @@
 /*
  *  Copyright (C) 1999-2002 Harri Porten (porten@kde.org)
  *  Copyright (C) 2001 Peter Kelly (pmk@post.com)
 /*
  *  Copyright (C) 1999-2002 Harri Porten (porten@kde.org)
  *  Copyright (C) 2001 Peter Kelly (pmk@post.com)

- *  Copyright (C) 2004, 2007, 2008, 2009 Apple Inc. All rights reserved.
+ *  Copyright (C) 2004, 2007, 2008, 2009, 2014 Apple Inc. All rights reserved.

  *
  *  This library is free software; you can redistribute it and/or
  *  modify it under the terms of the GNU Library General Public
  *
  *  This library is free software; you can redistribute it and/or
  *  modify it under the terms of the GNU Library General Public


@@ -24,6 +24,7 @@
 #include "GetterSetter.h"
 
 #include "Error.h"
 #include "GetterSetter.h"
 
 #include "Error.h"

+#include "Exception.h"

 #include "JSObject.h"
 #include "JSCInlines.h"
 #include <wtf/Assertions.h>
 #include "JSObject.h"
 #include "JSCInlines.h"
 #include <wtf/Assertions.h>


@@ -32,29 +33,52 @@ namespace JSC {
 
 STATIC_ASSERT_IS_TRIVIALLY_DESTRUCTIBLE(GetterSetter);
 
 
 STATIC_ASSERT_IS_TRIVIALLY_DESTRUCTIBLE(GetterSetter);
 

-const ClassInfo GetterSetter::s_info = { "GetterSetter", 0, 0, 0, CREATE_METHOD_TABLE(GetterSetter) };
+const ClassInfo GetterSetter::s_info = { "GetterSetter", 0, 0, CREATE_METHOD_TABLE(GetterSetter) };

 
 void GetterSetter::visitChildren(JSCell* cell, SlotVisitor& visitor)
 {
     GetterSetter* thisObject = jsCast<GetterSetter*>(cell);
     ASSERT_GC_OBJECT_INHERITS(thisObject, info());
 
 void GetterSetter::visitChildren(JSCell* cell, SlotVisitor& visitor)
 {
     GetterSetter* thisObject = jsCast<GetterSetter*>(cell);
     ASSERT_GC_OBJECT_INHERITS(thisObject, info());

-    ASSERT(thisObject->structure()->typeInfo().overridesVisitChildren());

     JSCell::visitChildren(thisObject, visitor);
 
     visitor.append(&thisObject->m_getter);
     visitor.append(&thisObject->m_setter);
 }
 
     JSCell::visitChildren(thisObject, visitor);
 
     visitor.append(&thisObject->m_getter);
     visitor.append(&thisObject->m_setter);
 }
 

+GetterSetter* GetterSetter::withGetter(VM& vm, JSGlobalObject* globalObject, JSObject* newGetter)
+{
+    if (isGetterNull()) {
+        setGetter(vm, globalObject, newGetter);
+        return this;
+    }
+    
+    GetterSetter* result = GetterSetter::create(vm, globalObject);
+    result->setGetter(vm, globalObject, newGetter);
+    result->setSetter(vm, globalObject, setter());
+    return result;
+}
+
+GetterSetter* GetterSetter::withSetter(VM& vm, JSGlobalObject* globalObject, JSObject* newSetter)
+{
+    if (isSetterNull()) {
+        setSetter(vm, globalObject, newSetter);
+        return this;
+    }
+    
+    GetterSetter* result = GetterSetter::create(vm, globalObject);
+    result->setGetter(vm, globalObject, getter());
+    result->setSetter(vm, globalObject, newSetter);
+    return result;
+}
+

 JSValue callGetter(ExecState* exec, JSValue base, JSValue getterSetter)
 {
     // FIXME: Some callers may invoke get() without checking for an exception first.
     // We work around that by checking here.
     if (exec->hadException())
 JSValue callGetter(ExecState* exec, JSValue base, JSValue getterSetter)
 {
     // FIXME: Some callers may invoke get() without checking for an exception first.
     // We work around that by checking here.
     if (exec->hadException())

-        return exec->exception();
+        return exec->exception()->value();

 
     JSObject* getter = jsCast<GetterSetter*>(getterSetter)->getter();
 
     JSObject* getter = jsCast<GetterSetter*>(getterSetter)->getter();

-    if (!getter)
-        return jsUndefined();

 
     CallData callData;
     CallType callType = getter->methodTable(exec->vm())->getCallData(getter, callData);
 
     CallData callData;
     CallType callType = getter->methodTable(exec->vm())->getCallData(getter, callData);


@@ -63,13 +87,16 @@ JSValue callGetter(ExecState* exec, JSValue base, JSValue getterSetter)
 
 void callSetter(ExecState* exec, JSValue base, JSValue getterSetter, JSValue value, ECMAMode ecmaMode)
 {
 
 void callSetter(ExecState* exec, JSValue base, JSValue getterSetter, JSValue value, ECMAMode ecmaMode)
 {

-    JSObject* setter = jsCast<GetterSetter*>(getterSetter)->setter();
-    if (!setter) {
+    GetterSetter* getterSetterObj = jsCast<GetterSetter*>(getterSetter);
+
+    if (getterSetterObj->isSetterNull()) {

         if (ecmaMode == StrictMode)
             throwTypeError(exec, StrictModeReadonlyPropertyWriteError);
         return;
     }
 
         if (ecmaMode == StrictMode)
             throwTypeError(exec, StrictModeReadonlyPropertyWriteError);
         return;
     }
 

+    JSObject* setter = getterSetterObj->setter();
+

     MarkedArgumentBuffer args;
     args.append(value);
 
     MarkedArgumentBuffer args;
     args.append(value);