ICU-66108.tar.gz

[apple/icu.git] / icuSources / i18n / transreg.cpp

diff --git a/icuSources/i18n/transreg.cpp b/icuSources/i18n/transreg.cpp
index 834e4ce80772f36f8166be5e7a8a73bbcb8ca0f0..47d8fbfe2d75afea966e2dd926d4d09c443b3338 100644 (file)
--- a/icuSources/i18n/transreg.cpp
+++ b/icuSources/i18n/transreg.cpp
@@ -1,6 +1,8 @@
+// © 2016 and later: Unicode, Inc. and others.
+// License & terms of use: http://www.unicode.org/copyright.html

 /*
 **********************************************************************
 /*
 **********************************************************************

-*   Copyright (c) 2001-2006, International Business Machines
+*   Copyright (c) 2001-2014, International Business Machines

 *   Corporation and others.  All Rights Reserved.
 **********************************************************************
 *   Date        Name        Description
 *   Corporation and others.  All Rights Reserved.
 **********************************************************************
 *   Date        Name        Description


@@ -44,8 +46,34 @@ static const UChar LOCALE_SEP  = 95; // '_'
 //static const UChar VARIANT_SEP = 0x002F; // '/'
 
 // String constants
 //static const UChar VARIANT_SEP = 0x002F; // '/'
 
 // String constants

-static const UChar NO_VARIANT[] = { 0 }; // empty string
-static const UChar ANY[] = { 65, 110, 121, 0 }; // Any
+static const UChar ANY[] = { 0x41, 0x6E, 0x79, 0 }; // Any
+static const UChar LAT[] = { 0x4C, 0x61, 0x74, 0 }; // Lat
+
+// empty string
+#define NO_VARIANT UnicodeString()
+
+// initial estimate for specDAG size
+// ICU 60 Transliterator::countAvailableSources()
+//#define SPECDAG_INIT_SIZE 149
+// Apple adjustment
+#define SPECDAG_INIT_SIZE 134
+
+// initial estimate for number of variant names
+#define VARIANT_LIST_INIT_SIZE 11
+#define VARIANT_LIST_MAX_SIZE 31
+
+// initial estimate for availableIDs count (default estimate is 8 => multiple reallocs)
+// ICU 60 Transliterator::countAvailableIDs()
+//#define AVAILABLE_IDS_INIT_SIZE 641
+// Apple adjustment
+#define AVAILABLE_IDS_INIT_SIZE 493
+
+// initial estimate for number of targets for source "Any", "Lat"
+// ICU 60 Transliterator::countAvailableTargets("Any")/("Latn")
+//#define ANY_TARGETS_INIT_SIZE 125
+// Apple adjustmennt
+#define ANY_TARGETS_INIT_SIZE 102
+#define LAT_TARGETS_INIT_SIZE 23

 
 /**
  * Resource bundle key for the RuleBasedTransliterator rule.
 
 /**
  * Resource bundle key for the RuleBasedTransliterator rule.


@@ -109,7 +137,7 @@ Transliterator* TransliteratorAlias::create(UParseError& pe,
             return 0;
         }
         if (compoundFilter != 0)
             return 0;
         }
         if (compoundFilter != 0)

-            t->adoptFilter((UnicodeSet*)compoundFilter->clone());
+            t->adoptFilter(compoundFilter->clone());

         break;
     case COMPOUND:
         {
         break;
     case COMPOUND:
         {


@@ -151,8 +179,8 @@ Transliterator* TransliteratorAlias::create(UParseError& pe,
 
             if (U_SUCCESS(ec)) {
                 t = new CompoundTransliterator(ID, transliterators,
 
             if (U_SUCCESS(ec)) {
                 t = new CompoundTransliterator(ID, transliterators,

-                    (compoundFilter ? (UnicodeSet*)(compoundFilter->clone()) : 0),
-                    anonymousRBTs, pe, ec);
+                        (compoundFilter ? compoundFilter->clone() : nullptr),
+                        anonymousRBTs, pe, ec);

                 if (t == 0) {
                     ec = U_MEMORY_ALLOCATION_ERROR;
                     return 0;
                 if (t == 0) {
                     ec = U_MEMORY_ALLOCATION_ERROR;
                     return 0;


@@ -164,8 +192,7 @@ Transliterator* TransliteratorAlias::create(UParseError& pe,
         }
         break;
     case RULES:
         }
         break;
     case RULES:

-        U_ASSERT(FALSE); // don't call create() if isRuleBased() returns TRUE!
-        break;
+        UPRV_UNREACHABLE; // don't call create() if isRuleBased() returns TRUE!

     }
     return t;
 }
     }
     return t;
 }


@@ -185,11 +212,11 @@ void TransliteratorAlias::parse(TransliteratorParser& parser,
 }
 
 //----------------------------------------------------------------------
 }
 
 //----------------------------------------------------------------------

-// class Spec
+// class TransliteratorSpec

 //----------------------------------------------------------------------
 
 /**
 //----------------------------------------------------------------------
 
 /**

- * A Spec is a string specifying either a source or a target.  In more
+ * A TransliteratorSpec is a string specifying either a source or a target.  In more

  * general terms, it may also specify a variant, but we only use the
  * Spec class for sources and targets.
  *
  * general terms, it may also specify a variant, but we only use the
  * Spec class for sources and targets.
  *


@@ -203,10 +230,10 @@ void TransliteratorAlias::parse(TransliteratorParser& parser,
  * canonical form, or the script is transformed from an abbreviation
  * to a full name.
  */
  * canonical form, or the script is transformed from an abbreviation
  * to a full name.
  */

-class Spec : public UMemory {
+class TransliteratorSpec : public UMemory {

  public:
  public:

-    Spec(const UnicodeString& spec);
-    ~Spec();
+    TransliteratorSpec(const UnicodeString& spec);
+    ~TransliteratorSpec();

 
     const UnicodeString& get() const;
     UBool hasFallback() const;
 
     const UnicodeString& get() const;
     UBool hasFallback() const;


@@ -230,16 +257,15 @@ class Spec : public UMemory {
     UBool isNextLocale; // TRUE if nextSpec is a locale
     ResourceBundle* res;
 
     UBool isNextLocale; // TRUE if nextSpec is a locale
     ResourceBundle* res;
 

-    Spec(const Spec &other); // forbid copying of this class
-    Spec &operator=(const Spec &other); // forbid copying of this class
+    TransliteratorSpec(const TransliteratorSpec &other); // forbid copying of this class
+    TransliteratorSpec &operator=(const TransliteratorSpec &other); // forbid copying of this class

 };
 
 };
 

-Spec::Spec(const UnicodeString& theSpec)
+TransliteratorSpec::TransliteratorSpec(const UnicodeString& theSpec)

 : top(theSpec),
   res(0)
 {
     UErrorCode status = U_ZERO_ERROR;
 : top(theSpec),
   res(0)
 {
     UErrorCode status = U_ZERO_ERROR;

-    CharString topch(theSpec);

     Locale topLoc("");
     LocaleUtility::initLocaleFromName(theSpec, topLoc);
     if (!topLoc.isBogus()) {
     Locale topLoc("");
     LocaleUtility::initLocaleFromName(theSpec, topLoc);
     if (!topLoc.isBogus()) {


@@ -258,7 +284,8 @@ Spec::Spec(const UnicodeString& theSpec)
     status = U_ZERO_ERROR;
     static const int32_t capacity = 10;
     UScriptCode script[capacity]={USCRIPT_INVALID_CODE};
     status = U_ZERO_ERROR;
     static const int32_t capacity = 10;
     UScriptCode script[capacity]={USCRIPT_INVALID_CODE};

-    int32_t num = uscript_getCode(topch,script,capacity, &status);
+    int32_t num = uscript_getCode(CharString().appendInvariantChars(theSpec, status).data(),
+                                  script, capacity, &status);

     if (num > 0 && script[0] != USCRIPT_INVALID_CODE) {
         scriptName = UnicodeString(uscript_getName(script[0]), -1, US_INV);
     }
     if (num > 0 && script[0] != USCRIPT_INVALID_CODE) {
         scriptName = UnicodeString(uscript_getName(script[0]), -1, US_INV);
     }


@@ -280,15 +307,15 @@ Spec::Spec(const UnicodeString& theSpec)
     reset();
 }
 
     reset();
 }
 

-Spec::~Spec() {
+TransliteratorSpec::~TransliteratorSpec() {

     delete res;
 }
 
     delete res;
 }
 

-UBool Spec::hasFallback() const {
+UBool TransliteratorSpec::hasFallback() const {

     return nextSpec.length() != 0;
 }
 
     return nextSpec.length() != 0;
 }
 

-void Spec::reset() {
+void TransliteratorSpec::reset() {

     if (spec != top) {
         spec = top;
         isSpecLocale = (res != 0);
     if (spec != top) {
         spec = top;
         isSpecLocale = (res != 0);


@@ -296,7 +323,7 @@ void Spec::reset() {
     }
 }
 
     }
 }
 

-void Spec::setupNext() {
+void TransliteratorSpec::setupNext() {

     isNextLocale = FALSE;
     if (isSpecLocale) {
         nextSpec = spec;
     isNextLocale = FALSE;
     if (isSpecLocale) {
         nextSpec = spec;


@@ -319,22 +346,22 @@ void Spec::setupNext() {
 // for(const UnicodeString& s(spec.get());
 //     spec.hasFallback(); s(spec.next())) { ...
 
 // for(const UnicodeString& s(spec.get());
 //     spec.hasFallback(); s(spec.next())) { ...
 

-const UnicodeString& Spec::next() {
+const UnicodeString& TransliteratorSpec::next() {

     spec = nextSpec;
     isSpecLocale = isNextLocale;
     setupNext();
     return spec;
 }
 
     spec = nextSpec;
     isSpecLocale = isNextLocale;
     setupNext();
     return spec;
 }
 

-const UnicodeString& Spec::get() const {
+const UnicodeString& TransliteratorSpec::get() const {

     return spec;
 }
 
     return spec;
 }
 

-UBool Spec::isLocale() const {
+UBool TransliteratorSpec::isLocale() const {

     return isSpecLocale;
 }
 
     return isSpecLocale;
 }
 

-ResourceBundle& Spec::getBundle() const {
+ResourceBundle& TransliteratorSpec::getBundle() const {

     return *res;
 }
 
     return *res;
 }
 


@@ -354,9 +381,9 @@ static void DEBUG_setup() {
 
 // Caller must call DEBUG_setup first.  Return index of given Entry,
 // if it is in use (not deleted yet), or -1 if not found.
 
 // Caller must call DEBUG_setup first.  Return index of given Entry,
 // if it is in use (not deleted yet), or -1 if not found.

-static int DEBUG_findEntry(Entry* e) {
+static int DEBUG_findEntry(TransliteratorEntry* e) {

     for (int i=0; i<DEBUG_entries->size(); ++i) {
     for (int i=0; i<DEBUG_entries->size(); ++i) {

-        if (e == (Entry*) DEBUG_entries->elementAt(i)) {
+        if (e == (TransliteratorEntry*) DEBUG_entries->elementAt(i)) {

             return i;
         }
     }
             return i;
         }
     }


@@ -364,7 +391,7 @@ static int DEBUG_findEntry(Entry* e) {
 }
 
 // Track object creation
 }
 
 // Track object creation

-static void DEBUG_newEntry(Entry* e) {
+static void DEBUG_newEntry(TransliteratorEntry* e) {

     DEBUG_setup();
     if (DEBUG_findEntry(e) >= 0) {
         // This should really never happen unless the heap is broken
     DEBUG_setup();
     if (DEBUG_findEntry(e) >= 0) {
         // This should really never happen unless the heap is broken


@@ -376,7 +403,7 @@ static void DEBUG_newEntry(Entry* e) {
 }
 
 // Track object deletion
 }
 
 // Track object deletion

-static void DEBUG_delEntry(Entry* e) {
+static void DEBUG_delEntry(TransliteratorEntry* e) {

     DEBUG_setup();
     int i = DEBUG_findEntry(e);
     if (i < 0) {
     DEBUG_setup();
     int i = DEBUG_findEntry(e);
     if (i < 0) {


@@ -387,7 +414,7 @@ static void DEBUG_delEntry(Entry* e) {
 }
 
 // Track object usage
 }
 
 // Track object usage

-static void DEBUG_useEntry(Entry* e) {
+static void DEBUG_useEntry(TransliteratorEntry* e) {

     if (e == NULL) return;
     DEBUG_setup();
     int i = DEBUG_findEntry(e);
     if (e == NULL) return;
     DEBUG_setup();
     int i = DEBUG_findEntry(e);


@@ -417,7 +444,7 @@ static void DEBUG_useEntry(Entry* e) {
  * for it.  We could easily add this if there is a need for it in the
  * future.
  */
  * for it.  We could easily add this if there is a need for it in the
  * future.
  */

-class Entry : public UMemory {
+class TransliteratorEntry : public UMemory {

 public:
     enum Type {
         RULES_FORWARD,
 public:
     enum Type {
         RULES_FORWARD,


@@ -444,26 +471,26 @@ public:
             Transliterator::Token   context;
         } factory; // For FACTORY
     } u;
             Transliterator::Token   context;
         } factory; // For FACTORY
     } u;

-    Entry();
-    ~Entry();
+    TransliteratorEntry();
+    ~TransliteratorEntry();

     void adoptPrototype(Transliterator* adopted);
     void setFactory(Transliterator::Factory factory,
                     Transliterator::Token context);
 
 private:
 
     void adoptPrototype(Transliterator* adopted);
     void setFactory(Transliterator::Factory factory,
                     Transliterator::Token context);
 
 private:
 

-    Entry(const Entry &other); // forbid copying of this class
-    Entry &operator=(const Entry &other); // forbid copying of this class
+    TransliteratorEntry(const TransliteratorEntry &other); // forbid copying of this class
+    TransliteratorEntry &operator=(const TransliteratorEntry &other); // forbid copying of this class

 };
 
 };
 

-Entry::Entry() {
+TransliteratorEntry::TransliteratorEntry() {

     u.prototype = 0;
     compoundFilter = NULL;
     entryType = NONE;
     DEBUG_newEntry(this);
 }
 
     u.prototype = 0;
     compoundFilter = NULL;
     entryType = NONE;
     DEBUG_newEntry(this);
 }
 

-Entry::~Entry() {
+TransliteratorEntry::~TransliteratorEntry() {

     DEBUG_delEntry(this);
     if (entryType == PROTOTYPE) {
         delete u.prototype;
     DEBUG_delEntry(this);
     if (entryType == PROTOTYPE) {
         delete u.prototype;


@@ -481,7 +508,7 @@ Entry::~Entry() {
     delete compoundFilter;
 }
 
     delete compoundFilter;
 }
 

-void Entry::adoptPrototype(Transliterator* adopted) {
+void TransliteratorEntry::adoptPrototype(Transliterator* adopted) {

     if (entryType == PROTOTYPE) {
         delete u.prototype;
     }
     if (entryType == PROTOTYPE) {
         delete u.prototype;
     }


@@ -489,7 +516,7 @@ void Entry::adoptPrototype(Transliterator* adopted) {
     u.prototype = adopted;
 }
 
     u.prototype = adopted;
 }
 

-void Entry::setFactory(Transliterator::Factory factory,
+void TransliteratorEntry::setFactory(Transliterator::Factory factory,

                        Transliterator::Token context) {
     if (entryType == PROTOTYPE) {
         delete u.prototype;
                        Transliterator::Token context) {
     if (entryType == PROTOTYPE) {
         delete u.prototype;


@@ -503,7 +530,7 @@ void Entry::setFactory(Transliterator::Factory factory,
 U_CDECL_BEGIN
 static void U_CALLCONV
 deleteEntry(void* obj) {
 U_CDECL_BEGIN
 static void U_CALLCONV
 deleteEntry(void* obj) {

-    delete (Entry*) obj;
+    delete (TransliteratorEntry*) obj;

 }
 U_CDECL_END
 
 }
 U_CDECL_END
 


@@ -513,11 +540,18 @@ U_CDECL_END
 
 TransliteratorRegistry::TransliteratorRegistry(UErrorCode& status) :
     registry(TRUE, status),
 
 TransliteratorRegistry::TransliteratorRegistry(UErrorCode& status) :
     registry(TRUE, status),

-    specDAG(TRUE, status),
-    availableIDs(status)
+    specDAG(TRUE, SPECDAG_INIT_SIZE, status),
+    variantList(VARIANT_LIST_INIT_SIZE, status),
+    availableIDs(AVAILABLE_IDS_INIT_SIZE, status)

 {
     registry.setValueDeleter(deleteEntry);
 {
     registry.setValueDeleter(deleteEntry);

-    availableIDs.setDeleter(uhash_deleteUnicodeString);
+    variantList.setDeleter(uprv_deleteUObject);
+    variantList.setComparer(uhash_compareCaselessUnicodeString);
+    UnicodeString *emptyString = new UnicodeString();
+    if (emptyString != NULL) {
+        variantList.addElement(emptyString, status);
+    }
+    availableIDs.setDeleter(uprv_deleteUObject);

     availableIDs.setComparer(uhash_compareCaselessUnicodeString);
     specDAG.setValueDeleter(uhash_deleteHashtable);
 }
     availableIDs.setComparer(uhash_compareCaselessUnicodeString);
     specDAG.setValueDeleter(uhash_deleteHashtable);
 }


@@ -530,7 +564,7 @@ Transliterator* TransliteratorRegistry::get(const UnicodeString& ID,
                                             TransliteratorAlias*& aliasReturn,
                                             UErrorCode& status) {
     U_ASSERT(aliasReturn == NULL);
                                             TransliteratorAlias*& aliasReturn,
                                             UErrorCode& status) {
     U_ASSERT(aliasReturn == NULL);

-    Entry *entry = find(ID);
+    TransliteratorEntry *entry = find(ID);

     return (entry == 0) ? 0
         : instantiateEntry(ID, entry, aliasReturn, status);
 }
     return (entry == 0) ? 0
         : instantiateEntry(ID, entry, aliasReturn, status);
 }


@@ -540,7 +574,7 @@ Transliterator* TransliteratorRegistry::reget(const UnicodeString& ID,
                                               TransliteratorAlias*& aliasReturn,
                                               UErrorCode& status) {
     U_ASSERT(aliasReturn == NULL);
                                               TransliteratorAlias*& aliasReturn,
                                               UErrorCode& status) {
     U_ASSERT(aliasReturn == NULL);

-    Entry *entry = find(ID);
+    TransliteratorEntry *entry = find(ID);

 
     if (entry == 0) {
         // We get to this point if there are two threads, one of which
 
     if (entry == 0) {
         // We get to this point if there are two threads, one of which


@@ -561,26 +595,26 @@ Transliterator* TransliteratorRegistry::reget(const UnicodeString& ID,
     // We have to detect this so we don't stomp over existing entry
     // data members and potentially leak memory (u.data and compoundFilter).
 
     // We have to detect this so we don't stomp over existing entry
     // data members and potentially leak memory (u.data and compoundFilter).
 

-    if (entry->entryType == Entry::RULES_FORWARD ||
-        entry->entryType == Entry::RULES_REVERSE ||
-        entry->entryType == Entry::LOCALE_RULES) {
+    if (entry->entryType == TransliteratorEntry::RULES_FORWARD ||
+        entry->entryType == TransliteratorEntry::RULES_REVERSE ||
+        entry->entryType == TransliteratorEntry::LOCALE_RULES) {

         
         if (parser.idBlockVector.isEmpty() && parser.dataVector.isEmpty()) {
             entry->u.data = 0;
         
         if (parser.idBlockVector.isEmpty() && parser.dataVector.isEmpty()) {
             entry->u.data = 0;

-            entry->entryType = Entry::ALIAS;
+            entry->entryType = TransliteratorEntry::ALIAS;

             entry->stringArg = UNICODE_STRING_SIMPLE("Any-NULL");
         }
         else if (parser.idBlockVector.isEmpty() && parser.dataVector.size() == 1) {
             entry->u.data = (TransliterationRuleData*)parser.dataVector.orphanElementAt(0);
             entry->stringArg = UNICODE_STRING_SIMPLE("Any-NULL");
         }
         else if (parser.idBlockVector.isEmpty() && parser.dataVector.size() == 1) {
             entry->u.data = (TransliterationRuleData*)parser.dataVector.orphanElementAt(0);

-            entry->entryType = Entry::RBT_DATA;
+            entry->entryType = TransliteratorEntry::RBT_DATA;

         }
         else if (parser.idBlockVector.size() == 1 && parser.dataVector.isEmpty()) {
             entry->stringArg = *(UnicodeString*)(parser.idBlockVector.elementAt(0));
             entry->compoundFilter = parser.orphanCompoundFilter();
         }
         else if (parser.idBlockVector.size() == 1 && parser.dataVector.isEmpty()) {
             entry->stringArg = *(UnicodeString*)(parser.idBlockVector.elementAt(0));
             entry->compoundFilter = parser.orphanCompoundFilter();

-            entry->entryType = Entry::ALIAS;
+            entry->entryType = TransliteratorEntry::ALIAS;

         }
         else {
         }
         else {

-            entry->entryType = Entry::COMPOUND_RBT;
+            entry->entryType = TransliteratorEntry::COMPOUND_RBT;

             entry->compoundFilter = parser.orphanCompoundFilter();
             entry->u.dataVector = new UVector(status);
             entry->stringArg.remove();
             entry->compoundFilter = parser.orphanCompoundFilter();
             entry->u.dataVector = new UVector(status);
             entry->stringArg.remove();


@@ -610,8 +644,14 @@ Transliterator* TransliteratorRegistry::reget(const UnicodeString& ID,
 }
 
 void TransliteratorRegistry::put(Transliterator* adoptedProto,
 }
 
 void TransliteratorRegistry::put(Transliterator* adoptedProto,

-                                 UBool visible) {
-    Entry *entry = new Entry();
+                                 UBool visible,
+                                 UErrorCode& ec)
+{
+    TransliteratorEntry *entry = new TransliteratorEntry();
+    if (entry == NULL) {
+        ec = U_MEMORY_ALLOCATION_ERROR;
+        return;
+    }

     entry->adoptPrototype(adoptedProto);
     registerEntry(adoptedProto->getID(), entry, visible);
 }
     entry->adoptPrototype(adoptedProto);
     registerEntry(adoptedProto->getID(), entry, visible);
 }


@@ -619,8 +659,13 @@ void TransliteratorRegistry::put(Transliterator* adoptedProto,
 void TransliteratorRegistry::put(const UnicodeString& ID,
                                  Transliterator::Factory factory,
                                  Transliterator::Token context,
 void TransliteratorRegistry::put(const UnicodeString& ID,
                                  Transliterator::Factory factory,
                                  Transliterator::Token context,

-                                 UBool visible) {
-    Entry *entry = new Entry();
+                                 UBool visible,
+                                 UErrorCode& ec) {
+    TransliteratorEntry *entry = new TransliteratorEntry();
+    if (entry == NULL) {
+        ec = U_MEMORY_ALLOCATION_ERROR;
+        return;
+    }

     entry->setFactory(factory, context);
     registerEntry(ID, entry, visible);
 }
     entry->setFactory(factory, context);
     registerEntry(ID, entry, visible);
 }


@@ -629,10 +674,15 @@ void TransliteratorRegistry::put(const UnicodeString& ID,
                                  const UnicodeString& resourceName,
                                  UTransDirection dir,
                                  UBool readonlyResourceAlias,
                                  const UnicodeString& resourceName,
                                  UTransDirection dir,
                                  UBool readonlyResourceAlias,

-                                 UBool visible) {
-    Entry *entry = new Entry();
-    entry->entryType = (dir == UTRANS_FORWARD) ? Entry::RULES_FORWARD
-        : Entry::RULES_REVERSE;
+                                 UBool visible,
+                                 UErrorCode& ec) {
+    TransliteratorEntry *entry = new TransliteratorEntry();
+    if (entry == NULL) {
+        ec = U_MEMORY_ALLOCATION_ERROR;
+        return;
+    }
+    entry->entryType = (dir == UTRANS_FORWARD) ? TransliteratorEntry::RULES_FORWARD
+        : TransliteratorEntry::RULES_REVERSE;

     if (readonlyResourceAlias) {
         entry->stringArg.setTo(TRUE, resourceName.getBuffer(), -1);
     }
     if (readonlyResourceAlias) {
         entry->stringArg.setTo(TRUE, resourceName.getBuffer(), -1);
     }


@@ -645,16 +695,20 @@ void TransliteratorRegistry::put(const UnicodeString& ID,
 void TransliteratorRegistry::put(const UnicodeString& ID,
                                  const UnicodeString& alias,
                                  UBool readonlyAliasAlias,
 void TransliteratorRegistry::put(const UnicodeString& ID,
                                  const UnicodeString& alias,
                                  UBool readonlyAliasAlias,

-                                 UBool visible) {
-    Entry *entry = new Entry();
-    entry->entryType = Entry::ALIAS;
-    if (readonlyAliasAlias) {
-        entry->stringArg.setTo(TRUE, alias.getBuffer(), -1);
-    }
-    else {
-        entry->stringArg = alias;
+                                 UBool visible,
+                                 UErrorCode& /*ec*/) {
+    TransliteratorEntry *entry = new TransliteratorEntry();
+    // Null pointer check
+    if (entry != NULL) {
+        entry->entryType = TransliteratorEntry::ALIAS;
+        if (readonlyAliasAlias) {
+            entry->stringArg.setTo(TRUE, alias.getBuffer(), -1);
+        }
+        else {
+            entry->stringArg = alias;
+        }
+        registerEntry(ID, entry, visible);

     }
     }

-    registerEntry(ID, entry, visible);

 }
 
 void TransliteratorRegistry::remove(const UnicodeString& ID) {
 }
 
 void TransliteratorRegistry::remove(const UnicodeString& ID) {


@@ -706,7 +760,7 @@ int32_t TransliteratorRegistry::countAvailableSources(void) const {
 
 UnicodeString& TransliteratorRegistry::getAvailableSource(int32_t index,
                                                           UnicodeString& result) const {
 
 UnicodeString& TransliteratorRegistry::getAvailableSource(int32_t index,
                                                           UnicodeString& result) const {

-    int32_t pos = -1;
+    int32_t pos = UHASH_FIRST;

     const UHashElement *e = 0;
     while (index-- >= 0) {
         e = specDAG.nextElement(pos);
     const UHashElement *e = 0;
     while (index-- >= 0) {
         e = specDAG.nextElement(pos);


@@ -735,7 +789,7 @@ UnicodeString& TransliteratorRegistry::getAvailableTarget(int32_t index,
         result.truncate(0); // invalid source
         return result;
     }
         result.truncate(0); // invalid source
         return result;
     }

-    int32_t pos = -1;
+    int32_t pos = UHASH_FIRST;

     const UHashElement *e = 0;
     while (index-- >= 0) {
         e = targets->nextElement(pos);
     const UHashElement *e = 0;
     while (index-- >= 0) {
         e = targets->nextElement(pos);


@@ -757,9 +811,15 @@ int32_t TransliteratorRegistry::countAvailableVariants(const UnicodeString& sour
     if (targets == 0) {
         return 0;
     }
     if (targets == 0) {
         return 0;
     }

-    UVector *variants = (UVector*) targets->get(target);
-    // variants may be 0 if the source/target are invalid
-    return (variants == 0) ? 0 : variants->size();
+    uint32_t varMask = targets->geti(target);
+    int32_t varCount = 0;
+    while (varMask > 0) {
+        if (varMask & 1) {
+            varCount++;
+        }
+        varMask >>= 1;
+    }
+    return varCount;

 }
 
 UnicodeString& TransliteratorRegistry::getAvailableVariant(int32_t index,
 }
 
 UnicodeString& TransliteratorRegistry::getAvailableVariant(int32_t index,


@@ -771,17 +831,25 @@ UnicodeString& TransliteratorRegistry::getAvailableVariant(int32_t index,
         result.truncate(0); // invalid source
         return result;
     }
         result.truncate(0); // invalid source
         return result;
     }

-    UVector *variants = (UVector*) targets->get(target);
-    if (variants == 0) {
-        result.truncate(0); // invalid target
-        return result;
-    }
-    UnicodeString *v = (UnicodeString*) variants->elementAt(index);
-    if (v == 0) {
-        result.truncate(0); // invalid index
-    } else {
-        result = *v;
+    uint32_t varMask = targets->geti(target);
+    int32_t varCount = 0;
+    int32_t varListIndex = 0;
+    while (varMask > 0) {
+        if (varMask & 1) {
+            if (varCount == index) {
+                UnicodeString *v = (UnicodeString*) variantList.elementAt(varListIndex);
+                if (v != NULL) {
+                    result = *v;
+                    return result;
+                }
+                break;
+            }
+            varCount++;
+        }
+        varMask >>= 1;
+        varListIndex++;

     }
     }

+    result.truncate(0); // invalid target or index

     return result;
 }
 
     return result;
 }
 


@@ -843,12 +911,12 @@ UOBJECT_DEFINE_RTTI_IMPLEMENTATION(TransliteratorRegistry::Enumeration)
 void TransliteratorRegistry::registerEntry(const UnicodeString& source,
                                            const UnicodeString& target,
                                            const UnicodeString& variant,
 void TransliteratorRegistry::registerEntry(const UnicodeString& source,
                                            const UnicodeString& target,
                                            const UnicodeString& variant,

-                                           Entry* adopted,
+                                           TransliteratorEntry* adopted,

                                            UBool visible) {
     UnicodeString ID;
     UnicodeString s(source);
     if (s.length() == 0) {
                                            UBool visible) {
     UnicodeString ID;
     UnicodeString s(source);
     if (s.length() == 0) {

-        s = ANY;
+        s.setTo(TRUE, ANY, 3);

     }
     TransliteratorIDParser::STVtoID(source, target, variant, ID);
     registerEntry(ID, s, target, variant, adopted, visible);
     }
     TransliteratorIDParser::STVtoID(source, target, variant, ID);
     registerEntry(ID, s, target, variant, adopted, visible);


@@ -858,7 +926,7 @@ void TransliteratorRegistry::registerEntry(const UnicodeString& source,
  * Convenience method.  Calls 6-arg registerEntry().
  */
 void TransliteratorRegistry::registerEntry(const UnicodeString& ID,
  * Convenience method.  Calls 6-arg registerEntry().
  */
 void TransliteratorRegistry::registerEntry(const UnicodeString& ID,

-                                           Entry* adopted,
+                                           TransliteratorEntry* adopted,

                                            UBool visible) {
     UnicodeString source, target, variant;
     UBool sawSource;
                                            UBool visible) {
     UnicodeString source, target, variant;
     UBool sawSource;


@@ -877,17 +945,20 @@ void TransliteratorRegistry::registerEntry(const UnicodeString& ID,
                                            const UnicodeString& source,
                                            const UnicodeString& target,
                                            const UnicodeString& variant,
                                            const UnicodeString& source,
                                            const UnicodeString& target,
                                            const UnicodeString& variant,

-                                           Entry* adopted,
+                                           TransliteratorEntry* adopted,

                                            UBool visible) {
     UErrorCode status = U_ZERO_ERROR;
     registry.put(ID, adopted, status);
     if (visible) {
         registerSTV(source, target, variant);
         if (!availableIDs.contains((void*) &ID)) {
                                            UBool visible) {
     UErrorCode status = U_ZERO_ERROR;
     registry.put(ID, adopted, status);
     if (visible) {
         registerSTV(source, target, variant);
         if (!availableIDs.contains((void*) &ID)) {

-            UnicodeString *newID = (UnicodeString *)ID.clone();
-            // NUL-terminate the ID string
-            newID->getTerminatedBuffer();
-            availableIDs.addElement(newID, status);
+            UnicodeString *newID = ID.clone();
+            // Check to make sure newID was created.
+            if (newID != NULL) {
+                // NUL-terminate the ID string
+                newID->getTerminatedBuffer();
+                availableIDs.addElement(newID, status);
+            }

         }
     } else {
         removeSTV(source, target, variant);
         }
     } else {
         removeSTV(source, target, variant);


@@ -897,9 +968,7 @@ void TransliteratorRegistry::registerEntry(const UnicodeString& ID,
 
 /**
  * Register a source-target/variant in the specDAG.  Variant may be
 
 /**
  * Register a source-target/variant in the specDAG.  Variant may be

- * empty, but source and target must not be.  If variant is empty then
- * the special variant NO_VARIANT is stored in slot zero of the
- * UVector of variants.
+ * empty, but source and target must not be.

  */
 void TransliteratorRegistry::registerSTV(const UnicodeString& source,
                                          const UnicodeString& target,
  */
 void TransliteratorRegistry::registerSTV(const UnicodeString& source,
                                          const UnicodeString& target,


@@ -909,32 +978,38 @@ void TransliteratorRegistry::registerSTV(const UnicodeString& source,
     UErrorCode status = U_ZERO_ERROR;
     Hashtable *targets = (Hashtable*) specDAG.get(source);
     if (targets == 0) {
     UErrorCode status = U_ZERO_ERROR;
     Hashtable *targets = (Hashtable*) specDAG.get(source);
     if (targets == 0) {

-        targets = new Hashtable(TRUE, status);
-        if (U_FAILURE(status) || targets == 0) {
+        int32_t size = 3;
+        if (source.compare(ANY,3) == 0) {
+            size = ANY_TARGETS_INIT_SIZE;
+        } else if (source.compare(LAT,3) == 0) {
+            size = LAT_TARGETS_INIT_SIZE;
+        }
+        targets = new Hashtable(TRUE, size, status);
+        if (U_FAILURE(status) || targets == NULL) {

             return;
         }
             return;
         }

-        targets->setValueDeleter(uhash_deleteUVector);

         specDAG.put(source, targets, status);
     }
         specDAG.put(source, targets, status);
     }

-    UVector *variants = (UVector*) targets->get(target);
-    if (variants == 0) {
-        variants = new UVector(uhash_deleteUnicodeString,
-                               uhash_compareCaselessUnicodeString, status);
-        if (variants == 0) {
+    int32_t variantListIndex = variantList.indexOf((void*) &variant, 0);
+    if (variantListIndex < 0) {
+        if (variantList.size() >= VARIANT_LIST_MAX_SIZE) {
+            // can't handle any more variants

             return;
         }
             return;
         }

-        targets->put(target, variants, status);
-    }
-    // assert(NO_VARIANT == "");
-    // We add the variant string.  If it is the special "no variant"
-    // string, that is, the empty string, we add it at position zero.
-    if (!variants->contains((void*) &variant)) {
-        if (variant.length() > 0) {
-            variants->addElement(new UnicodeString(variant), status);
-        } else {
-            variants->insertElementAt(new UnicodeString(NO_VARIANT), 0, status);
+        UnicodeString *variantEntry = new UnicodeString(variant);
+        if (variantEntry != NULL) {
+            variantList.addElement(variantEntry, status);
+            if (U_SUCCESS(status)) {
+                variantListIndex = variantList.size() - 1;
+            }
+        }
+        if (variantListIndex < 0) {
+            return;

         }
     }
         }
     }

+    uint32_t addMask = 1 << variantListIndex;
+    uint32_t varMask = targets->geti(target);
+    targets->puti(target, varMask | addMask, status);

 }
 
 /**
 }
 
 /**


@@ -945,17 +1020,24 @@ void TransliteratorRegistry::removeSTV(const UnicodeString& source,
                                        const UnicodeString& variant) {
     // assert(source.length() > 0);
     // assert(target.length() > 0);
                                        const UnicodeString& variant) {
     // assert(source.length() > 0);
     // assert(target.length() > 0);

-//    UErrorCode status = U_ZERO_ERROR;
+    UErrorCode status = U_ZERO_ERROR;

     Hashtable *targets = (Hashtable*) specDAG.get(source);
     Hashtable *targets = (Hashtable*) specDAG.get(source);

-    if (targets == 0) {
+    if (targets == NULL) {

         return; // should never happen for valid s-t/v
     }
         return; // should never happen for valid s-t/v
     }

-    UVector *variants = (UVector*) targets->get(target);
-    if (variants == 0) {
+    uint32_t varMask = targets->geti(target);
+    if (varMask == 0) {

         return; // should never happen for valid s-t/v
     }
         return; // should never happen for valid s-t/v
     }

-    variants->removeElement((void*) &variant);
-    if (variants->size() == 0) {
+    int32_t variantListIndex = variantList.indexOf((void*) &variant, 0);
+    if (variantListIndex < 0) {
+        return; // should never happen for valid s-t/v
+    }
+    int32_t remMask = 1 << variantListIndex;
+    varMask &= (~remMask);
+    if (varMask != 0) {
+        targets->puti(target, varMask, status);
+    } else {

         targets->remove(target); // should delete variants
         if (targets->count() == 0) {
             specDAG.remove(source); // should delete targets
         targets->remove(target); // should delete variants
         if (targets->count() == 0) {
             specDAG.remove(source); // should delete targets


@@ -969,12 +1051,12 @@ void TransliteratorRegistry::removeSTV(const UnicodeString& source,
  *
  * Caller does NOT own returned object.
  */
  *
  * Caller does NOT own returned object.
  */

-Entry* TransliteratorRegistry::findInDynamicStore(const Spec& src,
-                                                  const Spec& trg,
+TransliteratorEntry* TransliteratorRegistry::findInDynamicStore(const TransliteratorSpec& src,
+                                                  const TransliteratorSpec& trg,

                                                   const UnicodeString& variant) const {
     UnicodeString ID;
     TransliteratorIDParser::STVtoID(src, trg, variant, ID);
                                                   const UnicodeString& variant) const {
     UnicodeString ID;
     TransliteratorIDParser::STVtoID(src, trg, variant, ID);

-    Entry *e = (Entry*) registry.get(ID);
+    TransliteratorEntry *e = (TransliteratorEntry*) registry.get(ID);

     DEBUG_useEntry(e);
     return e;
 }
     DEBUG_useEntry(e);
     return e;
 }


@@ -990,10 +1072,10 @@ Entry* TransliteratorRegistry::findInDynamicStore(const Spec& src,
  *
  * Caller does NOT own returned object.
  */
  *
  * Caller does NOT own returned object.
  */

-Entry* TransliteratorRegistry::findInStaticStore(const Spec& src,
-                                                 const Spec& trg,
+TransliteratorEntry* TransliteratorRegistry::findInStaticStore(const TransliteratorSpec& src,
+                                                 const TransliteratorSpec& trg,

                                                  const UnicodeString& variant) {
                                                  const UnicodeString& variant) {

-    Entry* entry = 0;
+    TransliteratorEntry* entry = 0;

     if (src.isLocale()) {
         entry = findInBundle(src, trg, variant, UTRANS_FORWARD);
     } else if (trg.isLocale()) {
     if (src.isLocale()) {
         entry = findInBundle(src, trg, variant, UTRANS_FORWARD);
     } else if (trg.isLocale()) {


@@ -1026,8 +1108,8 @@ static const UChar TRANSLITERATE[] = {84,114,97,110,115,108,105,116,101,114,97,1
  * On success, create a new Entry object, populate it, and return it.
  * The caller owns the returned object.
  */
  * On success, create a new Entry object, populate it, and return it.
  * The caller owns the returned object.
  */

-Entry* TransliteratorRegistry::findInBundle(const Spec& specToOpen,
-                                            const Spec& specToFind,
+TransliteratorEntry* TransliteratorRegistry::findInBundle(const TransliteratorSpec& specToOpen,
+                                            const TransliteratorSpec& specToFind,

                                             const UnicodeString& variant,
                                             UTransDirection direction)
 {
                                             const UnicodeString& variant,
                                             UTransDirection direction)
 {


@@ -1043,36 +1125,33 @@ Entry* TransliteratorRegistry::findInBundle(const Spec& specToOpen,
         // but must be consistent and documented.
         if (pass == 0) {
             utag.append(direction == UTRANS_FORWARD ?
         // but must be consistent and documented.
         if (pass == 0) {
             utag.append(direction == UTRANS_FORWARD ?

-                        TRANSLITERATE_TO : TRANSLITERATE_FROM);
+                        TRANSLITERATE_TO : TRANSLITERATE_FROM, -1);

         } else {
         } else {

-            utag.append(TRANSLITERATE);
+            utag.append(TRANSLITERATE, -1);

         }
         UnicodeString s(specToFind.get());
         utag.append(s.toUpper(""));
         }
         UnicodeString s(specToFind.get());
         utag.append(s.toUpper(""));

-        CharString tag(utag);
-        

         UErrorCode status = U_ZERO_ERROR;
         UErrorCode status = U_ZERO_ERROR;

-        ResourceBundle subres(specToOpen.getBundle().get(tag, status));
+        ResourceBundle subres(specToOpen.getBundle().get(
+            CharString().appendInvariantChars(utag, status).data(), status));

         if (U_FAILURE(status) || status == U_USING_DEFAULT_WARNING) {
             continue;
         }
         if (U_FAILURE(status) || status == U_USING_DEFAULT_WARNING) {
             continue;
         }

-        
+

         s.truncate(0);
         if (specToOpen.get() != LocaleUtility::initNameFromLocale(subres.getLocale(), s)) {
             continue;
         }
         s.truncate(0);
         if (specToOpen.get() != LocaleUtility::initNameFromLocale(subres.getLocale(), s)) {
             continue;
         }

-        
+

         if (variant.length() != 0) {
         if (variant.length() != 0) {

-            CharString var(variant);

             status = U_ZERO_ERROR;
             status = U_ZERO_ERROR;

-            resStr = subres.getStringEx(var, status);
+            resStr = subres.getStringEx(
+                CharString().appendInvariantChars(variant, status).data(), status);

             if (U_SUCCESS(status)) {
                 // Exit loop successfully
                 break;
             }
             if (U_SUCCESS(status)) {
                 // Exit loop successfully
                 break;
             }

-        }
-        
-        else {
+        } else {

             // Variant is empty, which means match the first variant listed.
             status = U_ZERO_ERROR;
             resStr = subres.getStringEx(1, status);
             // Variant is empty, which means match the first variant listed.
             status = U_ZERO_ERROR;
             resStr = subres.getStringEx(1, status);


@@ -1090,7 +1169,7 @@ Entry* TransliteratorRegistry::findInBundle(const Spec& specToOpen,
 
     // We have succeeded in loading a string from the locale
     // resources.  Create a new registry entry to hold it and return it.
 
     // We have succeeded in loading a string from the locale
     // resources.  Create a new registry entry to hold it and return it.

-    Entry *entry = new Entry();
+    TransliteratorEntry *entry = new TransliteratorEntry();

     if (entry != 0) {
         // The direction is always forward for the
         // TransliterateTo_xxx and TransliterateFrom_xxx
     if (entry != 0) {
         // The direction is always forward for the
         // TransliterateTo_xxx and TransliterateFrom_xxx


@@ -1099,7 +1178,7 @@ Entry* TransliteratorRegistry::findInBundle(const Spec& specToOpen,
         // the direction is the value passed in to this
         // function.
         int32_t dir = (pass == 0) ? UTRANS_FORWARD : direction;
         // the direction is the value passed in to this
         // function.
         int32_t dir = (pass == 0) ? UTRANS_FORWARD : direction;

-        entry->entryType = Entry::LOCALE_RULES;
+        entry->entryType = TransliteratorEntry::LOCALE_RULES;

         entry->stringArg = resStr;
         entry->intArg = dir;
     }
         entry->stringArg = resStr;
         entry->intArg = dir;
     }


@@ -1110,7 +1189,7 @@ Entry* TransliteratorRegistry::findInBundle(const Spec& specToOpen,
 /**
  * Convenience method.  Calls 3-arg find().
  */
 /**
  * Convenience method.  Calls 3-arg find().
  */

-Entry* TransliteratorRegistry::find(const UnicodeString& ID) {
+TransliteratorEntry* TransliteratorRegistry::find(const UnicodeString& ID) {

     UnicodeString source, target, variant;
     UBool sawSource;
     TransliteratorIDParser::IDtoSTV(ID, source, target, variant, sawSource);
     UnicodeString source, target, variant;
     UBool sawSource;
     TransliteratorIDParser::IDtoSTV(ID, source, target, variant, sawSource);


@@ -1138,13 +1217,25 @@ Entry* TransliteratorRegistry::find(const UnicodeString& ID) {
  *
  * Caller does NOT own returned object.  Return 0 on failure.
  */
  *
  * Caller does NOT own returned object.  Return 0 on failure.
  */

-Entry* TransliteratorRegistry::find(UnicodeString& source,
+TransliteratorEntry* TransliteratorRegistry::find(UnicodeString& source,

                                     UnicodeString& target,
                                     UnicodeString& variant) {
     
                                     UnicodeString& target,
                                     UnicodeString& variant) {
     

-    Spec src(source);
-    Spec trg(target);
-    Entry* entry;
+    TransliteratorSpec src(source);
+    TransliteratorSpec trg(target);
+    TransliteratorEntry* entry;
+
+    // Seek exact match in hashtable.  Temporary fix for ICU 4.6.
+    // TODO: The general logic for finding a matching transliterator needs to be reviewed.
+    // ICU ticket #8089
+    UnicodeString ID;
+    TransliteratorIDParser::STVtoID(source, target, variant, ID);
+    entry = (TransliteratorEntry*) registry.get(ID);
+    if (entry != 0) {
+        // std::string ss;
+        // std::cout << ID.toUTF8String(ss) << std::endl;
+        return entry;
+    }

 
     if (variant.length() != 0) {
         
 
     if (variant.length() != 0) {
         


@@ -1202,66 +1293,74 @@ Entry* TransliteratorRegistry::find(UnicodeString& source,
  * modified.
  */
 Transliterator* TransliteratorRegistry::instantiateEntry(const UnicodeString& ID,
  * modified.
  */
 Transliterator* TransliteratorRegistry::instantiateEntry(const UnicodeString& ID,

-                                                         Entry *entry,
+                                                         TransliteratorEntry *entry,

                                                          TransliteratorAlias* &aliasReturn,
                                                          UErrorCode& status) {
     Transliterator *t = 0;
     U_ASSERT(aliasReturn == 0);
 
     switch (entry->entryType) {
                                                          TransliteratorAlias* &aliasReturn,
                                                          UErrorCode& status) {
     Transliterator *t = 0;
     U_ASSERT(aliasReturn == 0);
 
     switch (entry->entryType) {

-    case Entry::RBT_DATA:
+    case TransliteratorEntry::RBT_DATA:

         t = new RuleBasedTransliterator(ID, entry->u.data);
         if (t == 0) {
             status = U_MEMORY_ALLOCATION_ERROR;
         }
         return t;
         t = new RuleBasedTransliterator(ID, entry->u.data);
         if (t == 0) {
             status = U_MEMORY_ALLOCATION_ERROR;
         }
         return t;

-    case Entry::PROTOTYPE:
+    case TransliteratorEntry::PROTOTYPE:

         t = entry->u.prototype->clone();
         if (t == 0) {
             status = U_MEMORY_ALLOCATION_ERROR;
         }
         return t;
         t = entry->u.prototype->clone();
         if (t == 0) {
             status = U_MEMORY_ALLOCATION_ERROR;
         }
         return t;

-    case Entry::ALIAS:
+    case TransliteratorEntry::ALIAS:

         aliasReturn = new TransliteratorAlias(entry->stringArg, entry->compoundFilter);
         if (aliasReturn == 0) {
             status = U_MEMORY_ALLOCATION_ERROR;
         }
         return 0;
         aliasReturn = new TransliteratorAlias(entry->stringArg, entry->compoundFilter);
         if (aliasReturn == 0) {
             status = U_MEMORY_ALLOCATION_ERROR;
         }
         return 0;

-    case Entry::FACTORY:
+    case TransliteratorEntry::FACTORY:

         t = entry->u.factory.function(ID, entry->u.factory.context);
         if (t == 0) {
             status = U_MEMORY_ALLOCATION_ERROR;
         }
         return t;
         t = entry->u.factory.function(ID, entry->u.factory.context);
         if (t == 0) {
             status = U_MEMORY_ALLOCATION_ERROR;
         }
         return t;

-    case Entry::COMPOUND_RBT:
+    case TransliteratorEntry::COMPOUND_RBT:

         {
         {

-            UVector* rbts = new UVector(status);
+            UVector* rbts = new UVector(entry->u.dataVector->size(), status);
+            // Check for null pointer
+            if (rbts == NULL) {
+                status = U_MEMORY_ALLOCATION_ERROR;
+                return NULL;
+            }

             int32_t passNumber = 1;
             for (int32_t i = 0; U_SUCCESS(status) && i < entry->u.dataVector->size(); i++) {
             int32_t passNumber = 1;
             for (int32_t i = 0; U_SUCCESS(status) && i < entry->u.dataVector->size(); i++) {

-                Transliterator* t = new RuleBasedTransliterator(UnicodeString(CompoundTransliterator::PASS_STRING) + (passNumber++),
+                // TODO: Should passNumber be turned into a decimal-string representation (1 -> "1")?
+                Transliterator* tl = new RuleBasedTransliterator(UnicodeString(CompoundTransliterator::PASS_STRING) + UnicodeString(passNumber++),

                     (TransliterationRuleData*)(entry->u.dataVector->elementAt(i)), FALSE);
                     (TransliterationRuleData*)(entry->u.dataVector->elementAt(i)), FALSE);

-                if (t == 0)
+                if (tl == 0)

                     status = U_MEMORY_ALLOCATION_ERROR;
                 else
                     status = U_MEMORY_ALLOCATION_ERROR;
                 else

-                    rbts->addElement(t, status);
+                    rbts->addElement(tl, status);

             }
             }

-            if (U_FAILURE(status))
+            if (U_FAILURE(status)) {
+                delete rbts;

                 return 0;
                 return 0;

+            }

             aliasReturn = new TransliteratorAlias(ID, entry->stringArg, rbts, entry->compoundFilter);
         }
         if (aliasReturn == 0) {
             status = U_MEMORY_ALLOCATION_ERROR;
         }
         return 0;
             aliasReturn = new TransliteratorAlias(ID, entry->stringArg, rbts, entry->compoundFilter);
         }
         if (aliasReturn == 0) {
             status = U_MEMORY_ALLOCATION_ERROR;
         }
         return 0;

-    case Entry::LOCALE_RULES:
+    case TransliteratorEntry::LOCALE_RULES:

         aliasReturn = new TransliteratorAlias(ID, entry->stringArg,
                                               (UTransDirection) entry->intArg);
         if (aliasReturn == 0) {
             status = U_MEMORY_ALLOCATION_ERROR;
         }
         return 0;
         aliasReturn = new TransliteratorAlias(ID, entry->stringArg,
                                               (UTransDirection) entry->intArg);
         if (aliasReturn == 0) {
             status = U_MEMORY_ALLOCATION_ERROR;
         }
         return 0;

-    case Entry::RULES_FORWARD:
-    case Entry::RULES_REVERSE:
+    case TransliteratorEntry::RULES_FORWARD:
+    case TransliteratorEntry::RULES_REVERSE:

         // Process the rule data into a TransliteratorRuleData object,
         // and possibly also into an ::id header and/or footer.  Then
         // we modify the registry with the parsed data and retry.
         // Process the rule data into a TransliteratorRuleData object,
         // and possibly also into an ::id header and/or footer.  Then
         // we modify the registry with the parsed data and retry.


@@ -1293,7 +1392,7 @@ Transliterator* TransliteratorRegistry::instantiateEntry(const UnicodeString& ID
                 // transliterators; if it lists something that's not
                 // installed, we'll get an error from ResourceBundle.
                 aliasReturn = new TransliteratorAlias(ID, rules,
                 // transliterators; if it lists something that's not
                 // installed, we'll get an error from ResourceBundle.
                 aliasReturn = new TransliteratorAlias(ID, rules,

-                    ((entry->entryType == Entry::RULES_REVERSE) ?
+                    ((entry->entryType == TransliteratorEntry::RULES_REVERSE) ?

                      UTRANS_REVERSE : UTRANS_FORWARD));
                 if (aliasReturn == 0) {
                     status = U_MEMORY_ALLOCATION_ERROR;
                      UTRANS_REVERSE : UTRANS_FORWARD));
                 if (aliasReturn == 0) {
                     status = U_MEMORY_ALLOCATION_ERROR;


@@ -1302,8 +1401,7 @@ Transliterator* TransliteratorRegistry::instantiateEntry(const UnicodeString& ID
         }
         return 0;
     default:
         }
         return 0;
     default:

-        U_ASSERT(FALSE); // can't get here
-        return 0;
+        UPRV_UNREACHABLE; // can't get here

     }
 }
 U_NAMESPACE_END
     }
 }
 U_NAMESPACE_END