]> git.saurik.com Git - apple/configd.git/blobdiff - SystemConfiguration.fproj/SCNetworkInterface.c
configd-1061.40.2.tar.gz
[apple/configd.git] / SystemConfiguration.fproj / SCNetworkInterface.c
index 5f70eaf13235f4d52fb2e4b80457dd28fa37a564..32c6c61f2441e9da698d9b9a79726a6a1cc18ff0 100644 (file)
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2004-2015 Apple Inc. All rights reserved.
+ * Copyright (c) 2004-2019 Apple Inc. All rights reserved.
  *
  * @APPLE_LICENSE_HEADER_START@
  *
  */
 
 
-#include <Availability.h>
 #include <TargetConditionals.h>
 #include <CoreFoundation/CoreFoundation.h>
 #include <CoreFoundation/CFRuntime.h>
-#include <SystemConfiguration/SystemConfiguration.h>
 #include "SCNetworkConfigurationInternal.h"
-#include <SystemConfiguration/SCValidation.h>
-#include <SystemConfiguration/SCPrivate.h>
 #include "SCPreferencesInternal.h"
 #include "SCHelper_client.h"
+#include "plugin_shared.h"
 
 #if    !TARGET_OS_IPHONE
 #include <EAP8021X/EAPClientProperties.h>
 #include <IOKit/network/IOEthernetInterface.h> // for kIOEthernetInterfaceClass
 #include <IOKit/serial/IOSerialKeys.h>
 #include <IOKit/storage/IOStorageDeviceCharacteristics.h>
-#if    !TARGET_IPHONE_SIMULATOR
+#if    !TARGET_OS_SIMULATOR
 #include <IOKit/usb/IOUSBLib.h>
-#endif // !TARGET_IPHONE_SIMULATOR
+#endif // !TARGET_OS_SIMULATOR
 
 #include "dy_framework.h"
 
-#ifndef        kIODeviceSupportsHoldKey
-#define        kIODeviceSupportsHoldKey        "V92Modem"
-#endif
-
 #ifndef        kPCIThunderboltString
 #define kPCIThunderboltString          "PCI-Thunderbolt"
 #endif
 
+#if    TARGET_OS_OSX
+#ifndef        kUSBSupportsIPhoneOS
+#define kUSBSupportsIPhoneOS           "SupportsIPhoneOS"
+#endif // !kUSBSupportsIPhoneOS
+#endif // TARGET_OS_OSX
+
 #ifndef        kIOUserEthernetInterfaceRoleKey
 #define        kIOUserEthernetInterfaceRoleKey "InterfaceRole"
 #endif
 
+#ifndef        kIOUSBHostInterfaceClassName
+#define kIOUSBHostInterfaceClassName   "IOUSBHostInterface"
+#endif
+
 #include <string.h>
+#include <sysdir.h>
 #include <mach/mach.h>
 #include <net/if.h>
 #include <net/if_types.h>
@@ -95,7 +99,9 @@
 #include <sys/sysctl.h>
 #include <pthread.h>
 #include <ifaddrs.h>
-#include <NSSystemDirectories.h>
+
+/* CrashReporter "Application Specific Information" */
+#include <CrashReporterClient.h>
 
 
 static CFStringRef     copy_interface_string                           (CFBundleRef bundle, CFStringRef key, Boolean localized);
@@ -104,10 +110,13 @@ static CFStringRef        __SCNetworkInterfaceCopyFormattingDescription   (CFTypeRef cf,
 static void            __SCNetworkInterfaceDeallocate                  (CFTypeRef cf);
 static Boolean         __SCNetworkInterfaceEqual                       (CFTypeRef cf1, CFTypeRef cf2);
 static CFHashCode      __SCNetworkInterfaceHash                        (CFTypeRef cf);
+static void            __SCNetworkInterfaceCacheAdd                    (CFStringRef bsdName, CFArrayRef matchingInterfaces);
+static Boolean         __SCNetworkInterfaceCacheIsOpen                 (void);
+static CFArrayRef      __SCNetworkInterfaceCacheCopy                   (CFStringRef bsdName);
 
 
 enum {
-       kSortInternalModem,
+       kSortInternalModem      = 0,
        kSortUSBModem,
        kSortModem,
        kSortBluetooth,
@@ -126,6 +135,7 @@ enum {
        kSortBluetoothPAN_NAP,
        kSortBluetoothPAN_U,
        kSortThunderbolt,
+       kSortCarPlay,
        kSortBond,
        kSortBridge,
        kSortVLAN,
@@ -133,6 +143,34 @@ enum {
 };
 
 
+static const char *sortOrderName[]     = {
+       "InternalModem",
+       "USBModem",
+       "Modem",
+       "Bluetooth",
+       "IrDA",
+       "SerialPort",
+       "WWAN",
+       "EthernetPPP",
+       "AirportPPP",
+       "Ethernet",
+       "FireWire",
+       "AirPort",
+       "OtherWireless",
+       "Tethered",
+       "WWANEthernet",
+       "BluetoothPAN_GN",
+       "BluetoothPAN_NAP",
+       "BluetoothPAN_U",
+       "Thunderbolt",
+       "CarPlay",
+       "Bond",
+       "Bridge",
+       "VLAN",
+       "Unknown"
+};
+
+
 const CFStringRef kSCNetworkInterfaceType6to4          = CFSTR("6to4");
 const CFStringRef kSCNetworkInterfaceTypeBluetooth     = CFSTR("Bluetooth");
 const CFStringRef kSCNetworkInterfaceTypeBond          = CFSTR("Bond");
@@ -155,103 +193,26 @@ const CFStringRef kSCNetworkInterfaceTypeWWAN            = CFSTR("WWAN");
 const CFStringRef kSCNetworkInterfaceTypeIPv4          = CFSTR("IPv4");
 
 static SCNetworkInterfacePrivate __kSCNetworkInterfaceIPv4     = {
-       INIT_CFRUNTIME_BASE(),                  // cfBase
-       NULL,                                   // interface type
-       FALSE,                                  // active
-       NULL,                                   // name
-       NULL,                                   // localized name
-       NULL,                                   // localization key
-       NULL,                                   // localization arg1
-       NULL,                                   // localization arg2
-       NULL,                                   // [layered] interface
-       NULL,                                   // prefs
-       NULL,                                   // store
-       NULL,                                   // serviceID
-       NULL,                                   // unsaved
-       NULL,                                   // entity_device
-       NULL,                                   // entity_device_unique
-       NULL,                                   // entity_type
-       NULL,                                   // entity_subtype
-       NULL,                                   // supported_interface_types
-       NULL,                                   // supported_protocol_types
-       NULL,                                   // address
-       NULL,                                   // addressString
-       FALSE,                                  // builtin
-       NULL,                                   // configurationAction
-       FALSE,                                  // hidden
-       NULL,                                   // location
-       NULL,                                   // path
-       0,                                      // entryID
-       NULL,                                   // overrides
-       FALSE,                                  // modemIsV92
-       NULL,                                   // name prefix
-       NULL,                                   // type
-       NULL,                                   // unit
-       { NULL, 0, 0 },                         // usb { name, vid, pid }
-       kSortUnknown,                           // sort_order
-       FALSE,                                  // supportsBond
-       { NULL, NULL, NULL },                   // bond { interfaces, mode, options }
-       FALSE,                                  // supportsBridge
-       { NULL, NULL },                         // bridge { interfaces, options }
-       FALSE,                                  // supportsVLAN
-       { NULL, NULL, NULL },                   // vlan { interface, tag, options }
-#if    !TARGET_IPHONE_SIMULATOR
-       NULL,                                   // IPMonitorControl
-#endif // !TARGET_IPHONE_SIMULATOR
+       .cfBase         = INIT_CFRUNTIME_BASE(),        // cfBase
+       .sort_order     = kSortUnknown,                 // sort_order
 };
 
 const SCNetworkInterfaceRef kSCNetworkInterfaceIPv4    = (SCNetworkInterfaceRef)&__kSCNetworkInterfaceIPv4;
 
 static SCNetworkInterfacePrivate __kSCNetworkInterfaceLoopback = {
-       INIT_CFRUNTIME_BASE(),                  // cfBase
-       NULL,                                   // interface type
-       FALSE,                                  // active
-       NULL,                                   // name
-       NULL,                                   // localized name
-       NULL,                                   // localization key
-       NULL,                                   // localization arg1
-       NULL,                                   // localization arg2
-       NULL,                                   // [layered] interface
-       NULL,                                   // prefs
-       NULL,                                   // store
-       NULL,                                   // serviceID
-       NULL,                                   // unsaved
-       NULL,                                   // entity_device
-       NULL,                                   // entity_device_unique
-       NULL,                                   // entity_type
-       NULL,                                   // entity_subtype
-       NULL,                                   // supported_interface_types
-       NULL,                                   // supported_protocol_types
-       NULL,                                   // address
-       NULL,                                   // addressString
-       FALSE,                                  // builtin
-       NULL,                                   // configurationAction
-       FALSE,                                  // hidden
-       NULL,                                   // location
-       NULL,                                   // path
-       0,                                      // entryID
-       NULL,                                   // overrides
-       FALSE,                                  // modemIsV92
-       NULL,                                   // name prefix
-       NULL,                                   // type
-       NULL,                                   // unit
-       { NULL, 0, 0 },                         // usb { name, vid, pid }
-       kSortUnknown,                           // sort_order
-       FALSE,                                  // supportsBond
-       { NULL, NULL, NULL },                   // bond { interfaces, mode, options }
-       FALSE,                                  // supportsBridge
-       { NULL, NULL },                         // bridge { interfaces, options }
-       FALSE,                                  // supportsVLAN
-       { NULL, NULL, NULL },                   // vlan { interface, tag, options }
-#if    !TARGET_IPHONE_SIMULATOR
-       NULL,                                   // IPMonitorControl
-#endif // !TARGET_IPHONE_SIMULATOR
+       .cfBase         = INIT_CFRUNTIME_BASE(),        // cfBase
+       .sort_order     = kSortUnknown,                 // sort_order
 };
 
 const SCNetworkInterfaceRef kSCNetworkInterfaceLoopback        = (SCNetworkInterfaceRef)&__kSCNetworkInterfaceLoopback;
 
 static CFMutableSetRef vendor_interface_types  = NULL;
 
+// A thread-specific convenience cache of all interfaces matching a bsd name
+// Key: CFStringRef (BSD name)
+// Value: CFArrayRef (matching interfaces)
+static __thread CFMutableDictionaryRef S_interface_cache = NULL;
+
 #pragma mark -
 #pragma mark SCNetworkInterface configuration details
 
@@ -296,9 +257,12 @@ static const struct {
        { &kSCNetworkInterfaceTypeL2TP          , NULL                , FALSE,  doPPP,          &kSCValNetInterfaceSubTypeL2TP,         doNone                                  },
        { &kSCNetworkInterfaceTypeModem         , &kSCEntNetModem     , FALSE,  doPPP,          &kSCValNetInterfaceSubTypePPPSerial,    doNone                                  },
        { &kSCNetworkInterfaceTypePPP           , &kSCEntNetPPP       , FALSE,  doNone,         NULL,                                   doDNS|doIPv4|doIPv6|doProxies|doSMB     },
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated"
        { &kSCNetworkInterfaceTypePPTP          , NULL                , FALSE,  doPPP,          &kSCValNetInterfaceSubTypePPTP,         doNone                                  },
+#pragma GCC diagnostic pop
        { &kSCNetworkInterfaceTypeSerial        , &kSCEntNetModem     , FALSE,  doPPP,          &kSCValNetInterfaceSubTypePPPSerial,    doNone                                  },
-       { &kSCNetworkInterfaceTypeVLAN          , &kSCEntNetEthernet  , TRUE ,  doNone,         NULL,                                   doDNS|doIPv4|doIPv6|doProxies|doSMB     },
+       { &kSCNetworkInterfaceTypeVLAN          , &kSCEntNetEthernet  , TRUE ,  doNone,         &kSCValNetInterfaceSubTypePPPoE,        doDNS|doIPv4|doIPv6|doProxies|doSMB     },
        { &kSCNetworkInterfaceTypeVPN           , &kSCEntNetVPN       , FALSE,  doNone,         NULL,                                   doDNS|doIPv4|doIPv6|doProxies|doSMB     },
        { &kSCNetworkInterfaceTypeWWAN          , &kSCEntNetModem     , FALSE,  doPPP,          &kSCValNetInterfaceSubTypePPPSerial,    doNone                                  },
        // =====================================  =================== ========== =============== ======================================= =========================================
@@ -342,6 +306,7 @@ static const CFRuntimeClass __SCNetworkInterfaceClass = {
 
 static pthread_once_t          initialized     = PTHREAD_ONCE_INIT;
 static pthread_once_t          iokit_quiet     = PTHREAD_ONCE_INIT;
+static pthread_mutex_t         lock            = PTHREAD_MUTEX_INITIALIZER;
 
 
 static mach_port_t             masterPort      = MACH_PORT_NULL;
@@ -405,9 +370,11 @@ __SCNetworkInterfaceCopyFormattingDescription(CFTypeRef cf, CFDictionaryRef form
        if (interfacePrivate->hidden) {
                CFStringAppendFormat(result, NULL, CFSTR(", hidden = TRUE"));
        }
-       if (interfacePrivate->modemIsV92) {
-               CFStringAppendFormat(result, NULL, CFSTR(", v.92"));
+#if    TARGET_OS_IPHONE
+       if (interfacePrivate->trustRequired) {
+               CFStringAppendFormat(result, NULL, CFSTR(", trust required = TRUE"));
        }
+#endif // TARGET_OS_IPHONE
        if (interfacePrivate->location != NULL) {
                CFStringAppendFormat(result, NULL, CFSTR(", location = %@"), interfacePrivate->location);
        }
@@ -423,6 +390,12 @@ __SCNetworkInterfaceCopyFormattingDescription(CFTypeRef cf, CFDictionaryRef form
        if (interfacePrivate->unit != NULL) {
                CFStringAppendFormat(result, NULL, CFSTR(", unit = %@"), interfacePrivate->unit);
        }
+       if (interfacePrivate->family != NULL) {
+               CFStringAppendFormat(result, NULL, CFSTR(", family = %@"), interfacePrivate->family);
+       }
+       if (interfacePrivate->subfamily != NULL) {
+               CFStringAppendFormat(result, NULL, CFSTR(", subfamily = %@"), interfacePrivate->subfamily);
+       }
        if ((interfacePrivate->usb.vid != NULL) || (interfacePrivate->usb.pid != NULL)) {
                int     pid     = 0;
                int     vid     = 0;
@@ -449,9 +422,15 @@ __SCNetworkInterfaceCopyFormattingDescription(CFTypeRef cf, CFDictionaryRef form
                CFStringAppendFormat(result, NULL, CFSTR(", action = %@"), interfacePrivate->configurationAction);
        }
        if (interfacePrivate->overrides != NULL) {
-               CFStringAppendFormat(result, formatOptions, CFSTR(", overrides = %p"), interfacePrivate->overrides);
+               CFStringRef     str;
+
+               str = _SCCopyDescription(interfacePrivate->overrides, formatOptions);
+               CFStringAppendFormat(result, formatOptions, CFSTR(", overrides = %@"), str);
+               CFRelease(str);
        }
-       CFStringAppendFormat(result, NULL, CFSTR(", order = %d"), interfacePrivate->sort_order);
+       CFStringAppendFormat(result, NULL, CFSTR(", order = %d (%s)"),
+                            interfacePrivate->sort_order,
+                            interfacePrivate->sort_order <= kSortUnknown ? sortOrderName[interfacePrivate->sort_order] : "?");
        if (interfacePrivate->prefs != NULL) {
                CFStringAppendFormat(result, NULL, CFSTR(", prefs = %p"), interfacePrivate->prefs);
        }
@@ -609,6 +588,12 @@ __SCNetworkInterfaceDeallocate(CFTypeRef cf)
        if (interfacePrivate->unit != NULL)
                CFRelease(interfacePrivate->unit);
 
+       if (interfacePrivate->family != NULL)
+               CFRelease(interfacePrivate->family);
+
+       if (interfacePrivate->subfamily != NULL)
+               CFRelease(interfacePrivate->subfamily);
+
        if (interfacePrivate->usb.name != NULL)
                CFRelease(interfacePrivate->usb.name);
 
@@ -641,10 +626,10 @@ __SCNetworkInterfaceDeallocate(CFTypeRef cf)
 
        if (interfacePrivate->vlan.options != NULL)
                CFRelease(interfacePrivate->vlan.options);
-#if    !TARGET_IPHONE_SIMULATOR
+#if    !TARGET_OS_SIMULATOR
        if (interfacePrivate->IPMonitorControl != NULL)
                CFRelease(interfacePrivate->IPMonitorControl);
-#endif // !TARGET_IPHONE_SIMULATOR
+#endif // !TARGET_OS_SIMULATOR
        return;
 }
 
@@ -793,55 +778,11 @@ __SCNetworkInterfaceCreatePrivate(CFAllocatorRef  allocator,
                return NULL;
        }
 
-       interfacePrivate->interface_type                = NULL;
-       interfacePrivate->active                        = FALSE;
-       interfacePrivate->name                          = NULL;
-       interfacePrivate->localized_name                = NULL;
-       interfacePrivate->localized_key                 = NULL;
-       interfacePrivate->localized_arg1                = NULL;
-       interfacePrivate->localized_arg2                = NULL;
-       interfacePrivate->interface                     = (interface != NULL) ? CFRetain(interface) : NULL;
-       interfacePrivate->prefs                         = (prefs     != NULL) ? CFRetain(prefs)     : NULL;
-       interfacePrivate->store                         = NULL;
-       interfacePrivate->serviceID                     = (serviceID != NULL) ? CFRetain(serviceID) : NULL;
-       interfacePrivate->unsaved                       = NULL;
-       interfacePrivate->entity_device                 = NULL;
-       interfacePrivate->entity_device_unique          = NULL;
-       interfacePrivate->entity_type                   = NULL;
-       interfacePrivate->entity_subtype                = NULL;
-       interfacePrivate->supported_interface_types     = NULL;
-       interfacePrivate->supported_protocol_types      = NULL;
-       interfacePrivate->address                       = NULL;
-       interfacePrivate->addressString                 = NULL;
-       interfacePrivate->builtin                       = FALSE;
-       interfacePrivate->configurationAction           = NULL;
-       interfacePrivate->hidden                        = FALSE;
-       interfacePrivate->location                      = NULL;
-       interfacePrivate->path                          = NULL;
-       interfacePrivate->entryID                       = 0;
-       interfacePrivate->overrides                     = NULL;
-       interfacePrivate->modemIsV92                    = FALSE;
-       interfacePrivate->prefix                        = NULL;
-       interfacePrivate->type                          = NULL;
-       interfacePrivate->unit                          = NULL;
-       interfacePrivate->usb.name                      = NULL;
-       interfacePrivate->usb.vid                       = NULL;
-       interfacePrivate->usb.pid                       = NULL;
-       interfacePrivate->sort_order                    = kSortUnknown;
-
-       interfacePrivate->supportsBond                  = FALSE;
-       interfacePrivate->bond.interfaces               = NULL;
-       interfacePrivate->bond.mode                     = NULL;
-       interfacePrivate->bond.options                  = NULL;
-
-       interfacePrivate->supportsBridge                = FALSE;
-       interfacePrivate->bridge.interfaces             = NULL;
-       interfacePrivate->bridge.options                = NULL;
-
-       interfacePrivate->supportsVLAN                  = FALSE;
-       interfacePrivate->vlan.interface                = NULL;
-       interfacePrivate->vlan.tag                      = NULL;
-       interfacePrivate->vlan.options                  = NULL;
+       /* initialize non-zero/NULL members */
+       interfacePrivate->interface     = (interface != NULL) ? CFRetain(interface) : NULL;
+       interfacePrivate->prefs         = (prefs     != NULL) ? CFRetain(prefs)     : NULL;
+       interfacePrivate->serviceID     = (serviceID != NULL) ? CFRetain(serviceID) : NULL;
+       interfacePrivate->sort_order    = kSortUnknown;
 
        return interfacePrivate;
 }
@@ -1074,6 +1015,7 @@ split_path(CFStringRef path)
 CFComparisonResult
 _SCNetworkInterfaceCompare(const void *val1, const void *val2, void *context)
 {
+#pragma unused(context)
        SCNetworkInterfacePrivateRef    dev1            = (SCNetworkInterfacePrivateRef)val1;
        SCNetworkInterfacePrivateRef    dev2            = (SCNetworkInterfacePrivateRef)val2;
        CFComparisonResult              res             = kCFCompareEqualTo;
@@ -1383,8 +1325,6 @@ pci_slot(io_registry_entry_t interface, CFTypeRef *pci_slot_name)
 
        slot_name = IORegistryEntryCreateCFProperty(interface, CFSTR("AAPL,slot-name"), NULL, 0);
        if (slot_name != NULL) {
-               CFIndex i;
-
                slot = CFStringCreateMutable(NULL, 0);
                if (isA_CFString(slot_name)) {
                        if (pci_slot_name != NULL) *pci_slot_name = CFStringCreateCopy(NULL, slot_name);
@@ -1396,7 +1336,7 @@ pci_slot(io_registry_entry_t interface, CFTypeRef *pci_slot_name)
                                              kCFStringEncodingUTF8);
                }
 
-               for (i = 0; i < sizeof(slot_prefixes)/sizeof(slot_prefixes[0]); i++) {
+               for (size_t i = 0; i < sizeof(slot_prefixes)/sizeof(slot_prefixes[0]); i++) {
                        CFIndex         len;
 
                        len = CFStringGetLength(slot_prefixes[i]);
@@ -1409,7 +1349,7 @@ pci_slot(io_registry_entry_t interface, CFTypeRef *pci_slot_name)
                        }
                }
 
-               for (i = 0; i < sizeof(slot_mappings)/sizeof(slot_mappings[0]); i++) {
+               for (size_t i = 0; i < sizeof(slot_mappings)/sizeof(slot_mappings[0]); i++) {
                        if (CFStringCompare(slot,
                                            slot_mappings[i].name,
                                            kCFCompareCaseInsensitive) == kCFCompareEqualTo) {
@@ -1437,7 +1377,7 @@ pci_slot(io_registry_entry_t interface, CFTypeRef *pci_slot_name)
                                        if (*pci_slot_name != NULL) CFRelease(*pci_slot_name);
                                        *pci_slot_name = parent_pci_slot_name;
                                } else {
-                                       CFRelease(parent_pci_slot_name);
+                                       if (parent_pci_slot_name != NULL) CFRelease(parent_pci_slot_name);
                                }
                        }
 
@@ -1459,6 +1399,7 @@ pci_slot(io_registry_entry_t interface, CFTypeRef *pci_slot_name)
 static CFComparisonResult
 compare_bsdNames(const void *val1, const void *val2, void *context)
 {
+#pragma unused(context)
        CFStringRef     bsd1    = (CFStringRef)val1;
        CFStringRef     bsd2    = (CFStringRef)val2;
 
@@ -1654,7 +1595,7 @@ isBluetoothBuiltin(Boolean *haveController)
        hciController = IOIteratorNext(iter);
        IOObjectRelease(iter);
        if(hciController != MACH_PORT_NULL) {
-#if    !TARGET_IPHONE_SIMULATOR
+#if    !TARGET_OS_SIMULATOR
                CFNumberRef     idVendor;
 
                idVendor = IORegistryEntryCreateCFProperty(hciController, CFSTR(kUSBVendorID), NULL, 0);
@@ -1669,7 +1610,7 @@ isBluetoothBuiltin(Boolean *haveController)
 
                        CFRelease(idVendor);
                }
-#endif // !TARGET_IPHONE_SIMULATOR
+#endif // !TARGET_OS_SIMULATOR
 
                IOObjectRelease(hciController);
        }
@@ -1706,24 +1647,39 @@ processUSBInterface(SCNetworkInterfacePrivateRef        interfacePrivate,
                    io_registry_entry_t                 bus,
                    CFDictionaryRef                     bus_dict)
 {
-#if    !TARGET_IPHONE_SIMULATOR
+#if    TARGET_OS_SIMULATOR
+#pragma unused(interfacePrivate)
+#pragma unused(interface)
+#endif // TARGET_OS_SIMULATOR
+#pragma unused(interface_dict)
+#pragma unused(controller)
+#pragma unused(controller_dict)
+#pragma unused(bus)
+#pragma unused(bus_dict)
+#if    !TARGET_OS_SIMULATOR
        // capture USB info
-       interfacePrivate->usb.name = IORegistryEntrySearchCFProperty(interface,
-                                                                    kIOServicePlane,
-                                                                    CFSTR(kUSBProductString),
-                                                                    NULL,
-                                                                    kIORegistryIterateRecursively | kIORegistryIterateParents);
-       interfacePrivate->usb.vid  = IORegistryEntrySearchCFProperty(interface,
-                                                                    kIOServicePlane,
-                                                                    CFSTR(kUSBVendorID),
-                                                                    NULL,
-                                                                    kIORegistryIterateRecursively | kIORegistryIterateParents);
-       interfacePrivate->usb.pid  = IORegistryEntrySearchCFProperty(interface,
-                                                                    kIOServicePlane,
-                                                                    CFSTR(kUSBProductID),
-                                                                    NULL,
-                                                                    kIORegistryIterateRecursively | kIORegistryIterateParents);
-#endif // !TARGET_IPHONE_SIMULATOR
+       if (interfacePrivate->usb.name == NULL) {
+               interfacePrivate->usb.name = IORegistryEntrySearchCFProperty(interface,
+                                                                            kIOServicePlane,
+                                                                            CFSTR(kUSBProductString),
+                                                                            NULL,
+                                                                            kIORegistryIterateRecursively | kIORegistryIterateParents);
+       }
+       if (interfacePrivate->usb.vid == NULL) {
+               interfacePrivate->usb.vid  = IORegistryEntrySearchCFProperty(interface,
+                                                                            kIOServicePlane,
+                                                                            CFSTR(kUSBVendorID),
+                                                                            NULL,
+                                                                            kIORegistryIterateRecursively | kIORegistryIterateParents);
+       }
+       if (interfacePrivate->usb.pid == NULL) {
+               interfacePrivate->usb.pid  = IORegistryEntrySearchCFProperty(interface,
+                                                                            kIOServicePlane,
+                                                                            CFSTR(kUSBProductID),
+                                                                            NULL,
+                                                                            kIORegistryIterateRecursively | kIORegistryIterateParents);
+       }
+#endif // !TARGET_OS_SIMULATOR
 
        return;
 }
@@ -1824,9 +1780,6 @@ merge_override(SCNetworkInterfacePrivateRef       interfacePrivate,
 }
 
 
-#define        BT_PAN_NAME     "Bluetooth PAN"
-#define        BT_PAN_MAC      BT_PAN_NAME " (MAC)"
-
 static Boolean
 processNetworkInterface(SCNetworkInterfacePrivateRef   interfacePrivate,
                        io_registry_entry_t             interface,
@@ -1849,7 +1802,7 @@ processNetworkInterface(SCNetworkInterfacePrivateRef      interfacePrivate,
            CFNumberGetValue(num, kCFNumberIntType, &ift)) {
                interfacePrivate->type = CFRetain(num);
        } else {
-               SC_log(LOG_INFO, "no interface type");
+               SC_log(LOG_INFO, "no interface type: %@", interface_dict);
                return FALSE;
        }
 
@@ -1901,6 +1854,10 @@ processNetworkInterface(SCNetworkInterfacePrivateRef     interfacePrivate,
                                                        interfacePrivate->interface_type        = kSCNetworkInterfaceTypeEthernet;
                                                        interfacePrivate->entity_type           = kSCValNetInterfaceTypeEthernet;
                                                        interfacePrivate->sort_order            = kSortBluetoothPAN_U;
+                                               } else if (CFEqual(val, CFSTR("CarPlay"))) {
+                                                       interfacePrivate->interface_type        = kSCNetworkInterfaceTypeEthernet;
+                                                       interfacePrivate->entity_type           = kSCValNetInterfaceTypeEthernet;
+                                                       interfacePrivate->sort_order            = kSortCarPlay;
                                                }
                                        }
 
@@ -1908,6 +1865,25 @@ processNetworkInterface(SCNetworkInterfacePrivateRef     interfacePrivate,
                                }
                        }
 
+#if    TARGET_OS_OSX
+                       if (interfacePrivate->interface_type == NULL) {
+                               val = IORegistryEntrySearchCFProperty(interface,
+                                                                     kIOServicePlane,
+                                                                     CFSTR(kUSBSupportsIPhoneOS),
+                                                                     NULL,
+                                                                     kIORegistryIterateRecursively | kIORegistryIterateParents);
+                               if (val != NULL) {
+                                       if (isA_CFBoolean(val) && CFBooleanGetValue(val)) {
+                                               interfacePrivate->interface_type        = kSCNetworkInterfaceTypeEthernet;
+                                               interfacePrivate->entity_type           = kSCValNetInterfaceTypeEthernet;
+                                               interfacePrivate->sort_order            = kSortTethered;
+                                       }
+
+                                       CFRelease(val);
+                               }
+                       }
+#endif // TARGET_OS_OSX
+
                        if (interfacePrivate->interface_type == NULL) {
                                str = IODictionaryCopyCFStringValue(bus_dict, CFSTR("name"));
                                if (str != NULL) {
@@ -2037,9 +2013,10 @@ processNetworkInterface(SCNetworkInterfacePrivateRef     interfacePrivate,
                                                io_registry_entry_t     node    = interface;
 
                                                while (provider != NULL) {
-#if    !TARGET_IPHONE_SIMULATOR
+#if    !TARGET_OS_SIMULATOR
                                                        if (CFEqual(provider, CFSTR(kIOUSBDeviceClassName)) ||
-                                                           CFEqual(provider, CFSTR(kIOUSBInterfaceClassName))) {
+                                                           CFEqual(provider, CFSTR(kIOUSBInterfaceClassName)) ||
+                                                           CFEqual(provider, CFSTR(kIOUSBHostInterfaceClassName))) {
                                                                // get USB info (if available)
                                                                processUSBInterface(interfacePrivate,
                                                                                    interface,
@@ -2056,7 +2033,7 @@ processNetworkInterface(SCNetworkInterfacePrivateRef      interfacePrivate,
                                                                }
                                                                break;
                                                        }
-#endif // !TARGET_IPHONE_SIMULATOR
+#endif // !TARGET_OS_SIMULATOR
 
                                                        if (node == interface) {
                                                                node = controller;
@@ -2215,18 +2192,18 @@ set_connection_script(SCNetworkInterfacePrivateRef interfacePrivate, CFStringRef
 static Boolean
 is_valid_connection_script(CFStringRef script)
 {
-       char                            ccl[MAXPATHLEN];
-       char                            path[MAXPATHLEN];
-       NSSearchPathEnumerationState    state;
+       char                                    ccl[MAXPATHLEN];
+       char                                    path[MAXPATHLEN];
+       sysdir_search_path_enumeration_state    state;
 
        (void) _SC_cfstring_to_cstring(script,
                                       ccl,
                                       sizeof(ccl),
                                       kCFStringEncodingUTF8);
 
-       state = NSStartSearchPathEnumeration(NSLibraryDirectory,
-                                            NSLocalDomainMask|NSSystemDomainMask);
-       while ((state = NSGetNextSearchPathEnumeration(state, path))) {
+       state = sysdir_start_search_path_enumeration(SYSDIR_DIRECTORY_LIBRARY,
+                                                    SYSDIR_DOMAIN_MASK_LOCAL|SYSDIR_DOMAIN_MASK_SYSTEM);
+       while ((state = sysdir_get_next_search_path_enumeration(state, path))) {
                size_t          n;
                struct stat     statBuf;
 
@@ -2370,22 +2347,6 @@ processSerialInterface(SCNetworkInterfacePrivateRef      interfacePrivate,
                // Modem
                interfacePrivate->interface_type        = kSCNetworkInterfaceTypeModem;
                interfacePrivate->sort_order            = kSortModem;
-
-               // V.92 support
-               val = IORegistryEntrySearchCFProperty(interface,
-                                                     kIOServicePlane,
-                                                     CFSTR(kIODeviceSupportsHoldKey),
-                                                     NULL,
-                                                     kIORegistryIterateRecursively | kIORegistryIterateParents);
-               if (val != NULL) {
-                       uint32_t        v92;
-
-                       if (isA_CFNumber(val) &&
-                           CFNumberGetValue(val, kCFNumberSInt32Type, &v92)) {
-                               interfacePrivate->modemIsV92 = (v92 == 1);
-                       }
-                       CFRelease(val);
-               }
        }
 
        // Entity (Type)
@@ -2641,8 +2602,6 @@ createInterface(io_registry_entry_t interface, processInterface func,
        CFTypeRef                       val;
 
        // Keys of interest
-#if    TARGET_IPHONE_SIMULATOR || 1    // while waiting for rdar://19431723
-#else
        const CFStringRef interface_dict_keys[] = {
                CFSTR(kIOInterfaceType),
                CFSTR(kIOBuiltin),
@@ -2655,7 +2614,6 @@ createInterface(io_registry_entry_t interface, processInterface func,
                CFSTR(kIOSerialBSDTypeKey),
                CFSTR(kIOLocation)
        };
-#endif // !TARGET_IPHONE_SIMULATOR
 
        const CFStringRef controller_dict_keys[] = {
                CFSTR(kIOFeatures),
@@ -2679,18 +2637,9 @@ createInterface(io_registry_entry_t interface, processInterface func,
                }
        }
 
-#if    TARGET_IPHONE_SIMULATOR || 1    // while waiting for rdar://19431723
-       // get the dictionary associated with the [interface] node
-       kr = IORegistryEntryCreateCFProperties(interface, &interface_dict, NULL, kNilOptions);
-       if (kr != kIOReturnSuccess) {
-               SC_log(LOG_INFO, "IORegistryEntryCreateCFProperties() failed, kr = 0x%x", kr);
-               goto done;
-       }
-#else
         interface_dict = copyIORegistryProperties(interface,
                                                   interface_dict_keys,
                                                   sizeof(interface_dict_keys)/sizeof(interface_dict_keys[0]));
-#endif // !TARGET_IPHONE_SIMULATOR
 
        // get the controller node
        kr = IORegistryEntryGetParentEntry(interface, kIOServicePlane, &controller);
@@ -2763,6 +2712,21 @@ createInterface(io_registry_entry_t interface, processInterface func,
                        interfacePrivate->hidden = TRUE;
                        CFRelease(val);
                }
+
+#if    TARGET_OS_IPHONE
+               // get TrustRequired preference
+               val = IORegistryEntrySearchCFProperty(interface,
+                                                     kIOServicePlane,
+                                                     kSCNetworkInterfaceTrustRequiredKey,
+                                                     NULL,
+                                                     kIORegistryIterateRecursively | kIORegistryIterateParents);
+               if (val != NULL) {
+                       if (isA_CFBoolean(val)) {
+                               interfacePrivate->trustRequired = CFBooleanGetValue(val);
+                       }
+                       CFRelease(val);
+               }
+#endif // TARGET_OS_IPHONE
        } else {
                CFRelease(interfacePrivate);
                interfacePrivate = NULL;
@@ -2783,8 +2747,10 @@ createInterface(io_registry_entry_t interface, processInterface func,
 
 
 static CF_RETURNS_RETAINED CFArrayRef
-findMatchingInterfaces(CFDictionaryRef matching, processInterface func,
-                      CFStringRef hidden_key)
+findMatchingInterfaces(CFDictionaryRef matching,
+                      processInterface func,
+                      CFStringRef      hidden_key,
+                      Boolean          keep_pre_configured)
 {
        CFMutableArrayRef       interfaces;
        io_registry_entry_t     interface;
@@ -2811,7 +2777,9 @@ findMatchingInterfaces(CFDictionaryRef matching, processInterface func,
 
                match = createInterface(interface, func, hidden_key);
                if (match != NULL) {
-                       CFArrayAppendValue(interfaces, match);
+                       if (keep_pre_configured || !_SCNetworkInterfaceIsApplePreconfigured(match)) {
+                               CFArrayAppendValue(interfaces, match);
+                       }
                        CFRelease(match);
                }
 
@@ -2831,9 +2799,7 @@ findMatchingInterfaces(CFDictionaryRef matching, processInterface func,
 static CFIndex
 findConfiguration(CFStringRef interface_type)
 {
-       CFIndex i;
-
-       for (i = 0; i < sizeof(configurations)/sizeof(configurations[0]); i++) {
+       for (size_t i = 0; i < sizeof(configurations)/sizeof(configurations[0]); i++) {
                if (CFEqual(interface_type, *configurations[i].interface_type)) {
                        return i;
                }
@@ -2937,9 +2903,14 @@ __SCNetworkInterfaceIsValidExtendedConfigurationType(SCNetworkInterfaceRef       inter
 
        /*
         * ???
-        * Do we match specific/known extended configuration types (e.g. EAPOL)
-        * and ensure that any non-standard extended configuration types be of
-        * the form com.myCompany.myType?
+        * Should we check/match and specifically allow known extended
+        * configuration types (e.g. EAPOL)?
+        *
+        * Should we check/match and specifically block known internal
+        * configuration types (e.g. QoSMarking)?
+        *
+        * Lastly, should we ensure that any non-standard extended configuration
+        * types be of the form com.myCompany.myType?
         * ???
         */
 
@@ -2963,6 +2934,7 @@ typedef struct {
 static void
 __addExtendedConfigurationType(const void *key, const void *value, void *context)
 {
+#pragma unused(value)
        CFStringRef                     extendedType    = (CFStringRef)key;
        extendedConfigurationRef        myContextRef    = (extendedConfigurationRef)context;
 
@@ -2984,6 +2956,27 @@ __addExtendedConfigurationType(const void *key, const void *value, void *context
 }
 
 
+static CFIndex
+findPerInterfaceConfiguration(SCNetworkInterfaceRef interface)
+{
+       CFIndex                         interfaceIndex;
+       SCNetworkInterfacePrivateRef    interfacePrivate        = (SCNetworkInterfacePrivateRef)interface;
+
+       interfaceIndex = findConfiguration(interfacePrivate->interface_type);
+       if (interfaceIndex == kCFNotFound) {
+               // if per-service (not per interface) configuration
+               return kCFNotFound;
+       }
+
+       if (!configurations[interfaceIndex].per_interface_config) {
+               // if per-interface configuration not allowed
+               return kCFNotFound;
+       }
+
+       return interfaceIndex;
+}
+
+
 static CF_RETURNS_RETAINED CFArrayRef
 extendedConfigurationTypes(SCNetworkInterfaceRef interface)
 {
@@ -3008,15 +3001,9 @@ extendedConfigurationTypes(SCNetworkInterfaceRef interface)
                goto done;
        }
 
-       interfaceIndex = findConfiguration(interfacePrivate->interface_type);
+       interfaceIndex = findPerInterfaceConfiguration(interface);
        if (interfaceIndex == kCFNotFound) {
-               // we don't allow per-service extended configurations
-               goto done;
-       }
-
-       if (!configurations[interfaceIndex].per_interface_config) {
-               // known interface type but we still don't allow
-               // per-service extended configurations
+               // if no per-interface configuration
                goto done;
        }
 
@@ -3140,9 +3127,9 @@ static CFArrayRef
 copyConfigurationPaths(SCNetworkInterfacePrivateRef    interfacePrivate,
                       CFStringRef                      extendedType)
 {
-       CFArrayRef                      array;
-       CFIndex                         interfaceIndex;
-       CFStringRef                     path;
+       CFArrayRef      array           = NULL;
+       CFIndex         interfaceIndex;
+       CFStringRef     path;
 
        interfaceIndex = findConfiguration(interfacePrivate->interface_type);
        if (interfaceIndex == kCFNotFound) {
@@ -3162,9 +3149,11 @@ copyConfigurationPaths(SCNetworkInterfacePrivateRef      interfacePrivate,
                array = stringCreateArray(path);
                CFRelease(path);
        }
-       else {
+
+       else if (interfacePrivate->serviceID != NULL) {
                array = copyPerInterfaceConfigurationPaths(interfacePrivate, extendedType);
        }
+
        return (array);
 }
 
@@ -3210,6 +3199,13 @@ __SCNetworkInterfaceCopyInterfaceEntity(SCNetworkInterfaceRef interface)
                                     kSCNetworkInterfaceHiddenConfigurationKey,
                                     kCFBooleanTrue);
        }
+#if    TARGET_OS_IPHONE
+       if (interfacePrivate->trustRequired) {
+               CFDictionarySetValue(entity,
+                                    kSCNetworkInterfaceTrustRequiredKey,
+                                    kCFBooleanTrue);
+       }
+#endif // TARGET_OS_IPHONE
 
        // match the "hardware" with the lowest layer
        while (TRUE) {
@@ -3247,19 +3243,6 @@ __SCNetworkInterfaceCopyInterfaceEntity(SCNetworkInterfaceRef interface)
                             kSCPropUserDefinedName,
                             SCNetworkInterfaceGetLocalizedDisplayName(interface));
 
-       // note that this is a V.92 capable modem
-       if (CFEqual(interfacePrivate->interface_type, kSCNetworkInterfaceTypeModem) &&
-           interfacePrivate->modemIsV92) {
-               int             one     = 1;
-               CFNumberRef     num;
-
-               num = CFNumberCreate(NULL, kCFNumberIntType, &one);
-               CFDictionarySetValue(entity,
-                                    kSCPropNetInterfaceSupportsModemOnHold,
-                                    num);
-               CFRelease(num);
-       }
-
        return entity;
 }
 
@@ -3419,15 +3402,16 @@ copy_ppp_entity(CFStringRef bsdName)
 
 
 SCNetworkInterfaceRef
-_SCNetworkInterfaceCreateWithBSDName(CFAllocatorRef            allocator,
-                                    CFStringRef                bsdName,
-                                    UInt32                     flags)
+_SCNetworkInterfaceCreateWithBSDName(CFAllocatorRef    allocator,
+                                    CFStringRef        bsdName,
+                                    UInt32             flags)
 {
+#pragma unused(allocator)
        CFMutableDictionaryRef  entity  = NULL;
        struct ifreq            ifr;
        SCNetworkInterfaceRef   interface;
 
-       bzero(&ifr, sizeof(ifr));
+       memset(&ifr, 0, sizeof(ifr));
        if (_SC_cfstring_to_cstring(bsdName, ifr.ifr_name, sizeof(ifr.ifr_name), kCFStringEncodingASCII) != NULL) {
                int     s;
 
@@ -3589,7 +3573,7 @@ __SCNetworkInterfaceSetIOInterfacePrefix (SCNetworkInterfaceRef interface,
 
 __private_extern__
 void
-__SCNetworkInterfaceSetIOInterfaceUnit (SCNetworkInterfaceRef interface,
+__SCNetworkInterfaceSetIOInterfaceUnit(SCNetworkInterfaceRef interface,
                                       CFNumberRef unit)
 {
        SCNetworkInterfacePrivateRef interfacePrivate;
@@ -3622,12 +3606,12 @@ __SCNetworkInterfaceSetIOInterfaceUnit (SCNetworkInterfaceRef interface,
 
        // Update the BSD Name
        if ((newBSDName == NULL) ||
-           (__SCNetworkInterfaceUpdateBSDName(interface, oldBSDName, newBSDName) == FALSE)) {
+           (!__SCNetworkInterfaceUpdateBSDName(interface, oldBSDName, newBSDName))) {
                SC_log(LOG_INFO, "BSD name update failed");
        }
 
        // Update the path
-       if (__SCNetworkInterfaceUpdateIOPath(interface) == FALSE) {
+       if (!__SCNetworkInterfaceUpdateIOPath(interface)) {
                SC_log(LOG_INFO, "IOPath update failed");
        }
 
@@ -3662,48 +3646,48 @@ __SCNetworkInterfaceCopyStorageEntity(SCNetworkInterfaceRef interface)
        CFDictionaryRef info = NULL;
        CFStringRef type = NULL;
 
-       if (interfacePrivate->active == TRUE) {
+       if (interfacePrivate->active) {
                active = kCFBooleanTrue;
        }
 
        bsdName = SCNetworkInterfaceGetBSDName(interface);
-       if (isA_CFString(bsdName) == NULL) {
+       if (!isA_CFString(bsdName)) {
                goto done;
        }
 
        builtin = interfacePrivate->builtin ? kCFBooleanTrue : kCFBooleanFalse;
        interfaceNamePrefix = _SCNetworkInterfaceGetIOInterfaceNamePrefix(interface);
-       if (isA_CFString(interfaceNamePrefix) == NULL) {
+       if (!isA_CFString(interfaceNamePrefix)) {
                goto done;
        }
 
        interfaceType = _SCNetworkInterfaceGetIOInterfaceType(interface);
-       if (isA_CFNumber(interfaceType) == NULL) {
+       if (!isA_CFNumber(interfaceType)) {
                goto done;
        }
 
        interfaceUnit = _SCNetworkInterfaceGetIOInterfaceUnit(interface);
-       if (isA_CFNumber(interfaceUnit) == NULL) {
+       if (!isA_CFNumber(interfaceUnit)) {
                goto done;
        }
 
        macAddress = _SCNetworkInterfaceGetHardwareAddress(interface);
-       if (isA_CFData(macAddress) == NULL) {
+       if (!isA_CFData(macAddress)) {
                goto done;
        }
 
        pathMatch = _SCNetworkInterfaceGetIOPath(interface);
-       if (isA_CFString(pathMatch) == NULL) {
+       if (!isA_CFString(pathMatch)) {
                goto done;
        }
 
        info = _SCNetworkInterfaceCopyInterfaceInfo(interface);
-       if (isA_CFDictionary(info) == NULL) {
+       if (!isA_CFDictionary(info)) {
                goto done;
        }
 
        type = SCNetworkInterfaceGetInterfaceType(interface);
-       if (isA_CFString(type) == NULL) {
+       if (!isA_CFString(type)) {
                goto done;
        }
 
@@ -3769,7 +3753,7 @@ __SCNetworkInterfaceMatchesName(CFStringRef name, CFStringRef key)
        CFStringRef     str;
 
        if (bundle == NULL) {
-               SC_log(LOG_NOTICE, "%s: no bundle information to compare interface names", __FUNCTION__);
+               SC_log(LOG_NOTICE, "no bundle information to compare interface names");
                return FALSE;
        }
 
@@ -3807,10 +3791,10 @@ __SCNetworkInterfaceMatchesName(CFStringRef name, CFStringRef key)
 
 
 static SCNetworkInterfaceRef
-__SCNetworkInterfaceCreateWithStorageEntity (CFAllocatorRef allocator,
-                                            CFDictionaryRef interface_entity,
-                                            SCPreferencesRef prefs)
+__SCNetworkInterfaceCreateWithStorageEntity(CFAllocatorRef     allocator,
+                                           CFDictionaryRef     interface_entity)
 {
+#pragma unused(allocator)
        SCNetworkInterfacePrivateRef interfacePrivate = NULL;
        CFBooleanRef    active = NULL;
        CFStringRef     bsdName = NULL;
@@ -3864,7 +3848,7 @@ __SCNetworkInterfaceCreateWithStorageEntity (CFAllocatorRef allocator,
                SC_log(LOG_INFO, "No IOInterfaceType");
                goto done;
        }
-       if (CFNumberGetValue(ioInterfaceType, kCFNumberIntType, &ioInterfaceTypeNum) == FALSE) {
+       if (!CFNumberGetValue(ioInterfaceType, kCFNumberIntType, &ioInterfaceTypeNum)) {
                SC_log(LOG_NOTICE, "Count not extract value from ioInterfaceType");
        }
        ioInterfaceUnit = CFDictionaryGetValue(interface_entity, CFSTR(kSCNetworkInterfaceIOInterfaceUnit));
@@ -3891,11 +3875,11 @@ __SCNetworkInterfaceCreateWithStorageEntity (CFAllocatorRef allocator,
                goto done;
        }
        userDefinedName = CFDictionaryGetValue(SCNetworkInterfaceInfo, kSCPropUserDefinedName);
-#if    !TARGET_IPHONE_SIMULATOR
+#if    !TARGET_OS_SIMULATOR
        usbProductName = CFDictionaryGetValue(SCNetworkInterfaceInfo, CFSTR(kUSBProductString));
        idProduct = CFDictionaryGetValue(SCNetworkInterfaceInfo, CFSTR(kUSBProductID));
        idVendor = CFDictionaryGetValue(SCNetworkInterfaceInfo, CFSTR(kUSBVendorID));
-#endif // !TARGET_IPHONE_SIMULATOR
+#endif // !TARGET_OS_SIMULATOR
 
        type = CFDictionaryGetValue(interface_entity, CFSTR(kSCNetworkInterfaceType));
        if (isA_CFString(type) == NULL) {
@@ -3943,11 +3927,77 @@ done:
 }
 
 
+__private_extern__
+void
+_SCNetworkInterfaceCacheOpen(void)
+{
+       if (!__SCNetworkInterfaceCacheIsOpen()) {
+               S_interface_cache = CFDictionaryCreateMutable(NULL,
+                                                             0,
+                                                             &kCFTypeDictionaryKeyCallBacks,
+                                                             &kCFTypeDictionaryValueCallBacks);
+               SC_log(LOG_DEBUG, "SCNetworkInterface cache (%p): open", S_interface_cache);
+       }
+}
+
+
+__private_extern__
+void
+_SCNetworkInterfaceCacheClose(void)
+{
+       if (__SCNetworkInterfaceCacheIsOpen()) {
+               SC_log(LOG_DEBUG, "SCNetworkInterface cache (%p): close", S_interface_cache);
+               CFRelease(S_interface_cache);
+               S_interface_cache = NULL;
+       }
+}
+
+
+static void
+__SCNetworkInterfaceCacheAdd(CFStringRef bsdName, CFArrayRef matchingInterfaces)
+{
+       if (__SCNetworkInterfaceCacheIsOpen() &&
+           bsdName != NULL &&
+           matchingInterfaces != NULL) {
+               SC_log(LOG_DEBUG, "SCNetworkInterface cache (%p): add %@", S_interface_cache, bsdName);
+               CFDictionaryAddValue(S_interface_cache, bsdName, matchingInterfaces);
+       }
+}
+
+
+static inline Boolean
+__SCNetworkInterfaceCacheIsOpen(void)
+{
+       return (S_interface_cache != NULL);
+}
+
+
+static CFArrayRef
+__SCNetworkInterfaceCacheCopy(CFStringRef bsdName)
+{
+       if (__SCNetworkInterfaceCacheIsOpen() &&
+           bsdName != NULL) {
+               CFArrayRef matchingInterfaces = CFDictionaryGetValue(S_interface_cache, bsdName);
+               if (matchingInterfaces) {
+                       CFRetain(matchingInterfaces);
+                       SC_log(LOG_DEBUG, "SCNetworkInterface cache (%p): copy w/ match for %@", S_interface_cache, bsdName);
+               } else {
+                       SC_log(LOG_DEBUG, "SCNetworkInterface cache (%p): copy w/ no match for %@", S_interface_cache, bsdName);
+               }
+
+               return matchingInterfaces;
+       }
+
+       return NULL;
+}
+
+
 SCNetworkInterfaceRef
-_SCNetworkInterfaceCreateWithEntity(CFAllocatorRef             allocator,
-                                   CFDictionaryRef             interface_entity,
-                                   SCNetworkServiceRef         service)
+_SCNetworkInterfaceCreateWithEntity(CFAllocatorRef     allocator,
+                                   CFDictionaryRef     interface_entity,
+                                   SCNetworkServiceRef service)
 {
+#pragma unused(allocator)
        SCNetworkInterfacePrivateRef    interfacePrivate        = NULL;
        CFStringRef                     ifDevice;
        CFStringRef                     ifName                  = NULL;
@@ -3964,7 +4014,7 @@ _SCNetworkInterfaceCreateWithEntity(CFAllocatorRef                allocator,
        if (service != NULL) {
                servicePref = ((SCNetworkServicePrivateRef)service)->prefs;
                useSystemInterfaces = ((__SCPreferencesUsingDefaultPrefs(servicePref)) &&
-                                      (__SCPreferencesGetLimitSCNetworkConfiguration(servicePref) == FALSE));
+                                      (!__SCPreferencesGetLimitSCNetworkConfiguration(servicePref)));
        }
 
        ifType = CFDictionaryGetValue(interface_entity, kSCPropNetInterfaceType);
@@ -4010,16 +4060,25 @@ _SCNetworkInterfaceCreateWithEntity(CFAllocatorRef              allocator,
                        goto done;
                }
                if (useSystemInterfaces) {
-                       if (_SC_cfstring_to_cstring(ifDevice, bsdName, sizeof(bsdName), kCFStringEncodingASCII) == NULL) {
-                               goto done;
-                       }
+                       // Check to see if we already have the info in the cache
+                       matching_interfaces = __SCNetworkInterfaceCacheCopy(ifDevice);
+                       if (matching_interfaces == NULL) {
+                               if (_SC_cfstring_to_cstring(ifDevice, bsdName, sizeof(bsdName), kCFStringEncodingASCII) == NULL) {
+                                       goto done;
+                               }
 
-                       matching = IOBSDNameMatching(masterPort, 0, bsdName);
-                       if (matching == NULL) {
-                               goto done;
+                               matching = IOBSDNameMatching(masterPort, 0, bsdName);
+                               if (matching == NULL) {
+                                       goto done;
+                               }
+                               matching_interfaces = findMatchingInterfaces(matching,
+                                                                            processNetworkInterface,
+                                                                            kSCNetworkInterfaceHiddenInterfaceKey,
+                                                                            TRUE);
+
+                               __SCNetworkInterfaceCacheAdd(ifDevice, matching_interfaces);
+                               CFRelease(matching);
                        }
-                       matching_interfaces = findMatchingInterfaces(matching, processNetworkInterface, kSCNetworkInterfaceHiddenInterfaceKey);
-                       CFRelease(matching);
                }
        } else if (CFEqual(ifType, kSCValNetInterfaceTypePPP)) {
                if (CFEqual(ifSubType, kSCValNetInterfaceSubTypePPPSerial)) {
@@ -4044,7 +4103,10 @@ _SCNetworkInterfaceCreateWithEntity(CFAllocatorRef               allocator,
                                                              sizeof(match_keys)/sizeof(match_keys[0]),
                                                              &kCFTypeDictionaryKeyCallBacks,
                                                              &kCFTypeDictionaryValueCallBacks);
-                               matching_interfaces = findMatchingInterfaces(matching, processSerialInterface, kSCNetworkInterfaceHiddenPortKey);
+                               matching_interfaces = findMatchingInterfaces(matching,
+                                                                            processSerialInterface,
+                                                                            kSCNetworkInterfaceHiddenPortKey,
+                                                                            TRUE);
                                CFRelease(matching);
                        }
                        if (ifUnique == NULL) {
@@ -4078,16 +4140,22 @@ _SCNetworkInterfaceCreateWithEntity(CFAllocatorRef              allocator,
                                                                      sizeof(match_keys)/sizeof(match_keys[0]),
                                                                      &kCFTypeDictionaryKeyCallBacks,
                                                                      &kCFTypeDictionaryValueCallBacks);
-                                       matching_interfaces = findMatchingInterfaces(matching, processSerialInterface, kSCNetworkInterfaceHiddenPortKey);
+                                       matching_interfaces = findMatchingInterfaces(matching,
+                                                                                    processSerialInterface,
+                                                                                    kSCNetworkInterfaceHiddenPortKey,
+                                                                                    TRUE);
                                        CFRelease(matching);
                                }
                        }
                } else if (CFEqual(ifSubType, kSCValNetInterfaceSubTypeL2TP)) {
                        interfacePrivate = (SCNetworkInterfacePrivateRef)SCNetworkInterfaceCreateWithInterface(kSCNetworkInterfaceIPv4,
                                                                                                               kSCNetworkInterfaceTypeL2TP);
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated"
                } else if (CFEqual(ifSubType, kSCValNetInterfaceSubTypePPTP)) {
                        interfacePrivate = (SCNetworkInterfacePrivateRef)SCNetworkInterfaceCreateWithInterface(kSCNetworkInterfaceIPv4,
                                                                                                               kSCNetworkInterfaceTypePPTP);
+#pragma GCC diagnostic pop
                } else {
                        // XXX do we allow non-Apple variants of PPP??? XXX
                        interfacePrivate = (SCNetworkInterfacePrivateRef)SCNetworkInterfaceCreateWithInterface(kSCNetworkInterfaceIPv4,
@@ -4231,11 +4299,11 @@ _SCNetworkInterfaceCreateWithEntity(CFAllocatorRef              allocator,
 
     done :
 
-       if ((interfacePrivate == NULL) || (useSystemInterfaces == FALSE))  {
+       if ((interfacePrivate == NULL) || !useSystemInterfaces)  {
                /*
                 * if device not present on this system
                 */
-               if (useSystemInterfaces == FALSE) {
+               if (!useSystemInterfaces) {
                        if (interfacePrivate != NULL) {
                                CFRelease(interfacePrivate);
                        }
@@ -4249,7 +4317,7 @@ _SCNetworkInterfaceCreateWithEntity(CFAllocatorRef                allocator,
 
                // Using UserDefinedName to check the validity of preferences file
                // when useSystemInterfaces is FALSE
-               if (useSystemInterfaces == FALSE) {
+               if (!useSystemInterfaces) {
                        CFStringRef userDefinedName = CFDictionaryGetValue(interface_entity, kSCPropUserDefinedName);
                        if (isA_CFString(userDefinedName) != NULL) {
                                CFRetain(userDefinedName);
@@ -4270,11 +4338,11 @@ _SCNetworkInterfaceCreateWithEntity(CFAllocatorRef              allocator,
                        CFStringRef     entity_hardware;
                        SCNetworkInterfaceRef virtualInterface;
 
-                       if ((useSystemInterfaces == FALSE) &&
+                       if (!useSystemInterfaces &&
                            (((virtualInterface = findBridgeInterface(servicePref, ifDevice)) != NULL) ||
 #if    !TARGET_OS_IPHONE
                            ((virtualInterface = findBondInterface(servicePref,  ifDevice)) != NULL) ||
-#endif
+#endif // !TARGET_OS_IPHONE
                            ((virtualInterface = findVLANInterface(servicePref, ifDevice)) != NULL))) {
                                CFRelease(interfacePrivate);
                                interfacePrivate = (SCNetworkInterfacePrivateRef)virtualInterface;
@@ -4317,7 +4385,7 @@ _SCNetworkInterfaceCreateWithEntity(CFAllocatorRef                allocator,
                } else if (CFEqual(ifType, kSCValNetInterfaceTypeFireWire)) {
                        interfacePrivate->interface_type = kSCNetworkInterfaceTypeFireWire;
                        interfacePrivate->sort_order     = kSortFireWire;
-               } else if (CFEqual(ifType, kSCValNetInterfaceTypePPP)) {
+               } else if (CFEqual(ifType, kSCValNetInterfaceTypePPP) && (ifSubType != NULL)) {
                        if (CFEqual(ifSubType, kSCValNetInterfaceSubTypePPPoE)) {
                                CFStringRef     entity_hardware;
 
@@ -4354,7 +4422,7 @@ _SCNetworkInterfaceCreateWithEntity(CFAllocatorRef                allocator,
                                        return NULL;
                                }
                        }
-               } else if (CFEqual(ifType, kSCValNetInterfaceTypeVPN)) {
+               } else if (CFEqual(ifType, kSCValNetInterfaceTypeVPN) && (ifSubType != NULL)) {
                        SCNetworkInterfaceRef   child;
                        CFRelease(interfacePrivate);
                        child = SCNetworkInterfaceCreateWithInterface(kSCNetworkInterfaceIPv4, ifSubType);
@@ -4378,12 +4446,13 @@ _SCNetworkInterfaceCreateWithEntity(CFAllocatorRef              allocator,
                        interfacePrivate = __SCNetworkInterfaceCreateCopy(NULL, kSCNetworkInterfaceLoopback, NULL, NULL);
                } else if (CFStringFind(ifType, CFSTR("."), 0).location != kCFNotFound) {
                        // if vendor interface
+                       pthread_mutex_lock(&lock);
                        if (vendor_interface_types == NULL) {
                                vendor_interface_types = CFSetCreateMutable(NULL, 0, &kCFTypeSetCallBacks);
                        }
                        CFSetAddValue(vendor_interface_types, ifType);
-
                        interfacePrivate->interface_type = CFSetGetValue(vendor_interface_types, ifType);
+                       pthread_mutex_unlock(&lock);
                } else {
                        // if unknown interface
                        CFRelease(interfacePrivate);
@@ -4394,6 +4463,11 @@ _SCNetworkInterfaceCreateWithEntity(CFAllocatorRef               allocator,
                if (CFDictionaryContainsKey(interface_entity, kSCNetworkInterfaceHiddenConfigurationKey)) {
                        interfacePrivate->hidden = TRUE;
                }
+#if    TARGET_OS_IPHONE
+               if (CFDictionaryContainsKey(interface_entity, kSCNetworkInterfaceTrustRequiredKey)) {
+                       interfacePrivate->trustRequired = TRUE;
+               }
+#endif // TARGET_OS_IPHONE
        }
 
        if (service != NULL) {
@@ -4472,7 +4546,7 @@ _SCNetworkInterfaceCreateWithEntity(CFAllocatorRef                allocator,
 
 __private_extern__
 CFArrayRef
-__SCNetworkInterfaceCopyAll_IONetworkInterface(void)
+__SCNetworkInterfaceCopyAll_IONetworkInterface(Boolean keep_pre_configured)
 {
        CFDictionaryRef         matching;
        CFArrayRef              new_interfaces;
@@ -4480,7 +4554,10 @@ __SCNetworkInterfaceCopyAll_IONetworkInterface(void)
        // get Ethernet, Firewire, Thunderbolt, and AirPort interfaces
 
        matching = IOServiceMatching(kIONetworkInterfaceClass);
-       new_interfaces = findMatchingInterfaces(matching, processNetworkInterface, kSCNetworkInterfaceHiddenInterfaceKey);
+       new_interfaces = findMatchingInterfaces(matching,
+                                               processNetworkInterface,
+                                               kSCNetworkInterfaceHiddenInterfaceKey,
+                                               keep_pre_configured);
        CFRelease(matching);
 
        return new_interfaces;
@@ -4508,7 +4585,10 @@ __SCNetworkInterfaceCopyAll_Modem()
                                      sizeof(match_keys)/sizeof(match_keys[0]),
                                      &kCFTypeDictionaryKeyCallBacks,
                                      &kCFTypeDictionaryValueCallBacks);
-       new_interfaces = findMatchingInterfaces(matching, processSerialInterface, kSCNetworkInterfaceHiddenPortKey);
+       new_interfaces = findMatchingInterfaces(matching,
+                                               processSerialInterface,
+                                               kSCNetworkInterfaceHiddenPortKey,
+                                               FALSE);
        CFRelease(matching);
 
        return new_interfaces;
@@ -4536,7 +4616,10 @@ __SCNetworkInterfaceCopyAll_RS232()
                                      sizeof(match_keys)/sizeof(match_keys[0]),
                                      &kCFTypeDictionaryKeyCallBacks,
                                      &kCFTypeDictionaryValueCallBacks);
-       new_interfaces = findMatchingInterfaces(matching, processSerialInterface, kSCNetworkInterfaceHiddenPortKey);
+       new_interfaces = findMatchingInterfaces(matching,
+                                               processSerialInterface,
+                                               kSCNetworkInterfaceHiddenPortKey,
+                                               FALSE);
        CFRelease(matching);
 
        return new_interfaces;
@@ -4545,7 +4628,7 @@ __SCNetworkInterfaceCopyAll_RS232()
 
 #if    !TARGET_OS_IPHONE
 static void
-addBTPANInterface(SCPreferencesRef prefs, CFMutableArrayRef all_interfaces)
+addBTPANInterface(CFMutableArrayRef all_interfaces)
 {
        CFIndex                 i;
        SCNetworkInterfaceRef   interface;
@@ -4599,14 +4682,16 @@ add_interfaces(CFMutableArrayRef all_interfaces, CFArrayRef new_interfaces)
 static void
 __waitForInterfaces()
 {
-       CFStringRef             key;
+       CFStringRef             key     = NULL;
        CFArrayRef              keys;
        Boolean                 ok;
-       SCDynamicStoreRef       store;
+       SCDynamicStoreRef       store   = NULL;
+
+       CRSetCrashLogMessage("Waiting for IOKit to quiesce (or timeout)");
 
        store = SCDynamicStoreCreate(NULL, CFSTR("SCNetworkInterfaceCopyAll"), NULL, NULL);
        if (store == NULL) {
-               return;
+               goto done;
        }
 
        key = SCDynamicStoreKeyCreate(NULL, CFSTR("%@" "InterfaceNamer"), kSCDynamicStoreDomainPlugin);
@@ -4627,8 +4712,8 @@ __waitForInterfaces()
                dict = SCDynamicStoreCopyValue(store, key);
                if (dict != NULL) {
                        if (isA_CFDictionary(dict) &&
-                           (CFDictionaryContainsKey(dict, CFSTR("*QUIET*")) ||
-                            CFDictionaryContainsKey(dict, CFSTR("*TIMEOUT*")))) {
+                           (CFDictionaryContainsKey(dict, kInterfaceNamerKey_Quiet) ||
+                            CFDictionaryContainsKey(dict, kInterfaceNamerKey_Timeout))) {
                                quiet = TRUE;
                        }
                        CFRelease(dict);
@@ -4651,8 +4736,10 @@ __waitForInterfaces()
 
     done :
 
-       CFRelease(key);
-       CFRelease(store);
+       CRSetCrashLogMessage(NULL);
+
+       if (key != NULL) CFRelease(key);
+       if (store != NULL) CFRelease(store);
        return;
 }
 
@@ -4673,7 +4760,7 @@ _SCNetworkInterfaceCopyAllWithPreferences(SCPreferencesRef prefs)
        all_interfaces = CFArrayCreateMutable(NULL, 0, &kCFTypeArrayCallBacks);
 
        // get Ethernet, Firewire, Thunderbolt, and AirPort interfaces
-       new_interfaces = __SCNetworkInterfaceCopyAll_IONetworkInterface();
+       new_interfaces = __SCNetworkInterfaceCopyAll_IONetworkInterface(FALSE);
        if (new_interfaces != NULL) {
                add_interfaces(all_interfaces, new_interfaces);
                CFRelease(new_interfaces);
@@ -4723,7 +4810,7 @@ _SCNetworkInterfaceCopyAllWithPreferences(SCPreferencesRef prefs)
 
 #if    !TARGET_OS_IPHONE
                // add BT-PAN interface
-               addBTPANInterface(prefs, all_interfaces);
+               addBTPANInterface(all_interfaces);
 #endif // !TARGET_OS_IPHONE
 
                if (temp_preferences) CFRelease(prefs);
@@ -4774,9 +4861,6 @@ SCNetworkInterfaceGetSupportedInterfaceTypes(SCNetworkInterfaceRef interface)
                        if (configurations[i].supported_interfaces & doPPP) {
                                CFArrayAppendValue(interfacePrivate->supported_interface_types, kSCNetworkInterfaceTypePPP);
                        }
-                       if (configurations[i].supported_interfaces & doPPTP) {
-                               CFArrayAppendValue(interfacePrivate->supported_interface_types, kSCNetworkInterfaceTypePPTP);
-                       }
                        if (configurations[i].supported_interfaces & doIPSec) {
                                CFArrayAppendValue(interfacePrivate->supported_interface_types, kSCNetworkInterfaceTypeIPSec);
                        }
@@ -4909,6 +4993,8 @@ SCNetworkInterfaceCreateWithInterface(SCNetworkInterfaceRef child, CFStringRef i
                parentPrivate->interface_type = kSCNetworkInterfaceTypeL2TP;
                parentPrivate->localized_key  = CFSTR("l2tp");
                parentPrivate->entity_type    = kSCEntNetL2TP;                  // interface config goes into "L2TP"
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated"
        } else if (CFEqual(interfaceType, kSCNetworkInterfaceTypePPTP)) {
                if ((childIndex == kCFNotFound) ||
                    ((configurations[childIndex].supported_interfaces & doPPTP) != doPPTP)) {
@@ -4918,6 +5004,7 @@ SCNetworkInterfaceCreateWithInterface(SCNetworkInterfaceRef child, CFStringRef i
                parentPrivate->interface_type = kSCNetworkInterfaceTypePPTP;
                parentPrivate->localized_key  = CFSTR("pptp");
                parentPrivate->entity_type    = kSCEntNetPPTP;                  // interface config goes into "PPTP"
+#pragma GCC diagnostic pop
        } else if (CFEqual(interfaceType, kSCNetworkInterfaceType6to4)) {
                if ((childIndex == kCFNotFound) ||
                    ((configurations[childIndex].supported_interfaces & do6to4) != do6to4)) {
@@ -4985,12 +5072,14 @@ SCNetworkInterfaceCreateWithInterface(SCNetworkInterfaceRef child, CFStringRef i
                }
        } else if (CFStringFind(interfaceType, CFSTR("."), 0).location != kCFNotFound) {
                // if custom interface type
+               pthread_mutex_lock(&lock);
                if (vendor_interface_types == NULL) {
                        vendor_interface_types = CFSetCreateMutable(NULL, 0, &kCFTypeSetCallBacks);
                }
                CFSetAddValue(vendor_interface_types, interfaceType);
-
                parentPrivate->interface_type = CFSetGetValue(vendor_interface_types, interfaceType);
+               pthread_mutex_unlock(&lock);
+
                parentPrivate->entity_type    = parentPrivate->interface_type;  // interface config goes into a
                                                                                // a dictionary with the same
                                                                                // name as the interfaceType
@@ -5001,6 +5090,10 @@ SCNetworkInterfaceCreateWithInterface(SCNetworkInterfaceRef child, CFStringRef i
 
        parentPrivate->hidden = childPrivate->hidden;
 
+#if    TARGET_OS_IPHONE
+       parentPrivate->trustRequired = childPrivate->trustRequired;
+#endif // TARGET_OS_IPHONE
+
        if (childPrivate->overrides != NULL) {
                parentPrivate->overrides = CFDictionaryCreateMutableCopy(NULL, 0, childPrivate->overrides);
        }
@@ -5230,7 +5323,7 @@ SCNetworkInterfaceGetHardwareAddressString(SCNetworkInterfaceRef interface)
            (interfacePrivate->addressString == NULL)) {
                uint8_t         *bp;
                char            *cp;
-               CFIndex         n;
+               size_t          n;
                char            mac[sizeof("xx:xx:xx:xx:xx:xx:xx:xx")];
                char            *mac_p  = mac;
 
@@ -5238,7 +5331,7 @@ SCNetworkInterfaceGetHardwareAddressString(SCNetworkInterfaceRef interface)
                n  = CFDataGetLength(interfacePrivate->address) * 3;
 
                if (n > sizeof(mac)) {
-                       mac_p = CFAllocatorAllocate(NULL, 0, n);
+                       mac_p = CFAllocatorAllocate(NULL, n, 0);
                }
 
                for (cp = mac_p; n > 0; n -= 3) {
@@ -5297,7 +5390,7 @@ copy_string_from_bundle(CFBundleRef bundle, CFStringRef key, Boolean localized)
                                                         key,
                                                         NETWORKINTERFACE_LOCALIZATIONS);
        }
-       
+
        return str;
 }
 
@@ -5309,18 +5402,18 @@ copy_interface_string(CFBundleRef bundle, CFStringRef key, Boolean localized)
        CFStringRef     str     = NULL;
 
        str = copy_string_from_bundle(bundle, key, localized);
-       
+
        if (str == NULL) {
                SC_log(LOG_ERR, "Received NULL string for the interface key: {Bundle: %@, key: %@, localized: %d}", bundle,
-                                                                                                                   key,
-                                                                                                                   localized);
+                                                                                                                   key,
+                                                                                                                   localized);
                goto done;
        }
-       
+
        if (CFEqual(str, key) && !reported) {
                const CFStringRef knownStrKey = CFSTR("airport");
                CFStringRef knownStrValue = NULL;
-               
+
                knownStrValue = copy_string_from_bundle(bundle, knownStrKey, localized);
                if (knownStrValue == NULL || CFEqual(knownStrValue, knownStrKey)) {
                        /* We are here because we requested for a localized/non-localized string
@@ -5331,13 +5424,13 @@ copy_interface_string(CFBundleRef bundle, CFStringRef key, Boolean localized)
                                                                                                                         knownStrKey,
                                                                                                                         localized);
 
-#if TARGET_OS_IPHONE
+#if    TARGET_OS_IPHONE
                        /* ...and we want to know about it! */
                        _SC_crash("Failed to retrieve interface string", NULL, NULL);
-#endif //TARGET_OS_IPHONE
+#endif //TARGET_OS_IPHONE
                        reported = TRUE;
                }
-               
+
                if (knownStrValue != NULL) {
                        CFRelease(knownStrValue);
                }
@@ -5551,11 +5644,11 @@ SCNetworkInterfaceGetLocalizedDisplayName(SCNetworkInterfaceRef interface)
 
 
 __private_extern__
-CFDictionaryRef
+CFPropertyListRef
 __SCNetworkInterfaceGetTemplateOverrides(SCNetworkInterfaceRef interface, CFStringRef overrideType)
 {
        SCNetworkInterfacePrivateRef    interfacePrivate        = (SCNetworkInterfacePrivateRef)interface;
-       CFDictionaryRef                 overrides               = NULL;
+       CFPropertyListRef               overrides               = NULL;
 
        if (interfacePrivate->overrides != NULL) {
                overrides = CFDictionaryGetValue(interfacePrivate->overrides, overrideType);
@@ -5724,6 +5817,7 @@ Boolean
 SCNetworkInterfaceSetConfiguration(SCNetworkInterfaceRef interface, CFDictionaryRef config)
 {
        CFStringRef     defaultType;
+       Boolean         ok;
 
        if (!isA_SCNetworkInterface(interface)) {
                _SCErrorSet(kSCStatusInvalidArgument);
@@ -5735,7 +5829,14 @@ SCNetworkInterfaceSetConfiguration(SCNetworkInterfaceRef interface, CFDictionary
                return FALSE;
        }
 
-       return __SCNetworkInterfaceSetConfiguration(interface, defaultType, config, FALSE);
+       ok = __SCNetworkInterfaceSetConfiguration(interface, defaultType, config, FALSE);
+       if (ok) {
+               SC_log(LOG_DEBUG, "SCNetworkInterfaceSetConfiguration(): %@ -> %@",
+                      interface,
+                      config != NULL ? config : (CFDictionaryRef)CFSTR("NULL"));
+       }
+
+       return ok;
 }
 
 
@@ -5744,6 +5845,8 @@ SCNetworkInterfaceSetExtendedConfiguration(SCNetworkInterfaceRef  interface,
                                           CFStringRef                  extendedType,
                                           CFDictionaryRef              config)
 {
+       Boolean         ok;
+
        if (!isA_SCNetworkInterface(interface)) {
                _SCErrorSet(kSCStatusInvalidArgument);
                return FALSE;
@@ -5753,7 +5856,14 @@ SCNetworkInterfaceSetExtendedConfiguration(SCNetworkInterfaceRef interface,
                return FALSE;
        }
 
-       return __SCNetworkInterfaceSetConfiguration(interface, extendedType, config, FALSE);
+       ok = __SCNetworkInterfaceSetConfiguration(interface, extendedType, config, FALSE);
+       if (ok) {
+               SC_log(LOG_DEBUG, "SCNetworkInterfaceSetExtendedConfiguration(): %@ -> %@",
+                      interface,
+                      config != NULL ? config : (CFDictionaryRef)CFSTR("NULL"));
+       }
+
+       return ok;
 }
 
 
@@ -5761,10 +5871,6 @@ SCNetworkInterfaceSetExtendedConfiguration(SCNetworkInterfaceRef interface,
 #pragma mark SCNetworkInterface [Refresh Configuration] API
 
 
-#ifndef kSCEntNetRefreshConfiguration
-#define kSCEntNetRefreshConfiguration  CFSTR("RefreshConfiguration")
-#endif // kSCEntNetRefreshConfiguration
-
 Boolean
 _SCNetworkInterfaceForceConfigurationRefresh(CFStringRef ifName)
 {
@@ -5874,11 +5980,13 @@ SCNetworkInterfaceForceConfigurationRefresh(SCNetworkInterfaceRef interface)
 }
 
 
+#if    !TARGET_OS_IPHONE
 Boolean
 SCNetworkInterfaceRefreshConfiguration(CFStringRef ifName)
 {
        return _SCNetworkInterfaceForceConfigurationRefresh(ifName);
 }
+#endif // !TARGET_OS_IPHONE
 
 
 #pragma mark -
@@ -6949,6 +7057,103 @@ SCNetworkInterfaceSetPassword(SCNetworkInterfaceRef             interface,
        return ok;
 }
 
+#pragma mark -
+#pragma mark SCNetworkInterface [Advisory] SPIs
+#if    TARGET_OS_SIMULATOR
+Boolean
+SCNetworkInterfaceSetAdvisory(SCNetworkInterfaceRef interface,
+                             SCNetworkInterfaceAdvisory advisory,
+                             CFStringRef reason)
+{
+#pragma unused(interface)
+#pragma unused(advisory)
+#pragma unused(reason)
+       return (FALSE);
+}
+
+Boolean
+SCNetworkInterfaceAdvisoryIsSet(SCNetworkInterfaceRef interface)
+{
+#pragma unused(interface)
+       return (FALSE);
+}
+
+CFStringRef
+SCNetworkInterfaceCopyAdvisoryNotificationKey(SCNetworkInterfaceRef interface)
+{
+#pragma unused(interface)
+       return (NULL);
+}
+
+#else /* TARGET_OS_SIMULATOR */
+Boolean
+SCNetworkInterfaceSetAdvisory(SCNetworkInterfaceRef interface,
+                             SCNetworkInterfaceAdvisory advisory,
+                             CFStringRef reason)
+{
+       IPMonitorControlRef             control;
+       SCNetworkInterfacePrivateRef    interfacePrivate =
+                                       (SCNetworkInterfacePrivateRef)interface;
+       CFStringRef                     ifName;
+
+       ifName = SCNetworkInterfaceGetBSDName(interface);
+       if (ifName == NULL) {
+               _SCErrorSet(kSCStatusInvalidArgument);
+               return (FALSE);
+       }
+       control = interfacePrivate->IPMonitorControl;
+       if (control == NULL) {
+               control = IPMonitorControlCreate();
+               if (control == NULL) {
+                       _SCErrorSet(kSCStatusFailed);
+                       return (FALSE);
+               }
+               interfacePrivate->IPMonitorControl = control;
+       }
+       return IPMonitorControlSetInterfaceAdvisory(control,
+                                                   ifName,
+                                                   advisory,
+                                                   reason);
+}
+
+Boolean
+SCNetworkInterfaceAdvisoryIsSet(SCNetworkInterfaceRef interface)
+{
+       IPMonitorControlRef             control;
+       SCNetworkInterfacePrivateRef    interfacePrivate =
+                                       (SCNetworkInterfacePrivateRef)interface;
+       CFStringRef                     ifName;
+
+       ifName = SCNetworkInterfaceGetBSDName(interface);
+       if (ifName == NULL) {
+               _SCErrorSet(kSCStatusInvalidArgument);
+               return (FALSE);
+       }
+       control = interfacePrivate->IPMonitorControl;
+       if (control == NULL) {
+               control = IPMonitorControlCreate();
+               if (control == NULL) {
+                       _SCErrorSet(kSCStatusFailed);
+                       return (FALSE);
+               }
+               interfacePrivate->IPMonitorControl = control;
+       }
+       return IPMonitorControlInterfaceAdvisoryIsSet(control, ifName);
+}
+
+CFStringRef
+SCNetworkInterfaceCopyAdvisoryNotificationKey(SCNetworkInterfaceRef interface)
+{
+       CFStringRef                     ifName;
+
+       ifName = SCNetworkInterfaceGetBSDName(interface);
+       if (ifName == NULL) {
+               _SCErrorSet(kSCStatusInvalidArgument);
+               return (NULL);
+       }
+       return IPMonitorControlCopyInterfaceAdvisoryNotificationKey(ifName);
+}
+#endif /* TARGET_OS_SIMULATOR */
 
 #pragma mark -
 #pragma mark SCNetworkInterface [InterfaceNamer] SPIs
@@ -6978,7 +7183,7 @@ _SCNetworkInterfaceCopyInterfaceInfo(SCNetworkInterfaceRef interface)
 
        // add USB info
        if ((interfacePrivate->usb.vid != NULL) || (interfacePrivate->usb.pid != NULL)) {
-#if    !TARGET_IPHONE_SIMULATOR
+#if    !TARGET_OS_SIMULATOR
                if (interfacePrivate->usb.name != NULL) {
                        CFDictionaryAddValue(info, CFSTR(kUSBProductString), interfacePrivate->usb.name);
                }
@@ -6988,7 +7193,7 @@ _SCNetworkInterfaceCopyInterfaceInfo(SCNetworkInterfaceRef interface)
                if (interfacePrivate->usb.pid != NULL) {
                        CFDictionaryAddValue(info, CFSTR(kUSBProductID), interfacePrivate->usb.pid);
                }
-#endif // !TARGET_IPHONE_SIMULATOR
+#endif // !TARGET_OS_SIMULATOR
        }
 
        if (CFDictionaryGetCount(info) == 0) {
@@ -7064,6 +7269,72 @@ _SCNetworkInterfaceGetIOInterfaceUnit(SCNetworkInterfaceRef interface)
 }
 
 
+static void
+update_ift_family(SCNetworkInterfaceRef interface)
+{
+       SCNetworkInterfacePrivateRef    interfacePrivate        = (SCNetworkInterfacePrivateRef)interface;
+
+       // note: family/subfamily are not in IORegistry, fetch with ioctl()
+
+       if ((interfacePrivate->family == NULL) && (interfacePrivate->subfamily == NULL)) {
+               CFStringRef     bsdName = SCNetworkInterfaceGetBSDName(interface);
+               struct ifreq    ifr;
+
+               memset(&ifr, 0, sizeof(ifr));
+               if ((bsdName != NULL) &&
+                   _SC_cfstring_to_cstring(bsdName, ifr.ifr_name, sizeof(ifr.ifr_name), kCFStringEncodingASCII) != NULL) {
+                       int     s;
+
+                       s = socket(AF_INET, SOCK_DGRAM, 0);
+                       if (s != -1) {
+                               if (ioctl(s, SIOCGIFTYPE, (caddr_t)&ifr) == -1) {
+                                       ifr.ifr_type.ift_family = 0;
+                                       ifr.ifr_type.ift_subfamily = 0;
+                               }
+                               close(s);
+                       }
+               }
+
+               interfacePrivate->family = CFNumberCreate(NULL,
+                                                         kCFNumberSInt32Type,
+                                                         &ifr.ifr_type.ift_family);
+               interfacePrivate->subfamily = CFNumberCreate(NULL,
+                                                            kCFNumberSInt32Type,
+                                                            &ifr.ifr_type.ift_subfamily);
+       }
+}
+
+
+CFNumberRef
+_SCNetworkInterfaceGetFamilyType(SCNetworkInterfaceRef interface)
+{
+       SCNetworkInterfacePrivateRef    interfacePrivate        = (SCNetworkInterfacePrivateRef)interface;
+
+       // note: family not in IORegistry, fetch with ioctl()
+
+       if (interfacePrivate->family == NULL) {
+               update_ift_family(interface);
+       }
+
+       return interfacePrivate->family;
+}
+
+
+CFNumberRef
+_SCNetworkInterfaceGetFamilySubType(SCNetworkInterfaceRef interface)
+{
+       SCNetworkInterfacePrivateRef    interfacePrivate        = (SCNetworkInterfacePrivateRef)interface;
+
+       // note: subfamily not in IORegistry, fetch with ioctl()
+
+       if (interfacePrivate->subfamily == NULL) {
+               update_ift_family(interface);
+       }
+
+       return interfacePrivate->subfamily;
+}
+
+
 CFStringRef
 _SCNetworkInterfaceGetIOPath(SCNetworkInterfaceRef interface)
 {
@@ -7101,11 +7372,20 @@ _SCNetworkInterfaceIsBuiltin(SCNetworkInterfaceRef interface)
 }
 
 
+Boolean
+_SCNetworkInterfaceIsTrustRequired(SCNetworkInterfaceRef interface)
+{
+       SCNetworkInterfacePrivateRef    interfacePrivate        = (SCNetworkInterfacePrivateRef)interface;
+
+       return interfacePrivate->trustRequired;
+}
+
+
 #pragma mark -
 #pragma mark SCNetworkInterface SPIs
 
 
-#if    !TARGET_OS_EMBEDDED
+#if    TARGET_OS_OSX
 
 SCNetworkInterfaceRef
 _SCNetworkInterfaceCopyBTPANInterface(void)
@@ -7124,7 +7404,7 @@ _SCNetworkInterfaceCopyBTPANInterface(void)
 
                if (isA_CFDictionary(dict) &&
                    CFDictionaryGetValueIfPresent(dict,
-                                                 CFSTR("_" BT_PAN_NAME "_"),
+                                                 kInterfaceNamerKey_BT_PAN_Name,
                                                  (const void **)&if_name) &&
                    isA_CFString(if_name)) {
                        CFMutableDictionaryRef  entity;
@@ -7151,7 +7431,7 @@ _SCNetworkInterfaceCopyBTPANInterface(void)
                if ((interfacePrivate != NULL) &&
                    (interfacePrivate->address == NULL) &&
                    CFDictionaryGetValueIfPresent(dict,
-                                                 CFSTR("_" BT_PAN_MAC "_"),
+                                                 kInterfaceNamerKey_BT_PAN_Mac,
                                                  (const void **)&addr) &&
                    isA_CFData(addr)) {
                        interfacePrivate->address = CFRetain(addr);
@@ -7162,7 +7442,7 @@ _SCNetworkInterfaceCopyBTPANInterface(void)
 
        return interface;
 }
-#endif // !TARGET_OS_EMBEDDED
+#endif // TARGET_OS_OSX
 
 
 CFStringRef
@@ -7275,6 +7555,54 @@ _SCNetworkInterfaceCopySlashDevPath(SCNetworkInterfaceRef interface)
 }
 
 
+#pragma mark -
+
+
+Boolean
+_SCNetworkInterfaceIsApplePreconfigured(SCNetworkInterfaceRef interface)
+{
+#if    TARGET_OS_SIMULATOR
+#pragma unused(interface)
+#else  // TARGET_OS_SIMULATOR
+       SCNetworkInterfacePrivateRef    interfacePrivate        = (SCNetworkInterfacePrivateRef)interface;
+
+       if (!_SCNetworkInterfaceIsHiddenConfiguration(interface)) {
+               // if not HiddenConfiguration
+               return FALSE;
+       }
+
+       if ((interfacePrivate->overrides == NULL) ||
+           (!CFDictionaryContainsKey(interfacePrivate->overrides, kSCNetworkProtocolTypeIPv4) &&
+            !CFDictionaryContainsKey(interfacePrivate->overrides, kSCNetworkProtocolTypeIPv6))) {
+               // if no [IPv4/IPv6] configuration overrides
+               return FALSE;
+       }
+
+       if (_SCNetworkInterfaceIsBuiltin(interface)) {
+               // if built-in (and overrides are present)
+               return TRUE;
+       }
+
+       if (_SCNetworkInterfaceIsCarPlay(interface)) {
+               // if CarPlay (and overrides are present)
+               return TRUE;
+       }
+
+       if (isA_CFNumber(interfacePrivate->usb.vid)) {
+               int             vid;
+
+               if (CFNumberGetValue(interfacePrivate->usb.vid, kCFNumberIntType, &vid) &&
+                   (vid == kIOUSBVendorIDAppleComputer)) {
+                       // if Apple interface (and overrides are present)
+                       return TRUE;
+               }
+       }
+#endif // TARGET_OS_SIMULATOR
+
+       return FALSE;
+}
+
+
 Boolean
 _SCNetworkInterfaceIsBluetoothPAN(SCNetworkInterfaceRef interface)
 {
@@ -7303,20 +7631,20 @@ _SCNetworkInterfaceIsBluetoothP2P(SCNetworkInterfaceRef interface)
 
 
 Boolean
-_SCNetworkInterfaceIsHiddenConfiguration(SCNetworkInterfaceRef interface)
+_SCNetworkInterfaceIsCarPlay(SCNetworkInterfaceRef interface)
 {
        SCNetworkInterfacePrivateRef    interfacePrivate        = (SCNetworkInterfacePrivateRef)interface;
 
-       return interfacePrivate->hidden;
+       return (interfacePrivate->sort_order == kSortCarPlay);
 }
 
 
 Boolean
-_SCNetworkInterfaceIsModemV92(SCNetworkInterfaceRef interface)
+_SCNetworkInterfaceIsHiddenConfiguration(SCNetworkInterfaceRef interface)
 {
        SCNetworkInterfacePrivateRef    interfacePrivate        = (SCNetworkInterfacePrivateRef)interface;
 
-       return interfacePrivate->modemIsV92;
+       return interfacePrivate->hidden;
 }
 
 
@@ -7371,6 +7699,48 @@ _SCNetworkInterfaceIsThunderbolt(SCNetworkInterfaceRef interface)
 }
 
 
+#pragma mark -
+
+
+CFDictionaryRef
+SCNetworkInterfaceGetQoSMarkingPolicy(SCNetworkInterfaceRef interface)
+{
+       CFDictionaryRef policy;
+
+       if (!isA_SCNetworkInterface(interface)) {
+               _SCErrorSet(kSCStatusInvalidArgument);
+               return NULL;
+       }
+
+       policy = __SCNetworkInterfaceGetConfiguration(interface, kSCEntNetQoSMarkingPolicy);
+       if (policy == NULL) {
+               _SCErrorSet(kSCStatusOK);
+       }
+
+       return policy;
+}
+
+Boolean
+SCNetworkInterfaceSetQoSMarkingPolicy(SCNetworkInterfaceRef interface, CFDictionaryRef policy)
+{
+       Boolean         ok;
+
+       if (!isA_SCNetworkInterface(interface)) {
+               _SCErrorSet(kSCStatusInvalidArgument);
+               return FALSE;
+       }
+
+       ok = __SCNetworkInterfaceSetConfiguration(interface, kSCEntNetQoSMarkingPolicy, policy, FALSE);
+       if (ok) {
+               SC_log(LOG_DEBUG, "SCNetworkInterfaceSetQoSMarkingPolicy(): %@ -> %@",
+                      interface,
+                      policy != NULL ? policy : (CFDictionaryRef)CFSTR("NULL"));
+       }
+
+       return ok;
+}
+
+
 #pragma mark -
 #pragma mark SCNetworkInterface [internal] SPIs
 
@@ -7382,6 +7752,7 @@ __SCNetworkInterfaceCreateCopy(CFAllocatorRef             allocator,
                               SCPreferencesRef         prefs,
                               CFStringRef              serviceID)
 {
+#pragma unused(allocator)
        SCNetworkInterfacePrivateRef            oldPrivate      = (SCNetworkInterfacePrivateRef)interface;
        SCNetworkInterfacePrivateRef            newPrivate;
 
@@ -7441,6 +7812,9 @@ __SCNetworkInterfaceCreateCopy(CFAllocatorRef             allocator,
                newPrivate->configurationAction = CFRetain(oldPrivate->configurationAction);
        }
        newPrivate->hidden                      = oldPrivate->hidden;
+#if    TARGET_OS_IPHONE
+       newPrivate->trustRequired               = oldPrivate->trustRequired;
+#endif // TARGET_OS_IPHONE
        if (oldPrivate->location != NULL) {
                newPrivate->location            = CFRetain(oldPrivate->location);
        }
@@ -7451,13 +7825,18 @@ __SCNetworkInterfaceCreateCopy(CFAllocatorRef           allocator,
        if (oldPrivate->overrides != NULL) {
                newPrivate->overrides           = CFDictionaryCreateMutableCopy(NULL, 0, oldPrivate->overrides);
        }
-       newPrivate->modemIsV92                  = oldPrivate->modemIsV92;
        if (oldPrivate->type != NULL) {
                newPrivate->type                = CFRetain(oldPrivate->type);
        }
        if (oldPrivate->unit != NULL) {
                newPrivate->unit                = CFRetain(oldPrivate->unit);
        }
+       if (oldPrivate->family != NULL) {
+               newPrivate->family              = CFRetain(oldPrivate->family);
+       }
+       if (oldPrivate->subfamily != NULL) {
+               newPrivate->subfamily           = CFRetain(oldPrivate->subfamily);
+       }
        if (oldPrivate->usb.name != NULL) {
                newPrivate->usb.name            = CFRetain(oldPrivate->usb.name);
        }
@@ -7622,6 +8001,7 @@ __SCNetworkInterfaceSetDeepConfiguration(SCNetworkSetRef set, SCNetworkInterface
        for (i = 0; interface != NULL; i++) {
                CFStringRef     defaultType;
                CFDictionaryRef interfaceConfiguration;
+               Boolean         ok;
 
                interfaceConfiguration = (configs != NULL) ? CFArrayGetValueAtIndex(configs, i) : NULL;
 
@@ -7637,18 +8017,20 @@ __SCNetworkInterfaceSetDeepConfiguration(SCNetworkSetRef set, SCNetworkInterface
                        }
                        if (set == NULL) {
                                // if service is not associated with the set
-                               if (!__SCNetworkInterfaceSetConfiguration(interface, defaultType, config, TRUE)) {
-                                       SC_log(LOG_INFO, "__SCNetworkInterfaceSetConfiguration() failed, interface=%@, type=%@",
-                                              interface,
-                                              defaultType);
-                               }
+                               ok = __SCNetworkInterfaceSetConfiguration(interface, defaultType, config, TRUE);
                        } else {
                                // apply default configuration to this set
-                               if (!__SCNetworkInterfaceSetDefaultConfiguration(set, interface, defaultType, config, TRUE)) {
-                                       SC_log(LOG_INFO, "__SCNetworkInterfaceSetDefaultConfiguration() failed, interface=%@, type=%@",
-                                              interface,
-                                              defaultType);
-                               }
+                               ok = __SCNetworkInterfaceSetDefaultConfiguration(set, interface, defaultType, config, TRUE);
+                       }
+                       if (ok) {
+                               SC_log(LOG_DEBUG, "__SCNetworkInterfaceSetDeepConfiguration(): %@, %@ -> %@",
+                                      interface,
+                                      defaultType,
+                                      config != NULL ? config : (CFDictionaryRef)CFSTR("NULL"));
+                       } else {
+                               SC_log(LOG_INFO, "__SCNetworkInterfaceSetDeepConfiguration() failed, interface=%@, type=%@",
+                                      interface,
+                                      defaultType);
                        }
 
                        extendedTypes = extendedConfigurationTypes(interface);
@@ -7662,14 +8044,20 @@ __SCNetworkInterfaceSetDeepConfiguration(SCNetworkSetRef set, SCNetworkInterface
 
                                        extendedType = CFArrayGetValueAtIndex(extendedTypes, j);
                                        config = (interfaceConfiguration != NULL) ? CFDictionaryGetValue(interfaceConfiguration, extendedType)
-                                       : NULL;
+                                                                                 : NULL;
                                        if (config == (CFDictionaryRef)kCFNull) {
                                                config = NULL;
                                        }
-                                       if (!__SCNetworkInterfaceSetConfiguration(interface, extendedType, config, TRUE)) {
-                                               SC_log(LOG_INFO, "__SCNetworkInterfaceSetConfiguration() failed, interface=%@, type=%@",
+                                       ok = __SCNetworkInterfaceSetConfiguration(interface, extendedType, config, TRUE);
+                                       if (ok) {
+                                               SC_log(LOG_DEBUG, "__SCNetworkInterfaceSetDeepConfiguration(): %@, %@ -> %@",
+                                                      interface,
+                                                      extendedType,
+                                                      config != NULL ? config : (CFDictionaryRef)CFSTR("NULL"));
+                                       } else {
+                                               SC_log(LOG_INFO, "__SCNetworkInterfaceSetDeepConfiguration() failed, interface=%@, type=%@",
                                                       interface,
-                                                      defaultType);
+                                                      extendedType);
                                        }
                                }
 
@@ -7706,7 +8094,7 @@ _SCNetworkInterfaceCopyActive(SCDynamicStoreRef store, CFStringRef bsdName)
 }
 
 
-#if    !TARGET_IPHONE_SIMULATOR
+#if    !TARGET_OS_SIMULATOR
 SCNetworkServicePrimaryRank
 SCNetworkInterfaceGetPrimaryRank(SCNetworkInterfaceRef interface)
 {
@@ -7759,21 +8147,6 @@ SCNetworkInterfaceSetPrimaryRank(SCNetworkInterfaceRef interface,
                                                       newRank);
 }
 
-static CFIndex
-findPerInterfaceConfig(SCNetworkInterfaceRef interface)
-{
-       CFIndex                         interfaceIndex;
-       SCNetworkInterfacePrivateRef    interfacePrivate
-               = (SCNetworkInterfacePrivateRef)interface;
-
-       interfaceIndex = findConfiguration(interfacePrivate->interface_type);
-       if (interfaceIndex == kCFNotFound
-           || !configurations[interfaceIndex].per_interface_config) {
-               return (kCFNotFound);
-       }
-       return (interfaceIndex);
-}
-
 Boolean
 SCNetworkInterfaceGetDisableUntilNeeded(SCNetworkInterfaceRef interface)
 {
@@ -7788,7 +8161,7 @@ SCNetworkInterfaceGetDisableUntilNeeded(SCNetworkInterfaceRef interface)
                _SCErrorSet(kSCStatusInvalidArgument);
                return (FALSE);
        }
-       interfaceIndex = findPerInterfaceConfig(interface);
+       interfaceIndex = findPerInterfaceConfiguration(interface);
        if (interfaceIndex == kCFNotFound) {
                _SCErrorSet(kSCStatusInvalidArgument);
                return (FALSE);
@@ -7825,7 +8198,7 @@ SCNetworkInterfaceGetDisableUntilNeeded(SCNetworkInterfaceRef interface)
 }
 
 Boolean
-SCNetworkInterfaceSetDisableUntilNeeded(SCNetworkInterfaceRef interface, Boolean disable)
+__SCNetworkInterfaceSetDisableUntilNeededValue(SCNetworkInterfaceRef interface, CFTypeRef disable)
 {
        CFIndex                         count;
        CFIndex                         i;
@@ -7839,7 +8212,11 @@ SCNetworkInterfaceSetDisableUntilNeeded(SCNetworkInterfaceRef interface, Boolean
                _SCErrorSet(kSCStatusInvalidArgument);
                return (FALSE);
        }
-       interfaceIndex = findPerInterfaceConfig(interface);
+       if ((disable != NULL) && !isA_CFNumber(disable)) {
+               _SCErrorSet(kSCStatusInvalidArgument);
+               return (FALSE);
+       }
+       interfaceIndex = findPerInterfaceConfiguration(interface);
        if (interfaceIndex == kCFNotFound) {
                _SCErrorSet(kSCStatusInvalidArgument);
                return (FALSE);
@@ -7852,28 +8229,28 @@ SCNetworkInterfaceSetDisableUntilNeeded(SCNetworkInterfaceRef interface, Boolean
        count = CFArrayGetCount(path_list);
        for (i = 0; i < count; i++) {
                CFDictionaryRef         config;
-               CFNumberRef             disable_prop;
                CFMutableDictionaryRef  new_config;
                CFStringRef             path = CFArrayGetValueAtIndex(path_list, i);
-               int                     intval;
 
                config = __getPrefsConfiguration(interfacePrivate->prefs, path);
                if (config != NULL) {
                        new_config
                                = CFDictionaryCreateMutableCopy(NULL, 0, config);
-               }
-               else {
+               } else {
                        new_config
                                = CFDictionaryCreateMutable(NULL, 0,
                                                            &kCFTypeDictionaryKeyCallBacks,
                                                            &kCFTypeDictionaryValueCallBacks);
                }
-               intval = disable ? 1 : 0;
-               disable_prop = CFNumberCreate(NULL, kCFNumberIntType, &intval);
-               CFDictionarySetValue(new_config, kSCPropDisableUntilNeeded,
-                                    disable_prop);
-               CFRelease(disable_prop);
-               ok = __setPrefsConfiguration(interfacePrivate->prefs, path, new_config, FALSE);
+               if (disable != NULL) {
+                       CFDictionarySetValue(new_config, kSCPropDisableUntilNeeded, disable);
+               } else {
+                       CFDictionaryRemoveValue(new_config, kSCPropDisableUntilNeeded);
+               }
+               ok = __setPrefsConfiguration(interfacePrivate->prefs,
+                                            path,
+                                            (CFDictionaryGetCount(new_config) > 0) ? new_config : NULL,
+                                            FALSE);
                CFRelease(new_config);
                if (!ok) {
                        break;
@@ -7883,11 +8260,27 @@ SCNetworkInterfaceSetDisableUntilNeeded(SCNetworkInterfaceRef interface, Boolean
        return (ok);
 }
 
-#else  // !TARGET_IPHONE_SIMULATOR
+Boolean
+SCNetworkInterfaceSetDisableUntilNeeded(SCNetworkInterfaceRef interface, Boolean disable)
+{
+       Boolean         ok;
+       const int       one     = 1;
+       CFNumberRef     num;
+       const int       zero    = 0;
+
+       num = CFNumberCreate(NULL, kCFNumberIntType, disable ? &one : &zero);
+       ok = __SCNetworkInterfaceSetDisableUntilNeededValue(interface, num);
+       CFRelease(num);
+
+       return ok;
+}
+
+#else  // !TARGET_OS_SIMULATOR
 
 SCNetworkServicePrimaryRank
 SCNetworkInterfaceGetPrimaryRank(SCNetworkInterfaceRef interface)
 {
+#pragma unused(interface)
        return (kSCNetworkServicePrimaryRankDefault);
 }
 
@@ -7895,47 +8288,59 @@ Boolean
 SCNetworkInterfaceSetPrimaryRank(SCNetworkInterfaceRef interface,
                                 SCNetworkServicePrimaryRank newRank)
 {
+#pragma unused(interface)
+#pragma unused(newRank)
        _SCErrorSet(kSCStatusInvalidArgument);
        return (FALSE);
 }
 
-
 Boolean
 SCNetworkInterfaceGetDisableUntilNeeded(SCNetworkInterfaceRef interface)
 {
-    return (FALSE);
+#pragma unused(interface)
+       return (FALSE);
+}
+
+Boolean
+__SCNetworkInterfaceSetDisableUntilNeededValue(SCNetworkInterfaceRef interface, CFTypeRef disable)
+{
+#pragma unused(interface)
+#pragma unused(disable)
+       return (FALSE);
 }
 
 Boolean
 SCNetworkInterfaceSetDisableUntilNeeded(SCNetworkInterfaceRef interface, Boolean disable)
 {
-    _SCErrorSet(kSCStatusInvalidArgument);
-    return (FALSE);
+#pragma unused(interface)
+#pragma unused(disable)
+       _SCErrorSet(kSCStatusInvalidArgument);
+       return (FALSE);
 }
 
-#endif // !TARGET_IPHONE_SIMULATOR
+#endif // !TARGET_OS_SIMULATOR
 
 
 __private_extern__
 CFArrayRef  // SCNetworkInterfaceRef
-__SCNetworkInterfaceCopyStoredWithPreferences (SCPreferencesRef ni_prefs)
+__SCNetworkInterfaceCopyStoredWithPreferences(SCPreferencesRef ni_prefs)
 {
-       CFMutableArrayRef interfaceList = NULL;
+       CFStringRef             defaultNetworkInterfacePath     = NULL;
        CFArrayRef              if_list;
-       SCNetworkInterfaceRef interfaceNamer = NULL;
-       CFStringRef defaultNetworkInterfacePath = NULL;
+       CFMutableArrayRef       interfaceList                   = NULL;
+       SCNetworkInterfaceRef   interfaceNamer                  = NULL;
 
        /* initialize runtime */
        pthread_once(&initialized, __SCNetworkInterfaceInitialize);
 
        if (ni_prefs == NULL) {
                defaultNetworkInterfacePath = CFStringCreateWithFormat(NULL, NULL, CFSTR("%@/%@"), PREFS_DEFAULT_DIR, NETWORK_INTERFACES_PREFS);
+               assert(defaultNetworkInterfacePath != NULL);
                ni_prefs = SCPreferencesCreate(NULL, CFSTR("SCNetworkInterface"), defaultNetworkInterfacePath);
        }
 
        if_list = SCPreferencesGetValue(ni_prefs, INTERFACES);
-
-       if (isA_CFArray(if_list) != NULL) {
+       if (isA_CFArray(if_list)) {
                CFIndex i;
                CFIndex n       = CFArrayGetCount(if_list);
 
@@ -7945,7 +8350,7 @@ __SCNetworkInterfaceCopyStoredWithPreferences (SCPreferencesRef ni_prefs)
 
                        dict = CFArrayGetValueAtIndex(if_list, i);
                        if (isA_CFDictionary(dict) != NULL) {
-                               interfaceNamer = __SCNetworkInterfaceCreateWithStorageEntity(NULL, dict, ni_prefs);
+                               interfaceNamer = __SCNetworkInterfaceCreateWithStorageEntity(NULL, dict);
 
                                if (interfaceNamer != NULL) {
                                        CFArrayAppendValue(interfaceList, interfaceNamer);
@@ -7973,6 +8378,7 @@ __SCNetworkInterfaceSaveStoredWithPreferences(SCPreferencesRef prefs, CFArrayRef
 
        if (prefs == NULL) {    // TODO: Get the default preferences on the system
                defaultNetworkInterfacePath = CFStringCreateWithFormat(NULL, NULL, CFSTR("%@%@"), PREFS_DEFAULT_DIR, NETWORK_INTERFACES_PREFS);
+               assert(defaultNetworkInterfacePath != NULL);
                prefs = SCPreferencesCreate(NULL, CFSTR("SCNetworkInterface"), defaultNetworkInterfacePath);
        }
 
@@ -8031,8 +8437,8 @@ __SCNetworkInterfaceCreateWithNIPreferencesUsingBSDName(CFAllocatorRef allocator
                        if (tmp_bsdName == NULL) {
                                continue;
                        }
-                       if (CFEqual(bsdName, tmp_bsdName) == TRUE) {
-                               interface = __SCNetworkInterfaceCreateWithStorageEntity(allocator, dict, ni_prefs);
+                       if (CFEqual(bsdName, tmp_bsdName)) {
+                               interface = __SCNetworkInterfaceCreateWithStorageEntity(allocator, dict);
                                break;
                        }
                }
@@ -8076,3 +8482,23 @@ __SCNetworkInterfaceCreateMappingUsingBSDName(CFArrayRef interfaces)
 
        return mappingBSDToInterface;
 }
+
+__private_extern__ Boolean
+__SCNetworkInterfaceEntityIsPPTP(CFDictionaryRef entity)
+{
+       CFStringRef intfSubtype;
+
+       if (entity == NULL) {
+               return FALSE;
+       }
+
+       intfSubtype = CFDictionaryGetValue(entity, kSCPropNetInterfaceSubType);
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated"
+       if (intfSubtype != NULL && CFEqual(intfSubtype, kSCValNetInterfaceSubTypePPTP)) {
+               return TRUE;
+       }
+#pragma GCC diagnostic pop
+
+       return FALSE;
+}