From fe576f48fb48ec9d7612d811a7b7d64c41ccebbd Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sun, 1 May 2011 15:47:46 +0000 Subject: [PATCH] Verify the validity of the buffer size in wxBufferedDC. Passing invalid (e.g. negative) buffer size to wxBufferedDC resulted in many problems later on so refuse it immediately. Closes #13175. git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@67659 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/common/dcbufcmn.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/common/dcbufcmn.cpp b/src/common/dcbufcmn.cpp index 2e3d792400..2a8314d43e 100644 --- a/src/common/dcbufcmn.cpp +++ b/src/common/dcbufcmn.cpp @@ -105,6 +105,8 @@ IMPLEMENT_DYNAMIC_CLASS(wxSharedDCBufferManager, wxModule) void wxBufferedDC::UseBuffer(wxCoord w, wxCoord h) { + wxCHECK_RET( w >= -1 && h >= -1, "Invalid buffer size" ); + if ( !m_buffer || !m_buffer->IsOk() ) { if ( w == -1 || h == -1 ) -- 2.45.2