From fe1efe6ab784b0f364e7e949ac0afb4bbc3215d2 Mon Sep 17 00:00:00 2001
From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Sat, 20 Oct 2007 21:58:47 +0000
Subject: [PATCH] deprecate wxEffects

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@49276 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---
 include/wx/effects.h   | 32 ++++++++++++++++++++++++--------
 src/common/effects.cpp | 14 +++++++-------
 2 files changed, 31 insertions(+), 15 deletions(-)

diff --git a/include/wx/effects.h b/include/wx/effects.h
index eaf1f482ec..09080653d3 100644
--- a/include/wx/effects.h
+++ b/include/wx/effects.h
@@ -13,6 +13,12 @@
 #ifndef _WX_EFFECTS_H_
 #define _WX_EFFECTS_H_
 
+// this class is deprecated and will be removed in the next wx version
+//
+// please use wxRenderer::DrawBorder() instead of DrawSunkenEdge(); there is no
+// replacement for TileBitmap() but it doesn't seem to be very useful anyhow
+#ifdef WXWIN_COMPATIBILITY_2_8
+
 /*
  * wxEffects: various 3D effects
  */
@@ -22,17 +28,15 @@
 #include "wx/gdicmn.h"
 #include "wx/dc.h"
 
-class WXDLLEXPORT wxEffects: public wxObject
+class WXDLLEXPORT wxEffectsImpl: public wxObject
 {
-DECLARE_CLASS(wxEffects)
-
 public:
     // Assume system colours
-    wxEffects() ;
+    wxEffectsImpl() ;
     // Going from lightest to darkest
-    wxEffects(const wxColour& highlightColour, const wxColour& lightShadow,
-              const wxColour& faceColour, const wxColour& mediumShadow,
-              const wxColour& darkShadow) ;
+    wxEffectsImpl(const wxColour& highlightColour, const wxColour& lightShadow,
+                  const wxColour& faceColour, const wxColour& mediumShadow,
+                  const wxColour& darkShadow) ;
 
     // Accessors
     wxColour GetHighlightColour() const { return m_highlightColour; }
@@ -70,6 +74,18 @@ protected:
     wxColour    m_faceColour;       // Usually grey
     wxColour    m_mediumShadow;     // Usually dark grey
     wxColour    m_darkShadow;       // Usually black
+
+    DECLARE_CLASS(wxEffectsImpl)
 };
 
-#endif
+// current versions of g++ don't generate deprecation warnings for classes
+// declared deprecated, so define wxEffects as a typedef instead: this does
+// generate warnings with both g++ and VC (which also has no troubles with
+// directly deprecating the classes...)
+//
+// note that this g++ bug (16370) is supposed to be fixed in g++ 4.3.0
+typedef wxEffectsImpl wxDEPRECATED(wxEffects);
+
+#endif // WXWIN_COMPATIBILITY_2_8
+
+#endif // _WX_EFFECTS_H_
diff --git a/src/common/effects.cpp b/src/common/effects.cpp
index 4439ff42ba..8f34220fd6 100644
--- a/src/common/effects.cpp
+++ b/src/common/effects.cpp
@@ -1,6 +1,6 @@
 /////////////////////////////////////////////////////////////////////////////
 // Name:        src/common/effects.cpp
-// Purpose:     wxEffects implementation
+// Purpose:     wxEffectsImpl implementation
 // Author:      Julian Smart
 // Modified by:
 // Created:     25/4/2000
@@ -26,13 +26,13 @@
 #endif //WX_PRECOMP
 
 /*
- * wxEffects: various 3D effects
+ * wxEffectsImpl: various 3D effects
  */
 
-IMPLEMENT_CLASS(wxEffects, wxObject)
+IMPLEMENT_CLASS(wxEffectsImpl, wxObject)
 
 // Assume system colours
-wxEffects::wxEffects()
+wxEffectsImpl::wxEffectsImpl()
 {
     m_highlightColour = wxSystemSettings::GetColour(wxSYS_COLOUR_3DHILIGHT) ;
     m_lightShadow = wxSystemSettings::GetColour(wxSYS_COLOUR_3DLIGHT) ;
@@ -42,7 +42,7 @@ wxEffects::wxEffects()
 }
 
 // Going from lightest to darkest
-wxEffects::wxEffects(const wxColour& highlightColour, const wxColour& lightShadow,
+wxEffectsImpl::wxEffectsImpl(const wxColour& highlightColour, const wxColour& lightShadow,
                 const wxColour& faceColour, const wxColour& mediumShadow, const wxColour& darkShadow)
 {
     m_highlightColour = highlightColour;
@@ -53,7 +53,7 @@ wxEffects::wxEffects(const wxColour& highlightColour, const wxColour& lightShado
 }
 
 // Draw a sunken edge
-void wxEffects::DrawSunkenEdge(wxDC& dc, const wxRect& rect, int WXUNUSED(borderSize))
+void wxEffectsImpl::DrawSunkenEdge(wxDC& dc, const wxRect& rect, int WXUNUSED(borderSize))
 {
     wxPen highlightPen(m_highlightColour, 1, wxSOLID);
     wxPen lightShadowPen(m_lightShadow, 1, wxSOLID);
@@ -86,7 +86,7 @@ void wxEffects::DrawSunkenEdge(wxDC& dc, const wxRect& rect, int WXUNUSED(border
     dc.SetPen(wxNullPen);
 }
 
-bool wxEffects::TileBitmap(const wxRect& rect, wxDC& dc, const wxBitmap& bitmap)
+bool wxEffectsImpl::TileBitmap(const wxRect& rect, wxDC& dc, const wxBitmap& bitmap)
 {
     int w = bitmap.GetWidth();
     int h = bitmap.GetHeight();
-- 
2.45.2