From f7dd07f64d344e5b84c8dbe278ce4ad9da2a3c67 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Thu, 5 Apr 2012 13:55:51 +0000 Subject: [PATCH] No real changes, just use clearer names for wxMSW wxToolTip methods. Rename wxToolTip::DoAddOtherWindow() to DoAddHWND() as it should be used for adding any window associated with the tooltip, either the main or an auxiliary one. And rename wxToolTip::Add() to AddOtherWindow() because it shouldn't be used for the main window. See #14184. git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71096 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- include/wx/msw/tooltip.h | 4 ++-- src/msw/combobox.cpp | 2 +- src/msw/radiobox.cpp | 2 +- src/msw/spinctrl.cpp | 2 +- src/msw/tooltip.cpp | 10 +++++----- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/include/wx/msw/tooltip.h b/include/wx/msw/tooltip.h index a5184071af..ae512d928b 100644 --- a/include/wx/msw/tooltip.h +++ b/include/wx/msw/tooltip.h @@ -60,7 +60,7 @@ public: static void RelayEvent(WXMSG *msg); // add a window to the tooltip control - void Add(WXHWND hwnd); + void AddOtherWindow(WXHWND hwnd); // remove any tooltip from the window static void Remove(WXHWND hwnd, unsigned int id, const wxRect& rc); @@ -72,7 +72,7 @@ public: private: // Adds a window other than our main m_window to this tooltip. - void DoAddOtherWindow(WXHWND hWnd); + void DoAddHWND(WXHWND hWnd); // Perform the specified operation for the given window only. void DoSetTip(WXHWND hWnd); diff --git a/src/msw/combobox.cpp b/src/msw/combobox.cpp index c5a74dc211..1b99ac7f0f 100644 --- a/src/msw/combobox.cpp +++ b/src/msw/combobox.cpp @@ -665,7 +665,7 @@ void wxComboBox::DoSetToolTip(wxToolTip *tip) wxChoice::DoSetToolTip(tip); if ( tip && !HasFlag(wxCB_READONLY) ) - tip->Add(GetEditHWND()); + tip->AddOtherWindow(GetEditHWND()); } #endif // wxUSE_TOOLTIPS diff --git a/src/msw/radiobox.cpp b/src/msw/radiobox.cpp index c33b564474..1414e04edd 100644 --- a/src/msw/radiobox.cpp +++ b/src/msw/radiobox.cpp @@ -498,7 +498,7 @@ void wxRadioBox::DoSetItemToolTip(unsigned int item, wxToolTip *tooltip) // we have already checked for the item to be valid in wxRadioBoxBase const HWND hwndRbtn = (*m_radioButtons)[item]; if ( tooltip != NULL ) - tooltip->Add(hwndRbtn); + tooltip->AddOtherWindow(hwndRbtn); else // unset the tooltip wxToolTip::Remove(hwndRbtn, 0, wxRect(0,0,0,0)); // the second parameter can be zero since it's ignored by Remove() diff --git a/src/msw/spinctrl.cpp b/src/msw/spinctrl.cpp index 7919453f85..71c1221f49 100644 --- a/src/msw/spinctrl.cpp +++ b/src/msw/spinctrl.cpp @@ -604,7 +604,7 @@ void wxSpinCtrl::DoSetToolTip(wxToolTip *tip) wxSpinButton::DoSetToolTip(tip); if ( tip ) - tip->Add(m_hwndBuddy); + tip->AddOtherWindow(m_hwndBuddy); } #endif // wxUSE_TOOLTIPS diff --git a/src/msw/tooltip.cpp b/src/msw/tooltip.cpp index d18525e22b..853b96ac63 100644 --- a/src/msw/tooltip.cpp +++ b/src/msw/tooltip.cpp @@ -374,17 +374,17 @@ void wxToolTip::Remove() DoForAllWindows(&wxToolTip::DoRemove); } -void wxToolTip::Add(WXHWND hWnd) +void wxToolTip::AddOtherWindow(WXHWND hWnd) { if ( !m_others ) m_others = new wxToolTipOtherWindows; m_others->push_back(hWnd); - DoAddOtherWindow(hWnd); + DoAddHWND(hWnd); } -void wxToolTip::DoAddOtherWindow(WXHWND hWnd) +void wxToolTip::DoAddHWND(WXHWND hWnd) { HWND hwnd = (HWND)hWnd; @@ -502,7 +502,7 @@ void wxToolTip::SetWindow(wxWindow *win) // add the window itself if ( m_window ) { - Add(m_window->GetHWND()); + AddOtherWindow(m_window->GetHWND()); } #if !defined(__WXUNIVERSAL__) // and all of its subcontrols (e.g. radio buttons in a radiobox) as well @@ -526,7 +526,7 @@ void wxToolTip::SetWindow(wxWindow *win) // must have it by now! wxASSERT_MSG( hwnd, wxT("no hwnd for subcontrol?") ); - Add((WXHWND)hwnd); + AddOtherWindow((WXHWND)hwnd); } } #endif // !defined(__WXUNIVERSAL__) -- 2.45.2