From f26c1c3e4a1b76ac1ae03bc0bc1ec2393494e144 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Tue, 8 Dec 2009 15:56:21 +0000 Subject: [PATCH] Don't override DoGetBestSize() in wxGenericStaticText, it's unnecessary. The base class already does exactly the same thing -- except that it also accounts for the borders properly. Also fix access for a couple of DoXXX() member functions which should be protected and an event handler which can be private. git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@62821 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- include/wx/generic/stattextg.h | 6 +++--- src/generic/stattextg.cpp | 8 -------- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/include/wx/generic/stattextg.h b/include/wx/generic/stattextg.h index ef225e12b2..02860ea951 100644 --- a/include/wx/generic/stattextg.h +++ b/include/wx/generic/stattextg.h @@ -44,8 +44,8 @@ public: const wxString& name = wxStaticTextNameStr); +protected: virtual wxSize DoGetBestClientSize() const; - virtual wxSize DoGetBestSize() const; virtual void SetLabel(const wxString& label); virtual bool SetFont(const wxFont &font); @@ -53,11 +53,11 @@ public: virtual wxString DoGetLabel() const { return m_label; } virtual void DoSetLabel(const wxString& label); -protected: - void OnPaint(wxPaintEvent& event); void DoSetSize(int x, int y, int width, int height, int sizeFlags); private: + void OnPaint(wxPaintEvent& event); + wxString m_label; int m_mnemonic; diff --git a/src/generic/stattextg.cpp b/src/generic/stattextg.cpp index 2047f27d0e..d4cd0c364a 100644 --- a/src/generic/stattextg.cpp +++ b/src/generic/stattextg.cpp @@ -82,14 +82,6 @@ wxSize wxGenericStaticText::DoGetBestClientSize() const return wxSize(width, height); } -wxSize wxGenericStaticText::DoGetBestSize() const -{ - wxSize ret = DoGetBestClientSize(); - CacheBestSize(ret); - return ret; -} - - void wxGenericStaticText::SetLabel(const wxString& label) { wxControl::SetLabel(label); -- 2.45.2