From f01bca89fd89e8b07061f96d4329bf6cebe6232e Mon Sep 17 00:00:00 2001 From: Julian Smart Date: Thu, 16 Feb 2006 08:53:35 +0000 Subject: [PATCH] Applied patch [ 1431955 ] Fixes wxSocket* _Wait/Select From Angel Vidal Veiga git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@37619 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/common/socket.cpp | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/src/common/socket.cpp b/src/common/socket.cpp index 4525cfa2d7..7285254c4b 100644 --- a/src/common/socket.cpp +++ b/src/common/socket.cpp @@ -694,6 +694,8 @@ bool wxSocketBase::_Wait(long seconds, else timeout = m_timeout * 1000; + bool has_event_loop = wxTheApp ? (wxTheApp->GetTraits() ? true : false) : false; + // Wait in an active polling loop. // // NOTE: We duplicate some of the code in OnRequest, but this doesn't @@ -709,14 +711,15 @@ bool wxSocketBase::_Wait(long seconds, bool done = false; bool valid_result = false; -#if !defined(wxUSE_GUI) || !wxUSE_GUI + if (!has_event_loop) + { // This is used to avoid a busy loop on wxBase - having a select // timeout of 50 ms per iteration should be enough. if (timeout > 50) m_socket->SetTimeout(50); else m_socket->SetTimeout(timeout); -#endif + } while (!done) { @@ -754,20 +757,22 @@ bool wxSocketBase::_Wait(long seconds, done = true; else { -#if !defined(wxUSE_GUI) || !wxUSE_GUI + if (has_event_loop) + { + PROCESS_EVENTS(); + } + else + { // If there's less than 50 ms left, just call select with that timeout. if (time_left < 50) m_socket->SetTimeout(time_left); -#else - PROCESS_EVENTS(); -#endif - } + } + } } // Set timeout back to original value (we overwrote it for polling) -#if !defined(wxUSE_GUI) || !wxUSE_GUI - m_socket->SetTimeout(m_timeout*1000); -#endif + if (!has_event_loop) + m_socket->SetTimeout(m_timeout*1000); return valid_result; } -- 2.45.2