From eb96212b6ca08230668db1bbab173fb7fb55e696 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sun, 19 Dec 2004 19:55:01 +0000 Subject: [PATCH] do not inherit background colour in InheritAttributes() as it totally breaks themed backgrounds git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@31068 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/common/wincmn.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/common/wincmn.cpp b/src/common/wincmn.cpp index 546182a212..0c2192810b 100644 --- a/src/common/wincmn.cpp +++ b/src/common/wincmn.cpp @@ -983,8 +983,15 @@ void wxWindowBase::InheritAttributes() if ( parent->m_inheritFgCol && !m_hasFgCol ) SetForegroundColour(parent->GetForegroundColour()); + // inheriting (solid) background colour is wrong as it totally breaks + // any kind of themed backgrounds + // + // instead, the controls should use the same background as their parent + // (ideally by not drawing it at all) +#if 0 if ( parent->m_inheritBgCol && !m_hasBgCol ) SetBackgroundColour(parent->GetBackgroundColour()); +#endif // 0 } } -- 2.45.2